-
Notifications
You must be signed in to change notification settings - Fork 16.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
201-vmss-scale-existing: Updated azuredeploy.parameters.json to accept prereqs outputs #3820
Conversation
@PraveenAnil, |
"type": "Microsoft.Compute/virtualMachineScaleSets", | ||
"name": "existingvmss", | ||
"location": "[resourceGroup().location]", | ||
"apiVersion": "2016-04-30-preview", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's update this to 2017-03-30
"name": "[concat(variables('namingInfix'), 'ipconfig')]", | ||
"properties": { | ||
"subnet": { | ||
"id": "[concat('/subscriptions/', subscription().subscriptionId,'/resourceGroups/', resourceGroup().name, '/providers/Microsoft.Network/virtualNetworks/', variables('virtualNetworkName'), '/subnets/', variables('subnetName'))]" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
simplify with resourceId('Microsoft.Network/virtualNetworks/subnets, variables('virtualNetworkName'), variables('subnetName'))
} | ||
}, | ||
"osProfile": { | ||
"computerNamePrefix": "[toLower(substring(concat('existingvmss', uniqueString(resourceGroup().id)), 0, 9))]", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can just use existingVmss here... no need for uniqueString
Thanks for the feedback. I have updated the template with the suggested changes. |
Best Practice Checklist
Check these items before submitting a PR... See the Contribution Guide for the full detail: https://github.com/Azure/azure-quickstart-templates/blob/master/1-CONTRIBUTION-GUIDE/README.md
For details: https://github.com/Azure/azure-quickstart-templates/blob/master/1-CONTRIBUTION-GUIDE/bp-checklist.md
Changelog