Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ReleasePR redisenterprise] [Hub Generated] Review request for Microsoft.Cache to add version stable/2021-08-01 #1504

Conversation

openapi-sdkautomation[bot]
Copy link

@openapi-sdkautomation openapi-sdkautomation bot commented Feb 17, 2021

@ghost ghost added the automerge label Feb 17, 2021
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been auto-approved by the @msftbot for the azure-resource-manager-schemas repo.

@ghost
Copy link

ghost commented Feb 17, 2021

Hello @msftbot[bot]!

Because this pull request has the automerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 1 minute. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

Request to update Redis Enterprise version stable/2021-03-01 (#12967)

* Adds base for updating Microsoft.Cache from version preview/2020-10-01-preview to version 2021-03-01

* Updates readme

* Updates API version in new specs and examples

* Add support for persistence and fix other typos

* Fix SDK Warning: R2063 OperationIdNounConflictingModelNames

* Fix spellcheck error

* Fix acronym capitalization in descriptions

* Replace local parameters with common-types parameters

* Use naming convention consistent with Azure documentation

* Update word choice, remove deprecated x-ms-code-generation-setting, and fix operationId

* Add x-ms-secret extension and make TLS version a string enum

* Suppress errors about secrets being sent in responses

* Fix operation typo in example
@openapi-sdkautomation openapi-sdkautomation bot changed the title [ReleasePR redisenterprise] Update redisenterprise readme files for C#, Azure CLI, and Azure Resource Manager Schema [ReleasePR redisenterprise] Request to update Redis Enterprise version stable/2021-03-01 Feb 17, 2021
@ghost ghost removed the automerge label Feb 17, 2021
@TimLovellSmith
Copy link
Member

TimLovellSmith commented Feb 23, 2021

I don't think we need the schema checked in for this preview api-version [schemas/2020-10-01-preview/Microsoft.Cache.json], its about to become obsolete anyway since we have a new GA api-version.

@openapi-sdkautomation openapi-sdkautomation bot changed the title [ReleasePR redisenterprise] Request to update Redis Enterprise version stable/2021-03-01 [ReleasePR redisenterprise] {Redis Enterprise} Revert default tag to latest package intended for use by customers Mar 2, 2021
@openapi-sdkautomation openapi-sdkautomation bot changed the title [ReleasePR redisenterprise] {Redis Enterprise} Revert default tag to latest package intended for use by customers [ReleasePR redisenterprise] Update readme.azureresourceschema.md Mar 2, 2021
@openapi-sdkautomation openapi-sdkautomation bot changed the title [ReleasePR redisenterprise] Update readme.azureresourceschema.md [ReleasePR redisenterprise] Update redisenterprise readme files for Azure CLI Mar 2, 2021
@openapi-sdkautomation openapi-sdkautomation bot changed the title [ReleasePR redisenterprise] Update redisenterprise readme files for Azure CLI [ReleasePR redisenterprise] Correctly document minimumTlsVersion - which is create-only mutable Mar 25, 2021
@openapi-sdkautomation openapi-sdkautomation bot changed the title [ReleasePR redisenterprise] Correctly document minimumTlsVersion - which is create-only mutable [ReleasePR redisenterprise] Update all schemas.md files Apr 9, 2021
@openapi-sdkautomation openapi-sdkautomation bot changed the title [ReleasePR redisenterprise] Update all schemas.md files [ReleasePR redisenterprise] [Hub Generated] Review request for Microsoft.Cache to add version stable/2021-08-01 Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants