Add/update resource schemas with schemas generated from swagger docs #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { "$ref": "http://schema.management.azure.com/schemas/2016-03-30/Microsoft.Network.json#/resourceDefinitions/routeTables_routes"}, | ||
| { "$ref": "http://schema.management.azure.com/schemas/2016-03-30/Microsoft.Network.json#/resourceDefinitions/virtualnetworkgateways"}, | ||
| { "$ref": "http://schema.management.azure.com/schemas/2016-03-30/Microsoft.Network.json#/resourceDefinitions/virtualnetworks"}, | ||
| { "$ref": "http://schema.management.azure.com/schemas/2016-03-30/Microsoft.Network.json#/resourceDefinitions/virtualnetworks"}, |
There was a problem hiding this comment.
duplication of virutalNetworks
ghost
mentioned this pull request
|
@daschult LGTM for CDN schema, can you please also generate the schema from this swagger(https://github.com/Azure/azure-rest-api-specs/tree/master/arm-cdn/2015-06-01/swagger) as well? |
|
Is this pull request waiting on anything? |
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have created a tool that allows us to generate resource schemas from swagger docs (Azure/autorest#1018). This pull request adds/updates the schemas that I generated during my tests of my generation tool.