Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ReleasePR servicefabric] Add x-ms-pageable to generate API's that support using nextlink to return resources #2705

Closed
wants to merge 1 commit into from

Conversation

azure-sdk
Copy link

@azure-sdk azure-sdk commented Dec 9, 2022

@ghost ghost added the automerge label Dec 9, 2022
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been auto-approved by the @msftbot for the azure-resource-manager-schemas repo.

@ghost
Copy link

ghost commented Dec 9, 2022

Hello @msftbot[bot]!

Because this pull request has the automerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 1 minute. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

{AzureServiceFabric} fixes Azure/azure-rest-api-specs#22806 The ClusterVersion API redirects to invalid link (#22868)

"description": "The Service Fabric runtime version of the cluster. This property can only by set the user when upgradeMode is set to 'Manual'. To get list of available Service Fabric versions for new clusters use [ClusterVersion API](https://github.com/Azure/azure-rest-api-specs/issues/ClusterVersion.md)"

The link goes to ./ClusterVersion.md which does not exist. This actually causes dead links in the official MS documentation, e.g. [here](https://learn.microsoft.com/en-us/rest/api/servicefabric/clusters/list?tabs=HTTP#cluster).
@azure-sdk azure-sdk changed the title [ReleasePR servicefabric] Scrub custom-words.txt for non-words and descriptions for more inclusive terminology [ReleasePR servicefabric] {AzureServiceFabric} fixes Azure/azure-rest-api-specs#22806 The ClusterVersion API redirects to invalid link Mar 13, 2023
@azure-sdk azure-sdk force-pushed the sdkAuto/servicefabric branch from 544c749 to 6c253fd Compare March 13, 2023 04:57
@azure-sdk azure-sdk changed the title [ReleasePR servicefabric] {AzureServiceFabric} fixes Azure/azure-rest-api-specs#22806 The ClusterVersion API redirects to invalid link [ReleasePR servicefabric] Add x-ms-pageable to generate API's that support using nextlink to return resources Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants