Skip to content

Commit

Permalink
[Hub Generated] Review request for Microsoft.SqlVirtualMachine to add…
Browse files Browse the repository at this point in the history 
… version preview/2021-11-01-preview (#17252)

* Adds base for updating Microsoft.SqlVirtualMachine from version preview/2017-03-01-preview to version 2021-11-01-preview

* Updates readme

* Updates API version in new specs and examples

* add 2021-11-01 swagger

* add missing files, spellcheck, add MAXDOP to custom-words

* prettier check

* fix model validation errors

* fix swagger avocado failures, SDK azure-sdk-for-net failures due to DaysOfWeek

* add system data to AvailabilityGroupListener, SqlVirtualMachineGroup, SqlVirtualMachine

* update list operation for 2021-11-01

* add ms-identifier to address lintdiff R4041

* remove x-ms-identifiers property as it is not available yet on .net sdk

* add SqlVirtualMachines_StartAssessment

* update ResourceIdentity enum from IdentityTypeWithNone to IdentityType

* update list operations json

* prettier check

* re-add ms-identifier to address lintdiff R4041
  • Loading branch information
@rchlkm
rchlkm authored Feb 17, 2022
1 parent b4d0463 commit 18a4efa
Show file tree
Hide file tree
Showing 28 changed files with 3,577 additions and 13 deletions.
1 change: 1 addition & 0 deletions custom-words.txt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1185,6 +1185,7 @@ marketplacecatalog
marketplaceordering
maxclients
maxcoordinates
MAXDOP
MAXERRORS
maxfragmentationmemory
maximumblobsize
Expand Down
77 changes: 77 additions & 0 deletions ...lMachine/preview/2021-11-01-preview/examples/CreateOrUpdateAvailabilityGroupListener.json
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,77 @@
{
"parameters": {
"subscriptionId": "00000000-1111-2222-3333-444444444444",
"resourceGroupName": "testrg",
"sqlVirtualMachineGroupName": "testvmgroup",
"availabilityGroupListenerName": "agl-test",
"api-version": "2021-11-01-preview",
"parameters": {
"properties": {
"availabilityGroupName": "ag-test",
"loadBalancerConfigurations": [
{
"privateIpAddress": {
"ipAddress": "10.1.0.112",
"subnetResourceId": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.Network/virtualNetworks/test-vnet/subnets/default"
},
"loadBalancerResourceId": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.Network/loadBalancers/lb-test",
"probePort": 59983,
"sqlVirtualMachineInstances": [
"/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.SqlVirtualMachine/sqlVirtualMachines/testvm2",
"/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.SqlVirtualMachine/sqlVirtualMachines/testvm3"
]
}
],
"port": 1433
}
}
},
"responses": {
"200": {
"body": {
"properties": {
"provisioningState": "Updating",
"loadBalancerConfigurations": [
{
"privateIpAddress": {
"ipAddress": "10.1.0.113",
"subnetResourceId": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.Network/virtualNetworks/test-vnet/subnets/default"
},
"sqlVirtualMachineInstances": [
"/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.SqlVirtualMachine/sqlVirtualMachines/testvm2",
"/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.SqlVirtualMachine/sqlVirtualMachines/testvm3"
]
}
],
"port": 1433
},
"id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.SqlVirtualMachine/sqlVirtualMachineGroups/testvmgroup/availabilityGroupListeners/agl-test",
"name": "agl-test",
"type": "Microsoft.SqlVirtualMachine/sqlVirtualMachineGroups/availabilityGroupListeners"
}
},
"201": {
"body": {
"properties": {
"provisioningState": "Provisioning",
"loadBalancerConfigurations": [
{
"privateIpAddress": {
"ipAddress": "10.1.0.112",
"subnetResourceId": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.Network/virtualNetworks/test-vnet/subnets/default"
},
"sqlVirtualMachineInstances": [
"/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.SqlVirtualMachine/sqlVirtualMachines/testvm2",
"/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.SqlVirtualMachine/sqlVirtualMachines/testvm3"
]
}
],
"port": 1433
},
"id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.SqlVirtualMachine/sqlVirtualMachineGroups/testvmgroup/availabilityGroupListeners/agl-test",
"name": "agl-test",
"type": "Microsoft.SqlVirtualMachine/sqlVirtualMachineGroups/availabilityGroupListeners"
}
}
}
}
96 changes: 96 additions & 0 deletions ...iew/2021-11-01-preview/examples/CreateOrUpdateSqlVirtualMachineAutomatedBackupWeekly.json
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,96 @@
{
"parameters": {
"subscriptionId": "00000000-1111-2222-3333-444444444444",
"resourceGroupName": "testrg",
"sqlVirtualMachineName": "testvm",
"api-version": "2021-11-01-preview",
"parameters": {
"location": "northeurope",
"properties": {
"sqlServerLicenseType": "PAYG",
"sqlImageSku": "Enterprise",
"sqlManagement": "Full",
"virtualMachineResourceId": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.Compute/virtualMachines/testvm",
"serverConfigurationsManagementSettings": {
"sqlConnectivityUpdateSettings": {
"connectivityType": "PRIVATE",
"port": 1433,
"sqlAuthUpdateUserName": "sqllogin",
"sqlAuthUpdatePassword": "<password>"
},
"sqlStorageUpdateSettings": {
"diskCount": 1,
"startingDeviceId": 2,
"diskConfigurationType": "NEW"
},
"sqlWorkloadTypeUpdateSettings": {
"sqlWorkloadType": "OLTP"
},
"additionalFeaturesServerConfigurations": {
"isRServicesEnabled": false
}
},
"keyVaultCredentialSettings": {
"enable": false
},
"autoPatchingSettings": {
"enable": true,
"dayOfWeek": "Sunday",
"maintenanceWindowStartingHour": 2,
"maintenanceWindowDuration": 60
},
"autoBackupSettings": {
"enable": true,
"retentionPeriod": 17,
"enableEncryption": true,
"password": "<Password>",
"backupScheduleType": "Manual",
"backupSystemDbs": true,
"storageAccountUrl": "https://teststorage.blob.core.windows.net/",
"storageContainerName": "testcontainer",
"storageAccessKey": "<primary storage access key>",
"fullBackupFrequency": "Weekly",
"daysOfWeek": [
"Monday",
"Friday"
],
"fullBackupStartTime": 6,
"fullBackupWindowHours": 11,
"logBackupFrequency": 10
}
}
}
},
"responses": {
"200": {
"body": {
"properties": {
"virtualMachineResourceId": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.Compute/virtualMachines/testvm",
"provisioningState": "Updating",
"sqlServerLicenseType": "PAYG",
"sqlImageSku": "Enterprise",
"sqlManagement": "Full"
},
"location": "northeurope",
"id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.SqlVirtualMachine/sqlVirtualMachines/testvm",
"name": "testvm",
"type": "Microsoft.SqlVirtualMachine/sqlVirtualMachines"
}
},
"201": {
"body": {
"properties": {
"virtualMachineResourceId": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.Compute/virtualMachines/testvm",
"provisioningState": "Provisioning",
"sqlServerLicenseType": "PAYG",
"sqlImageSku": "Unknown",
"sqlManagement": "Full"
},
"location": "northeurope",
"id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.SqlVirtualMachine/sqlVirtualMachines/testvm",
"name": "testvm",
"type": "Microsoft.SqlVirtualMachine/sqlVirtualMachines"
}
}
}
}
67 changes: 67 additions & 0 deletions ...tualMachine/preview/2021-11-01-preview/examples/CreateOrUpdateSqlVirtualMachineGroup.json
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,67 @@
{
"parameters": {
"subscriptionId": "00000000-1111-2222-3333-444444444444",
"resourceGroupName": "testrg",
"sqlVirtualMachineGroupName": "testvmgroup",
"api-version": "2021-11-01-preview",
"parameters": {
"location": "northeurope",
"tags": {
"mytag": "myval"
},
"properties": {
"sqlImageOffer": "SQL2016-WS2016",
"sqlImageSku": "Enterprise",
"wsfcDomainProfile": {
"domainFqdn": "testdomain.com",
"ouPath": "OU=WSCluster,DC=testdomain,DC=com",
"clusterBootstrapAccount": "testrpadmin",
"clusterOperatorAccount": "testrp@testdomain.com",
"sqlServiceAccount": "sqlservice@testdomain.com",
"storageAccountUrl": "https://storgact.blob.core.windows.net/",
"storageAccountPrimaryKey": "<primary storage access key>"
}
}
}
},
"responses": {
"200": {
"body": {
"properties": {
"provisioningState": "UpdatingDomainful",
"sqlImageOffer": "SQL2016-WS2016",
"sqlImageSku": "Enterprise",
"wsfcDomainProfile": {
"storageAccountUrl": "https://storgact.blob.core.windows.net/"
}
},
"location": "northeurope",
"tags": {
"mytag": "myval"
},
"id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.SqlVirtualMachine/sqlVirtualMachineGroups/testvmgroup",
"name": "testvmgroup",
"type": "Microsoft.SqlVirtualMachine/sqlVirtualMachineGroups"
}
},
"201": {
"body": {
"properties": {
"provisioningState": "ProvisioningDomainful",
"sqlImageOffer": "SQL2016-WS2016",
"sqlImageSku": "Enterprise",
"wsfcDomainProfile": {
"storageAccountUrl": "https://storgact.blob.core.windows.net/"
}
},
"location": "northeurope",
"tags": {
"mytag": "myval"
},
"id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.SqlVirtualMachine/sqlVirtualMachineGroups/testvmgroup",
"name": "testvmgroup",
"type": "Microsoft.SqlVirtualMachine/sqlVirtualMachineGroups"
}
}
}
}
110 changes: 110 additions & 0 deletions ...irtualMachine/preview/2021-11-01-preview/examples/CreateOrUpdateSqlVirtualMachineMAX.json
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,110 @@
{
"parameters": {
"subscriptionId": "00000000-1111-2222-3333-444444444444",
"resourceGroupName": "testrg",
"sqlVirtualMachineName": "testvm",
"api-version": "2021-11-01-preview",
"parameters": {
"location": "northeurope",
"properties": {
"sqlServerLicenseType": "PAYG",
"sqlImageSku": "Enterprise",
"sqlManagement": "Full",
"virtualMachineResourceId": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.Compute/virtualMachines/testvm",
"serverConfigurationsManagementSettings": {
"sqlConnectivityUpdateSettings": {
"connectivityType": "PRIVATE",
"port": 1433,
"sqlAuthUpdateUserName": "sqllogin",
"sqlAuthUpdatePassword": "<password>"
},
"sqlStorageUpdateSettings": {
"diskCount": 1,
"startingDeviceId": 2,
"diskConfigurationType": "NEW"
},
"sqlWorkloadTypeUpdateSettings": {
"sqlWorkloadType": "OLTP"
},
"additionalFeaturesServerConfigurations": {
"isRServicesEnabled": false
},
"sqlInstanceSettings": {
"collation": "SQL_Latin1_General_CP1_CI_AS",
"maxDop": 8,
"isOptimizeForAdHocWorkloadsEnabled": true,
"minServerMemoryMB": 0,
"maxServerMemoryMB": 128
}
},
"keyVaultCredentialSettings": {
"enable": false
},
"autoPatchingSettings": {
"enable": true,
"dayOfWeek": "Sunday",
"maintenanceWindowStartingHour": 2,
"maintenanceWindowDuration": 60
},
"autoBackupSettings": {
"enable": true,
"retentionPeriod": 17,
"enableEncryption": true,
"password": "<Password>",
"backupScheduleType": "Manual",
"backupSystemDbs": true,
"storageAccountUrl": "https://teststorage.blob.core.windows.net/",
"storageContainerName": "testcontainer",
"storageAccessKey": "<primary storage access key>",
"fullBackupFrequency": "Daily",
"fullBackupStartTime": 6,
"fullBackupWindowHours": 11,
"logBackupFrequency": 10
},
"assessmentSettings": {
"enable": true,
"runImmediately": true,
"schedule": {
"enable": true,
"weeklyInterval": 1,
"monthlyOccurrence": null,
"dayOfWeek": "Sunday",
"startTime": "23:17"
}
}
}
}
},
"responses": {
"200": {
"body": {
"properties": {
"virtualMachineResourceId": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.Compute/virtualMachines/testvm",
"provisioningState": "Updating",
"sqlServerLicenseType": "PAYG",
"sqlImageSku": "Enterprise",
"sqlManagement": "Full"
},
"location": "northeurope",
"id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.SqlVirtualMachine/sqlVirtualMachines/testvm",
"name": "testvm",
"type": "Microsoft.SqlVirtualMachine/sqlVirtualMachines"
}
},
"201": {
"body": {
"properties": {
"virtualMachineResourceId": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.Compute/virtualMachines/testvm",
"provisioningState": "Provisioning",
"sqlServerLicenseType": "PAYG",
"sqlImageSku": "Unknown",
"sqlManagement": "Full"
},
"location": "northeurope",
"id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/testrg/providers/Microsoft.SqlVirtualMachine/sqlVirtualMachines/testvm",
"name": "testvm",
"type": "Microsoft.SqlVirtualMachine/sqlVirtualMachines"
}
}
}
}
Loading

0 comments on commit 18a4efa

Please sign in to comment.