Merge branch 'master' into operationsApis

.azure-pipelines-preproduction/package.json

@@ -11,7 +11,7 @@
   "license": "MIT",
   "devDependencies": {
     "@azure/avocado": "^0.6.2",
-    "@azure/rest-api-specs-scripts": "^0.5.7",
+    "@azure/rest-api-specs-scripts": "^0.6.1",
     "@ts-common/commonmark-to-markdown": "^1.2.0",
     "@ts-common/fs": "0.2.0",
     "@ts-common/iterator": "^0.3.6",

.azure-pipelines/SDKAutomation.yml

@@ -2,7 +2,10 @@ trigger:
   batch: false
   branches:
     include:
-      - "*"
+      - master
+
+pr:
+  autoCancel: false
 
 jobs:
 - job: "SDKAutomation"

.github/reviewer.yml

@@ -3,8 +3,6 @@
 - group:
     name: default
     users:
-      - githubID: ruowan
-        email: ruowan@microsoft.com
       - githubID: raych1
         email: raychen@microsoft.com
       - githubID: MyronFanQiu

.github/sla.yml

@@ -3,35 +3,46 @@
     action: sendEmailToAssignee
     repoWhitelist:
       - Azure/azure-rest-api-specs
+    scope: pull_request
     args:
       booleanFilterExpression: "!(WaitForARMFeedback||(DoNotMerge&&(ARMSignedOff||Approved)))"
       limit: 48h
-      message: '<p> Dear Swagger reviewer, <br> <br> Please response to the PR ${PR_URL}. The PR isn''t updated in 48 hours. <br> <hr /> <br> Quick info. <ul> <li>If no response from ARM review board, please send email to armapireview@microsoft.com.</li> <li>If need immediate ARM review, please get ARM review oncall contact point from ICM https://icm.ad.msft.net/imp/v3/oncall/current under Service "Azure Resource Manager" and Team "RP Manifest Approvers"</li> <li>If no response from Azure API review board, please send email to azureapirbcore@microsoft.com.</li> <li>If you have problem to fix CI task errors, please send email to Visual Studio China Swagger and Tool team vscswagger@microsoft.com.</li> <li>If you want to opt out from Swagger reviewing for out of office period, please set vacation date at https://inframonitorweb1.azurewebsites.net/Home/MyView.</li> <li>Pls refer to <a href="onenote:https://microsoft.sharepoint.com/teams/IoTToolingTeam/SiteAssets/IoT Tooling Team Notebook/Azure Management Experience - transition.one#Swagger%20reviewing%20process§ion-id={ECE847C4-519B-4448-A1A0-8E84A7EFE8AB}&page-id={F6E345FE-46E1-420F-B837-6BF76167DE05}&end">Swagger review process (onenote)</a> for more about Swagger review process.</li> </ul> Best regards, <br> Azure Management Experience </p>'
-      subject: "Action Required: Please respond to PR ${PR_URL}"
+      message: '<p> Dear Swagger reviewer, <br> <br> Please response to the PR ${URL} . The PR isn''t updated in 48 hours. <br> <hr /> <br> Quick info. <ul> <li>If no response from ARM review board, please send email to armapireview@microsoft.com.</li> <li>If need immediate ARM review, please get ARM review oncall contact point from ICM https://icm.ad.msft.net/imp/v3/oncall/current under Service "Azure Resource Manager" and Team "RP Manifest Approvers"</li> <li>If no response from Azure API review board, please send email to azureapirbcore@microsoft.com.</li> <li>If you have problem to fix CI task errors, please send email to Visual Studio China Swagger and Tool team vscswagger@microsoft.com.</li> <li>If you want to opt out from Swagger reviewing for out of office period, please set vacation date at https://inframonitorweb1.azurewebsites.net/Home/MyView.</li> <li>Pls refer to <a href="onenote:https://microsoft.sharepoint.com/teams/IoTToolingTeam/SiteAssets/IoT Tooling Team Notebook/Azure Management Experience - transition.one#Swagger%20reviewing%20process§ion-id={ECE847C4-519B-4448-A1A0-8E84A7EFE8AB}&page-id={F6E345FE-46E1-420F-B837-6BF76167DE05}&end">Swagger review process (onenote)</a> for more about Swagger review process.</li> </ul> Best regards, <br> Azure Management Experience </p>'
+      subject: "Action Required: Please respond to PR ${URL}"
     description: "None initial response in 48 hours. For public repo."
     name: "[PUBLIC] initial response notification"
 
 - scheduleTask:
     action: sendEmailToAssignee
     repoWhitelist:
       - Azure/azure-rest-api-specs-pr
+    scope: pull_request
     args:
       booleanFilterExpression: "!(WaitForARMFeedback||Approved-OkToMerge||(DoNotMerge&&(ARMSignedOff||Approved)))"
       limit: 48h
-      message: '<p> Dear Swagger reviewer, <br> <br> Please response to the PR ${PR_URL}. The PR isn''t updated in 48 hours. <br> <hr /> <br> Quick info. <ul> <li>If no response from ARM review board, please send email to armapireview@microsoft.com.</li> <li>If need immediate ARM review, please get ARM review oncall contact point from ICM https://icm.ad.msft.net/imp/v3/oncall/current under Service "Azure Resource Manager" and Team "RP Manifest Approvers"</li> <li>If no response from Azure API review board, please send email to azureapirbcore@microsoft.com.</li> <li>If you have problem to fix CI task errors, please send email to Visual Studio China Swagger and Tool team vscswagger@microsoft.com.</li> <li>If you want to opt out from Swagger reviewing for out of office period, please set vacation date at https://inframonitorweb1.azurewebsites.net/Home/MyView.</li> <li>Pls refer to <a href="onenote:https://microsoft.sharepoint.com/teams/IoTToolingTeam/SiteAssets/IoT Tooling Team Notebook/Azure Management Experience - transition.one#Swagger%20reviewing%20process§ion-id={ECE847C4-519B-4448-A1A0-8E84A7EFE8AB}&page-id={F6E345FE-46E1-420F-B837-6BF76167DE05}&end">Swagger review process (onenote)</a> for more about Swagger review process.</li> </ul> Best regards, <br> Azure Management Experience </p>'
-      subject: "Action Required: Please respond to PR ${PR_URL}"
+      message: '<p> Dear Swagger reviewer, <br> <br> Please response to the PR ${URL} . The PR isn''t updated in 48 hours. <br> <hr /> <br> Quick info. <ul> <li>If no response from ARM review board, please send email to armapireview@microsoft.com.</li> <li>If need immediate ARM review, please get ARM review oncall contact point from ICM https://icm.ad.msft.net/imp/v3/oncall/current under Service "Azure Resource Manager" and Team "RP Manifest Approvers"</li> <li>If no response from Azure API review board, please send email to azureapirbcore@microsoft.com.</li> <li>If you have problem to fix CI task errors, please send email to Visual Studio China Swagger and Tool team vscswagger@microsoft.com.</li> <li>If you want to opt out from Swagger reviewing for out of office period, please set vacation date at https://inframonitorweb1.azurewebsites.net/Home/MyView.</li> <li>Pls refer to <a href="onenote:https://microsoft.sharepoint.com/teams/IoTToolingTeam/SiteAssets/IoT Tooling Team Notebook/Azure Management Experience - transition.one#Swagger%20reviewing%20process§ion-id={ECE847C4-519B-4448-A1A0-8E84A7EFE8AB}&page-id={F6E345FE-46E1-420F-B837-6BF76167DE05}&end">Swagger review process (onenote)</a> for more about Swagger review process.</li> </ul> Best regards, <br> Azure Management Experience </p>'
+      subject: "Action Required: Please respond to PR ${URL}"
     description: "None initial response in 48 hours. For private repo."
     name: "[PRIVATE] initial response notification"
 
 - scheduleTask:
     action: sendEmail
-    repoWhitelist:
-      - Azure/azure-rest-api-specs
+    scope: pull_request
     args:
       booleanFilterExpression: "(WaitForARMFeedback&&!ARMSignedOff&&!ARMChangesRequested&&!ARMReviewInProgress)"
-      limit: 5d
-      subject: "Action Required: Please help to review PR ${PR_URL}"
-      message: "<p> Dear ARM review board, <br> <br>Please review PR ${PR_URL}, the PR is waiting for ARM review over 3 days. Thanks.<br><hr /> <br>Quick info<ul><li>If you have feedback about the notification email, please contact us at vscswagger@microsoft.com.</li><li>After reviewing, please remove “WaitForARMFeedback” label from PR to avoid receiving notification on the same PR.</li><li>Please do not reply to this email, this is an automatic generated email.</li></ul>Best regards,<br> Azure Management Experience</p>"
+      limit: 3d
+      subject: "Action Required: Please help to review PR ${URL}"
+      message: "<p> Dear ARM review board, <br> <br>Please review PR ${URL} , the PR is waiting for ARM review over 3 days. Thanks.<br><hr /> <br>Quick info<ul><li>If you have feedback about the notification email, please contact us at vscswagger@microsoft.com.</li><li>After reviewing, please remove “WaitForARMFeedback” label from PR to avoid receiving notification on the same PR.</li><li>Please do not reply to this email, this is an automatic generated email.</li></ul>Best regards,<br> Azure Management Experience</p>"
       to: armapireview@microsoft.com
     description: "send email to ARM team for over 5 days PRs labelled with WaitForARMFeedback"
     name: "send email to ARM team"
+
+- scheduleTask:
+    action: sendEmailToAssignee
+    scope: issue
+    args:
+      booleanFilterExpression: "triage"
+      limit: 48h
+      message: "<p> Dear Swagger reviewer, <br> <br> Please response to the issue ${URL} . The issue isn't updated in 48 hours. <br> <hr /> <br> Quick info. <ul>  <li>If you have any question, please send email to Visual Studio Swagger and Tool team vscswagger@microsoft.com.</li>  </ul> Best regards, <br> Azure Management Experience </p>"
+      subject: "Action Required: Please respond to issue ${URL}"
+      cc: Ankun.Ning@microsoft.com

CODEOWNERS

@@ -34,19 +34,20 @@
 /specification/insights/ @gucalder
 /specification/intune/ @vrmurthy01
 /specification/iothub/ @rkmanda
-/specification/keyvault/ @schaabs
+/specification/keyvault/ @schaabs @heaths
 /specification/logic/ @pankajsn @tonytang-microsoft-com
 /specification/machinelearning/ @nonstatic2014
 /specification/machinelearningcompute/ @shutchings
 /specification/managementpartner/ @jeffrey-ace
-/specification/mediaservices/ @brianblum
+/specification/mediaservices/ @giakas
 /specification/mobileengagement/ @pshrosbree
 /specification/monitor/ @gucalder
 /specification/mysql/ @qingqingyuan
-/specification/network/ @MikhailTryakhov @number213
+/specification/network/ @MikhailTryakhov @number213 @solhaile @v-shhatt
 /specification/notificationhubs/ @amolr @smithab
 /specification/operationalinsights/ @sw47
 /specification/operationsmanagement/ @dashimi16
+/specification/peering/ @rileymckenna
 /specification/policyinsights/ @bulentelmaci
 /specification/postgresql/ @qingqingyuan
 /specification/powerbidedicated/ @tarostok
@@ -58,7 +59,8 @@
 /specification/relay/ @sethmanheim @v-ajnava
 /specification/resources/ @Tiano2017 @rajshah11 @vivsriaus
 /specification/scheduler/ @pinwang81
-/specification/search/ @brjohnstmsft
+/specification/search/data-plane/ @brjohnstmsft @arv100kri @bleroy
+/specification/search/resource-manager/ @abhi1509 @miwelsh @tjacobhi
 /specification/serialconsole/ @amitchat @craigw @asinn826
 /specification/service-map/ @daveirwin1
 /specification/servicebus/ @sazeesha @v-ajnava

README.md

@@ -82,7 +82,7 @@ The structure should appear like so:
 Currently, the specifications are expected to be in Swagger JSON format
 
 ## Next steps
-The next step in the process after a spec is completed is to generate SDKs and API reference documentation. Go to the [Azure Developer Experience guide](https://github.com/Azure/adx-documentation-pr) for more information.
+The next step in the process after a spec is completed is to generate SDKs and API reference documentation. If you're Microsoft employee, go to the [Azure Developer Experience guide](https://github.com/Azure/adx-documentation-pr) for more information.
 
 ---
 _This project has adopted the [Microsoft Open Source Code of Conduct](https://opensource.microsoft.com/codeofconduct/). For more information see the [Code of Conduct FAQ](https://opensource.microsoft.com/codeofconduct/faq/) or contact [opencode@microsoft.com](mailto:opencode@microsoft.com) with any additional questions or comments._

azure-pipelines.yml

@@ -1,5 +1,13 @@
 name: "Azure OpenAPI"
 
+trigger:
+  branches:
+    include:
+      - master
+
+pr:
+  autoCancel: false
+
 variables:
   TRAVIS: 'true'
   TRAVIS_BRANCH: $(System.PullRequest.TargetBranch)
@@ -19,3 +27,4 @@ jobs:
 - template: .azure-pipelines/LintDiff.yml
 - template: .azure-pipelines/NetworkValidation.yml
 - template: .azure-pipelines/Spellcheck.yml
+- template: .azure-pipelines/PrettierCheck.yml