Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'restorePointInTime' in 'sqlPool' should have 'format: date-time' property #13108

Closed
SLRXXX opened this issue Feb 23, 2021 · 7 comments
Closed

'restorePointInTime' in 'sqlPool' should have 'format: date-time' property #13108

SLRXXX opened this issue Feb 23, 2021 · 7 comments
Labels
needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team Service Attention Workflow: This issue is responsible by Azure service team. Synapses

Comments

@SLRXXX
Copy link
Contributor

SLRXXX commented Feb 23, 2021 •
edited
Loading

I remember we have it before, so in generated SDK type for 'restorePointInTime' is Date in js.
Somehow 'format' information got lost, now in some SDK it's type goes to string.
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Feb 23, 2021
@zhenglaizhang
Copy link
Contributor

Hi @SLRXXX could you help give more info about which version and which RP has this issue?
I need locate the spec, and check if its service or sdk gen issue, so that I can route to correct owner

@zhenglaizhang zhenglaizhang added needs-author-feedback Workflow: More information is needed from author to address the issue. and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Feb 24, 2021
@SLRXXX
Copy link
Contributor Author

SLRXXX commented Feb 24, 2021

@zhenglaizhang
Files are
https://github.com/Azure/azure-rest-api-specs/blob/master/specification/synapse/resource-manager/Microsoft.Synapse/preview/2019-06-01-preview/sqlPool.json
and
https://github.com/Azure/azure-rest-api-specs/blob/master/specification/synapse/resource-manager/Microsoft.Synapse/stable/2020-12-01/sqlPool.json

For SDK as '@azure/arm-synapse', before version 3.0.0, typeof restorePointInTime is Date. Since 3.0.0, it got string.
It's not a SDK gen issue because we lost the {"format": "date-time"} property for restorePointInTime in swagger file.
It's a little hard for me to find in which PR this property got lost.

@ghost ghost added needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team and removed needs-author-feedback Workflow: More information is needed from author to address the issue. labels Feb 24, 2021
@zhenglaizhang zhenglaizhang added Service Attention Workflow: This issue is responsible by Azure service team. Synapses labels Feb 24, 2021
@zhenglaizhang
Copy link
Contributor

@SLRXXX thanks for the detailed info, its quite helpful, I will try to route this to synapse service team

@zhenglaizhang
Copy link
Contributor

@amoghnatu can you help take a look at this or help route to the correct owner for the issue? thanks in advance!

@amoghnatu
Copy link
Contributor

@zhenglaizhang Ack.

@srinuthati can you take a look at this and fix this as part of your current swagger changes?

@srinuthati
Copy link
Contributor

srinuthati commented Feb 24, 2021 via email

@SLRXXX
Copy link
Contributor Author

SLRXXX commented Mar 2, 2021

I see it in the latest version.
Thank you for help! @srinuthati @zhenglaizhang

@SLRXXX SLRXXX closed this as completed Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team Service Attention Workflow: This issue is responsible by Azure service team. Synapses
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@zhenglaizhang @amoghnatu @SLRXXX @srinuthati