Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EventGrid] Default value is invalid for sku #13167

Closed
mikhailshilkov opened this issue Feb 25, 2021 · 9 comments
Closed

[EventGrid] Default value is invalid for sku #13167

mikhailshilkov opened this issue Feb 25, 2021 · 9 comments
Assignees
@ahamad-MS
Labels
Event Grid Service Attention Workflow: This issue is responsible by Azure service team.

Comments

@mikhailshilkov
Copy link
Contributor

In the latest 2020-10-15-preview API version, the sku property defines a default value "Basic":

azure-rest-api-specs/specification/eventgrid/resource-manager/Microsoft.EventGrid/preview/2020-10-15-preview/EventGrid.json

Line 5926 in 35bd110

"default": "Basic"

This is wrong because sku is an object of type ResourceSku with a property name. It's the property that should have the default value.
@ghost ghost added needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Feb 25, 2021
@mikhailshilkov mikhailshilkov mentioned this issue Feb 25, 2021
Merged
25 tasks
@raych1 raych1 added Event Grid Service Attention Workflow: This issue is responsible by Azure service team. and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Mar 2, 2021
@ghost
Copy link

ghost commented Mar 2, 2021

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @jfggdl.

Issue Details

In the latest 2020-10-15-preview API version, the sku property defines a default value "Basic":

azure-rest-api-specs/specification/eventgrid/resource-manager/Microsoft.EventGrid/preview/2020-10-15-preview/EventGrid.json

Line 5926 in 35bd110

"default": "Basic"

This is wrong because sku is an object of type ResourceSku with a property name. It's the property that should have the default value.

Author: mikhailshilkov
Assignees: ahamad-MS, raych1
Labels:

Event Grid, Service Attention, question
Milestone: -

@raych1 raych1 removed the question The issue doesn't require a change to the product in order to be resolved. Most issues start as that label Mar 2, 2021
@raych1
Copy link
Member

raych1 commented Mar 2, 2021

@ahamad-MS , I saw you update the spec recently. Can you have a look at this issue? Thanks.

@ahamad-MS
Copy link
Contributor

Thanks for reaching out and opening this issue. We will take a look and respond back.

thanks

@ahamad-MS
Copy link
Contributor

The issue seems to be valid. We will track this for a quick fix. thanks for reporting this @mikhailshilkov .. Somehow, this was not caught in swagger check tools.

@ahamad-MS
Copy link
Contributor

This bug is part of the latest swagger update here: #13397 (review) .. Closing this issue as being addressed.

Thanks

@mikhailshilkov
Copy link
Contributor Author

This issue is still present in an older API version:

Could you please fix it everywhere?

@raych1
Copy link
Member

raych1 commented Mar 19, 2021

@ahamad-MS , can you please take care of fixes for other versions?

@ahamad-MS
Copy link
Contributor

Yes.. We will take care of it separately. thanks

@mikhailshilkov
Copy link
Contributor Author

What's the status here? The problem is still there... Could you please reopen the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ahamad-MS ahamad-MS

Labels
Event Grid Service Attention Workflow: This issue is responsible by Azure service team.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mikhailshilkov @ahamad-MS @raych1