-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EventGrid (2020-06-10 and 2020-10-15-preview): Swagger Correctness --- Fix swagger for setting readonly for privateEndpointConnections for topic, domain properties #13397
Conversation
…atest preview and stable api version
Hi @ahamad-MS, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
Thank you @JeffreyRichter for the approval. Thanks |
…- Fix swagger for setting readonly for privateEndpointConnections for topic, domain properties (Azure#13397) * fix example * Fix multiple linter and swagger correctness/completeness issues for latest preview and stable api version * Fix format * fix examples * fix validation model errors * fix validation model errors * fix example * remove default * revert 2020-06 changes * fix eventgrid swagger file with multiple linter and correctness fixes * fix 2020-06-01 stable swagger * fix 2020-06-01 stable swagger -- part 2 * fix format * fix prettier check * additional format fix * fix examples and wrong response code * fix validator * fix validator * fix remaining swagger correctness issues * fix end of file * fix lintter * Add readonly tag for privateEndpointConnections for both domain and topic properties * Fix sku default value * fix prettier Co-authored-by: Ashraf Hamad <ahamad@ntdev.microsoft.com>
…- Fix swagger for setting readonly for privateEndpointConnections for topic, domain properties (Azure#13397) * fix example * Fix multiple linter and swagger correctness/completeness issues for latest preview and stable api version * Fix format * fix examples * fix validation model errors * fix validation model errors * fix example * remove default * revert 2020-06 changes * fix eventgrid swagger file with multiple linter and correctness fixes * fix 2020-06-01 stable swagger * fix 2020-06-01 stable swagger -- part 2 * fix format * fix prettier check * additional format fix * fix examples and wrong response code * fix validator * fix validator * fix remaining swagger correctness issues * fix end of file * fix lintter * Add readonly tag for privateEndpointConnections for both domain and topic properties * Fix sku default value * fix prettier Co-authored-by: Ashraf Hamad <ahamad@ntdev.microsoft.com>
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
What's the purpose of the update?
When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
No service side deployment needed. This is existing code/deployment.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
As soon as possible to get green on S360
If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.