-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resource manager statusMessage property has incorrect type. #2355
Comments
After recent discoveries in JSON schema I believe the correct thing to do here is remove the "type" so that statusMessage is treated as a wildcard type. @olydis @fearthecowboy do you agree? |
I believe that should be the case; I think we're still waiting for everyone to fix the generators to get the right behavior everywhere. |
Do we need to wait for that before updating the swagger? |
@olydis is going to verify that there isn't any breaking change to the code model if you do this now. |
Confirmed: The current modeler (the one that does not handle object types properly) generates identical output for |
Looks like the issue is fixed in #2486, I will close it, if any guys has concern or questions, pls reopen it. thanks! |
In https://github.com/Azure/azure-rest-api-specs/blob/master/specification/resources/resource-manager/Microsoft.Resources/stable/2017-05-10/resources.json#L2068. The property statusMessage is defined as object however the service doesn't always return an object (sometimes a string). This results in broken behavior for the Go SDK. The type must be either a string or an object and the service must abide by the specified contract. See Azure/azure-sdk-for-go#938 for more details.
The text was updated successfully, but these errors were encountered: