Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change statusMessage property to wildcard type. #2486

Merged
merged 1 commit into from
Feb 16, 2018

Conversation

jhendrixMSFT
Copy link
Member

@jhendrixMSFT jhendrixMSFT commented Feb 13, 2018

The statusMessage can be a string or a JSON object, so model it as a
wildcard type.

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

The statusMessage can be a string or a JSON object, so model it as a
wildcard type.
@jhendrixMSFT
Copy link
Member Author

Fixes #2355.

@jhendrixMSFT jhendrixMSFT self-assigned this Feb 13, 2018
@azuresdkci azuresdkci assigned mcardosos and unassigned jhendrixMSFT Feb 13, 2018
@azuresdkciprbot
Copy link

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/resources/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 71
After the PR: Warning(s): 0 Error(s): 71

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@AutorestCI
Copy link

AutorestCI commented Feb 13, 2018

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#2003

@AutorestCI
Copy link

AutorestCI commented Feb 13, 2018

Automation for azure-sdk-for-go

Encountered a Subprocess error: (azure-sdk-for-go)

Command: dep ensure
Finished with return code 127
and output:

/bin/sh: 1: dep: not found

@jhendrixMSFT
Copy link
Member Author

@vivsriaus can you please confirm this change applies to all API versions?

@vivsriaus
Copy link
Contributor

@jhendrixMSFT thanks for making this change. Will this be considered a breaking change in SDK? How does the generated code look with these changes?

I'll confirm if this can apply to all API versions today.

@jhendrixMSFT
Copy link
Member Author

@vivsriaus By luck this doesn't introduce any breaking changes while formalizing the behavior (see the linked issue for the details).

@jhendrixMSFT
Copy link
Member Author

@sarangan12 can you please take a look at the Ruby build failure?

Copy link
Contributor

@vivsriaus vivsriaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for making this change!

@sarangan12
Copy link
Contributor

Reason for the Ruby CI Failure:

The root cause of this issue is this PR: #2469 This basically moved a folder to a different location. But, the swagger_to_sdk expects it in the old place. https://github.com/Azure/azure-sdk-for-ruby/blob/master/swagger_to_sdk_config.json#L1214 which is causing the error. I would recommend you to go ahead and merge it for now (if there are no other issues). I will fix the config

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants