-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change statusMessage property to wildcard type. #2486
Conversation
The statusMessage can be a string or a JSON object, so model it as a wildcard type.
Fixes #2355. |
Hi There, I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result: File: AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback Thanks for your co-operation. |
Automation for azure-sdk-for-pythonA PR has been created for you: |
Automation for azure-sdk-for-goEncountered a Subprocess error: (azure-sdk-for-go)
Command: dep ensure /bin/sh: 1: dep: not found |
@vivsriaus can you please confirm this change applies to all API versions? |
@jhendrixMSFT thanks for making this change. Will this be considered a breaking change in SDK? How does the generated code look with these changes? I'll confirm if this can apply to all API versions today. |
@vivsriaus By luck this doesn't introduce any breaking changes while formalizing the behavior (see the linked issue for the details). |
@sarangan12 can you please take a look at the Ruby build failure? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for making this change!
Reason for the Ruby CI Failure: The root cause of this issue is this PR: #2469 This basically moved a folder to a different location. But, the swagger_to_sdk expects it in the old place. https://github.com/Azure/azure-sdk-for-ruby/blob/master/swagger_to_sdk_config.json#L1214 which is causing the error. I would recommend you to go ahead and merge it for now (if there are no other issues). I will fix the config |
The statusMessage can be a string or a JSON object, so model it as a
wildcard type.
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-version
in the path should match theapi-version
in the spec).Quality of Swagger