Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AppServicePlans_CreateOrUpdate is missing 201 reponse #3648

Closed
pietro opened this issue Aug 15, 2018 · 2 comments
Closed

AppServicePlans_CreateOrUpdate is missing 201 reponse #3648

pietro opened this issue Aug 15, 2018 · 2 comments
Labels
App Services Service Attention Workflow: This issue is responsible by Azure service team.

Comments

@pietro
Copy link
Contributor

pietro commented Aug 15, 2018

The definitions on [1] and [2] have responses with 200 and 202 statuses. But the API also returns 201 as seen in hashicorp/terraform-provider-azurerm#917.

[1] https://github.com/Azure/azure-rest-api-specs/blob/master/specification/web/resource-manager/Microsoft.Web/stable/2016-09-01/AppServicePlans.json
[2] https://github.com/Azure/azure-rest-api-specs/blob/master/specification/web/resource-manager/Microsoft.Web/stable/2018-02-01/AppServicePlans.json
pietro pushed a commit to pietro/azure-rest-api-specs that referenced this issue Aug 30, 2018
Add 201 response to AppServicePlans_CreateOrUpdate.
f3abdbf 
Fixes Azure#3648.
This was referenced Aug 30, 2018
Closed
Closed
Closed
@bsiegel bsiegel added the Service Attention Workflow: This issue is responsible by Azure service team. label Sep 26, 2018
@tombuildsstuff
Copy link
Contributor

@marstr would you be able to take a look into this for us? :)

@pietro pietro mentioned this issue Oct 29, 2018
Merged
@pietro
Copy link
Contributor Author

pietro commented Oct 29, 2018

Sorry, I didn't know github would add so many comments to this issue. Anyway, I created a new PR that addresses the issues my first PR had.

pietro added a commit to pietro/azure-rest-api-specs that referenced this issue Jan 17, 2019
@pietro
Add 201 response to AppServicePlans_CreateOrUpdate.
f13c7e5 
Fixes Azure#3648.
sarangan12 pushed a commit that referenced this issue Feb 26, 2019
@pietro @sarangan12
Add 201 response to AppServicePlans_CreateOrUpdate (#4351)
81cd2dd 
* Add 201 response to AppServicePlans_CreateOrUpdate.

Fixes #3648.

* Add examples of 201 response to AppServicePlans_CreateOrUpdate.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
App Services Service Attention Workflow: This issue is responsible by Azure service team.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@bsiegel @pietro @sarangan12 @tombuildsstuff @lmazuel