Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI broken on master since December 4th #8324

Closed
ctaggart opened this issue Feb 6, 2020 · 4 comments
Closed

CI broken on master since December 4th #8324

ctaggart opened this issue Feb 6, 2020 · 4 comments
Assignees
Labels

Comments

@ctaggart
Copy link
Contributor

ctaggart commented Feb 6, 2020

It appears that CI has been failing on the master branch since December 4th when "Enable SDK Automation V2 in CI" was merged. #7548 @NullMDR @akning-ms

image

Can you please figure out how to make CI on master green again?

@PhoenixHe-NV
Copy link
Contributor

The failing of Advocado is a known issue @ruowan . For SDK Automation itself its high failing rate is currently known and expected. Which CI failure do you want to call out @ctaggart ?

@ctaggart
Copy link
Contributor Author

ctaggart commented Feb 7, 2020

Why is it known and expected to have a high failing fate of CI failures on the master branch? If it is just the Advocado tests that are flaky. Why not disable them to make CI green?

On #8296, I'm trying to make CI pass. It is failing on LintDiff and I can't figure out why or reproduce it locally. I began to wonder if it was even passing on master and then I noticed master CI has been broken for two months. Having a broken CI for the master branch in my experience, is usually really bad. I understand, this situation may be different, but I don't currently know why.

@akning-ms
Copy link
Contributor

Thanks @ctaggart , Good feedback, We are working on this issues. for Lint issue, I have replied in PR

@PhoenixHe-NV
Copy link
Contributor

Fixed by #8634

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants