Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable SDK Automation V2 in CI #7548

Merged
merged 3 commits into from
Dec 4, 2019

Conversation

PhoenixHe-NV
Copy link
Contributor

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@AutorestCI
Copy link

AutorestCI commented Oct 18, 2019

Automation for azure-sdk-for-go

Unable to detect any generation context from this PR.

@AutorestCI
Copy link

AutorestCI commented Oct 18, 2019

Automation for azure-sdk-for-python

Unable to detect any generation context from this PR.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 18, 2019

In Testing, Please Ignore

[Logs] (Generated from a9d26b9, Iteration 2)

No readme.md specification configuration files were found that are associated with the files modified in this pull request.

@PhoenixHe-NV PhoenixHe-NV added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Oct 18, 2019
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

- template: .azure-pipelines/SwaggerToSDK.yml
- template: .azure-pipelines/NetworkValidation.yml
- template: .azure-pipelines/Spellcheck.yml
stages:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's difference between stage and job

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stage are set of jobs that could be triggered together with certain condition or work flow.

@yungezz
Copy link
Member

yungezz commented Oct 21, 2019

looks good in general, about when to enable it, need to do it after Ignite, Nov 4th to avoid any impact to Ignite asks.

@PhoenixHe-NV PhoenixHe-NV force-pushed the tih-enable-sdk-automation-v2 branch from d83d1b6 to a9d26b9 Compare October 21, 2019 03:20
@PhoenixHe-NV
Copy link
Contributor Author

@PhoenixHe-NV PhoenixHe-NV force-pushed the tih-enable-sdk-automation-v2 branch from a9d26b9 to 1e90149 Compare November 26, 2019 06:40
@PhoenixHe-NV PhoenixHe-NV force-pushed the tih-enable-sdk-automation-v2 branch from 1e90149 to 643ac03 Compare November 26, 2019 06:47
@PhoenixHe-NV
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@PhoenixHe-NV PhoenixHe-NV removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Dec 3, 2019
@yungezz
Copy link
Member

yungezz commented Dec 3, 2019

i've approved this PR, seems CI status not updated

@PhoenixHe-NV
Copy link
Contributor Author

/azp run automation - sdk

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@PhoenixHe-NV PhoenixHe-NV reopened this Dec 4, 2019
@PhoenixHe-NV
Copy link
Contributor Author

/azp run automation - sdk

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Dec 4, 2019

azure-sdk-for-java - Release

Pending...

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Dec 4, 2019

azure-sdk-for-js - Release

Pending...

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Dec 4, 2019

azure-sdk-for-net - Release

Pending...

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Dec 4, 2019

azure-sdk-for-python - Release

Pending...

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Dec 4, 2019

azure-sdk-for-go - Release

Pending...

@PhoenixHe-NV
Copy link
Contributor Author

/azp run ~ Ignore Test-only (rest-api-specs)

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yungezz
Copy link
Member

yungezz commented Dec 4, 2019

loop @akning-ms for review also

@akning-ms akning-ms merged commit 2e8ca78 into Azure:master Dec 4, 2019
TalluriAnusha pushed a commit to AsrOneSdk/azure-rest-api-specs that referenced this pull request Dec 11, 2019
* Update config for SDK Automation

* Update registry name

* Update display name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants