Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Compute Profile Available #895

Closed
marstr opened this issue Jan 31, 2017 · 20 comments
Closed

New Compute Profile Available #895

marstr opened this issue Jan 31, 2017 · 20 comments
Assignees
Labels
Compute P1 Service Attention Workflow: This issue is responsible by Azure service team.

Comments

@marstr
Copy link
Member

marstr commented Jan 31, 2017

As seen in Azure/azure-sdk-for-go#525 authored by @moritzheiber:

Working with Virtual Machine Scale Sets with Ubuntu using this SDK isn't very easy since it neither allows for Scale Sets to carry extensions, nor, since the compute API is using an outdated version, modification of customData passed to each instance.
However, customData is the only way of passing data to Scale Set instances using the go SDK. This means modifying the customData property will only work if you take down the Scale Set prior to modification.
API version 2016-08-30 does support modification of the customData property and I'ld vouch for a bump in API versions in the compute client, if possible.
//cc @pellepelster @fbernitt

A new Swagger profile needs to be defined to accommodate new functionality in the Azure service.

@colemickens
Copy link

(Hopefully one of these new Compute swaggers will include the MSI-related fields. I have an internal thread about this, but I thought it was worth mentioning here as well)

@moritzheiber
Copy link

Solving this issue would be really helpful because without the newer API specs using Scale Sets is pretty much impossible to get right through the dependent SDKs

@amarzavery
Copy link
Contributor

amarzavery commented Feb 1, 2017 via email

@huangpf
Copy link
Contributor

huangpf commented Feb 1, 2017

2016-08-30 doesn't seem to be an official API version. Is it for a special or preview release or internal customers?

@moritzheiber
Copy link

I was referencing this support thread in my issue submitted for the Golang SDK.

@huangpf
Copy link
Contributor

huangpf commented Feb 1, 2017

From the Compute spec, you can see there is no such official API version:
https://github.com/Azure/azure-rest-api-specs/tree/master/arm-compute

But I believe AutoRest generated API in any language supports overriding the request being sent, please refer to how this C# handler is defined:
https://github.com/Azure/azure-sdk-for-net/blob/AutoRest/src/ResourceManagement/Compute/Compute.Tests/Helpers/RecordedDelegatingHandler.cs

I don't think we have a plan to add a spec with that API version, but I would like to add @singhkays to help confirm.

@moritzheiber
Copy link

So you're saying there is an API version, but it's unofficial, thus there will be no support inside the official SDKs?

@huangpf
Copy link
Contributor

huangpf commented Feb 1, 2017

This needs service team's confirmation, awaiting @singhkays.

@singhkays
Copy link

Sorry @huangpf, I don't own this. From the linked support thread looks like @gbowerman might have some knowledge of this re:VMSS. Also adding @stephbaron for Compute spec question.

@moritzheiber
Copy link

moritzheiber commented Feb 1, 2017

To provide some context: Asking the AzureCloud API itself about the providers available and their respective API versions returns the following snippet for virtualMachineScaleSets:

{
  "aliases": null,
  "apiVersions": [
    "2016-08-30",
    "2016-03-30",
    "2015-06-15",
    "2015-05-01-preview"
  ],
  "locations": [
    "East US",
    "East US 2",
    "West US",
    "Central US",
    "North Central US",
    "South Central US",
    "North Europe",
    "West Europe",
    "East Asia",
    "Southeast Asia",
    "Japan East",
    "Japan West",
    "Australia East",
    "Australia Southeast",
    "Brazil South",
    "Canada Central",
    "Canada East",
    "West US 2",
    "West Central US",
    "UK South",
    "UK West"
  ],
  "properties": null,
  "resourceType": "virtualMachineScaleSets"
}

That's why I was expecting these specs to support the API version I mentioned.

@gbowerman
Copy link
Contributor

The currently valid Compute API versions are: 2016-03-30 and 2016-04-30-preview.
Despite the preview moniker the latter will be one we recommend to use in production starting next week (2/8). A little while after that it will be 2017-03-30. Therefore the AzureCloud API should return these values (and possibly the 2016-06-15 one as well though I hope no-one uses it since it was before scale set GA).

@moritzheiber
Copy link

moritzheiber commented Feb 2, 2017

@gbowerman Okay, I understand. Three questions though:

  1. Why is the API returning the (supposedly unsupported) version 2016-08-30 as "available" then?
  2. Why do you recommend using version 2016-08-30 in the linked support thread?
  3. Shouldn't the SDK not be a representation of what's available, and not what's recommended? I mean, it's not like your target audience are toddlers .. ?

I'm not trying to be obnoxious here, but the feature I'm after is only supported by the newer API version, and, according to the Azure API, it seems like it's supposed to be supported, thus I was looking for support in the official SDK as well.

Am I missing something? Just trying to make sense of it.

@gbowerman
Copy link
Contributor

gbowerman commented Feb 2, 2017

@moritzheiber as I understand it, 1, 2, 3 above are bugs we need to fix. Your questions are not obnoxious. They are a useful elucidation of the problem. I've started a thread with the Compute API owners - various Compute resources have the same and apparently invalid dates.

@kirthik kirthik added the Compute label Feb 2, 2017
@hassanbabaie
Copy link

@gbowerman Hi Guy, it doesn't look like Microsoft's API documentation has changed, do you know if the move to 2016-04-30-preview is delayed?

@gbowerman
Copy link
Contributor

@hassanbabaie 2016-04-30-preview is GA today. Hopefully you'll see the API updated shortly.

@hassanbabaie
Copy link

@gbowerman yes spotted it now, thanks!

@kirthik
Copy link
Contributor

kirthik commented Feb 15, 2017

@gbowerman , @stephbaron : Please close this if the issue is resolved.

@kirthik kirthik assigned gbowerman and stephbaron and unassigned veronicagg Feb 15, 2017
@kirthik kirthik added the P1 label Feb 15, 2017
@moritzheiber
Copy link

Err, how's 2016-04-30-preview going GA solving this issue? I will still be unable to use Scale Sets properly ..

@cberner
Copy link

cberner commented Apr 5, 2017

It looks like 2017-03-30 has been released, could that be added? We're still blocked on using Scale Sets because the custom_data field can't be modified under the 2016-04-30-preview API version.

> az provider list
...
"apiVersions": [
          "2017-03-30",
          "2016-08-30",
          "2016-04-30-preview",
          "2016-03-30",
          "2015-06-15",
          "2015-05-01-preview"
        ],

@bsiegel bsiegel added the Service Attention Workflow: This issue is responsible by Azure service team. label Sep 26, 2018
@salameer
Copy link
Member

salameer commented Oct 9, 2018

Closing due to inactivity

@salameer salameer closed this as completed Oct 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Compute P1 Service Attention Workflow: This issue is responsible by Azure service team.
Projects
None yet
Development

No branches or pull requests