-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Access Reviews schema #10010
Added Access Reviews schema #10010
Conversation
[Staging] Swagger Validation Report
️✔️ |
Azure Pipelines successfully started running 1 pipeline(s). |
Trenton Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-go
|
azure-sdk-for-java
|
Azure CLI Extension Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-js
|
azure-sdk-for-python
|
azure-sdk-for-net
|
Can one of the admins verify this patch? |
e876f9c
to
74e7450
Compare
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-python-track2
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
74e7450
to
534ae71
Compare
Azure Pipelines successfully started running 1 pipeline(s). |
534ae71
to
ea0885f
Compare
Azure Pipelines successfully started running 1 pipeline(s). |
ea0885f
to
01d8895
Compare
Azure Pipelines successfully started running 1 pipeline(s). |
01d8895
to
84562ba
Compare
Azure Pipelines successfully started running 1 pipeline(s). |
84562ba
to
67fffef
Compare
Azure Pipelines successfully started running 1 pipeline(s). |
@qianwens can you please take a look at these changes? |
Azure Pipelines successfully started running 1 pipeline(s). |
67fffef
to
88288a6
Compare
Azure Pipelines successfully started running 1 pipeline(s). |
88288a6
to
5923e10
Compare
Azure Pipelines successfully started running 1 pipeline(s). |
5923e10
to
9efaec3
Compare
Azure Pipelines successfully started running 1 pipeline(s). |
@qianwens I've added a DoNotMerge label for the moment since I want to release the SDK after we've pushed out some service updates. I'll remove it as soon as the service updates are deployed and remove this label. We can merge it then. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did diff between approved private PR and this one. Delta looks good to me.
Is this PR still needed? If so, Please close this PR and create a new one since this one has exceeded 3 months. |
Hi, @shubhamguptacal. The PR has be closed for a long time and it's related branch still exist. If no further used for over 14 days, I will delete this related branch. Please tell me if you still need this branch. |
Hi, @shubhamguptacal. The PR has be closed for a long time and it's related branch still exist. Please tell me if you still need this branch or i will delete it in 14 days. |
2 similar comments
Hi, @shubhamguptacal. The PR has be closed for a long time and it's related branch still exist. Please tell me if you still need this branch or i will delete it in 14 days. |
Hi, @shubhamguptacal. The PR has be closed for a long time and it's related branch still exist. Please tell me if you still need this branch or i will delete it in 14 days. |
IGA (Identity Governance and Administration group) has a service called access reviews. The access reviews scenario for ARM involves reviewing access of user resource assignments. There is documentation for the scenario available here.
This PR includes exposure of Access Review APIs in the existing resource provider Microsoft.Authorization. We already had a preliminary review meeting with Kristopher Bash in this regard and the PR against the private repo was already reviewed : https://github.com/Azure/azure-rest-api-specs-pr/pull/1213