Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Access Reviews schema #10010

Closed
wants to merge 1 commit into from
Closed

Added Access Reviews schema #10010

wants to merge 1 commit into from

Conversation

shubhamguptacal
Copy link
Contributor

@shubhamguptacal shubhamguptacal commented Jul 1, 2020

IGA (Identity Governance and Administration group) has a service called access reviews. The access reviews scenario for ARM involves reviewing access of user resource assignments. There is documentation for the scenario available here.

This PR includes exposure of Access Review APIs in the existing resource provider Microsoft.Authorization. We already had a preliminary review meeting with Kristopher Bash in this regard and the PR against the private repo was already reviewed : https://github.com/Azure/azure-rest-api-specs-pr/pull/1213

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jul 1, 2020

[Staging] Swagger Validation Report

️✔️BreakingChange [Detail]
 There are no breaking changes. 
️✔️LintDiff [Detail]
 Validation passes for LintDiff. 
️✔️Avocado [Detail]
 Validation passes for Avocado. 
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 1, 2020

Trenton Generation

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 1, 2020

azure-sdk-for-go

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 1, 2020

azure-sdk-for-java

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 1, 2020

Azure CLI Extension Generation

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 1, 2020

azure-sdk-for-js

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 9efaec3 with merge commit bb9847a223172a9cae7cab51a09b660b28450247. SDK Automation 13.0.17.20200619.4
  • ️✔️@azure/arm-authorization [View full logs]  [Preview SDK Changes]
    Only show 100 items here, please refer to log for details.
    [npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
    [npmPack] npm WARN deprecated resolve-url@0.2.1: https://github.com/lydell/resolve-url#deprecated
    [npmPack] npm WARN deprecated urix@0.1.0: Please see https://github.com/lydell/urix#deprecated
    [npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
    [npmPack] loaded rollup.config.js with warnings
    [npmPack] (!) Unused external imports
    [npmPack] default imported from external module 'rollup' but never used
    [npmPack] 
    [npmPack] ./esm/authorizationManagementClient.js → ./dist/arm-authorization.js...
    [npmPack] created ./dist/arm-authorization.js in 357ms
    [npmPack] npm notice 
    [npmPack] npm notice package: @azure/arm-authorization@8.3.2
    [npmPack] npm notice === Tarball Contents === 
    [npmPack] npm notice 87.1kB  dist/arm-authorization.js                                      
    [npmPack] npm notice 29.3kB  dist/arm-authorization.min.js                                  
    [npmPack] npm notice 2.1kB   esm/authorizationManagementClient.js                           
    [npmPack] npm notice 2.5kB   esm/authorizationManagementClientContext.js                    
    [npmPack] npm notice 2.5kB   esm/operations/classicAdministrators.js                        
    [npmPack] npm notice 470B    esm/models/classicAdministratorsMappers.js                     
    [npmPack] npm notice 9.5kB   esm/operations/denyAssignments.js                              
    [npmPack] npm notice 489B    esm/models/denyAssignmentsMappers.js                           
    [npmPack] npm notice 1.6kB   esm/operations/globalAdministrator.js                          
    [npmPack] npm notice 414B    esm/models/globalAdministratorMappers.js                       
    [npmPack] npm notice 345B    esm/models/index.js                                            
    [npmPack] npm notice 623B    esm/operations/index.js                                        
    [npmPack] npm notice 22.5kB  esm/models/mappers.js                                          
    [npmPack] npm notice 5.2kB   esm/models/parameters.js                                       
    [npmPack] npm notice 4.8kB   esm/operations/permissions.js                                  
    [npmPack] npm notice 439B    esm/models/permissionsMappers.js                               
    [npmPack] npm notice 3.5kB   esm/operations/providerOperationsMetadataOperations.js         
    [npmPack] npm notice 530B    esm/models/providerOperationsMetadataOperationsMappers.js      
    [npmPack] npm notice 13.0kB  esm/operations/roleAssignments.js                              
    [npmPack] npm notice 484B    esm/models/roleAssignmentsMappers.js                           
    [npmPack] npm notice 6.0kB   esm/operations/roleDefinitions.js                              
    [npmPack] npm notice 464B    esm/models/roleDefinitionsMappers.js                           
    [npmPack] npm notice 1.0kB   rollup.config.js                                               
    [npmPack] npm notice 1.7kB   package.json                                                   
    [npmPack] npm notice 457B    tsconfig.json                                                  
    [npmPack] npm notice 216.9kB dist/arm-authorization.js.map                                  
    [npmPack] npm notice 27.6kB  dist/arm-authorization.min.js.map                              
    [npmPack] npm notice 860B    esm/authorizationManagementClient.d.ts.map                     
    [npmPack] npm notice 1.1kB   esm/authorizationManagementClient.js.map                       
    [npmPack] npm notice 493B    esm/authorizationManagementClientContext.d.ts.map              
    [npmPack] npm notice 1.4kB   esm/authorizationManagementClientContext.js.map                
    [npmPack] npm notice 1.1kB   esm/operations/classicAdministrators.d.ts.map                  
    [npmPack] npm notice 1.5kB   esm/operations/classicAdministrators.js.map                    
    [npmPack] npm notice 227B    esm/models/classicAdministratorsMappers.d.ts.map               
    [npmPack] npm notice 240B    esm/models/classicAdministratorsMappers.js.map                 
    [npmPack] npm notice 4.4kB   esm/operations/denyAssignments.d.ts.map                        
    [npmPack] npm notice 5.9kB   esm/operations/denyAssignments.js.map                          
    [npmPack] npm notice 235B    esm/models/denyAssignmentsMappers.d.ts.map                     
    [npmPack] npm notice 248B    esm/models/denyAssignmentsMappers.js.map                       
    [npmPack] npm notice 621B    esm/operations/globalAdministrator.d.ts.map                    
    [npmPack] npm notice 891B    esm/operations/globalAdministrator.js.map                      
    [npmPack] npm notice 197B    esm/models/globalAdministratorMappers.d.ts.map                 
    [npmPack] npm notice 210B    esm/models/globalAdministratorMappers.js.map                   
    [npmPack] npm notice 13.3kB  esm/models/index.d.ts.map                                      
    [npmPack] npm notice 275B    esm/operations/index.d.ts.map                                  
    [npmPack] npm notice 126B    esm/models/index.js.map                                        
    [npmPack] npm notice 290B    esm/operations/index.js.map                                    
    [npmPack] npm notice 1.2kB   esm/models/mappers.d.ts.map                                    
    [npmPack] npm notice 12.2kB  esm/models/mappers.js.map                                      
    [npmPack] npm notice 1.2kB   esm/models/parameters.d.ts.map                                 
    [npmPack] npm notice 4.0kB   esm/models/parameters.js.map                                   
    [npmPack] npm notice 2.1kB   esm/operations/permissions.d.ts.map                            
    [npmPack] npm notice 2.8kB   esm/operations/permissions.js.map                              
    [npmPack] npm notice 204B    esm/models/permissionsMappers.d.ts.map                         
    [npmPack] npm notice 217B    esm/models/permissionsMappers.js.map                           
    [npmPack] npm notice 1.5kB   esm/operations/providerOperationsMetadataOperations.d.ts.map   
    [npmPack] npm notice 2.0kB   esm/operations/providerOperationsMetadataOperations.js.map     
    [npmPack] npm notice 280B    esm/models/providerOperationsMetadataOperationsMappers.d.ts.map
    [npmPack] npm notice 293B    esm/models/providerOperationsMetadataOperationsMappers.js.map  
    [npmPack] npm notice 6.2kB   esm/operations/roleAssignments.d.ts.map                        
    [npmPack] npm notice 8.3kB   esm/operations/roleAssignments.js.map                          
    [npmPack] npm notice 225B    esm/models/roleAssignmentsMappers.d.ts.map                     
    [npmPack] npm notice 238B    esm/models/roleAssignmentsMappers.js.map                       
    [npmPack] npm notice 2.9kB   esm/operations/roleDefinitions.d.ts.map                        
    [npmPack] npm notice 3.8kB   esm/operations/roleDefinitions.js.map                          
    [npmPack] npm notice 222B    esm/models/roleDefinitionsMappers.d.ts.map                     
    [npmPack] npm notice 235B    esm/models/roleDefinitionsMappers.js.map                       
    [npmPack] npm notice 3.3kB   README.md                                                      
    [npmPack] npm notice 1.4kB   esm/authorizationManagementClient.d.ts                         
    [npmPack] npm notice 2.3kB   src/authorizationManagementClient.ts                           
    [npmPack] npm notice 809B    esm/authorizationManagementClientContext.d.ts                  
    [npmPack] npm notice 2.3kB   src/authorizationManagementClientContext.ts                    
    [npmPack] npm notice 2.3kB   esm/operations/classicAdministrators.d.ts                      
    [npmPack] npm notice 4.6kB   src/operations/classicAdministrators.ts                        
    [npmPack] npm notice 160B    esm/models/classicAdministratorsMappers.d.ts                   
    [npmPack] npm notice 421B    src/models/classicAdministratorsMappers.ts                     
    [npmPack] npm notice 12.3kB  esm/operations/denyAssignments.d.ts                            
    [npmPack] npm notice 22.4kB  src/operations/denyAssignments.ts                              
    [npmPack] npm notice 179B    esm/models/denyAssignmentsMappers.d.ts                         
    [npmPack] npm notice 450B    src/models/denyAssignmentsMappers.ts                           
    [npmPack] npm notice 1.1kB   esm/operations/globalAdministrator.d.ts                        
    [npmPack] npm notice 2.2kB   src/operations/globalAdministrator.ts                          
    [npmPack] npm notice 104B    esm/models/globalAdministratorMappers.d.ts                     
    [npmPack] npm notice 363B    src/models/globalAdministratorMappers.ts                       
    [npmPack] npm notice 37.0kB  esm/models/index.d.ts                                          
    [npmPack] npm notice 307B    esm/operations/index.d.ts                                      
    [npmPack] npm notice 35.3kB  src/models/index.ts                                            

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 1, 2020

azure-sdk-for-python

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 9efaec3 with merge commit bb9847a223172a9cae7cab51a09b660b28450247. SDK Automation 13.0.17.20200619.4
  • ️✔️azure-mgmt-authorization [View full logs]  [Preview SDK Changes]
    [build_conf] INFO:packaging_tools:Building template azure-mgmt-authorization
    [build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
    [build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
    [build_conf] INFO:packaging_tools:Template done azure-mgmt-authorization
    [after_scripts|python] INFO:__main__:Default API version will be: v2018_09_01_preview
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
    [ChangeLog] Size of delta 58.355% size of original (original: 38192 chars, delta: 22287 chars)
    [ChangeLog] **Features**
    [ChangeLog] 
    [ChangeLog]   - Added operation group AccessReviewDefaultSettingsOperations
    [ChangeLog]   - Added operation group AccessReviewInstanceDecisionsOperations
    [ChangeLog]   - Added operation group AccessReviewInstanceOperations
    [ChangeLog]   - Added operation group AccessReviewInstancesOperations
    [ChangeLog]   - Added operation group AccessReviewScheduleDefinitionsOperations
    [ChangeLog]   - Added operation group Operations

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 1, 2020

azure-sdk-for-net

️✔️ succeeded [Logs] [Expand Details]

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 1, 2020

azure-sdk-for-python-track2

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@shubhamguptacal
Copy link
Contributor Author

@qianwens can you please take a look at these changes?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@shubhamguptacal shubhamguptacal added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Jul 7, 2020
@shubhamguptacal
Copy link
Contributor Author

@qianwens I've added a DoNotMerge label for the moment since I want to release the SDK after we've pushed out some service updates. I'll remove it as soon as the service updates are deployed and remove this label. We can merge it then.

@majastrz majastrz added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Aug 4, 2020
Copy link
Member

@majastrz majastrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did diff between approved private PR and this one. Delta looks good to me.

@qianwens
Copy link
Member

Is this PR still needed? If so, Please close this PR and create a new one since this one has exceeded 3 months.

@qianwens qianwens closed this Nov 5, 2020
@JackTn
Copy link
Member

JackTn commented Aug 23, 2021

Hi, @shubhamguptacal. The PR has be closed for a long time and it's related branch still exist. If no further used for over 14 days, I will delete this related branch. Please tell me if you still need this branch.

@JackTn
Copy link
Member

JackTn commented Jun 16, 2022

Hi, @shubhamguptacal. The PR has be closed for a long time and it's related branch still exist. Please tell me if you still need this branch or i will delete it in 14 days.

2 similar comments
@JackTn
Copy link
Member

JackTn commented Jun 16, 2022

Hi, @shubhamguptacal. The PR has be closed for a long time and it's related branch still exist. Please tell me if you still need this branch or i will delete it in 14 days.

@JackTn
Copy link
Member

JackTn commented Jun 16, 2022

Hi, @shubhamguptacal. The PR has be closed for a long time and it's related branch still exist. Please tell me if you still need this branch or i will delete it in 14 days.

@JackTn JackTn deleted the accessreviews branch July 5, 2022 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review DoNotMerge <valid label in PR review process> use to hold merge after approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants