-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding swagger files for 2020-02-02-preview API version for ManagedInstance operation group #10150
Adding swagger files for 2020-02-02-preview API version for ManagedInstance operation group #10150
Conversation
… 2015-05-01-preview API version for ManagedInstnces operation group
Pipelines were unable to run due to time out waiting for the pull request to finish merging. |
[Staging] Swagger Validation Report
️✔️ |
Can one of the admins verify this patch? |
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-js - Release
|
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-go - Release
|
azure-sdk-for-java - Release
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-python - Release
- Breaking Change detected in SDK
|
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-net - Release
|
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
@ChenTanyi Can you take a look at this, or assign whoever is needed. We are looking to publish documentation until August 5th |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New API needs ARM side review first. From sdk side, please add sdk generation with specific language for this api-version.
@@ -495,6 +495,7 @@ input-file: | |||
- ./Microsoft.Sql/preview/2020-02-02-preview/ServerSecurityAlertPolicies.json | |||
- ./Microsoft.Sql/preview/2020-02-02-preview/operations.json | |||
- ./Microsoft.Sql/preview/2020-02-02-preview/managedDatabases.json | |||
- ./Microsoft.Sql/preview/2020-02-02-preview/managedInstances.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems the 2020-02-02-preview
hasn't been added to SDK generation in readme.*.md
. Please add specific language for sdk generation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ChenTanyi . I tried to do this, but I am not sure what needs to be changed. We need .Net SDK generation and Python SDK generation for PS and CLI clients. For the path "specification/sql/resource-manager/" I don't see any readme.csharp.md or readme.python.md files, and all api versions from all time are here. Can you help me pointing out in more details what is missing? Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
csharp is https://github.com/Azure/azure-rest-api-specs/tree/3336f84f2e03b2f201ccdae0ceeb4a2d087354d9/specification/sql/resource-manager#c
python is https://github.com/Azure/azure-rest-api-specs/tree/3336f84f2e03b2f201ccdae0ceeb4a2d087354d9/specification/sql/resource-manager#python
It seems both of they don't need specific version in readme. If you only need these two SDK, maybe it no need to change.
…eeded for swagger generation
Azure Pipelines successfully started running 1 pipeline(s). |
Pull request contains merge conflicts. |
Merging azure-rest-api-specs master to petrajkogit/azure-rest-api-specs
No commit pushedDate could be found for PR 10150 in repo Azure/azure-rest-api-specs |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is OK to merge if you don't need any other SDK generation.
Please tell me when you want to merge.
@ChenTanyi Thanks, yes it is ready to merge |
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.