Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the CSharp, Python and GO SDK namespace to Microsoft.Migrate.ResourceMover and … #10661

Merged
merged 4 commits into from
Sep 9, 2020

Conversation

ajaygit158
Copy link
Member

…updated the output folder to match the folder structure in .NET SDK.

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Sep 1, 2020

[Staging] Swagger Validation Report

️✔️BreakingChange [Detail]
 There are no breaking changes. 
️✔️LintDiff [Detail]
 Validation passes for LintDiff. 
️✔️Avocado [Detail]
 Validation passes for Avocado. 
️✔️ModelValidation [Detail]
 Validation passes for ModelValidation. 
️✔️SemanticValidation [Detail]
 Validation passes for SemanticValidation. 
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 1, 2020

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 1, 2020

azure-sdk-for-net - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 1, 2020

azure-sdk-for-java - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from b7867a9 with merge commit 38e0aab. SDK Automation 13.0.17.20200904.2
    Failed to find any diff after autorest so no changed packages was found.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 1, 2020

azure-sdk-for-js - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from b7867a9 with merge commit 38e0aab. SDK Automation 13.0.17.20200904.2
    Failed to find any diff after autorest so no changed packages was found.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 1, 2020

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 1, 2020

azure-sdk-for-python - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from b7867a9 with merge commit 38e0aab. SDK Automation 13.0.17.20200904.2
    Failed to close the generation pull request at https://github.com/AzureSDKAutomation/azure-sdk-for-python/pull/1952: HttpError: Reference does not exist, {"name":"HttpError","status":422,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-length":"122","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Wed, 09 Sep 2020 04:04:49 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"422 Unprocessable Entity","strict-transport-security":"max-age=31536000; includeSubdomains; preload","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; format=json","x-github-request-id":"07D8:5589:11982F3:15A673C:5F585461","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4663","x-ratelimit-reset":"1599624984","x-ratelimit-used":"337","x-xss-protection":"1; mode=block"},"request":{"method":"DELETE","url":"https://api.github.com/repos/AzureSDKAutomation/azure-sdk-for-python/git/refs/heads/sdkAutomation/azure-mgmt-resourcemover@10661","headers":{"accept":"application/vnd.github.v3+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"token [REDACTED]","content-length":0},"request":{"validate":{"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest/reference/git#delete-a-reference"}
    Failed to close the generation pull request at https://github.com/AzureSDKAutomation/azure-sdk-for-python/pull/1930: HttpError: Reference does not exist, {"name":"HttpError","status":422,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-length":"122","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Wed, 09 Sep 2020 04:04:49 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"422 Unprocessable Entity","strict-transport-security":"max-age=31536000; includeSubdomains; preload","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; format=json","x-github-request-id":"07D9:7F86:179E9E7:1D606F6:5F585461","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4661","x-ratelimit-reset":"1599624984","x-ratelimit-used":"339","x-xss-protection":"1; mode=block"},"request":{"method":"DELETE","url":"https://api.github.com/repos/AzureSDKAutomation/azure-sdk-for-python/git/refs/heads/sdkAutomation/track2_azure-mgmt-regionmove@10661","headers":{"accept":"application/vnd.github.v3+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"token [REDACTED]","content-length":0},"request":{"validate":{"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest/reference/git#delete-a-reference"}
    Failed to close the generation pull request at https://github.com/AzureSDKAutomation/azure-sdk-for-python/pull/1929: HttpError: Reference does not exist, {"name":"HttpError","status":422,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-length":"122","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Wed, 09 Sep 2020 04:04:49 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"422 Unprocessable Entity","strict-transport-security":"max-age=31536000; includeSubdomains; preload","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; format=json","x-github-request-id":"07DA:2F3D:59A4D1:70921C:5F585461","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4660","x-ratelimit-reset":"1599624984","x-ratelimit-used":"340","x-xss-protection":"1; mode=block"},"request":{"method":"DELETE","url":"https://api.github.com/repos/AzureSDKAutomation/azure-sdk-for-python/git/refs/heads/sdkAutomation/azure-mgmt-regionmove@10661","headers":{"accept":"application/vnd.github.v3+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"token [REDACTED]","content-length":0},"request":{"validate":{"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest/reference/git#delete-a-reference"}
    [azure-mgmt-resourcemover][ChangeLog] WARNING: Failed to generate ChangeLog.
  • ⚠️azure-mgmt-resourcemover [View full logs]  [Release SDK Changes]
    [build_conf] INFO:packaging_tools:Building template azure-mgmt-resourcemover
    [build_conf] INFO:packaging_tools.conf:Build default conf for azure-mgmt-resourcemover
    [build_conf] INFO:packaging_tools:Template done azure-mgmt-resourcemover
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [build_package] /z/venv/lib/python3.6/site-packages/setuptools/dist.py:397: UserWarning: Normalizing '0.1.0-preview' to '0.1.0rc0'
    [build_package]   normalized_version,
    [build_package] warning: no files found matching '*.py' under directory 'tests'
    [build_package] warning: no files found matching '*.yaml' under directory 'tests'
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [build_package] /z/venv/lib/python3.6/site-packages/setuptools/dist.py:397: UserWarning: Normalizing '0.1.0-preview' to '0.1.0rc0'
    [build_package]   normalized_version,
    [build_package] warning: no files found matching '*.py' under directory 'tests'
    [build_package] warning: no files found matching '*.yaml' under directory 'tests'
    [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
    Not exact 2 reports found:
    code_reports/latest/report.json
    Not generating changelog.
    [ChangeLog] WARNING: Failed to generate ChangeLog.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 1, 2020

azure-sdk-for-python-track2 - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from b7867a9 with merge commit 38e0aab. SDK Automation 13.0.17.20200904.2
    Failed to close the generation pull request at https://github.com/AzureSDKAutomation/azure-sdk-for-python/pull/1951: HttpError: Reference does not exist, {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Wed, 09 Sep 2020 04:04:50 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; format=json","x-github-request-id":"040C:5DBE:1D50E02A:236994CB:5F585461","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4657","x-ratelimit-reset":"1599624984","x-ratelimit-used":"343","x-xss-protection":"1; mode=block"},"request":{"method":"DELETE","url":"https://api.github.com/repos/AzureSDKAutomation/azure-sdk-for-python/git/refs/heads/sdkAutomation/track2_azure-mgmt-resourcemover@10661","headers":{"accept":"application/vnd.github.v3+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"token [REDACTED]","content-length":0},"request":{"validate":{"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest/reference/git#delete-a-reference"}
    [AutoRest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'MoveResourceProperties-sourceResourceSettings' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
    [AutoRest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'MoveResourceProperties-moveStatus' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
    [AutoRest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'MoveResourceProperties-errors' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
    [AutoRest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'SubnetReference' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
    [AutoRest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'LoadBalancerBackendAddressPoolReference' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
    [AutoRest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'LoadBalancerNatRuleReference' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
    [AutoRest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'SqlServerResourceSettings' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
    [AutoRest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'ResourceGroupResourceSettings' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'MoveResourceProperties-sourceResourceSettings' with an undefined type and 'allOf'/'anyOf'/'oneOf' is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'MoveResourceProperties-moveStatus' with an undefined type and 'allOf'/'anyOf'/'oneOf' is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'MoveResourceProperties-errors' with an undefined type and 'allOf'/'anyOf'/'oneOf' is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'MoveResourceFilter' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'MoveResourceFilterProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'MoveResourceError' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'MoveResourceErrorBody' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'CloudError' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'CloudErrorBody' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    [track2_azure-mgmt-resourcemover][ChangeLog] WARNING: Failed to generate ChangeLog.
  • ⚠️azure-mgmt-resourcemover [View full logs]  [Release SDK Changes]
    [build_conf_init]   Cache entry deserialization failed, entry ignored
    [build_conf_init]   Cache entry deserialization failed, entry ignored
    [build_conf] INFO:packaging_tools:Building template azure-mgmt-resourcemover
    [build_conf] INFO:packaging_tools.conf:Build default conf for azure-mgmt-resourcemover
    [build_conf] INFO:packaging_tools:Template done azure-mgmt-resourcemover
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [build_package] /z/venv/lib/python3.6/site-packages/setuptools/dist.py:397: UserWarning: Normalizing '0.1.0-preview' to '0.1.0rc0'
    [build_package]   normalized_version,
    [build_package] warning: no files found matching '*.py' under directory 'tests'
    [build_package] warning: no files found matching '*.yaml' under directory 'tests'
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [build_package] /z/venv/lib/python3.6/site-packages/setuptools/dist.py:397: UserWarning: Normalizing '0.1.0-preview' to '0.1.0rc0'
    [build_package]   normalized_version,
    [build_package] warning: no files found matching '*.py' under directory 'tests'
    [build_package] warning: no files found matching '*.yaml' under directory 'tests'
    [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
    Not exact 2 reports found:
    code_reports/latest/report.json
    Not generating changelog.
    [ChangeLog] WARNING: Failed to generate ChangeLog.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 1, 2020

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 1, 2020

azure-resource-manager-schemas - Release

⚠️ warning [Logs] [Expand Details]

@leni-msft
Copy link
Contributor

@allenjzhang pls help check this PR regarding .NET SDK

@ajaygit158 ajaygit158 force-pushed the ajgupt/UpdateCsharpSdkNamespace branch from 2da282c to c6b2c82 Compare September 3, 2020 02:39
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ajaygit158 ajaygit158 changed the title Updated the CSharp SDK namespace to Microsoft.Migrate.RegionMove and … Updated the CSharp, Python and GO SDK namespace to Microsoft.Migrate.RegionMove and … Sep 3, 2020
@ajaygit158 ajaygit158 changed the title Updated the CSharp, Python and GO SDK namespace to Microsoft.Migrate.RegionMove and … Updated the CSharp, Python and GO SDK namespace to Microsoft.Migrate.ResourceMover and … Sep 3, 2020
@ajaygit158 ajaygit158 added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Sep 3, 2020
@allenjzhang allenjzhang removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Sep 3, 2020
@leni-msft
Copy link
Contributor

@ajaygit158 @allenjzhang Is this PR ready to merge?

@ajaygit158 ajaygit158 force-pushed the ajgupt/UpdateCsharpSdkNamespace branch from c6b2c82 to 0cbd315 Compare September 9, 2020 02:25
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@leni-msft leni-msft self-requested a review September 9, 2020 03:19
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@leni-msft leni-msft merged commit 38e0aab into Azure:master Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants