-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated the CSharp, Python and GO SDK namespace to Microsoft.Migrate.ResourceMover and … #10661
Merged
leni-msft
merged 4 commits into
Azure:master
from
ajaygit158:ajgupt/UpdateCsharpSdkNamespace
Sep 9, 2020
Merged
Updated the CSharp, Python and GO SDK namespace to Microsoft.Migrate.ResourceMover and … #10661
leni-msft
merged 4 commits into
Azure:master
from
ajaygit158:ajgupt/UpdateCsharpSdkNamespace
Sep 9, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Staging] Swagger Validation Report
️✔️ |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-net - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-go - Release
|
azure-sdk-for-python - Release
|
azure-sdk-for-python-track2 - Release
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-resource-manager-schemas - Release
|
This was referenced Sep 1, 2020
@allenjzhang pls help check this PR regarding .NET SDK |
ajaygit158
force-pushed
the
ajgupt/UpdateCsharpSdkNamespace
branch
from
September 3, 2020 02:39
2da282c
to
c6b2c82
Compare
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Sep 3, 2020
ajaygit158
changed the title
Updated the CSharp SDK namespace to Microsoft.Migrate.RegionMove and …
Updated the CSharp, Python and GO SDK namespace to Microsoft.Migrate.RegionMove and …
Sep 3, 2020
ajaygit158
changed the title
Updated the CSharp, Python and GO SDK namespace to Microsoft.Migrate.RegionMove and …
Updated the CSharp, Python and GO SDK namespace to Microsoft.Migrate.ResourceMover and …
Sep 3, 2020
ajaygit158
added
the
DoNotMerge
<valid label in PR review process> use to hold merge after approval
label
Sep 3, 2020
allenjzhang
removed
the
DoNotMerge
<valid label in PR review process> use to hold merge after approval
label
Sep 3, 2020
@ajaygit158 @allenjzhang Is this PR ready to merge? |
…updated the output folder to match the folder structure in .NET SDK.
ajaygit158
force-pushed
the
ajgupt/UpdateCsharpSdkNamespace
branch
from
September 9, 2020 02:25
c6b2c82
to
0cbd315
Compare
Azure Pipelines successfully started running 1 pipeline(s). |
leni-msft
suggested changes
Sep 9, 2020
Azure Pipelines successfully started running 1 pipeline(s). |
leni-msft
approved these changes
Sep 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…updated the output folder to match the folder structure in .NET SDK.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.