-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update VmssVMExtension to use SubResource #10745
Conversation
List to include VmssVm extension
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-python - Release
- Breaking Change detected in SDK
|
azure-sdk-for-net - Release
|
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-java - Release
|
azure-sdk-for-js - Release
|
azure-resource-manager-schemas - Release
|
azure-sdk-for-python-track2 - Release
- Breaking Change detected in SDK
|
azure-sdk-for-go - Release
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
specification/compute/resource-manager/Microsoft.Compute/stable/2020-06-01/compute.json
Show resolved
Hide resolved
Remove the WaitForARMFeedback since this PR does not need ARM's feedback |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Hi @sds6 how is the breaking change review going? |
I have started the process through template https://msazure.visualstudio.com/One/_workitems/edit/8570769 |
Azure Pipelines successfully started running 1 pipeline(s). |
Hi @sds6, one or multiple breaking change(s) is detected in your PR. Pls follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
Hi @sds6, are there any updates on this? |
HI, I have started the review process here : |
* change to sub resource. List to include VmssVm extension * remove location from example * add name and type * make name readonly * remove location Co-authored-by: Sachin Doddaiah Shylaja <sadoddai@microsoft.com>
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.