task1212475-addtrack2 #10860
Merged
task1212475-addtrack2 #10860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add azure resource schema and track 2
[Staging] Swagger Validation Report
️✔️ |
|
|
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-java - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-go - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-js - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-python - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-net - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
|
Azure Pipelines successfully started running 1 pipeline(s). |
JackTn
requested review from
ArcturusZhang,
leniatgh,
zhenglaizhang and
qiaozha
zhenglaizhang
approved these changes
Oct 16, 2020
|
@leni-msft can you double check the schema readme template file? we are updating the template files here and openapihub will use this template file to generate readme file for new services. so just want to make sure the templates are correct and up to date. thanks. |
leniatgh
approved these changes
Oct 16, 2020
There was a problem hiding this comment.
Hi @JackTn and @zhenglaizhang I just left one question. If the answer to that is yes, I suppose the go part would be good enough for me.
|
@YalinLi0312 can you help take a look at if csharp readme update is ok? |
markcowl
requested changes
Oct 22, 2020
qiaozha
reviewed
Oct 23, 2020
add /sdk/
|
Azure Pipelines successfully started running 1 pipeline(s). |
qiaozha
approved these changes
Oct 23, 2020
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run unifiedPipeline |
|
No pipelines are associated with this pull request. |
|
Hi @markcowl, could you help review again and approve the PR to unblock the PR merging? thanks! |
giromm2ms
pushed a commit
to giromm2ms/azure-rest-api-specs
that referenced
this pull request
Dec 20, 2020
* Update for test * Create readme.azureresourceschema.md * Create readme.azureresourceschema.md * Update readme.chsarp.md * Update readme.typescript.md * Update readme.ruby.md * Update readme.go.md * Update readme.python.md * Update samplereadme.md * Update readme.chsarp.md * Update samplereadme.md * Update readme.chsarp.md * Update readme.python.md * Update readme.go.md * Update readme.ruby.md * Update readme.typescript.md * Update samplereadme.md * Update readme.python.md * Revert "Merge branch 'master' into patch-3" This reverts commit a9b26ac, reversing changes made to 36bc60c. * Update readme.azureresourceschema.md * Update samplereadme.md * Update readme.go.md * Update readme.go.md * Update readme.go.md * Update readme.azureresourceschema.md * Update samplereadme.md * Update samplereadme.md * Update readme.python.md * Update readme.azureresourceschema.md * Update readme.go.md * Update documentation/samplefiles/readme.go.md Co-authored-by: Arcturus <ufo54153@gmail.com> * Update readme.typescript.md * Delete readme.ruby.md * Update readme.go.md * Update readme.typescript.md add /sdk/ * Rename readme.chsarp.md to readme.csharp.md * Update samplereadme.md Co-authored-by: Phoenix He <tih@microsoft.com> Co-authored-by: Lei Ni <7233663+leni-msft@users.noreply.github.com> Co-authored-by: Arcturus <ufo54153@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.