-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Anf 7393 update swagger rest api to 2020 07 01 #11032
Anf 7393 update swagger rest api to 2020 07 01 #11032
Conversation
[Staging] Swagger Validation Report
️✔️ |
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-js - Release
|
azure-sdk-for-go - Release
|
azure-sdk-for-python - Release
|
azure-sdk-for-net - Release
|
azure-sdk-for-java - Release
|
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Trenton Generation - Release
|
Azure Pipelines successfully started running 1 pipeline(s). |
specification/netapp/resource-manager/Microsoft.NetApp/stable/2020-06-01/netapp.json
Outdated
Show resolved
Hide resolved
"create" | ||
] | ||
}, | ||
"id": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The delta diff with 06-01 shows these are the main changes. Since this is PATCH definition (line 2423) and these are all read-only and Non-patchable, it is strange they are being added here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
@allenjzhang Looks like this was added to address a oav validation issue found by one of our developers. This looks like it should have been in already, also ensures that here we follow same pattern as other operations.
@chiragg4u Can you take a look at my comment on the diff between 06 and 07? The change is small but didn't make sense to me. |
Azure Pipelines successfully started running 1 pipeline(s). |
No pipelines are associated with this pull request. |
/azp run |
No pipelines are associated with this pull request. |
@allenjzhang @chiragg4u |
/azp run |
No pipelines are associated with this pull request. |
@allenjzhang |
From the comment, it seems like service was already supporting this property and it was a miss on swagger side. And moreover its a read only property. signing off on the change from ARM side. |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
@allenjzhang Reverted |
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.