[Draft] Capacity RP Quota APIs for GA #11195
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pportTicketAction. 2. Removing state=enabledForPreview. 3. Updating Example.
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
"details":" "Channel": "fatal", "Text": "swagger-document-override/md-override-loader - FAILED" "Channel": "fatal", "Text": "Error: Could not read 'file:///home/vsts/work/1/azure-rest-api-specs/specification/sql/resource-manager/Microsoft.Sql/preview/2020-08-01-preview/Databases.json'."(node:6328) UnhandledPromiseRejectionWarning: Error: Could not read 'file:///home/vsts/work/1/azure-rest-api-specs/specification/sql/resource-manager/Microsoft.Sql/preview/2020-08-01-preview/Databases.json'. at ReadThroughDataSource.ReadStrict (/home/vsts/.autorest/@microsoft.azure_autorest-core@2.0.4417/node_modules/@microsoft.azure/autorest-core/dist/lib/data-store/data-store.js:26:19)", "location":"https://github.com/Azure/azure-rest-api-specs/blob/d5c462b01befb738f24bc6b0e5830e4c73a1b48d/specification/sql/resource-manager/readme.md" |
️❌Avocado: 46 Errors, 2 Warnings failed [Detail]
Only 10 items are listed, please refer to log for more details.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️⚠️[Staging] Cross Version BreakingChange (Base on preview version): 24 Warnings warning [Detail]
Only 10 items are listed, please refer to log for more details.
- Compared Swaggers (Based on Oad v0.8.1)
- original: preview/2019-07-19/quota.json <---> new: stable/2020-10-25/quota.json
- original: preview/2019-06-01-preview/databases.json <---> new: preview/2020-08-01-preview/databases.json
- original: preview/2017-10-01-preview/elasticPools.json <---> new: preview/2020-08-01-preview/elasticPools.json
| Rule | Message |
|---|---|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.Capacity/autoQuotaIncrease' removed or restructured? New: azure-rest-api-specs/blob/d5c462b01befb738f24bc6b0e5830e4c73a1b48d/ Old: Microsoft.Capacity/preview/2019-07-19/quota.json#L384:5 |
|
| The new version is missing a definition that was found in the old version. Was 'SeverityTypes' removed or renamed? New: Microsoft.Capacity/stable/2020-10-25/quota.json#L382:3 Old: Microsoft.Capacity/preview/2019-07-19/quota.json#L467:3 |
|
| The new version is missing a definition that was found in the old version. Was 'ContactMethod' removed or renamed? New: Microsoft.Capacity/stable/2020-10-25/quota.json#L382:3 Old: Microsoft.Capacity/preview/2019-07-19/quota.json#L467:3 |
|
| The new version is missing a definition that was found in the old version. Was 'AqiState' removed or renamed? New: Microsoft.Capacity/stable/2020-10-25/quota.json#L382:3 Old: Microsoft.Capacity/preview/2019-07-19/quota.json#L467:3 |
|
| The new version is missing a definition that was found in the old version. Was 'aqiSettings' removed or renamed? New: Microsoft.Capacity/stable/2020-10-25/quota.json#L382:3 Old: Microsoft.Capacity/preview/2019-07-19/quota.json#L467:3 |
|
| The new version is missing a definition that was found in the old version. Was 'EmailActions' removed or renamed? New: Microsoft.Capacity/stable/2020-10-25/quota.json#L382:3 Old: Microsoft.Capacity/preview/2019-07-19/quota.json#L467:3 |
|
| The new version is missing a definition that was found in the old version. Was 'Actions' removed or renamed? New: Microsoft.Capacity/stable/2020-10-25/quota.json#L382:3 Old: Microsoft.Capacity/preview/2019-07-19/quota.json#L467:3 |
|
| The new version is missing a definition that was found in the old version. Was 'SupportRequestAction' removed or renamed? New: Microsoft.Capacity/stable/2020-10-25/quota.json#L382:3 Old: Microsoft.Capacity/preview/2019-07-19/quota.json#L467:3 |
|
| The new version is missing a definition that was found in the old version. Was 'AutoQuotaIncreaseDetail' removed or renamed? New: Microsoft.Capacity/stable/2020-10-25/quota.json#L382:3 Old: Microsoft.Capacity/preview/2019-07-19/quota.json#L467:3 |
|
| The new version is missing a definition that was found in the old version. Was 'autoQuotaIncreaseSettings' removed or renamed? New: Microsoft.Capacity/stable/2020-10-25/quota.json#L382:3 Old: Microsoft.Capacity/preview/2019-07-19/quota.json#L467:3 |
️⚠️[Staging] Cross Version BreakingChange (Base on stable version): 123 Warnings warning [Detail]
Only 10 items are listed, please refer to log for more details.
- Compared Swaggers (Based on Oad v0.8.1)
- original: stable/2014-04-01/databases.json <---> new: preview/2020-08-01-preview/databases.json
- original: stable/2014-04-01/elasticPools.json <---> new: preview/2020-08-01-preview/elasticPools.json
| Rule | Message |
|---|---|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Sql/servers/{serverName}/recommendedElasticPools/{recommendedElasticPoolName}/databases' removed or restructured? New: azure-rest-api-specs/blob/d5c462b01befb738f24bc6b0e5830e4c73a1b48d/ Old: Microsoft.Sql/stable/2014-04-01/databases.json#L542:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Sql/servers/{serverName}/recommendedElasticPools/{recommendedElasticPoolName}/databases/{databaseName}' removed or restructured? New: azure-rest-api-specs/blob/d5c462b01befb738f24bc6b0e5830e4c73a1b48d/ Old: Microsoft.Sql/stable/2014-04-01/databases.json#L492:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Sql/servers/{serverName}/elasticPools/{elasticPoolName}/databases/{databaseName}' removed or restructured? New: azure-rest-api-specs/blob/d5c462b01befb738f24bc6b0e5830e4c73a1b48d/ Old: Microsoft.Sql/stable/2014-04-01/databases.json#L396:5 |
|
| The new version is missing a client parameter that was found in the old version. Was 'TransparentDataEncryptionNameParameter' removed or renamed? New: Microsoft.Sql/preview/2020-08-01-preview/elasticPools.json#L521:3 Old: Microsoft.Sql/stable/2014-04-01/elasticPools.json#L390:3 |
|
| The new version is missing a client parameter that was found in the old version. Was 'TransparentDataEncryptionNameParameter' removed or renamed? New: Microsoft.Sql/preview/2020-08-01-preview/databases.json#L1567:3 Old: Microsoft.Sql/stable/2014-04-01/databases.json#L998:3 |
|
| The new version is missing a client parameter that was found in the old version. Was 'DatabaseExpandParameter' removed or renamed? New: Microsoft.Sql/preview/2020-08-01-preview/databases.json#L1567:3 Old: Microsoft.Sql/stable/2014-04-01/databases.json#L998:3 |
|
| The new version is missing a client parameter that was found in the old version. Was 'DatabaseExpandParameter' removed or renamed? New: Microsoft.Sql/preview/2020-08-01-preview/elasticPools.json#L521:3 Old: Microsoft.Sql/stable/2014-04-01/elasticPools.json#L390:3 |
|
| The new version adds a response code 'default'. New: Microsoft.Sql/preview/2020-08-01-preview/databases.json#L92:11 |
|
| The new version adds a response code 'default'. New: Microsoft.Sql/preview/2020-08-01-preview/databases.json#L141:11 |
|
| The new version adds a response code '202'. New: Microsoft.Sql/preview/2020-08-01-preview/elasticPools.json#L216:11 |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rahuls-microsoft
changed the title
|
Azure Pipelines successfully started running 1 pipeline(s). |
Azure CLI Extension Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-go
|
azure-sdk-for-js
|
azure-sdk-for-java
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-python
- Breaking Change detected in SDK
|
azure-sdk-for-net
|
azure-sdk-for-python
- Breaking Change detected in SDK
|
azure-resource-manager-schemas
|
Trenton Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
raych1
added
the
NotReadyForReview
|
@rahuls-microsoft , please remove |
|
There are 2 services behind Microsoft.Capacity : @raych1 do you see any issue with this structure ? having 2 services behind same namespace ? |
rahuls-microsoft
requested review from
MehaKaushik,
MikhailTryakhov,
MS-syh2qs,
Sandido and
shurd
as code owners
This was referenced Dec 1, 2020
|
The build has started failing after merge from master. |
@rahuls-microsoft , please fix the |
Q1. What can I do about other team's update from master branch?
|
|
Created a new fork from master and new Pull request - #11930. |
|
Created a new fork from master and new Pull request - #11930. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.