[Hub Generated] Review request for Microsoft.CostManagement to add version stable/2019-11-01 #11303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Staging] Swagger Validation Report
️✔️ |
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-java - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-js - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-net - Release
|
azure-sdk-for-python - Release
- Breaking Change detected in SDK
|
azure-resource-manager-schemas - Release
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-go - Release
|
Azure CLI Extension Generation - Release
|
This was referenced Oct 20, 2020
This was referenced Oct 20, 2020
|
Azure Pipelines successfully started running 1 pipeline(s). |
ArcturusZhang
added
the
WaitForARMFeedback
pilor
added
the
ARMChangesRequested
pilor
suggested changes
Oct 21, 2020
| @@ -379,6 +379,54 @@ | |||
| } | |||
| } | |||
| }, | |||
| "/{scope}/providers/Microsoft.CostManagement/views/render": { | |||
There was a problem hiding this comment.
This URI needs to specify what view to render. You can't have POST actions on a resource type collection
There was a problem hiding this comment.
Removed all the views/render api changes from the PR.
Had a talk with the team after reading all the comments and we will be making changes to the api and redocumenting in a different PR. This PR will only add the two missing fields. Is this good for us to get unblocked on the small changes in this PR?
| "in": "body", | ||
| "required": true, | ||
| "schema": { | ||
| "$ref": "#/definitions/View" |
There was a problem hiding this comment.
This should be driven off of the name of the view in the URI since views are a resource that users create. If you want to allow rendering of a dynamic view without creating a view resource then the action would need to be directly on your provider (i.e. POST .../Microsoft.CostManagement/renderOnDemandView)
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/MYDEVTESTRG/providers/Microsoft.CostManagement/views/swaggerExample", |
There was a problem hiding this comment.
is this POST action creating a new resource in its current form? What does this ID point to? Why is the resource type "downloadLink"?
| "eTag": "\"1d4ffa5a9c2430c\"", | ||
| "properties": { | ||
| "imageUrl": "https://storagepilot.blob.core.windows.net/dashboardimage/2020/10/19/5/31/eff0d624-8630-4ced-bd9b-971df5878fcb?sv=2016-05-31", | ||
| "errorMessage": "" |
There was a problem hiding this comment.
In what scenario would an errorMessage be returned with a 200 response?
There was a problem hiding this comment.
Very valid point. Change reverted.
...t-management/resource-manager/Microsoft.CostManagement/stable/2019-11-01/costmanagement.json
Show resolved
Hide resolved
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Please go through the contribution checklist added as part of the review and mark them completed. Also Please go through the ARM API Review Checklist. These steps are required before review can be continued. |
|
Hi, @elabicha Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
1 similar comment
|
Hi, @elabicha Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
chiragg4u
removed
ARMChangesRequested
|
Removed ARMReview Requirement tags from the PR as the new change no more require ARM approval. |
ArcturusZhang
approved these changes
Nov 6, 2020
giromm2ms
pushed a commit
to giromm2ms/azure-rest-api-specs
that referenced
this pull request
Dec 20, 2020
…rsion stable/2019-11-01 (Azure#11303) * Adding render api swagger * add missing properties * changing view list schema to array * Fix get view list examples * revert view list changes * fix prettier * fix spell check * undo render api swagger changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.