Fix Swagger Linting issues reported #11462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @riserrad Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
The new version adds a response code 'default'. New: Microsoft.TimeSeriesInsights/stable/2020-05-15/timeseriesinsights.json#L61:11 |
️️✔️[Staging] LintDiff succeeded [Detail] [Expand]
Validation passes for LintDiff.
️️✔️[Staging] Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️[Staging] ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️[Staging] SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
There are no breaking changes.
|
Azure Pipelines successfully started running 1 pipeline(s). |
Azure CLI Extension Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-java
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-go
|
azure-sdk-for-js
|
azure-sdk-for-net
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-python
- Breaking Change detected in SDK
|
azure-sdk-for-python-track2
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Trenton Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
|
Hi @njuCZ , we made this change to the swagger spec as we received a notification saying that we should do so. It seems that it produces a breaking change. What do you suggest us doing in this case? Thanks |
|
Hi @riserrad, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
Hi @njuCZ , as described above, this change is to make this spec comply with the new rule R4005 that states that |
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
|
Hi, @riserrad your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). cc @njuCZ |
| @@ -57,6 +57,12 @@ | |||
| "schema": { | |||
| "$ref": "#/definitions/OperationListResult" | |||
| } | |||
| }, | |||
| "default": { | |||
| "description": "HTTP 404 (Not Found): The list of operations could not be found.", | |||
There was a problem hiding this comment.
nit, but I usually see a generic error message here such as: "Error response describing why the operation failed." although I also noticed other services mentioning 404 as part of the description. Will check if there's any guidance around unifying these descriptions, but nothing to block this PR.
There was a problem hiding this comment.
Thanks, @jorgecotillo . I'd appreciate any guidance on this. If you find anything, could you mail me at my MSFT mail?
Thanks!
njuCZ
added
Approved-BreakingChange
njuCZ
approved these changes
Nov 16, 2020
|
/azp run |
Swagger Generation Artifacts
|
| Rule | Message |
|---|---|
|
"logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=175127&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b", "detail":"Run.ps1 failed with exit code 128 " |
️️✔️[Staging] azure-sdk-for-go succeeded [Detail] [Expand]
- Breaking Change Detected
- Breaking Change Detected️✔️Succeeded [Logs] Generate from 33e090d7e38cb4e21f127aad821ae8a9d66b8a1c. SDK Automation 14.0.0command sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json command go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
️✔️timeseriesinsights/mgmt/2020-05-15/timeseriesinsights [View full logs] [Preview SDK Changes] Breaking Change Detectedinfo [Changelog] ## Breaking Changes info [Changelog] info [Changelog] ## Signature Changes info [Changelog] info [Changelog] ### Funcs info [Changelog] info [Changelog] 1. NewOperationListResultPage info [Changelog] - Params info [Changelog] - From: func(context.Context, OperationListResult) (OperationListResult, error) info [Changelog] - To: OperationListResult, func(context.Context, OperationListResult) (OperationListResult, error) info [Changelog]
️✔️preview/timeseriesinsights/mgmt/2018-08-15-preview/timeseriesinsights [View full logs] [Preview SDK Changes] Breaking Change Detectedinfo [Changelog] ## Breaking Changes info [Changelog] info [Changelog] ## Signature Changes info [Changelog] info [Changelog] ### Funcs info [Changelog] info [Changelog] 1. NewOperationListResultPage info [Changelog] - Params info [Changelog] - From: func(context.Context, OperationListResult) (OperationListResult, error) info [Changelog] - To: OperationListResult, func(context.Context, OperationListResult) (OperationListResult, error) info [Changelog]
️✔️timeseriesinsights/mgmt/2017-11-15/timeseriesinsights [View full logs] [Preview SDK Changes] Breaking Change Detectedinfo [Changelog] ## Breaking Changes info [Changelog] info [Changelog] ## Signature Changes info [Changelog] info [Changelog] ### Funcs info [Changelog] info [Changelog] 1. NewOperationListResultPage info [Changelog] - Params info [Changelog] - From: func(context.Context, OperationListResult) (OperationListResult, error) info [Changelog] - To: OperationListResult, func(context.Context, OperationListResult) (OperationListResult, error) info [Changelog]
️✔️preview/timeseriesinsights/mgmt/2017-02-28-preview/timeseriesinsights [View full logs] [Preview SDK Changes] Breaking Change Detectedinfo [Changelog] ## Breaking Changes info [Changelog] info [Changelog] ## Signature Changes info [Changelog] info [Changelog] ### Funcs info [Changelog] info [Changelog] 1. NewOperationListResultPage info [Changelog] - Params info [Changelog] - From: func(context.Context, OperationListResult) (OperationListResult, error) info [Changelog] - To: OperationListResult, func(context.Context, OperationListResult) (OperationListResult, error) info [Changelog]
️️✔️[Staging] azure-resource-manager-schemas succeeded [Detail] [Expand]
️✔️Succeeded [Logs] Generate from 33e090d7e38cb4e21f127aad821ae8a9d66b8a1c. Schema Automation 14.0.0warn Skip initScript due to not configured command npx n 12 command autorest --use=@autorest/azureresourceschema@3.0.92 --version=3.0.6320 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/w/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/timeseriesinsights/resource-manager/readme.md
️✔️timeseriesinsights [View full logs] [Preview Schema Changes]cmderr [resource-manager] node-pre-gyp cmderr [resource-manager] WARN Using request for node-pre-gyp https download cmderr [resource-manager] template-schema-validation-tools@1.0.0 No repository field. cmderr [resource-manager] optional SKIPPING OPTIONAL DEPENDENCY: fsevents@2.1.2 (node_modules/fsevents): cmderr [resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.2: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
️️✔️[Staging] azure-sdk-for-js succeeded [Detail] [Expand]
️✔️Succeeded [Logs] Generate from 33e090d7e38cb4e21f127aad821ae8a9d66b8a1c. SDK Automation 14.0.0warn Skip initScript due to not configured command autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/w/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/timeseriesinsights/resource-manager/readme.md
️✔️@azure/arm-timeseriesinsights [View full logs] [Preview SDK Changes]cmderr [npmPack] loaded rollup.config.js with warnings cmderr [npmPack] (!) Unused external imports cmderr [npmPack] default imported from external module 'rollup' but never used cmderr [npmPack] ./esm/timeSeriesInsightsClient.js → ./dist/arm-timeseriesinsights.js... cmderr [npmPack] created ./dist/arm-timeseriesinsights.js in 341ms
️️✔️[Staging] azure-sdk-for-python succeeded [Detail] [Expand]
- Breaking Change Detected
- Breaking Change Detected️✔️Succeeded [Logs] Generate from 33e090d7e38cb4e21f127aad821ae8a9d66b8a1c. SDK Automation 14.0.0warn Skip initScript due to not configured command npx n 12 command python3 -m venv venv command pip install setuptools wheel command pip install pathlib jinja2 msrestazure command autorest --version=V2 --use=@microsoft.azure/autorest.python@~4.0.71 --python --python-mode=update --multiapi --keep-version-file --no-async --python-sdks-folder=/home/vsts/work/1/s/w/azure-sdk-for-python/sdk ../azure-rest-api-specs/specification/timeseriesinsights/resource-manager/readme.md
️✔️azure-mgmt-timeseriesinsights [View full logs] [Preview SDK Changes] Breaking Change Detectedcmderr [buildPackage] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type' cmderr [buildPackage] warnings.warn(msg) cmderr [buildPackage] warning: no files found matching '*.py' under directory 'tests' cmderr [buildPackage] warning: no files found matching '*.yaml' under directory 'tests' cmderr [buildPackage] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type' cmderr [buildPackage] warnings.warn(msg) cmderr [buildPackage] warning: no files found matching '*.py' under directory 'tests' cmderr [buildPackage] warning: no files found matching '*.yaml' under directory 'tests' cmderr [changelogSetup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment cmderr [changelogSetup] Cannot uninstall requirement azure-nspkg, not installed cmderr [changelogSetup] Command '['/home/vsts/work/1/s/w/azure-sdk-for-python_tmp/venv/bin/python', '-m', 'pip', 'uninstall', '-y', 'azure-nspkg']' returned non-zero exit status 1. cmderr [changelogReportLatest] INFO:__main__:Looking for Autorest generated package in azure.mgmt.timeseriesinsights cmderr [changelogReportLatest] INFO:__main__:Found azure.mgmt.timeseriesinsights cmderr [changelogReportLatest] INFO:__main__:Working on azure.mgmt.timeseriesinsights cmderr [changelogReportLatest] INFO:__main__:Report written to sdk/timeseriesinsights/azure-mgmt-timeseriesinsights/code_reports/latest/report.json cmderr [changelogReportLatest] INFO:__main__:Download versions of azure-mgmt-timeseriesinsights on PyPI cmderr [changelogReportLatest] INFO:__main__:Got ['0.1.0', '0.2.0'] cmderr [changelogReportLatest] INFO:__main__:Only keep last PyPI version cmderr [changelogReportLatest] INFO:__main__:Installing version 0.2.0 of azure-mgmt-timeseriesinsights in a venv cmderr [changelogReportLatest] INFO:__main__:Looking for Autorest generated package in azure.mgmt.timeseriesinsights cmderr [changelogReportLatest] INFO:__main__:Found azure.mgmt.timeseriesinsights cmderr [changelogReportLatest] INFO:__main__:Working on azure.mgmt.timeseriesinsights cmderr [changelogReportLatest] INFO:__main__:Report written to sdk/timeseriesinsights/azure-mgmt-timeseriesinsights/code_reports/0.2.0/report.json cmdout [Changelog] Size of delta 22.923% size of original (original: 37429 chars, delta: 8580 chars) cmdout [Changelog] **Features** cmdout [Changelog] - Model EventHubEventSourceCreateOrUpdateParameters has a new parameter local_timestamp cmdout [Changelog] - Model EventSourceCreateOrUpdateParameters has a new parameter local_timestamp cmdout [Changelog] - Model IoTHubEventSourceCreateOrUpdateParameters has a new parameter local_timestamp cmdout [Changelog] **Breaking changes** cmdout [Changelog] - Operation EnvironmentsOperations.update has a new signature warn Breaking change found in changelog
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
Hi @riserrad, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
This was referenced Nov 16, 2020
This was referenced Nov 16, 2020
Merged
xiangyan99
added a commit
that referenced
this pull request
Dec 7, 2020
* CICD Swagger changes for git config APIs (#11528)
* Swagger changes added for workspace & gitintegration specs
* Updated workspace spec related git repository
* Added gitintegration spec
* Updated example files related to workspace
* Added gitintegration example files
* Remove 'Requires Premium Sku' (#11590)
* Add missing API. (#11548)
* Fix spelling for private link hub path.
* Add missing disableInteractiveQuery API.
* Refactor workspace name to common type.
* Prettier fix.
Co-authored-by: raviarora <raviarora@MININT-54JRS6K.fareast.corp.microsoft.com>
Co-authored-by: Ravi Arora <raviarora@microsoft.com>
* fix correctness errors for AVS 2019-08-09-preview API (#11545)
* backport Operations_List to AVS 2019-08-09 API
* add deprecated clusterID
* "format": "int32"
* Add Databases APIs to a new PostgreSQL version 2020-11-05-preview (#11432)
* [Hub Generated] Review request for Microsoft.ContainerInstance to add version stable/2020-11-01 (#11449)
* AVS 2020-07-17-preview (#10866)
* feature: Storage Policies contact: David Becher @thinkdavid
feature: NSX DHCP/Segments & Port Mirroring contacts: Christian Pomales & Weronika Zamlynny & Rebekah Hess
feature: Credential Rotation, contact: Chenghao Liu @cliu78
feature: Global Reach, contact: James Spearman @jspearman3
feature: Private Cloud Addons, contact @leedouglas
* feature: NSX DHCP/Segments & Port Mirroring contacts: Christian Pomales & Weronika Zamlynny & Rebekah Hess
feature: Credential Rotation, contact: Chenghao Liu @cliu78
feature: Global Reach, contact: James Spearman @jspearman3
feature: Private Cloud Addons, contact @leedouglas
* adjusted readme files to reflect new 2020-07-17-preview api
* fixed spelling validation issues
* preview was not specified in path, should fix go sdk validation error
* -preview left of in readme
* typo of preview and spelling validation fix
* prettier run fixes
* updated swagger because storage policy now will not have the same display around minHosts
* storage policy changed to string
* Update spec
* Add 200 back to nsx patches
* Added 200 back to nsx deletes
* Add provisioningState to nsx models with async operations
* remove arc from api
* remove x-ms-secret for PrivateClouds_ListAdminCredentials
* fix correctness for Operations_list
* pub back x-ms-secret in AdminCredentials
* x-ms-secret on password
* PrivateCloudUpdate can update the resource tags
* Add GETs for gateway and virtual machine resources
* Add virtual machine GET
* Add gateway GET
* minor fixes
* Fixed autorest warnings related to nsx apis
* npx prettier --write specification/vmware/**/*.json
* fixed R2066 name warning
* rename example files as well
Co-authored-by: Christian Pomales <chpomale@microsoft.com>
Co-authored-by: Cameron Taggart <cameron.taggart@microsoft.com>
leedouglas/azure-rest-api-specs#5
* different solution to PUT empty body of `{}`
* default for internet is Disabled
* put flatten back
just need to upgrade pythong autorest to 5.x
* add provisioningState to ManagementCluster
* add readOnly storagePolicy to ManagementCluster
* remove storage policy
* removed all mentions of storage policy
* removed from createor update
* npx prettier --write specification/vmware/**/*.json
Co-authored-by: David Becher <dabecher@microsoft.com>
Co-authored-by: Cameron Taggart <cameron.taggart@microsoft.com>
* remove examples/DefaultStoragePolicies_List.json
* add Credential Rotation back in
* fully qualified vmware.json
Co-authored-by: David Becher <dabecher@microsoft.com>
Co-authored-by: Christian Pomales <chpomale@microsoft.com>
Co-authored-by: david becher <dab4au@virginia.edu>
Co-authored-by: Cameron Taggart <cameron.taggart@microsoft.com>
Co-authored-by: Cameron Taggart <cameron.taggart@gmail.com>
Co-authored-by: Christian Pomales <12565983+ChristianPomales@users.noreply.github.com>
* remove invalid package-2016-08 for RecoveryServices (#11287)
* add notification track2 config (#11439)
* add policyinsights track2 config (#11398)
* Compute: update readme.java.md (#11241)
* [Datadog] Add terms APIs (#11435)
* [Datadog] Add terms APIs
* Feedback
* Feedback
* Update read.cli.md
* Change to PUT
* Feedback
* IoTHub: update readme.java.md (#11244)
* [Storage] File share snapshots CRUD (#11372)
* hybrid-2020-09-01 (#11556)
* hybrid-2020-09-01
* update
* 20201020 regionalmove (#11582)
* regionmove
* resourcemover
* new-typescript-file (#11611)
* [T2]containerservice for track2 python sdk (#11275)
* Added cloud service NIC and PIP APIs specifications (#11568)
* Added cloud service NIC and PIP APIs specifications
* Moved new APIs to 2020-07-01 version
* Updated version to 2020-07-01 in json files
* Updated api version tp 2020-07-01 in examples
Co-authored-by: Richa Jain <ricjain@microsoft.com>
* add action word to pr template (#11623)
* SDK Automation Doc Update (#11422)
* SDK Automation Doc Update
* Use reference file for schema
* Update SwaggerToSdkConfigSchema.json
* Update breakingchangelabel
* Update example
* Add extra envs support
* Add result in generateOutput
* Configurable integrationPR
* Fix description and samples (#11606)
* update samples
* doc link
* apimsi
* Dev containerservice microsoft.container service 2020 11 01 (#11588)
* Adds base for updating Microsoft.ContainerService from version stable/2020-09-01 to version 2020-11-01
* Updates readme
* Updates API version in new specs and examples
* add autoupgradeprofile to 2020-11-01 (#11363)
* add autoupgradeprofile
* add autoupgrader profile to mc
* format change
Co-authored-by: Xiahe Liu <Xiahe.Liu@microsoft.com>
* add pod subnet id on agentpool (#11310)
* aks: add pod identity profile spec (#11366)
* add private dns zone property in 2020-11-01 (#11311)
Co-authored-by: Li Ma <lima2@microsoft.com>
* Remove invalid pattern and adjust description (#11312)
* aks: fix pod identity profile field names (#11484)
* aks: add missing `podIdentityProfile.enabled` field
* aks: typo
* add non upgrade channel (#11492)
Co-authored-by: Xiahe Liu <Xiahe.Liu@microsoft.com>
* Make identityProfile mutable (#11458)
* Add KubeletConfig and LinuxOSConfig specs (#11490)
* aks: update readme tag for 1101 (#11472)
* aks: update readme tag
* aks: add `2020-11-01-only`
* resovle merge conlicts to master, adding recent master change to dev branch (#11604)
Co-authored-by: Xiahe Liu <Xiahe.Liu@microsoft.com>
Co-authored-by: Xiahe Liu <Xiahe.Liu@microsoft.com>
Co-authored-by: Paul Miller <pmiller@microsoft.com>
Co-authored-by: hbc <me@hbc.rocks>
Co-authored-by: Super <mali_no2@hotmail.com>
Co-authored-by: Li Ma <lima2@microsoft.com>
Co-authored-by: Qingchuan Hao <haoqingchuan@hotmail.com>
Co-authored-by: Tongyao Si <tosi@microsoft.com>
Co-authored-by: Bo Wang <61758179+bowang-666@users.noreply.github.com>
Co-authored-by: Phoenix He <tih@microsoft.com>
* [Synapse] - Update operation id for rename API (#11517)
* [Synapse] - Update operation id for rename API
* Update operation id
Co-authored-by: Dongwei Wang <dongwwa@microsoft.com>
* [Text Analytics] rename notstarted to notStarted (#11571)
* rename notstarted to notStarted
* adding rejected
* fix allof
* fix
* fix
* make results required
* name is optional
* Revert: spec changes for Libmary Management in bigDataPool (#11612)
* Revert "attributes added in LibraryInfo in BigDataPool specs (#11415)"
This reverts commit 5d48a7dc324dd221d5e0455e3947c5fc39084132.
* Revert "Custom Library support in Spark pool (#11172)"
This reverts commit c653ee788c4dd74ede34ff17e64e7c0c45681e3e.
Co-authored-by: Navneet Singh <navsi@microsoft.com>
* fix example (#11631)
Co-authored-by: Ashraf Hamad <ahamad@ntdev.microsoft.com>
* update (#11641)
* Adding API to support generating access token for ApplicationInsights Profiler (#11393)
* Adds base for updating Microsoft.Insights from version preview/2020-10-05-preview to version 2020-10-26-preview
* Updates readme
* Updates API version in new specs and examples
* Update readme to pointing to profilerToken_API.json
* Update operations list
* Add profiler token getter
* Wire up the defintions
* Fix error: additonal property of liveToken
* Append post action
* Update api-version for example
* Fix some small issues
* Update readme for the resolving autorest check issue
* From profilertoken to profilerToken
* Ran prettier
* Appending back missing readme for 2020-10 tag
* Fix some mistakes
* Use common error response
* Tag secret with x-ms-secret
* Remove list operations
* Clean up packages
* Making 2 post operations for token
* Remove unused operations_list.json example
* Align with official master
* Resolve conflicts
* Add x-ms-secret for the token
* Update error response schema ref
* Update operation ids
* Remove unused error response
* Add SecureScores & SecureScoreControls as new supported datatypes in Automations resource (#11577)
* Add SubAssessment event source type and add more automations examples
* Change Location isReadOnlu to false
* Test
* Add new read/write location and add new type TrackedResourceLocation
* Minor
* minor
* prettier fixes
* Change variable name to TrackedResourceLocation
* Change type name TrackedResourceLocation to AzureTrackedResourceLocation
* Update automations example
* Add SecureScores & SecureScoreControls as new supported datatypes in Automations resource
* add openapi-subtype (#11639)
* #8187884: Swagger Correctness: MICROSOFT.PORTAL(Azure Portal (IbizaFx)) (#11494)
* #8187884: Swagger Correctness: MICROSOFT.PORTAL(Azure Portal (IbizaFx))
* Update examples
* Fix Linter error on integer format
* Fix Prettier
* Fix Linter error
Co-authored-by: Alex Kachanov <alkac@corp.microsoft.com>
* Revert "Adding API to support generating access token for ApplicationInsights Profiler (#11393)" (#11662)
This reverts commit 80db0e5cef00f0e666c2e1e39d23729eb0c0b0d8.
* Add track2 config to cosmosdb (#10589)
* Fix output-folder (#11645)
* Babylon branding change (#11654)
Rename babylon to purview
* Fix output-folder (#11659)
* [T2] containerservice python automation fix (#11669)
* python automation fix
* Update readme.python.md
* Fix S360 validation issues (#11652)
* FIxing Privatestore ,Offer properties and examples
* Fixing properties types
* Fixing camel cases
* Add Idempotence to custom-words.txt
* prettier check changes
* adding description to isGov
* resolve conflicts
* Fix updateSuppressedDueIdempotence type
* FIx swagger validation issues
* Fix json
* Fix indentation conflicts
* Fix corruption
* Fix validations
* Try renaming preview API version again (#11619)
* Try renaming preview API version again
* Added preview swagger version
* Another try at adding back the preview apis
* Next try at putting -preview API back
* Fixed typo
* Added Java and Typescript generators to resource manager
* Revert typescript.md to original
* Added js and java languages
* Removed SevSnpVm until we have a stronger confidential VM story
* Removed other SevSnpVm vestiges
* update (#11629)
* Fix Swagger Linting issues reported (#11462)
* Fixing linting issues according to report (task 8554751)
* Adding a default response to operations
* Amend error response to indicate that we return additional error info. (#11678)
* Adding Identity to Patch Vault (#11646)
* Create 2020-10-01 version of resources swagger with templateLink.queryString property (#11637)
* Initial commit
* Add templateLink.queryString property into 2020-10 resources version
* Prettier fix
* Fix api-version in examples
* Change description of queryString
* Fixed an undefined tag in readme
* Avocado fixes
* Suppress pre-existing lint errors
* Fix template specs tag
* Revert "Fix template specs tag"
This reverts commit c0a2358b1ff17f1a6e278a79e9a691b4226f1ac4.
* For real this time: Fix template specs tag
Co-authored-by: Filiz Topatan <fitopata@microsoft.com>
* Add WVD Scaling Plan resource definitions (#11224)
Co-authored-by: Jeremy Hurren <jehurren@microsoft.com>
* fix AVS 2020-03-20 correctness errors for empty body and internet default (#11486)
* backport empty body and internet default fixes
* leave flatten on
* hide StorageAccountCredentials put (#11670)
* hide StorageAccountCredentials put
* hide StorageAccounts put
* add traceLevel, continueOnError, and runConcurrently properties to Dataflow activity properties (#11640)
* Fix custom-words.txt (#11696)
* [Synapse] - Fix typo in SqlServer Swagger spec (#11567)
Co-authored-by: Dongwei Wang <dongwwa@microsoft.com>
* Removing encryptionprotector APIs as this can land the service in an incosttent state (#11663)
* Update readme.md (#11564)
* Microsoft.OperationalInsights: Updating property name + Adding a new resource (#11649)
* Updating property name.
* example update.
* Adding force cmk to workspace.
* Adding default error response.
* Removing redundant examples.
* adding workspace capping to example per code review request.
* Per review request.
Co-authored-by: Dudi Likvornik <dulikvor@microsoft.com>
* Add new api-version for databoxedge (#11694)
* [Hub Generated] Review request for Microsoft.Cache to add version preview/2020-10-01-preview (#11683)
* New Readme Config File
* New Go Language Readme Config File
* New Typescript Language Readme Config File
* New Python Language Readme Config File
* New C# Language Readme Config File
* New Ruby Language Readme Config File
* New Swagger Spec File
* New Swagger Example Spec File
* Initial updates for public preview
* Add default error response. Add integer format.
* Add 200 response to delete operations.
* Add custom words for Redis Enterprise.
* Update whitespace for prettier.
* Update whitespace for prettier.
* Update whitespace for prettier.
* Revert "Update whitespace for prettier."
This reverts commit 4f04b1bfbf35407c783a3249e783ba4b34590ea9.
* Revert "Update whitespace for prettier."
This reverts commit ccca6d5e636f2e3aa38f80c735638e8445a6c42e.
* Revert "Update whitespace for prettier."
This reverts commit 3d72e6bed67117d7a407ba5fd467673f0f12d16b.
* Update whitespace for prettier.
* Update Go settings
* Including .NET SDK in list of SDKs automatically generated.
* Update csharp settings.
* Fix typo.
* Updates addressing comments from reviewer.
* Fix provisioningState errors.
* Update clusteringPolicy description and related examples.
* Remove Enterprise_E1 SKU.
* Updates per comments from reviewer.
* Remove illegal terminal states from provisioningState. Add new resourceState.
* Utilize common properties from updated v2 types.json
* Add 'Deleting' state to ProvisioningState enum.
* Make operationIds of Database operations consistent.
* IoTC 2011 Adding jobs, DTDLv2 templates, groups (#11622)
* Adding jobs, DTDLv2 templates, groups
* Spelling mistakes fix
* Trying to suppress email lint
* Small update to fix linter
* Added additional suppression for long running ops
* Again
* Updated again
* Removing the other suppressors
* New suppression without quotes
* back to just email suppression
* Update to use common type (#11710)
* fix java readme (#11695)
* Fixed some more Swagger issues (#11713)
Co-authored-by: Amogh Natu <amnat@microsoft.com>
* Microsoft.PolicyInsights/checkPolicyRestrictions API (#10798)
* CheckPolicyRestrictions API
* Run prettier
* Increment package version
* Remove from old tag
* Remove suppression
* Change PartitionOption to object to allow expression (#11613)
* add httpRequestTimeout to odata based connector activities
* add httpRequestTimeout to odata based connector activities
* add sql parallel read properties
* change partitionOption to object
* change ParallelOption to object
* [Monitor] Add DataCollRules section readme.go.md (#11707)
* 20201113 streamanalytics (#11671)
* sdk-no-flatten
* use unique jobName is examples
* s360 fixes for Azure DNS (#11591)
* s360 fixes for Azure DNS
* Additional property
* Property fix
* Readonly property
* CloudError fix
* Examples. cloud error
* Avocado fix
* read.md
* Prettier
* Threat Intelligence: Update name and descriptions of definitions, parameters (#10949)
* Update API descriptions
* Resolve Comments
* Update parameter name of create/update indicator apis
* Fix example issue
* Fix support swagger correctness violation (#11709)
* updated version, example and schema changes
* fixing examples and updating readme files
* Update support.json by gangan
Removed html tags (kept some <br/> but can remove them as well)
moved all of the links to md style.
* Update support.json
Added CSP and Sev 1 description
* Updates from swagger json review
* Updates from examples review
* prettier check
* updating custom words and running prettier
* fixing path in readme.go.md
* Reverted change from invalid upstream merfe
* Fix swagger correctness violation for integer type format
* Try to change format to int64 since int32 is flagged as breaking change
* Revert "Try to change format to int64 since int32 is flagged as breaking change"
This reverts commit cb602d9fcec11dee2a5bed30d86f4d329f74d47b.
Co-authored-by: Bhavin Shah <bhshah@microsoft.com>
Co-authored-by: shahbj79 <shahbj79@hotmail.com>
Co-authored-by: Ganga Narayanan <gangan@microsoft.com>
Co-authored-by: Nilay Chheda <nichheda@microsoft.com>
* Add new synapse rbac api spec (#11384)
* Add files via upload
* Fix validation issues
* Fix validation issues
* Fix prettier check issue
* fix validation errors
* Made review fixes
* Run prettier check
* Review fix
Co-authored-by: Dongwei Wang <dongwwa@microsoft.com>
* Specifying shipping address required property to autorest. (#11717)
* Ensuring autorest generation follow specific order of required properties in shippingAddress
* added details sharp yaml
* Removing renameSqlPool api (#11664)
* [ACR] SystemData and new readonly KeyVaultProperties (#11601)
* [Hub Generated] Review request for Microsoft.StoragePool to add version preview/2020-03-15-preview (#11718)
* New Readme Config File
* New Go Language Readme Config File
* New Typescript Language Readme Config File
* New Python Language Readme Config File
* New C# Language Readme Config File
* New Ruby Language Readme Config File
* New Swagger Spec File
* New Swagger Example Spec File
* StoragePool RP swagger definition
* Added missing file
* Added missing title and description
* Prettier fix
* Fixing js code gen issue
Co-authored-by: Harshitha Akkaraju <hakkaraj@microsoft.com>
* Swagger Correctness for Cognitive Services (#11405)
* Swagger Correctness
* Undo changes in 2016-02-01-preview
* Move location of field
* change enum type to string for Sku.tier
* Microsoft.Capacity 2020-10-01-preview update (#11668)
* Update openapi-authoring-automated-guidelines.md to avoid comfusing (#11208)
* Update openapi-authoring-automated-guidelines.md
* Update openapi-authoring-automated-guidelines.md
* change url of suppressing process
* Reverting the changed made for the address space update in peered vNets. PR: 11090 (#11731)
Co-authored-by: Hari Prasad Perabattula <haperaba@microsoft.com>
* set readonly property of contentStorageAccount to false (#11630)
Co-authored-by: Zhejun Zhao <t-zhzhao@microsoft.com>
* Add Nullable annotation (#11684)
Co-authored-by: Dongwei Wang <dongwwa@microsoft.com>
* Revert missing response code. (#11690)
* Revert missing response code.
* Prettier format fix.
Co-authored-by: Ravi Arora <raviarora@microsoft.com>
* Microsoft.OperationalInsights: Property name change. (#11752)
* Microsoft.OperationalInsights: Proerty name change.
* Style fix.
Co-authored-by: Dudi Likvornik <dulikvor@microsoft.com>
* [T2] devtestlabs for python track2 (#11724)
* python track2
* python
* Managed Services Swagger Consistency Fixes (#11471)
* Updated 2018-06-01-preview specs
* Updated 2019-04-01-preview specs
* Updated 2018-06-01-preview specs
* Updated 2020-02-01-preview specs
* Updated 2019-06-01 specs
* Updated 2019-09-01 specs
* Updated 2018-06-01-preview examples
* Updated ErrorResponse model
* Model validation fix
* Removed readOnly=true for ErrorResponse
* Updated type specification for error
* Removed old type reference for ErrorResponse
* Changes to avoid Breaking changes for dotnet (#11739)
* Microsoft.Compute: Include CloudServices Resource Swagger under API Version 2020-10-01-preview (#11704)
Co-authored-by: Sanchit Kumar <Sanchit.Kumar@microsoft.com>
* [T2] datalakestore for python track2 (#11722)
* python track2
* python.md
* [Hub Generated] Review request for Microsoft.MixedReality to add version preview/2019-02-28-preview (#11626)
* add isDataAction to listOperations spec
* check if type is wrong
* Type should be boolean
* add identity and kind to the spatial accounts def
* isDataAction should be an enum
* move isDataAction to its own enum
* remove kind from list
* refer to common types instead of defining inline
* update schema to reflect reality
* remove extraneous curly brace
* add curly brace at the correct location
* change nameAvailable to boolean
* add a format for integer type
* change example
* updated wrong file
* remove format per breaking change discussion
* fix prettier error
* update pr assignment (#11750)
* Fix some bad output folder in go SDK (#11781)
* Fix s360 kpis for 2020-03-01. (#11593)
* Fix s360 kpis for 2020-03-01.
* Delete Caches_Delete.json.bak
Remove backup file that was accidentally pushed.
* Delete Caches_Flush.json.bak
Remove backup file that was accidentally pushed.
* Delete Caches_Start.json.bak
Remove backup file that was accidentally pushed.
* Delete Caches_Stop.json.bak
Remove backup file that was accidentally pushed.
* Delete Caches_UpgradeFirmware.json.bak
Remove backup file that was accidentally pushed.
* Delete StorageTargets_Delete.json.bak
Remove backup file that was accidentally pushed.
* Add change directory to reservations spec 2020-10-01-preview (#11555)
* Add change directory to reservations spec 2020-10-01-preview
* refactoring and updating description
* prettier and spellcheck
* Revert "prettier and spellcheck"
This reverts commit b2a9735fe4791b6202083c5d4111a2f588b5b947.
* Revert "refactoring and updating description"
This reverts commit 9dfdd7878629eb83a33070712b302bc1fba94f1e.
* Revert "Add change directory to reservations spec 2020-10-01-preview"
This reverts commit 064f7a9f86a72620d123d69a13c23ef8a61c38b7.
* moving change directory to new api version
* fixing lint error
* update default tag
Co-authored-by: Sean Oh <hyo@microsoft.com>
* [ACR] New API version 2020-11-01-preview: AZ and On-Prem support (#11412)
* Adding managedBy property that is returned by the API but not in swagger (#11788)
* Updates advisor.Json to improve Documentation for Suppressions_Get operation (#11433)
Co-authored-by: Yen-Chun Chang <yenchunchang@microsoft.com>
* AssociatedWorkspaces and CapacityReservationProperties added to cluster (#11736)
* AssociatedWorkspaces and CapacityReservationProperties added to cluster. Cluser defualt error bug fixed
* change AssociatedWorkspaces to array
* fix validation errors
* fix validation errors
* missing token added
* read only properties deleted
* read only properties deleted
* LintDIff Errors Fixed
* LACluster added to WorkspaceSku
* update error description
* revert types.json changes
* add prettier
* change default error response to use V2 format
* use V2 types.json file
Co-authored-by: Arie Olshanezky <arolshan@microsoft.com>
* add validate config server(stable) (#10858)
* add validate config server(stable)
* prettier
* typo
* BRP prune backup store API (#11479)
* Add backup external store pruning to the API spec
* Fix CI
* Marketplace miberezi 2020 (#11787)
* FIxing Privatestore ,Offer properties and examples
* Fixing properties types
* Fixing camel cases
* Add Idempotence to custom-words.txt
* prettier check changes
* adding description to isGov
* resolve conflicts
* Fix updateSuppressedDueIdempotence type
* FIx swagger validation issues
* Fix json
* Fix indentation conflicts
* Fix corruption
* Fix validations
* FIx marketplace swagger
* Download files for cm sensors (#11635)
* Added API of DownloadQuotaData to iotDefenderSettings and DownloadResetPassword to iotSensors
* Added reset password api also for the on premise iot sensors
* renamed DownloadQuotaData to DownloadManagerActivation
* Fixed the body in the DownloadResetPassword API
* Azure Healthbot swagger (#11681)
* Azure Healthbot swagger .
* Fixes according to review.
* Fixes according to review.
* Fixes according to review.
* Update samplereadme.md (#11800)
fix language readme path
* Updating Package Manifest Schema in Private Preview API (#11688)
* tried fixing packge infomration flagging (#10870)
* [Hub Generated] Review request for Microsoft.Maps/DEM to add version preview/1.0 (#11410)
* Adds base for updating Microsoft.Maps from version Alias/preview to version 2020-12-01-preview
* Updates readme
* Updates API version in new specs and examples
* Add DEM API reference docs
* Fixing Typos & format
* Fix Typos
* Add dem in render.json
* apply comments
* apply comments
* Apply comments
* Fix validation
* Revert change about version
Co-authored-by: Yuqi Zhang <yuqzhan@microsoft.com>
* [Hub Generated] Review request for Microsoft.Logic to add version stable/2019-05-01 (#11627)
* Adding integration service environment encryption configuration details to Logic spec
* Correcting json format errors
* Correcting json formats
* Updating examples
* Fixing encryption key properties definition
Co-authored-by: Rama Krishna Rayudu <rarayudu@microsoft.com>
* fix powerplatforrm ref & duplicates (#11580)
* Microsoft.ProviderHub GA API version (#11775)
* RPaaS 2020.11.20 GA specs
* update readme
* prettier fix and add custom words
* spelling
* update SDKs
* go sdk
Co-authored-by: Wendy Chang <wendychang@microsoft.com>
* top level name can be 64 char long (#11692)
* Update comment.yml (#11797)
* Update Azure SQLDB 2020-08-01-preview swagger files (#10994)
* Update 2020-08-01 preview swagger files
and fix lint error
* rollback the sql common type file reference.
* Fix RESPONSE_SCHEMA_NOT_IN_SPEC validation errors in example files
* address part of example files errors.verify the fixes.
* fix LocationCapabilityListByLocation.json
* fix OBJECT_ADDITIONAL_PROPERTIES
* update with most of fix
* BackupShortTermRetentionPolicies fix
* public only
* fix server Key with internal PR
* change resource group name DatabaseVulnerabilityAssessmentScans
* Dev saas microsoft.saa s 2018 03 01 beta (#11680)
* from local
Signed-off-by: Dina Yakobovich <diyakobo@microsoft.com>
* add examples
* fix saasDelete
* fix again saasDelete
* change to lowerCase
* second change to lower Case
* fix parameters
* update deleteOptions definition
* add folder
* add new line and cSpell
* typing errors
* change example rsponse
* change response of application example
* add statuses to responses
* change put payload parameters name
* change tag properties
* add readme files
* move x-ms-exaples to the right place
* add defoult response
* fix error responses
* change operation schema
* add 200 to delete response
* fix worning
* readme files
* remove long running
* add space
* spelling errors
* comments fixing
* return operation
* readonly
* add suppression
* [NetAppFiles] Anf 8187 update swagger rest api to 2020 08 01 (#11689)
* Add 2020-08-01 folder
* Update api version
* update readme
* update readme
* issue in readme
* issue in readme
* issue in readme
* touch
Co-authored-by: Audunn Baldvinsson <audunn.baldvinsson@netapp.com>
* fix typo issue (#11818)
* [Hub Generated] Review request for Microsoft.Maps/Microsoft.Maps to add version preview/1.0 (#11745)
* Adding string type suppport for feature state style rule
* Making the Integer, Boolean and string rule types appear in a strange way. I think this is better than not having them on the doc. Working with the team to figure out a way to do it better.
* Cleaning up the workarounds. Added a link to the reference page.
* Minor change to the text.
* Correctign the stateset description to say that a feature can have only one state set at a given point.
* Prettier changes.
* One more prettier change. By the tool.
Co-authored-by: Subbarayudu Kamma <skamma@microsoft.com>
* Update pull_request_assignment.yml (#11814)
* correct-package-name (#11666)
* Make DedicatedHostGroup.properties.supportAutomaticPlacement default to false (#11697)
* Removed maximum for DedicatedHostGroup
* Default supportAutomaticPlacement to false
* Updating vmSize description to correct hyperlinks and add a note on deprecating VirtualMachineSizeTypes enum in subsequent api-versions. (#11595)
* Removing vmSizeTypes enum
* Updating description and reverting the enum removal which will be done in a new api-version as a breaking change.
Co-authored-by: Avinash Akka <avakka@microsoft.com>
* python track2 (#11728)
* Update ci-fix.md (#11828)
* Aggregated swagger changes k8connect (#11817)
* aggregated swagger changes k8conect
* prettier fix
Co-authored-by: Siri Teja Reddy Kasireddy <sikasire@microsoft.com>
* Fix errors in various of readme files encountered in the recent go SDK release (#11826)
* Fix an issue on windows
* Fix cdn
* Fix cognitiveservices/customVision
* Fix cognitiveservices/personalizer
* Fix cognitiveservices/translatorText
* Fix data plane digitaltwins
* Remove problematic tag from release - no impact on sdk, this has never been released
* amend Fix cognitiveservices/translatorText
* Fix imds
* Fix migrate readme that are mistakenly damaged in #10305
* add one api-version back
* Fix digtaltwins data plane again
* Fix hybridnetwork
* Fix streamanlytics
* Revert some changes of digitaltwins
* Revert imds
* Fix migrate
* Fix migrate again
* remove pipeline old un-needed tasks (#11730)
* add privateLinkResources and privateEndpointConnection for 2020-09 API (#11837)
* Updating existing CRR APIs and protection APIs (#10962)
* Fixing bug in PrepareDataMoveResponse Class
* Updating existing CRR and protection APIs
* Adding examples
* Updating APIs to 2020-07-01
* Updating conflict
* Resolving failures
* Update
* Update
* Update
* Update
* Adding workloadCRRAccessToken
* Adding discriminator for CRRAccesToken
* Update
* Reverting change to 2020-07-01
* Update
* Update
* Fixing prettier
* Fix attestation output folder (#11838)
* Combining existing versions in latest version 2020-10-01 (#11733)
* Combining existing versions in latest version 2020-10-01
* Correcting version
* Fixing prettier
* Adding 2018-12-20 in latest package
* ASR: removing blob uri and sas token from examples (#11834)
* removing blob uri and sas token from examplaes
* added place holder value
* Remove api-version in recoveryservicebackup (#11846)
* add deploymentmanager track2 config (#11845)
* [Resources] Add extended locations in the /providers/resourceTypes API in 2020-08-01 version (#10986)
* copy everything from 2020-06-01
* replace 2020-06-01 with 2020-08-01
* add the new API /resourceTypes. add "locationMappings" property.
* add examples
* update readme.md
* run prettier
* fix tag for package-templatespecs
* Add changes to API version 2020-10-01
* [EntityQueries] - Adding EntityQueryKind to EntityQueries and changing Properties to Expansion properties (#11776)
* update swagger - aading LogicAppResourceId to Action put and response
* update swagger - changing to logicAppResourceId style
* adding LogicAppResourceId to Actions Request & Response
* adding LogicAppResourceId to Actions Request & Response
* adding Action property base
* editing examples and adding reauired to logicAppResourceId
* from LogicAppResourceId to logicAppResourceId
* running prettier
* running prettier
* removing required for LogicAppRexourceId
* changing logicApp propery doc
* changing logicApp propery description
* adding kind to entity queries and changing entityQueriesProperties to ExpansionEntityQueriesProperties
* changin return for entityQueryById
* added new rules (#11677)
* Fix the titles of Azure Stack HCI examples (#11853)
* Adding AFDX swagger and its examples (#11655)
* Adding AFDX swagger and its examples
* fix examples and added odata back
* added readme and fixed small sematic problems
* fix log analytics
* updates
* updates
* updates
* updates
* updates
* updates
* updates
* UPDATES
* add secret version back
* lint errors 1
* lint error 2
* lint 3
* lint 4
* updates
* spell check
* add origingroupoverrideaction
* address comments
* fixes
* updates
* remove ruleset update
* updates
Co-authored-by: Shirley Jiang <xujia@microsoft.com>
* Add some profile tag for go SDK to serve the new profile 2020-09-01 (#10923)
* some update of the tags for profiles
* final update for profiles
* a fix of tag name
* Remove the changes for web readme since it does not work
* Rename tag for compute, revert keyvault tag change
* update
* Adding lint rules: R4028,R4029,R4030 (#11812)
* add R4028
* update doc (#11843)
* update doc
* update description
* format
* add scope
Co-authored-by: jianye xi <jianyxi@microsoft.com>
Co-authored-by: Ruoxuan Wang <52271048+ruowan@users.noreply.github.com>
* update examples (#11807)
* adding throttle analytics export API two new filters (#11806)
* updating with two new filters
* fix typo
* typo
* add timeout support for Synapse notebook and job def (#11860)
* [Synapse] - Add missing API version parameter (#11751)
* [Synapse] - Add missing API version parameter and pageable
* Fix lint
* Fix recent found issues
* Fix lint error
* Fix model validation errors
* Remove x-ms-pageable
* Rename Action to RequiredAction
* Revert x-ms-pageable and AccessDecisions
* Update description for AccessDecisions
* Update checkAccessSynapseRbac.json
Slight wording fix
Co-authored-by: Dongwei Wang <dongwwa@microsoft.com>
Co-authored-by: Jonathan Turner <jonathandturner@users.noreply.github.com>
* [Synapse] - Update enum name from BlobEventTypes to BlobEventType (#11864)
Co-authored-by: Dongwei Wang <dongwwa@microsoft.com>
* Re-order parameters in swagger spec to avoid breaking change in SDK (#11883)
* [Hub Generated] Review request for Microsoft.CostManagement to add version stable/2019-11-01 (#11657)
* Created Separate Swagger for Exports
* add exports swagger to readme.md
* Exports swagger correctness
* Exports swagger correctness
* dataSet in examples
* fix dataSet in examples
* add dataSet to exportList and exportExecutionList examples
* Update ExportCreateOrUpdateByManagementGroup.json
* dataSet property of QueryDefinition costmanagement.json
* undo changes to costmanagement.json
* use ExportDefinition instead of QueryDefinition
* prettier fix
* Include CloudServices resource in API Version '2020-10-01-preview' in ARM Schema (#11874)
Co-authored-by: Sanchit Kumar <Sanchit.Kumar@microsoft.com>
* add maps track2 config (#11867)
* add labservices track2 config (#11866)
* Relay : Removed subscription and entities names from examples (#11891)
* removed subscription and entities names from examples
* example
* Fixing issue 11848 (#11888)
* Fixing issue 11848
* Fixing issue 11848
* Fixing lint errors
* Iot sites and sensor zones (#11296)
* iot-sites-and-zones
* rename displayName and fix missing params
* change caps mistake
* prettier run changes
* Delete Get.json
* Delete Delete.json
* Delete Put.json
* Delete List.json
* remove required tags
* fix merge
Co-authored-by: Gal Moshe <gamoshe@microsoft.com>
Co-authored-by: Gal Moshe <gamoshe@gamoshe.local>
* Change Hostname per documentation recommendations (#11714)
* Communication common api types (#11749)
* Common API types for Communication Services: Error and Identifier
* Rename type to kind
* Make error, code, message required as specified in guidelines
* Make all props on Identifier read-only
* prettier fix to add an empty line at the end
* add common.json to README
* make identifier id required and fix linter issues
* fix spelling
* make details an array of errors, rename error to CommunicationError
* grammar fix
* remove properties that are identical to id
* add support track2 config (#11894)
* Fix Analysis Services for Swagger Completeness (#11638)
* Fix Analysis Services for Swagger Completeness
* Fix for lintdiff issues
* Change schema to error
* Default schema change
* Adding title and description
* Add separator
* Some changes to address R4018
* Fix parameter
* Move parameter
* Remove a parameter
* Fix quotes bug
* Add required parameters to address R4018
* More updates to Operations API response schema
* Cleaner schema change following the example schema under R4018
* Fix for prettier tool
* fix the output folder for profile 2020-09-01 (#11920)
* Update DomainServices: Add missing property (#11885)
* Update domainservices.json
Add missing migrationProperties property
Fix casing for ForestTrust
* Update domainservices.json
Add missing migrationProperties property
Fix casing for ForestTrust
* DomainServices: Update completionPercentage format
* DomainServices: Update completionPercentage format
* DomainServices: Change casing for trustedDomainFqdn and remoteDnsIps
* DomainServices: Change casing for trustedDomainFqdn and remoteDnsIps
DomainServices: Change casing for trustedDomainFqdn and remoteDnsIps
* Microsoft.Authorization 2020-09-01 policy entity APIs (#11712)
* Copy old specs to new path
* Add 2020-09-01 policy entities
* Add description
* Fix prettier
* Fix schema and python
* Remove preview API from stable tag
* Fix go path
* Small amount of swagger validation cleanup
* Fix prettier violation
* Remove obsolete sku property
* Fix GO readme ordering
* Partially revert GO ordering
* add api-version of 2020-10-01 for resources (#11921)
* Defender for iot/8670818 sites and sensors (#11703)
* iot-sites-and-zones
* rename displayName and fix missing params
* change caps mistake
* prettier run changes
* Delete Get.json
* Delete Delete.json
* Delete Put.json
* Delete List.json
* added sensor's properties
* fix specification/security/resource-manager/readme.md
* clean redundant lines in readme
* prettier-fix
* put should return whole object
* indentation fix
* fix enum values
Co-authored-by: Gal Moshe <gamoshe@microsoft.com>
Co-authored-by: galmoshe <33285417+galmoshe@users.noreply.github.com>
* Fix 2019-06-01-preview/FailoverManagedInstance.json (#11880)
* Change Appearance format to v3.2-preview.2 (#11255)
* v3.1-preview.2
* v3.2-preview change appearance format
* change to solve comments
* typo
* Prettier
* update readme
* update version and solve comment
* change version to v3.2-preview.2
Co-authored-by: Jiayuan Shi <jiayshi@microsoft.com>
* Schema Change for New Event Grid Events Emitting from Service Bus (#11935)
* draft for schema changes
* Revert "draft for schema changes"
This reverts commit 04faa0dda5d0c187b9fb485e3b8068e778cfccaf.
* schema change
* modify existing swagger
* Portal revision API (#11738)
* Portal revision API
* fixed spec errors
* fixed references
* fixed return code on create and added long running operation properties
* fixed create response
* fixed comments
* small fix
* [Hub Generated] Review request for Microsoft.CostManagement to add version stable/2020-06-01 (#11753)
* Creating separate swagger file for exports
* add exports swagger to readme
* edit api version
* add "TheLast7Days" to exports timeframes
* remove 'TheLast7Days' from export timeframes
* prettier fix
* prettier fix 2
* Fix for swagger correctness: eTag property missing and recurrence not required
* Update description to indicate force delete is in preview (#11763)
* updating compute.json for force delete
* update description
* update to string
* updating description
* update description
* update comment
* add example
* added example and updated prettier
* updated prettier
* [Hub Generated] Review request for Microsoft.Authorization to add version preview/2020-04-01-preview (#11506)
* [DataFactory]: Add CMK Properties (#10867)
* [DataFactory]: Add CMK Properties
* Prettier validation
* Model Identity Type as string
* RemoveEnumChanges
* Add missing properties in appplatform preview API (#10612)
* add missing properties to 2019-05-01-preview
* update examples
* generate go sdk for authorization (#11942)
* Revert "generate go sdk for authorization (#11942)" (#11944)
This reverts commit c00cdbf22fa96afb7c1ef68aa1f73e9fc52f5ad8.
* fix monitor package name (#11947)
* fix monitor package name
* fix CI
* add storagesync track2 config (#11923)
* Microsoft.key vault dp 7.3 preview (#11464)
* Update Swagger for key rotation
* Update api version
* Fixed build error
* Fixed model validation in keys
* Fixed model validation error in certificates
* Add new version 7.3-preview based on 7.2-preview
* Fixed lint error
* Update api version tag
* Revert changes
* Update keyvault.json (#11040)
* Update keyvault.json
* Update keyvault.json
* Update keyvault.json
* azure-sdk-for-java automation config enable track2 (#11865)
DataPlane not supported
* add attestation track2 config (#11925)
* Update references for OpenAPI (#11859)
* adding the field on which on which summary is done in the response (#11383)
Co-authored-by: Durgesh Kumar <dukum@microsoft.com>
* Remove the problematic api-version in operationalinsights (#11857)
* add databricks track2 config (#11844)
* Fix problematic inheritance structure in security (#11156)
* Fix problematic inherintance structure
* Add back the missing discriminator
* Fix examples
* rename model
* Update pull_request_assignment.yml (#11974)
* add appplatform track2 config (#11924)
* [Hub Generated] Public private branch 'credscan-fix' (#11939)
* Fix credscan
* Fix more credentials
* [webapp]:Add endpoint for AppService CLI Github token endpoint (#11036)
* Copied over from 2020-06-01
* Changed from 2020-06 to 2020-09
* Added api specs for github auth endpoint
* Copy over Microsoft.CertificateRegistration and Microsoft.DomainRegistration, and small fixes
* Add systemdata
* Add in missing commondefinitions and webapps.json that wasn't copied over from old version
Co-authored-by: Calvin Chan <calcha@microsoft.com>
Co-authored-by: praveen <praveen2909@gmail.com>
Co-authored-by: Seth Speaks <sspeaks@microsoft.com>
Co-authored-by: xolve <ra.ravi.rav@gmail.com>
Co-authored-by: raviarora <raviarora@MININT-54JRS6K.fareast.corp.microsoft.com>
Co-authored-by: Ravi Arora <raviarora@microsoft.com>
Co-authored-by: Cameron Taggart <cameron.taggart@microsoft.com>
Co-authored-by: gechris <69321460+gechris@users.noreply.github.com>
Co-authored-by: worldhello126 <49164775+worldhello126@users.noreply.github.com>
Co-authored-by: Douglas Lee <65295939+leedouglas@users.noreply.github.com>
Co-authored-by: David Becher <dabecher@microsoft.com>
Co-authored-by: Christian Pomales <chpomale@microsoft.com>
Co-authored-by: david becher <dab4au@virginia.edu>
Co-authored-by: Cameron Taggart <cameron.taggart@gmail.com>
Co-authored-by: Christian Pomales <12565983+ChristianPomales@users.noreply.github.com>
Co-authored-by: Kaihui (Kerwin) Sun <sunkaihuisos@gmail.com>
Co-authored-by: Chuang <54572251+xccc-msft@users.noreply.github.com>
Co-authored-by: Limin Gu <48228819+limingu@users.noreply.github.com>
Co-authored-by: Zhenfeng <john.chan08@yahoo.com>
Co-authored-by: colawwj <70128817+colawwj@users.noreply.github.com>
Co-authored-by: changlong-liu <59815250+changlong-liu@users.noreply.github.com>
Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com>
Co-authored-by: Richa Jain <richa.jain1912@gmail.com>
Co-authored-by: Richa Jain <ricjain@microsoft.com>
Co-authored-by: Zhenglai Zhang <darinzh@microsoft.com>
Co-authored-by: Phoenix He <tih@microsoft.com>
Co-authored-by: Samir Solanki <samirsolanki@outlook.com>
Co-authored-by: xhl873 <66849509+xhl873@users.noreply.github.com>
Co-authored-by: Xiahe Liu <Xiahe.Liu@microsoft.com>
Co-authored-by: Paul Miller <pmiller@microsoft.com>
Co-authored-by: hbc <me@hbc.rocks>
Co-authored-by: Super <mali_no2@hotmail.com>
Co-authored-by: Li Ma <lima2@microsoft.com>
Co-authored-by: Qingchuan Hao <haoqingchuan@hotmail.com>
Co-authored-by: Tongyao Si <tosi@microsoft.com>
Co-authored-by: Bo Wang <61758179+bowang-666@users.noreply.github.com>
Co-authored-by: Dongwei Wang <bean0idear@163.com>
Co-authored-by: Dongwei Wang <dongwwa@microsoft.com>
Co-authored-by: Deyaaeldeen Almahallawi <dealmaha@microsoft.com>
Co-authored-by: Navneet Singh <navneetnsit09@gmail.com>
Co-authored-by: Navneet Singh <navsi@microsoft.com>
Co-authored-by: Ashraf Hamad <ahamad-MS@users.noreply.github.com>
Co-authored-by: Ashraf Hamad <ahamad@ntdev.microsoft.com>
Co-authored-by: Saar Shen <saars@microsoft.com>
Co-authored-by: surashed <55134940+surashed@users.noreply.github.com>
Co-authored-by: Sanjai Ganesh Jeenagiri <sanjaiganesh@users.noreply.github.com>
Co-authored-by: AKachan0v <alkac@microsoft.com>
Co-authored-by: Alex Kachanov <alkac@corp.microsoft.com>
Co-authored-by: kai ru <69238381+kairu-ms@users.noreply.github.com>
Co-authored-by: Arcturus <dapzhang@microsoft.com>
Co-authored-by: liuyu1981831m <66749717+liuyu1981831m@users.noreply.github.com>
Co-authored-by: MiriBerezin <73054714+MiriBerezin@users.noreply.github.com>
Co-authored-by: Larry Osterman <LarryOsterman@users.noreply.github.com>
Co-authored-by: Ric Serradas <riserrad@microsoft.com>
Co-authored-by: Jimmy Campbell <jimmyca@microsoft.com>
Co-authored-by: asmaskar <58723769+asmaskar@users.noreply.github.com>
Co-authored-by: Gokul Premraj <gopremra@microsoft.com>
Co-authored-by: Filiz Topatan <fitopata@microsoft.com>
Co-authored-by: Jeremy Hurren <lordjeb@lordjeb.com>
Co-authored-by: Jeremy Hurren <jehurren@microsoft.com>
Co-authored-by: Adhish Chugh <adhishchugh@icloud.com>
Co-authored-by: Shrecho <57687274+tunafish88@users.noreply.github.com>
Co-authored-by: Arik Olsh <47111029+arolshan@users.noreply.github.com>
Co-authored-by: Dudi Likvornik <likdudi@gmail.com>
Co-authored-by: Dudi Likvornik <dulikvor@microsoft.com>
Co-authored-by: andrew <69653137+greenms@users.noreply.github.com>
Co-authored-by: Vivian Liu <viv.liu25@gmail.com>
Co-authored-by: rapatank <69176921+rapatank@users.noreply.github.com>
Co-authored-by: Tanyi Chen <tanchen@microsoft.com>
Co-authored-by: Amogh Natu <natu.amogh@gmail.com>
Co-authored-by: Amogh Natu <amnat@microsoft.com>
Co-authored-by: Chris Eggert <pilor@users.noreply.github.com>
Co-authored-by: Zhiyong Yang <gayang@microsoft.com>
Co-authored-by: Jorge Herrera <69991673+herreraj-ms@users.noreply.github.com>
Co-authored-by: Vladimir Raikov <vladrai@users.noreply.github.com>
Co-authored-by: hunngu-ms <63322431+hunngu-ms@users.noreply.github.com>
Co-authored-by: Nilay Chheda <mit2nil@gmail.com>
Co-authored-by: Bhavin Shah <bhshah@microsoft.com>
Co-authored-by: shahbj79 <shahbj79@hotmail.com>
Co-authored-by: Ganga Narayanan <gangan@microsoft.com>
Co-authored-by: Nilay Chheda <nichheda@microsoft.com>
Co-authored-by: srkakuru <50426366+srkakuru@users.noreply.github.com>
Co-authored-by: Dhawal Jain <41853104+dhawal777@users.noreply.github.com>
Co-authored-by: Adithya Upadhya <adupadhy@microsoft.com>
Co-authored-by: Harshitha Akkaraju <24836340+harshitha-akkaraju@users.noreply.github.com>
Co-authored-by: Harshitha Akkaraju <hakkaraj@microsoft.com>
Co-authored-by: Yang Yuan <yangyuan@users.noreply.github.com>
Co-authored-by: Ju Hee Lee <juhee0202@gmail.com>
Co-authored-by: JianyeXi <59603451+jianyexi@users.noreply.github.com>
Co-authored-by: Hari Prasad Perabattula <harics24@users.noreply.github.com>
Co-authored-by: Hari Prasad Perabattula <haperaba@microsoft.com>
Co-authored-by: anjou <anjou1997@gmail.com>
Co-authored-by: Zhejun Zhao <t-zhzhao@microsoft.com>
Co-authored-by: Saif Kayani <saifkay36@gmail.com>
Co-authored-by: Sanchit Kumar <sanchitkum@gmail.com>
Co-authored-by: Sanchit Kumar <Sanchit.Kumar@microsoft.com>
Co-authored-by: roytan-microsoft <73565668+roytan-microsoft@users.noreply.github.com>
Co-authored-by: brpanask <64860651+brpanask@users.noreply.github.com>
Co-authored-by: hyo <31109331+corquiri@users.noreply.github.com>
Co-authored-by: Sean Oh <hyo@microsoft.com>
Co-authored-by: Jeanine Burke <41650461+jaysterp@users.noreply.github.com>
Co-authored-by: yenchunchang <rebiex0915@gmail.com>
Co-authored-by: Yen-Chun Chang <yenchunchang@microsoft.com>
Co-authored-by: dhaiman <67913163+dhaiman@users.noreply.github.com>
Co-authored-by: Arie Olshanezky <arolshan@microsoft.com>
Co-authored-by: ninpan-ms <71061174+ninpan-ms@users.noreply.github.com>
Co-authored-by: poetw <45549150+poetw@users.noreply.github.com>
Co-authored-by: MichalHel <51286657+MichalHel@users.noreply.github.com>
Co-authored-by: guy-microsoft <50947884+guy-microsoft@users.noreply.github.com>
Co-authored-by: Tianen <347142915@qq.com>
Co-authored-by: lavinir <56975945+lavinir@users.noreply.github.com>
Co-authored-by: nivats <41890611+nivats@users.noreply.github.com>
Co-authored-by: yuqi2 <yuqi2@g.clemson.edu>
Co-authored-by: Yuqi Zhang <yuqzhan@microsoft.com>
Co-authored-by: rarayudu <ramakrishna.rayudu@gmail.com>
Co-authored-by: Rama Krishna Rayudu <rarayudu@microsoft.com>
Co-authored-by: wwendyc <wendy.changw@gmail.com>
Co-authored-by: Wendy Chang <wendychang@microsoft.com>
Co-authored-by: datr93 <43795914+datr93@users.noreply.github.com>
Co-authored-by: Ruoxuan Wang <52271048+ruowan@users.noreply.github.com>
Co-authored-by: Ji Wang <wangjiprc@gmail.com>
Co-authored-by: diyakobo <73845794+diyakobo@users.noreply.github.com>
Co-authored-by: Auðunn <audunn@netapp.com>
Co-authored-by: Audunn Baldvinsson <audunn.baldvinsson@netapp.com>
Co-authored-by: Subbarayudu Kamma <35783011+subbarayudukamma@users.noreply.github.com>
Co-authored-by: Subbarayudu Kamma <skamma@microsoft.com>
Co-authored-by: dochung4 <40577926+dochung4@users.noreply.github.com>
Co-authored-by: Avinash <akka@usc.edu>
Co-authored-by: Avinash Akka <avakka@microsoft.com>
Co-authored-by: siriteja <32883500+sirireddy12@users.noreply.github.com>
Co-authored-by: Siri Teja Reddy Kasireddy <sikasire@microsoft.com>
Co-authored-by: Pratima Upadhyay <pratima.upadhyay02@gmail.com>
Co-authored-by: ayfathim <ayfathim@microsoft.com>
Co-authored-by: Tiano2017 <31759375+Tiano2017@users.noreply.github.com>
Co-authored-by: ori-licht <58462609+ori-licht@users.noreply.github.com>
Co-authored-by: Magdalena Białecka <2598290+mbialecka@users.noreply.github.com>
Co-authored-by: Shirley Jiang <shirleychiang27@gmail.com>
Co-authored-by: Shirley Jiang <xujia@microsoft.com>
Co-authored-by: jianye xi <jianyxi@microsoft.com>
Co-authored-by: Theodore Chang <thchan@microsoft.com>
Co-authored-by: Long Tian <ltian@microsoft.com>
Co-authored-by: Jonathan Turner <jonathandturner@users.noreply.github.com>
Co-authored-by: paornela <70660621+paornela@users.noreply.github.com>
Co-authored-by: Ajit Navasare <v-ajnav@microsoft.com>
Co-authored-by: galmoshe <33285417+galmoshe@users.noreply.github.com>
Co-authored-by: Gal Moshe <gamoshe@microsoft.com>
Co-authored-by: Gal Moshe <gamoshe@gamoshe.local>
Co-authored-by: John Gallardo <jgalla@microsoft.com>
Co-authored-by: Dominik <domessin@microsoft.com>
Co-authored-by: Suriyha <52430352+Suriyha@users.noreply.github.com>
Co-authored-by: jihochang <jihochang@users.noreply.github.com>
Co-authored-by: Ami Hollander <Ami.Hollander@microsoft.com>
Co-authored-by: Ji Wang <jiwang5@microsoft.com>
Co-authored-by: shijiayuan <jiayuans@usc.edu>
Co-authored-by: Jiayuan Shi <jiayshi@microsoft.com>
Co-authored-by: DorothySun216 <55454966+DorothySun216@users.noreply.github.com>
Co-authored-by: Igor O <ygrik@hotmail.com>
Co-authored-by: Aishwarya Seetharaman <24403906+Aishwarya-C-S@users.noreply.github.com>
Co-authored-by: Daniel Orozco <64658732+dagoroz@users.noreply.github.com>
Co-authored-by: Pacodel <pacodel@microsoft.com>
Co-authored-by: Yuwei Zhou <yuwzho@microsoft.com>
Co-authored-by: njucz <zhcheng@microsoft.com>
Co-authored-by: qinl-li <63257243+qinl-li@users.noreply.github.com>
Co-authored-by: Jack Lichwa <52512203+jlichwa@users.noreply.github.com>
Co-authored-by: dukum <55188537+dukum@users.noreply.github.com>
Co-authored-by: Durgesh Kumar <dukum@microsoft.com>
Co-authored-by: Calvin <calvinch4n@gmail.com>
Co-authored-by: Calvin Chan <calcha@microsoft.com>
giromm2ms
pushed a commit
to giromm2ms/azure-rest-api-specs
that referenced
this pull request
Dec 20, 2020
* Fixing linting issues according to report (task 8554751) * Adding a default response to operations
ghost
pushed a commit
to Azure/azure-resource-manager-schemas
that referenced
this pull request
Jan 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We received the following request to fix Linting issues in our Swagger Resource Manager spec:
R4005:UniqueXmsEnumName
R4010:RequiredDefaultResponse
This change is to fix specifically those two.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.