Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Examples for Provider instances #11505

Merged

Conversation

PakDLiu
Copy link
Contributor

@PakDLiu PakDLiu commented Nov 3, 2020

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @PakDLiu Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Nov 3, 2020

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail]
    There are no breaking changes.
    ️️✔️~[Staging] LintDiff succeeded [Detail]
    Validation passes for LintDiff.
    ️️✔️~[Staging] Avocado succeeded [Detail]
    Validation passes for Avocado.
    ️️✔️~[Staging] ModelValidation succeeded [Detail]
    Validation passes for ModelValidation.
    ️️✔️~[Staging] SemanticValidation succeeded [Detail]
    Validation passes for SemanticValidation.
    ️️✔️~[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail]
    There are no breaking changes.
    ️️✔️~[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail]
    There are no breaking changes.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Nov 3, 2020

    Swagger Generation Artifacts

    ️️✔️~[Staging] ApiDocPreview succeeded [Detail]
    Posted by Swagger Pipeline | How to fix these errors?

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Nov 3, 2020

    Azure CLI Extension Generation - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Nov 3, 2020

    azure-sdk-for-java - Release

    ️✔️ succeeded [Logs] [Expand Details]
    • ️✔️ Generate from aa8ba56 with merge commit 64d0c92. SDK Automation 13.0.17.20200918.2
    • ️✔️sdk/hanaonazure/mgmt-v2017_11_03_preview [View full logs]  [Release SDK Changes]
      Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Thu, 05 Nov 2020 07:54:36 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0401:DBAB:856B6B3:986AF14:5FA3AFBC","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Nov 3, 2020

    azure-sdk-for-go - Release

    ️✔️ succeeded [Logs] [Expand Details]
    • ️✔️ Generate from aa8ba56 with merge commit 64d0c92. SDK Automation 13.0.17.20200918.2
    • ️✔️preview/hanaonazure/mgmt/2017-11-03-preview [View full logs]  [Release SDK Changes]
      Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Thu, 05 Nov 2020 07:55:00 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"07C2:9CA8:56301ED:63756EC:5FA3AFD3","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Nov 3, 2020

    azure-sdk-for-js - Release

    ️✔️ succeeded [Logs] [Expand Details]
    • ️✔️ Generate from aa8ba56 with merge commit 64d0c92. SDK Automation 13.0.17.20200918.2
    • ️✔️@azure/arm-hanaonazure [View full logs]  [Release SDK Changes]
      [npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
      [npmPack] npm WARN deprecated resolve-url@0.2.1: https://github.com/lydell/resolve-url#deprecated
      [npmPack] npm WARN deprecated urix@0.1.0: Please see https://github.com/lydell/urix#deprecated
      [npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
      [npmPack] loaded rollup.config.js with warnings
      [npmPack] (!) Unused external imports
      [npmPack] default imported from external module 'rollup' but never used
      [npmPack] 
      [npmPack] ./esm/hanaManagementClient.js → ./dist/arm-hanaonazure.js...
      [npmPack] created ./dist/arm-hanaonazure.js in 252ms
      [npmPack] npm notice 
      [npmPack] npm notice package: @azure/arm-hanaonazure@3.0.0
      [npmPack] npm notice === Tarball Contents === 
      [npmPack] npm notice 43.2kB dist/arm-hanaonazure.js                     
      [npmPack] npm notice 13.7kB dist/arm-hanaonazure.min.js                 
      [npmPack] npm notice 1.6kB  esm/hanaManagementClient.js                 
      [npmPack] npm notice 2.6kB  esm/hanaManagementClientContext.js          
      [npmPack] npm notice 263B   esm/models/index.js                         
      [npmPack] npm notice 364B   esm/operations/index.js                     
      [npmPack] npm notice 10.0kB esm/models/mappers.js                       
      [npmPack] npm notice 1.5kB  esm/operations/operations.js                
      [npmPack] npm notice 361B   esm/models/operationsMappers.js             
      [npmPack] npm notice 1.8kB  esm/models/parameters.js                    
      [npmPack] npm notice 9.2kB  esm/operations/providerInstances.js         
      [npmPack] npm notice 468B   esm/models/providerInstancesMappers.js      
      [npmPack] npm notice 906B   rollup.config.js                            
      [npmPack] npm notice 8.9kB  esm/operations/sapMonitors.js               
      [npmPack] npm notice 462B   esm/models/sapMonitorsMappers.js            
      [npmPack] npm notice 1.7kB  package.json                                
      [npmPack] npm notice 457B   tsconfig.json                               
      [npmPack] npm notice 90.4kB dist/arm-hanaonazure.js.map                 
      [npmPack] npm notice 13.1kB dist/arm-hanaonazure.min.js.map             
      [npmPack] npm notice 691B   esm/hanaManagementClient.d.ts.map           
      [npmPack] npm notice 814B   esm/hanaManagementClient.js.map             
      [npmPack] npm notice 507B   esm/hanaManagementClientContext.d.ts.map    
      [npmPack] npm notice 1.4kB  esm/hanaManagementClientContext.js.map      
      [npmPack] npm notice 4.9kB  esm/models/index.d.ts.map                   
      [npmPack] npm notice 181B   esm/operations/index.d.ts.map               
      [npmPack] npm notice 126B   esm/models/index.js.map                     
      [npmPack] npm notice 195B   esm/operations/index.js.map                 
      [npmPack] npm notice 839B   esm/models/mappers.d.ts.map                 
      [npmPack] npm notice 5.9kB  esm/models/mappers.js.map                   
      [npmPack] npm notice 659B   esm/operations/operations.d.ts.map          
      [npmPack] npm notice 905B   esm/operations/operations.js.map            
      [npmPack] npm notice 209B   esm/models/operationsMappers.d.ts.map       
      [npmPack] npm notice 222B   esm/models/operationsMappers.js.map         
      [npmPack] npm notice 494B   esm/models/parameters.d.ts.map              
      [npmPack] npm notice 1.3kB  esm/models/parameters.js.map                
      [npmPack] npm notice 2.5kB  esm/operations/providerInstances.d.ts.map   
      [npmPack] npm notice 4.3kB  esm/operations/providerInstances.js.map     
      [npmPack] npm notice 283B   esm/models/providerInstancesMappers.d.ts.map
      [npmPack] npm notice 296B   esm/models/providerInstancesMappers.js.map  
      [npmPack] npm notice 2.7kB  esm/operations/sapMonitors.d.ts.map         
      [npmPack] npm notice 4.6kB  esm/operations/sapMonitors.js.map           
      [npmPack] npm notice 281B   esm/models/sapMonitorsMappers.d.ts.map      
      [npmPack] npm notice 294B   esm/models/sapMonitorsMappers.js.map        
      [npmPack] npm notice 3.2kB  README.md                                   
      [npmPack] npm notice 1.2kB  esm/hanaManagementClient.d.ts               
      [npmPack] npm notice 1.6kB  src/hanaManagementClient.ts                 
      [npmPack] npm notice 906B   esm/hanaManagementClientContext.d.ts        
      [npmPack] npm notice 2.3kB  src/hanaManagementClientContext.ts          
      [npmPack] npm notice 13.8kB esm/models/index.d.ts                       
      [npmPack] npm notice 133B   esm/operations/index.d.ts                   
      [npmPack] npm notice 13.3kB src/models/index.ts                         
      [npmPack] npm notice 332B   src/operations/index.ts                     
      [npmPack] npm notice 982B   esm/models/mappers.d.ts                     
      [npmPack] npm notice 8.2kB  src/models/mappers.ts                       
      [npmPack] npm notice 1.1kB  esm/operations/operations.d.ts              
      [npmPack] npm notice 2.2kB  src/operations/operations.ts                
      [npmPack] npm notice 133B   esm/models/operationsMappers.d.ts           
      [npmPack] npm notice 325B   src/models/operationsMappers.ts             
      [npmPack] npm notice 556B   esm/models/parameters.d.ts                  
      [npmPack] npm notice 1.8kB  src/models/parameters.ts                    
      [npmPack] npm notice 7.5kB  esm/operations/providerInstances.d.ts       
      [npmPack] npm notice 13.3kB src/operations/providerInstances.ts         
      [npmPack] npm notice 240B   esm/models/providerInstancesMappers.d.ts    
      [npmPack] npm notice 435B   src/models/providerInstancesMappers.ts      
      [npmPack] npm notice 7.5kB  esm/operations/sapMonitors.d.ts             
      [npmPack] npm notice 13.8kB src/operations/sapMonitors.ts               
      [npmPack] npm notice 234B   esm/models/sapMonitorsMappers.d.ts          
      [npmPack] npm notice 437B   src/models/sapMonitorsMappers.ts            
      [npmPack] npm notice 1.1kB  LICENSE.txt                                 
      [npmPack] npm notice === Tarball Details === 
      [npmPack] npm notice name:          @azure/arm-hanaonazure                  
      [npmPack] npm notice version:       3.0.0                                   
      [npmPack] npm notice filename:      azure-arm-hanaonazure-3.0.0.tgz         
      [npmPack] npm notice package size:  42.9 kB                                 
      [npmPack] npm notice unpacked size: 332.2 kB                                
      [npmPack] npm notice shasum:        0cbddfb71b3977e40f5484953ce928bd710ce6a2
      [npmPack] npm notice integrity:     sha512-/lq9ZQZeY/AjK[...]JLCRp0LH9WBTg==
      [npmPack] npm notice total files:   69                                      
      [npmPack] npm notice 
      Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Thu, 05 Nov 2020 07:51:34 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0441:4447:147709:41DC4B:5FA3AF06","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Nov 3, 2020

    azure-sdk-for-net - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Nov 3, 2020

    azure-sdk-for-python - Release

    - Breaking Change detected in SDK

    ⚠️ warning [Logs] [Expand Details]
    • ⚠️ Generate from aa8ba56 with merge commit 64d0c92. SDK Automation 13.0.17.20200918.2
    • ⚠️azure-mgmt-hanaonazure [View full logs]  [Release SDK Changes] Breaking Change Detected
      [build_conf] INFO:packaging_tools:Building template azure-mgmt-hanaonazure
      [build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
      [build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
      [build_conf] INFO:packaging_tools:Template done azure-mgmt-hanaonazure
      [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
      [build_package]   warnings.warn(msg)
      [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
      [build_package]   warnings.warn(msg)
      Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Thu, 05 Nov 2020 07:53:10 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0400:2191:837F944:95E7E6C:5FA3AF66","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}
      [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
      [ChangeLog] Size of delta 6.971% size of original (original: 8880 chars, delta: 619 chars)
      [ChangeLog] **Breaking changes**
      [ChangeLog] 
      [ChangeLog]   - Parameter location of model TrackedResource is now required
      [ChangeLog]   - Parameter location of model SapMonitor is now required

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Nov 3, 2020

    azure-sdk-for-python-track2

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Nov 3, 2020

    azure-resource-manager-schemas - Release

    ⚠️ warning [Logs] [Expand Details]
    • ⚠️ Generate from aa8ba56 with merge commit 64d0c92. Schema Automation 13.0.17.20200918.2
      Failed to find any diff after autorest so no changed packages was found.

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Nov 3, 2020

    Trenton Generation - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @qianwens qianwens merged commit 64d0c92 into Azure:master Nov 5, 2020
    giromm2ms pushed a commit to giromm2ms/azure-rest-api-specs that referenced this pull request Dec 20, 2020
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants