Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose nic in dms sdk #11575

Merged
merged 2 commits into from
Nov 9, 2020
Merged

expose nic in dms sdk #11575

merged 2 commits into from
Nov 9, 2020

Conversation

zouxinghao
Copy link

@zouxinghao zouxinghao commented Nov 6, 2020

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@zouxinghao zouxinghao requested a review from hitenjava as a code owner November 6, 2020 22:35
@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Nov 6, 2020

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail]
There are no breaking changes.

️️✔️~[Staging] LintDiff succeeded [Detail]
Validation passes for LintDiff.

️️✔️~[Staging] Avocado succeeded [Detail]
Validation passes for Avocado.
️️✔️~[Staging] ModelValidation succeeded [Detail]
Validation passes for ModelValidation.
️️✔️~[Staging] SemanticValidation succeeded [Detail]
Validation passes for SemanticValidation.
️️✔️~[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail]
There are no breaking changes.
️️✔️~[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail]
There are no breaking changes.
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Nov 6, 2020

Swagger Generation Artifacts

️️✔️~[Staging] ApiDocPreview succeeded [Detail]
 Please click here to preview with your @microsoft account. 
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Nov 6, 2020

azure-sdk-for-python - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from fb06639 with merge commit cddec4b. SDK Automation 13.0.17.20200918.2
  • ️✔️azure-mgmt-datamigration [View full logs]  [Release SDK Changes]
    [build_conf_init]   Retrying (Retry(total=4, connect=None, read=None, redirect=None, status=None)) after connection broken by 'ConnectTimeoutError(, 'Connection to pypi.python.org timed out. (connect timeout=15)')': /simple/pytoml/
    [build_conf_init]   Retrying (Retry(total=4, connect=None, read=None, redirect=None, status=None)) after connection broken by 'ConnectTimeoutError(, 'Connection to pypi.python.org timed out. (connect timeout=15)')': /simple/attrs/
    [build_conf_init]   Retrying (Retry(total=4, connect=None, read=None, redirect=None, status=None)) after connection broken by 'ConnectTimeoutError(, 'Connection to pypi.python.org timed out. (connect timeout=15)')': /simple/docutils/
    [build_conf] INFO:packaging_tools:Building template azure-mgmt-datamigration
    [build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
    [build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
    [build_conf] INFO:packaging_tools:Template done azure-mgmt-datamigration
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
    [ChangeLog] Size of delta 0.083% size of original (original: 197859 chars, delta: 164 chars)
    [ChangeLog] **Features**
    [ChangeLog] 
    [ChangeLog]   - Model DataMigrationService has a new parameter virtual_nic_id

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Nov 6, 2020

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Nov 6, 2020

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Nov 6, 2020

azure-sdk-for-java - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from fb06639 with merge commit cddec4b. SDK Automation 13.0.17.20200918.2
  • ️✔️sdk/datamigration/mgmt-v2017_11_15_preview [View full logs]  [Release SDK Changes]
  • ️✔️sdk/datamigration/mgmt-v2018_03_31_preview [View full logs]  [Release SDK Changes]
  • ⚠️sdk/datamigration/mgmt-v2018_07_15_preview [View full logs]  [Release SDK Changes]
      [mvn] [ERROR] COMPILATION ERROR : 
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/datamigration/mgmt-v2018_07_15_preview/src/main/java/com/microsoft/azure/management/datamigration/v2018_07_15_preview/implementation/CommandPropertiesInner.java:[26,82] cannot find symbol
      [mvn]   symbol: class MigrateMISyncCompleteCommandProperties
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/datamigration/mgmt-v2018_07_15_preview/src/main/java/com/microsoft/azure/management/datamigration/v2018_07_15_preview/implementation/CommandPropertiesInner.java:[27,73] cannot find symbol
      [mvn]   symbol: class MigrateSyncCompleteCommandProperties
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/datamigration/mgmt-v2018_07_15_preview/src/main/java/com/microsoft/azure/management/datamigration/v2018_07_15_preview/implementation/CommandPropertiesInner.java:[28,49] cannot find symbol
      [mvn]   symbol: class MongoDbCancelCommand
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/datamigration/mgmt-v2018_07_15_preview/src/main/java/com/microsoft/azure/management/datamigration/v2018_07_15_preview/implementation/CommandPropertiesInner.java:[29,49] cannot find symbol
      [mvn]   symbol: class MongoDbFinishCommand
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/datamigration/mgmt-v2018_07_15_preview/src/main/java/com/microsoft/azure/management/datamigration/v2018_07_15_preview/implementation/CommandPropertiesInner.java:[30,50] cannot find symbol
      [mvn]   symbol: class MongoDbRestartCommand
      [mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-datamigration: Compilation failure: Compilation failure: 
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/datamigration/mgmt-v2018_07_15_preview/src/main/java/com/microsoft/azure/management/datamigration/v2018_07_15_preview/implementation/CommandPropertiesInner.java:[26,82] cannot find symbol
      [mvn] [ERROR]   symbol: class MigrateMISyncCompleteCommandProperties
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/datamigration/mgmt-v2018_07_15_preview/src/main/java/com/microsoft/azure/management/datamigration/v2018_07_15_preview/implementation/CommandPropertiesInner.java:[27,73] cannot find symbol
      [mvn] [ERROR]   symbol: class MigrateSyncCompleteCommandProperties
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/datamigration/mgmt-v2018_07_15_preview/src/main/java/com/microsoft/azure/management/datamigration/v2018_07_15_preview/implementation/CommandPropertiesInner.java:[28,49] cannot find symbol
      [mvn] [ERROR]   symbol: class MongoDbCancelCommand
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/datamigration/mgmt-v2018_07_15_preview/src/main/java/com/microsoft/azure/management/datamigration/v2018_07_15_preview/implementation/CommandPropertiesInner.java:[29,49] cannot find symbol
      [mvn] [ERROR]   symbol: class MongoDbFinishCommand
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/datamigration/mgmt-v2018_07_15_preview/src/main/java/com/microsoft/azure/management/datamigration/v2018_07_15_preview/implementation/CommandPropertiesInner.java:[30,50] cannot find symbol
      [mvn] [ERROR]   symbol: class MongoDbRestartCommand
      [mvn] [ERROR] -> [Help 1]
      [mvn] [ERROR] 
      [mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
      [mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
      [mvn] [ERROR] 
      [mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
      [mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Nov 6, 2020

    azure-resource-manager-schemas - Release

    ️✔️ succeeded [Logs] [Expand Details]
    • ️✔️ Generate from fb06639 with merge commit cddec4b. Schema Automation 13.0.17.20200918.2
      [datamigration][after_scripts|node] configure: WARNING: secure clearing/zeroing of memory is not supported by the selected crypto backend
      [datamigration][after_scripts|node] configure: WARNING: secure clearing/zeroing of memory is not supported by the selected crypto backend
      [datamigration][after_scripts|node] configure: WARNING: secure clearing/zeroing of memory is not supported by the selected crypto backend
    • ️✔️datamigration [View full logs]  [Release Schema Changes]
        [after_scripts|node] PostProcessor finished successfully.
        [after_scripts|node]   5838 passing (1m)
        AzureResourceSchema has no registered package commands.

      @openapi-sdkautomation
      Copy link

      openapi-sdkautomation bot commented Nov 6, 2020

      azure-sdk-for-js - Release

      ️✔️ succeeded [Logs] [Expand Details]
      • ️✔️ Generate from fb06639 with merge commit cddec4b. SDK Automation 13.0.17.20200918.2
      • ️✔️@azure/arm-datamigration [View full logs]  [Release SDK Changes]
        Only show 100 items here, please refer to log for details.
        [npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
        [npmPack] npm WARN deprecated resolve-url@0.2.1: https://github.com/lydell/resolve-url#deprecated
        [npmPack] npm WARN deprecated urix@0.1.0: Please see https://github.com/lydell/urix#deprecated
        [npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
        [npmPack] loaded rollup.config.js with warnings
        [npmPack] (!) Unused external imports
        [npmPack] default imported from external module 'rollup' but never used
        [npmPack] 
        [npmPack] ./esm/dataMigrationServiceClient.js → ./dist/arm-datamigration.js...
        [npmPack] created ./dist/arm-datamigration.js in 810ms
        [npmPack] npm notice 
        [npmPack] npm notice package: @azure/arm-datamigration@2.0.0
        [npmPack] npm notice === Tarball Contents === 
        [npmPack] npm notice 565.2kB dist/arm-datamigration.js                     
        [npmPack] npm notice 228.7kB dist/arm-datamigration.min.js                 
        [npmPack] npm notice 1.9kB   esm/dataMigrationServiceClient.js             
        [npmPack] npm notice 2.5kB   esm/dataMigrationServiceClientContext.js      
        [npmPack] npm notice 9.7kB   esm/operations/files.js                       
        [npmPack] npm notice 8.3kB   esm/models/filesMappers.js                    
        [npmPack] npm notice 263B    esm/models/index.js                           
        [npmPack] npm notice 492B    esm/operations/index.js                       
        [npmPack] npm notice 334.9kB esm/models/mappers.js                         
        [npmPack] npm notice 2.2kB   esm/operations/operations.js                  
        [npmPack] npm notice 414B    esm/models/operationsMappers.js               
        [npmPack] npm notice 2.9kB   esm/models/parameters.js                      
        [npmPack] npm notice 7.1kB   esm/operations/projects.js                    
        [npmPack] npm notice 8.3kB   esm/models/projectsMappers.js                 
        [npmPack] npm notice 2.4kB   esm/operations/resourceSkus.js                
        [npmPack] npm notice 473B    esm/models/resourceSkusMappers.js             
        [npmPack] npm notice 916B    rollup.config.js                              
        [npmPack] npm notice 22.4kB  esm/operations/services.js                    
        [npmPack] npm notice 8.5kB   esm/models/servicesMappers.js                 
        [npmPack] npm notice 8.2kB   esm/operations/serviceTasks.js                
        [npmPack] npm notice 8.3kB   esm/models/serviceTasksMappers.js             
        [npmPack] npm notice 10.0kB  esm/operations/tasks.js                       
        [npmPack] npm notice 8.3kB   esm/models/tasksMappers.js                    
        [npmPack] npm notice 2.3kB   esm/operations/usages.js                      
        [npmPack] npm notice 374B    esm/models/usagesMappers.js                   
        [npmPack] npm notice 1.7kB   package.json                                  
        [npmPack] npm notice 457B    tsconfig.json                                 
        [npmPack] npm notice 1.0MB   dist/arm-datamigration.js.map                 
        [npmPack] npm notice 146.1kB dist/arm-datamigration.min.js.map             
        [npmPack] npm notice 878B    esm/dataMigrationServiceClient.d.ts.map       
        [npmPack] npm notice 1.2kB   esm/dataMigrationServiceClient.js.map         
        [npmPack] npm notice 518B    esm/dataMigrationServiceClientContext.d.ts.map
        [npmPack] npm notice 1.4kB   esm/dataMigrationServiceClientContext.js.map  
        [npmPack] npm notice 4.7kB   esm/operations/files.d.ts.map                 
        [npmPack] npm notice 6.0kB   esm/operations/files.js.map                   
        [npmPack] npm notice 3.0kB   esm/models/filesMappers.d.ts.map              
        [npmPack] npm notice 3.0kB   esm/models/filesMappers.js.map                
        [npmPack] npm notice 96.4kB  esm/models/index.d.ts.map                     
        [npmPack] npm notice 288B    esm/operations/index.d.ts.map                 
        [npmPack] npm notice 126B    esm/models/index.js.map                       
        [npmPack] npm notice 302B    esm/operations/index.js.map                   
        [npmPack] npm notice 13.4kB  esm/models/mappers.d.ts.map                   
        [npmPack] npm notice 177.2kB esm/models/mappers.js.map                     
        [npmPack] npm notice 1.0kB   esm/operations/operations.d.ts.map            
        [npmPack] npm notice 1.4kB   esm/operations/operations.js.map              
        [npmPack] npm notice 238B    esm/models/operationsMappers.d.ts.map         
        [npmPack] npm notice 251B    esm/models/operationsMappers.js.map           
        [npmPack] npm notice 774B    esm/models/parameters.d.ts.map                
        [npmPack] npm notice 2.3kB   esm/models/parameters.js.map                  
        [npmPack] npm notice 3.3kB   esm/operations/projects.d.ts.map              
        [npmPack] npm notice 4.4kB   esm/operations/projects.js.map                
        [npmPack] npm notice 3.0kB   esm/models/projectsMappers.d.ts.map           
        [npmPack] npm notice 3.0kB   esm/models/projectsMappers.js.map             
        [npmPack] npm notice 1.0kB   esm/operations/resourceSkus.d.ts.map          
        [npmPack] npm notice 1.5kB   esm/operations/resourceSkus.js.map            
        [npmPack] npm notice 278B    esm/models/resourceSkusMappers.d.ts.map       
        [npmPack] npm notice 291B    esm/models/resourceSkusMappers.js.map         
        [npmPack] npm notice 6.1kB   esm/operations/services.d.ts.map              
        [npmPack] npm notice 10.7kB  esm/operations/services.js.map                
        [npmPack] npm notice 3.1kB   esm/models/servicesMappers.d.ts.map           
        [npmPack] npm notice 3.1kB   esm/models/servicesMappers.js.map             
        [npmPack] npm notice 3.8kB   esm/operations/serviceTasks.d.ts.map          
        [npmPack] npm notice 5.1kB   esm/operations/serviceTasks.js.map            
        [npmPack] npm notice 3.0kB   esm/models/serviceTasksMappers.d.ts.map       
        [npmPack] npm notice 3.1kB   esm/models/serviceTasksMappers.js.map         
        [npmPack] npm notice 4.8kB   esm/operations/tasks.d.ts.map                 
        [npmPack] npm notice 6.2kB   esm/operations/tasks.js.map                   
        [npmPack] npm notice 3.0kB   esm/models/tasksMappers.d.ts.map              
        [npmPack] npm notice 3.0kB   esm/models/tasksMappers.js.map                
        [npmPack] npm notice 1.1kB   esm/operations/usages.d.ts.map                
        [npmPack] npm notice 1.5kB   esm/operations/usages.js.map                  
        [npmPack] npm notice 221B    esm/models/usagesMappers.d.ts.map             
        [npmPack] npm notice 234B    esm/models/usagesMappers.js.map               
        [npmPack] npm notice 3.3kB   README.md                                     
        [npmPack] npm notice 1.3kB   esm/dataMigrationServiceClient.d.ts           
        [npmPack] npm notice 2.0kB   src/dataMigrationServiceClient.ts             
        [npmPack] npm notice 818B    esm/dataMigrationServiceClientContext.d.ts    
        [npmPack] npm notice 2.2kB   src/dataMigrationServiceClientContext.ts      
        [npmPack] npm notice 12.2kB  esm/operations/files.d.ts                     
        [npmPack] npm notice 21.5kB  src/operations/files.ts                       
        [npmPack] npm notice 8.1kB   esm/models/filesMappers.d.ts                  
        [npmPack] npm notice 8.8kB   src/models/filesMappers.ts                    
        [npmPack] npm notice 305.2kB esm/models/index.d.ts                         
        [npmPack] npm notice 261B    esm/operations/index.d.ts                     
        [npmPack] npm notice 290.1kB src/models/index.ts                           
        [npmPack] npm notice 460B    src/operations/index.ts                       
        [npmPack] npm notice 29.7kB  esm/models/mappers.d.ts                       

      @openapi-sdkautomation
      Copy link

      openapi-sdkautomation bot commented Nov 6, 2020

      azure-sdk-for-net - Release

      ️✔️ succeeded [Logs] [Expand Details]

      @openapi-sdkautomation
      Copy link

      openapi-sdkautomation bot commented Nov 6, 2020

      Trenton Generation - Release

      No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

      @openapi-workflow-bot
      Copy link

      Hi @zouxinghao, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
      Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
      If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ma/swaggerfeedback.

      @hitenjava hitenjava requested a review from binuj November 6, 2020 22:58
      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @openapi-sdkautomation
      Copy link

      openapi-sdkautomation bot commented Nov 6, 2020

      azure-sdk-for-python-track2 - Release

      No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

      @ruowan ruowan merged commit cddec4b into master Nov 9, 2020
      @openapi-workflow-bot
      Copy link

      Hi, @zouxinghao Thanks for your PR. I am workflow bot for review process. Here are some small tips.

    • Please ensure to do self-check against checklists in first PR comment.
    • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
    • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

      giromm2ms pushed a commit to giromm2ms/azure-rest-api-specs that referenced this pull request Dec 20, 2020
      * expose nic in dms skd
      
      * remove require for nic
      
      Co-authored-by: Xinghao Zou <xizo@microsoft.com>
      @JackTn JackTn deleted the xizo/dev/dms_sdk_nic branch August 9, 2021 10:17
      Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
      Labels
      None yet
      Projects
      None yet
      Development

      Successfully merging this pull request may close these issues.

      3 participants