-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DNS API's to AVS 2020-07-17-preview #11876
Conversation
Swagger Validation Report
|
Rule | Message |
---|---|
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: Microsoft.AVS/preview/2020-07-17-preview/vmware.json#L2662:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: Microsoft.AVS/preview/2020-07-17-preview/vmware.json#L2707:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: Microsoft.AVS/preview/2020-07-17-preview/vmware.json#L2914:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: Microsoft.AVS/preview/2020-07-17-preview/vmware.json#L2959:5 |
️⚠️
LintDiff: 8 Warnings warning [Detail]
- Linted configuring files (Based on source branch, openapi-validator v1.5.0 , classic-openapi-validator v1.1.4 )
- Linted configuring files (Based on target branch, openapi-validator v1.5.0 , classic-openapi-validator v1.1.4 )
Rule | Message |
---|---|
The response of operation:'WorkloadNetworks_ListDnsServices' is defined without 'systemData'. Consider adding the systemData to the response. New: Microsoft.AVS/preview/2020-07-17-preview/vmware.json#L2663 |
|
The response of operation:'WorkloadNetworks_GetDnsService' is defined without 'systemData'. Consider adding the systemData to the response. New: Microsoft.AVS/preview/2020-07-17-preview/vmware.json#L2708 |
|
The response of operation:'WorkloadNetworks_CreateDnsService' is defined without 'systemData'. Consider adding the systemData to the response. New: Microsoft.AVS/preview/2020-07-17-preview/vmware.json#L2751 |
|
The response of operation:'WorkloadNetworks_UpdateDnsService' is defined without 'systemData'. Consider adding the systemData to the response. New: Microsoft.AVS/preview/2020-07-17-preview/vmware.json#L2810 |
|
The response of operation:'WorkloadNetworks_ListDnsZones' is defined without 'systemData'. Consider adding the systemData to the response. New: Microsoft.AVS/preview/2020-07-17-preview/vmware.json#L2915 |
|
The response of operation:'WorkloadNetworks_GetDnsZone' is defined without 'systemData'. Consider adding the systemData to the response. New: Microsoft.AVS/preview/2020-07-17-preview/vmware.json#L2960 |
|
The response of operation:'WorkloadNetworks_CreateDnsZone' is defined without 'systemData'. Consider adding the systemData to the response. New: Microsoft.AVS/preview/2020-07-17-preview/vmware.json#L3003 |
|
The response of operation:'WorkloadNetworks_UpdateDnsZone' is defined without 'systemData'. Consider adding the systemData to the response. New: Microsoft.AVS/preview/2020-07-17-preview/vmware.json#L3062 |
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
There are no breaking changes.
Swagger Generation Artifacts
|
NewApiVersionRequired reason: |
A new API version is not required because this is only for Azure public cloud and there are no client libraries for it. For the same reasons, it is also not a breaking change. I will be reviewing this with the breaking change board review on Monday, December 7th with work item https://msazure.visualstudio.com/One/_workitems/edit/8893405. |
Hi @leni-msft, please merge. The breaking change has been approved. |
@ArcturusZhang Pls help check the go sdk error |
Co-authored-by: Rebekah Hess <rebekahess253@gmail.com>
This adds DNS APIs to a preview version. It was developed and reviewed privately at https://github.com/Azure/azure-rest-api-specs-pr/pull/2408 before this. We are not building SDKs for this preview version. This preview API is only in Azure public cloud.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.