Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove AVS 2019-08-09-preview #12041

Merged
merged 1 commit into from
Dec 18, 2020

Conversation

ctaggart
Copy link
Contributor

@ctaggart ctaggart commented Dec 9, 2020

This removes the AVS 2019-08-09-preview API. It was removed from ARM a few days ago:
https://armmanifest.visualstudio.com/One/_git/Manifest/pullrequest/2608?_a=overview


MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@ctaggart ctaggart requested a review from lirenhe as a code owner December 9, 2020 23:17
@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Dec 9, 2020

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️LintDiff succeeded [Detail] [Expand]
Validation passes for LintDiff.
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
There are no breaking changes.
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Dec 9, 2020

Swagger Generation Artifacts

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs]Release - Generate from 9c40bc3. SDK Automation 14.0.0
    warn	Skip initScript due to not configured
    command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/vmware/resource-manager/readme.md
  • ️✔️@azure/arm-avs [View full logs]  [Release SDK Changes]
    cmderr	[npmPack] loaded rollup.config.js with warnings
    cmderr	[npmPack] (!) Unused external imports
    cmderr	[npmPack] default imported from external module 'rollup' but never used
    cmderr	[npmPack] ./esm/avsClient.js → ./dist/arm-avs.js...
    cmderr	[npmPack] created ./dist/arm-avs.js in 540ms
️️✔️ azure-sdk-for-python succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs]Release - Generate from 9c40bc3. SDK Automation 14.0.0
    warn	Skip initScript due to not configured
    command	npx n 12
    command	python3 -m venv venv
    command	pip install --upgrade setuptools wheel pip
    command	pip install pathlib jinja2 msrestazure
    command	autorest --version=V2 --use=@microsoft.azure/autorest.python@~4.0.71 --python --python-mode=update --multiapi --keep-version-file --no-async --python-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-python/sdk ../azure-rest-api-specs/specification/vmware/resource-manager/readme.md
  • ️✔️azure-mgmt-avs [View full logs]  [Release SDK Changes] Breaking Change Detected
    cmderr	[buildConf] INFO:packaging_tools:Building template azure-mgmt-avs
    cmderr	[buildConf] INFO:packaging_tools.conf:Skipping default conf since the file exists
    cmderr	[buildConf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
    cmderr	[buildConf] INFO:packaging_tools:Template done azure-mgmt-avs
    cmderr	[buildPackage] warning: no files found matching '*.py' under directory 'tests'
    cmderr	[buildPackage] warning: no files found matching '*.yaml' under directory 'tests'
    cmderr	[buildPackage] warning: no files found matching '*.py' under directory 'tests'
    cmderr	[buildPackage] warning: no files found matching '*.yaml' under directory 'tests'
    cmderr	[changelogSetup] WARNING: Skipping azure-nspkg as it is not installed.
    cmderr	[changelogReport] INFO:__main__:Looking for Autorest generated package in azure.mgmt.avs
    cmderr	[changelogReport] INFO:__main__:Found azure.mgmt.avs
    cmderr	[changelogReport] INFO:__main__:Working on azure.mgmt.avs
    cmderr	[changelogReport] INFO:__main__:Report written to sdk/compute/azure-mgmt-avs/code_reports/latest/report.json
    cmderr	[changelogReportLatest] INFO:__main__:Download versions of azure-mgmt-avs on PyPI
    cmderr	[changelogReportLatest] INFO:__main__:Got ['0.1.0', '1.0.0rc1', '1.0.0']
    cmderr	[changelogReportLatest] INFO:__main__:Only keep last PyPI version
    cmderr	[changelogReportLatest] INFO:__main__:Installing version 1.0.0 of azure-mgmt-avs in a venv
    cmderr	[changelogReportLatest] Cache entry deserialization failed, entry ignored
    cmderr	[changelogReportLatest] INFO:__main__:Looking for Autorest generated package in azure.mgmt.avs
    cmderr	[changelogReportLatest] INFO:__main__:Found azure.mgmt.avs
    cmderr	[changelogReportLatest] INFO:__main__:Working on azure.mgmt.avs
    cmderr	[changelogReportLatest] INFO:__main__:Report written to sdk/compute/azure-mgmt-avs/code_reports/1.0.0/report.json
    cmdout	[Changelog] Size of delta 59.840% size of original (original: 52731 chars, delta: 31554 chars)
    cmdout	[Changelog] **Features**
    cmdout	[Changelog]   - Model PrivateCloudUpdate has a new parameter nsxt_password
    cmdout	[Changelog]   - Model PrivateCloudUpdate has a new parameter vcenter_password
    cmdout	[Changelog]   - Added operation group WorkloadNetworksOperations
    cmdout	[Changelog]   - Added operation group GlobalReachConnectionsOperations
    cmdout	[Changelog] **Breaking changes**
    cmdout	[Changelog]   - Operation ClustersOperations.create_or_update has a new signature
    cmdout	[Changelog]   - Operation ClustersOperations.create_or_update has a new signature
    cmdout	[Changelog]   - Operation HcxEnterpriseSitesOperations.create_or_update has a new signature
    cmdout	[Changelog]   - Operation AuthorizationsOperations.create_or_update has a new signature
    warn	Breaking change found in changelog
️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs]Release - Generate from 9c40bc3. SDK Automation 14.0.0
    warn	Skip initScript due to not configured
    command	sudo apt-get install -y dotnet-sdk-5.0
    command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/vmware/resource-manager/readme.md
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
  • ️✔️Microsoft.Azure.Management.Avs [View full logs]  [Release SDK Changes]
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs]Release - Generate from 9c40bc3. SDK Automation 14.0.0
    command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
    command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️preview/avs/mgmt/2020-07-17-preview/avs [View full logs]  [Release SDK Changes]
    Only show 60 items here, please refer to log for details.
    info	[Changelog] 1. WorkloadNetworksClient.CreateDNSZone(context.Context, string, string, string, WorkloadNetworkDNSZone) (WorkloadNetworksCreateDNSZoneFuture, error)
    info	[Changelog] 1. WorkloadNetworksClient.CreateDNSZonePreparer(context.Context, string, string, string, WorkloadNetworkDNSZone) (*http.Request, error)
    info	[Changelog] 1. WorkloadNetworksClient.CreateDNSZoneResponder(*http.Response) (WorkloadNetworkDNSZone, error)
    info	[Changelog] 1. WorkloadNetworksClient.CreateDNSZoneSender(*http.Request) (WorkloadNetworksCreateDNSZoneFuture, error)
    info	[Changelog] 1. WorkloadNetworksClient.DeleteDNSService(context.Context, string, string, string) (WorkloadNetworksDeleteDNSServiceFuture, error)
    info	[Changelog] 1. WorkloadNetworksClient.DeleteDNSServicePreparer(context.Context, string, string, string) (*http.Request, error)
    info	[Changelog] 1. WorkloadNetworksClient.DeleteDNSServiceResponder(*http.Response) (autorest.Response, error)
    info	[Changelog] 1. WorkloadNetworksClient.DeleteDNSServiceSender(*http.Request) (WorkloadNetworksDeleteDNSServiceFuture, error)
    info	[Changelog] 1. WorkloadNetworksClient.DeleteDNSZone(context.Context, string, string, string) (WorkloadNetworksDeleteDNSZoneFuture, error)
    info	[Changelog] 1. WorkloadNetworksClient.DeleteDNSZonePreparer(context.Context, string, string, string) (*http.Request, error)
    info	[Changelog] 1. WorkloadNetworksClient.DeleteDNSZoneResponder(*http.Response) (autorest.Response, error)
    info	[Changelog] 1. WorkloadNetworksClient.DeleteDNSZoneSender(*http.Request) (WorkloadNetworksDeleteDNSZoneFuture, error)
    info	[Changelog] 1. WorkloadNetworksClient.GetDNSService(context.Context, string, string, string) (WorkloadNetworkDNSService, error)
    info	[Changelog] 1. WorkloadNetworksClient.GetDNSServicePreparer(context.Context, string, string, string) (*http.Request, error)
    info	[Changelog] 1. WorkloadNetworksClient.GetDNSServiceResponder(*http.Response) (WorkloadNetworkDNSService, error)
    info	[Changelog] 1. WorkloadNetworksClient.GetDNSServiceSender(*http.Request) (*http.Response, error)
    info	[Changelog] 1. WorkloadNetworksClient.GetDNSZone(context.Context, string, string, string) (WorkloadNetworkDNSZone, error)
    info	[Changelog] 1. WorkloadNetworksClient.GetDNSZonePreparer(context.Context, string, string, string) (*http.Request, error)
    info	[Changelog] 1. WorkloadNetworksClient.GetDNSZoneResponder(*http.Response) (WorkloadNetworkDNSZone, error)
    info	[Changelog] 1. WorkloadNetworksClient.GetDNSZoneSender(*http.Request) (*http.Response, error)
    info	[Changelog] 1. WorkloadNetworksClient.ListDNSServices(context.Context, string, string) (WorkloadNetworkDNSServicesListPage, error)
    info	[Changelog] 1. WorkloadNetworksClient.ListDNSServicesComplete(context.Context, string, string) (WorkloadNetworkDNSServicesListIterator, error)
    info	[Changelog] 1. WorkloadNetworksClient.ListDNSServicesPreparer(context.Context, string, string) (*http.Request, error)
    info	[Changelog] 1. WorkloadNetworksClient.ListDNSServicesResponder(*http.Response) (WorkloadNetworkDNSServicesList, error)
    info	[Changelog] 1. WorkloadNetworksClient.ListDNSServicesSender(*http.Request) (*http.Response, error)
    info	[Changelog] 1. WorkloadNetworksClient.ListDNSZones(context.Context, string, string) (WorkloadNetworkDNSZonesListPage, error)
    info	[Changelog] 1. WorkloadNetworksClient.ListDNSZonesComplete(context.Context, string, string) (WorkloadNetworkDNSZonesListIterator, error)
    info	[Changelog] 1. WorkloadNetworksClient.ListDNSZonesPreparer(context.Context, string, string) (*http.Request, error)
    info	[Changelog] 1. WorkloadNetworksClient.ListDNSZonesResponder(*http.Response) (WorkloadNetworkDNSZonesList, error)
    info	[Changelog] 1. WorkloadNetworksClient.ListDNSZonesSender(*http.Request) (*http.Response, error)
    info	[Changelog] 1. WorkloadNetworksClient.UpdateDNSService(context.Context, string, string, string, WorkloadNetworkDNSService) (WorkloadNetworksUpdateDNSServiceFuture, error)
    info	[Changelog] 1. WorkloadNetworksClient.UpdateDNSServicePreparer(context.Context, string, string, string, WorkloadNetworkDNSService) (*http.Request, error)
    info	[Changelog] 1. WorkloadNetworksClient.UpdateDNSServiceResponder(*http.Response) (WorkloadNetworkDNSService, error)
    info	[Changelog] 1. WorkloadNetworksClient.UpdateDNSServiceSender(*http.Request) (WorkloadNetworksUpdateDNSServiceFuture, error)
    info	[Changelog] 1. WorkloadNetworksClient.UpdateDNSZone(context.Context, string, string, string, WorkloadNetworkDNSZone) (WorkloadNetworksUpdateDNSZoneFuture, error)
    info	[Changelog] 1. WorkloadNetworksClient.UpdateDNSZonePreparer(context.Context, string, string, string, WorkloadNetworkDNSZone) (*http.Request, error)
    info	[Changelog] 1. WorkloadNetworksClient.UpdateDNSZoneResponder(*http.Response) (WorkloadNetworkDNSZone, error)
    info	[Changelog] 1. WorkloadNetworksClient.UpdateDNSZoneSender(*http.Request) (WorkloadNetworksUpdateDNSZoneFuture, error)
    info	[Changelog]
    info	[Changelog] ## Struct Changes
    info	[Changelog]
    info	[Changelog] ### New Structs
    info	[Changelog]
    info	[Changelog] 1. WorkloadNetworkDNSService
    info	[Changelog] 1. WorkloadNetworkDNSServiceProperties
    info	[Changelog] 1. WorkloadNetworkDNSServicesList
    info	[Changelog] 1. WorkloadNetworkDNSServicesListIterator
    info	[Changelog] 1. WorkloadNetworkDNSServicesListPage
    info	[Changelog] 1. WorkloadNetworkDNSZone
    info	[Changelog] 1. WorkloadNetworkDNSZoneProperties
    info	[Changelog] 1. WorkloadNetworkDNSZonesList
    info	[Changelog] 1. WorkloadNetworkDNSZonesListIterator
    info	[Changelog] 1. WorkloadNetworkDNSZonesListPage
    info	[Changelog] 1. WorkloadNetworksCreateDNSServiceFuture
    info	[Changelog] 1. WorkloadNetworksCreateDNSZoneFuture
    info	[Changelog] 1. WorkloadNetworksDeleteDNSServiceFuture
    info	[Changelog] 1. WorkloadNetworksDeleteDNSZoneFuture
    info	[Changelog] 1. WorkloadNetworksUpdateDNSServiceFuture
    info	[Changelog] 1. WorkloadNetworksUpdateDNSZoneFuture
    info	[Changelog]
  • ️✔️avs/mgmt/2020-03-20/avs [View full logs]  [Release SDK Changes]
    info	[Changelog] No exported changes
️❌ azure-sdk-for-java failed [Detail]
  • Failed [Logs]Release - Generate from 9c40bc3. SDK Automation 14.0.0
    command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
    command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
    cmderr	[generate.py] 2020-12-18 05:06:45 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-avs"
    cmderr	[generate.py] 2020-12-18 05:06:45 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
    cmderr	[generate.py] 2020-12-18 05:06:45 INFO autorest --version=3.0.6327 --use=@autorest/java@4.0.6 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/avs/azure-resourcemanager-avs --java.namespace=com.azure.resourcemanager.avs  --package-version=1.0.0-beta.1 --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --pipeline.modelerfour.flatten-payloads=false --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/vmware/resource-manager/readme.md
    cmderr	[generate.py] ERROR (PreCheck/PropertyRedeclaration): Schema 'PrivateCloudProperties' has a property 'vcenterPassword' that is conflicting with a property in the parent schema 'PrivateCloudUpdateProperties' differs more than just description : [enum => '<removed>',x-ms-enum => '<removed>',x-ms-secret => 'true']
    cmderr	[generate.py] ERROR (PreCheck/PropertyRedeclaration): Schema 'PrivateCloudProperties' has a property 'nsxtPassword' that is conflicting with a property in the parent schema 'PrivateCloudUpdateProperties' differs more than just description : [enum => '<removed>',x-ms-enum => '<removed>',x-ms-secret => 'true']
    cmderr	[generate.py] FATAL: Error: 2 errors occured -- cannot continue.
    cmderr	[generate.py]   Error: Plugin prechecker reported failure.
    cmderr	[generate.py] 2020-12-18 05:07:28 ERROR [GENERATE] Autorest fail
    ENOENT: no such file or directory, stat 'azure-sdk-for-java/sdk/avs/azure-resourcemanager-avs/pom.xml'
    Error: ENOENT: no such file or directory, stat 'azure-sdk-for-java/sdk/avs/azure-resourcemanager-avs/pom.xml'
  • ️✔️azure-resourcemanager-avs [View full logs
    error	Fatal error: ENOENT: no such file or directory, stat 'azure-sdk-for-java/sdk/avs/azure-resourcemanager-avs/pom.xml'
    error	The following packages are still pending:
    error		azure-resourcemanager-avs
️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs]Release - Generate from 9c40bc3. Schema Automation 14.0.0
    warn	Skip initScript due to not configured
    command	npx n 12
    command	autorest --use=@autorest/azureresourceschema@3.0.92 --version=3.0.6320 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/vmware/resource-manager/readme.md
  • ️✔️vmware [View full logs]  [Release Schema Changes]
    cmderr	[resource-manager] node-pre-gyp
    cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
    cmderr	[resource-manager] WARN template-schema-validation-tools@1.0.0 No repository field.
    cmderr	[resource-manager] WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@2.1.3 (node_modules/fsevents):
    cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.3: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

@erich-wang
Copy link
Member

@ctaggart , removing APIs are breaking changes, have you gotten approval per Breaking Change Policy

@openapi-workflow-bot
Copy link

Hi @ctaggart, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ma/swaggerfeedback.

@JeffreyRichter JeffreyRichter self-requested a review December 14, 2020 18:05
@JeffreyRichter JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Dec 14, 2020
@ctaggart
Copy link
Contributor Author

@erich-wang, the breaking change for removing this preview API version was approved today.

@akning-ms
Copy link
Contributor

@ctaggart , we may also consider the impact for the SDK released previously which is based on this API version. do yo have the data for the SDK version which is using this API version?

@akning-ms
Copy link
Contributor

akning-ms commented Dec 16, 2020

based on breaking change policy for preview version, we should have one year announce time to retire it.

@ctaggart
Copy link
Contributor Author

we may also consider the impact for the SDK released previously which is based on this API version. do yo have the data for the SDK version which is using this API version?

The current versions of all SDKs are using the 2020-03-20 GA API. The 2019-08-09-preview was not being used and can no longer be used.

based on breaking change policy for preview version, we should have one year announce time to retire it.

The breaking change policy for retirement of previews is 90 days. This process was followed and approved.
https://dev.azure.com/msazure/AzureWiki/_wiki/wikis/AzureWiki.wiki/37683/Retirement-of-Previews

@erich-wang erich-wang merged commit 9c40bc3 into Azure:master Dec 18, 2020
@erich-wang
Copy link
Member

@ctaggart , I'm closing this PR, please raise request for new version of SDK.

josuhazure pushed a commit to josuhazure/azure-rest-api-specs that referenced this pull request Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 CI-BreakingChange-Python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants