-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/riteshc/swagger correctness mhsm fixes #12209
Feature/riteshc/swagger correctness mhsm fixes #12209
Conversation
Merge Azure/azure-rest-api-specs into riteshchitlangia1/azure-rest-api-specs
Merge Azure/azure-rest-api-specs/master to riteshchitlangia1/azure-rest-api-specs/master
Hi, @riteshchitlangia1 Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
Swagger Validation Report
|
Rule | Message |
---|---|
1011 - AddingResponseCode |
The new version adds a response code '202'. New: Microsoft.KeyVault/preview/2020-04-01-preview/managedHsm.json#L237:11 |
1011 - AddingResponseCode |
The new version adds a response code '204'. New: Microsoft.KeyVault/preview/2020-04-01-preview/managedHsm.json#L240:11 |
1027 - DefaultValueChanged |
The new version has a different default value than the previous one. New: Microsoft.KeyVault/preview/2020-04-01-preview/managedHsm.json#L417:9 Old: Microsoft.KeyVault/preview/2020-04-01-preview/managedHsm.json#L410:9 |
1029 - ReadonlyPropertyChanged |
The read only property has changed from 'false' to 'true'. New: Microsoft.KeyVault/preview/2020-04-01-preview/managedHsm.json#L401:9 Old: Microsoft.KeyVault/preview/2020-04-01-preview/managedHsm.json#L395:9 |
️⚠️
LintDiff: 1 Warnings warning [Detail]
- Linted configuring files (Based on source branch, openapi-validator v1.6.0 , classic-openapi-validator v1.1.5 )
- Linted configuring files (Based on target branch, openapi-validator v1.6.0 , classic-openapi-validator v1.1.5 )
Rule | Message |
---|---|
The operation 'ManagedHsms_Get' returns 202 status code, which indicates a long running operation, please enable 'x-ms-long-running-operation. New: Microsoft.KeyVault/preview/2020-04-01-preview/managedHsm.json#L206 |
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
Swagger Generation Artifacts
|
Hi @riteshchitlangia1, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
Breaking changes : this version is still preview so breaking changes are fine. |
@akning-ms @josefree can you help confirm that this is a |
Hi @riteshchitlangia1, can you provide a link for your ADO work item for S360 and list the item you try to fix. |
Here's the link to S360 work item: https://msazure.visualstudio.com/Swagger%20KPIs/_workitems/edit/8187858 https://portal.azure-devex-tools.com/amekpis/correctness/detail?errorId=CE6F3670-D5E6-48BE-90EB-CE2FF755D4E4 |
I have also submitted request to breaking change review board for approval. |
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.