Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2020-06-01-preview] Update certificate add refreshSecret operation #12226

Merged
merged 4 commits into from
Jan 7, 2021
Merged

[2020-06-01-preview] Update certificate add refreshSecret operation #12226

merged 4 commits into from
Jan 7, 2021

Conversation

KacieKK
Copy link
Member

@KacieKK KacieKK commented Dec 24, 2020 •
edited
Loading

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service

  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @KacieKK Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Dec 24, 2020 •
    edited
    Loading

    Swagger Validation Report

    ️❌BreakingChange: 1 Errors, 0 Warnings failed [Detail]

    Rule Message
    ❌ 1038 - AddedPath The new version is adding a path that was not found in the old version.
    New: Microsoft.ApiManagement/preview/2020-06-01-preview/apimcertificates.json#L322:5
    ️️✔️LintDiff succeeded [Detail] [Expand] 
    Validation passes for LintDiff.

    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand] 
    There are no breaking changes.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Dec 24, 2020 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand] 
     Please click here to preview with your @microsoft account.
    ️❌ azure-sdk-for-net failed [Detail]
    • ❌Failed [Logs] Generate from ec2a6762da5c3bdec3f401c70baf4dad2a0ee87d. SDK Automation 14.0.0 
      warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/apimanagement/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'GetEntityStateByOperation' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'GetEntityStateByApi' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'GetEntityStateByProduct' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'GetEntityState' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'CheckEntityExists' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'CheckEntityExists' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
    • ❌Microsoft.Azure.Management.ApiManagement [View full logs]  [Preview SDK Changes] 
      cmdout	[msbuild] /home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/ManagementApiTests/ApiDiagnosticTests.cs(62,101): error CS1503: Argument 2: cannot convert from 'System.Collections.Generic.Dictionary<string, string>' to 'string' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/Microsoft.Azure.Management.ApiManagement.Tests.csproj]
cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/ManagementApiTests/DiagnosticTests.cs(48,101): error CS1503: Argument 2: cannot convert from 'System.Collections.Generic.Dictionary<string, string>' to 'string' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/Microsoft.Azure.Management.ApiManagement.Tests.csproj]
cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/ManagementApiTests/LoggerTests.cs(78,95): error CS1503: Argument 2: cannot convert from 'System.Collections.Generic.Dictionary<string, string>' to 'string' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/Microsoft.Azure.Management.ApiManagement.Tests.csproj]
cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/ManagementApiTests/GatewayTests.cs(178,21): error CS1929: 'IGatewayHostnameConfigurationOperations' does not contain a definition for 'Delete' and the best extension method overload 'ApiOperationsExtensions.Delete(IApiOperations, string, string, string, string, bool?)' requires a receiver of type 'IApiOperations' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/Microsoft.Azure.Management.ApiManagement.Tests.csproj]
cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/ManagementApiTests/GatewayTests.cs(210,25): error CS1929: 'IGatewayHostnameConfigurationOperations' does not contain a definition for 'Delete' and the best extension method overload 'ApiOperationsExtensions.Delete(IApiOperations, string, string, string, string, bool?)' requires a receiver of type 'IApiOperations' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/Microsoft.Azure.Management.ApiManagement.Tests.csproj]
cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/ManagementApiTests/LoggerTests.cs(203,101): error CS1503: Argument 2: cannot convert from 'System.Collections.Generic.Dictionary<string, string>' to 'string' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/Microsoft.Azure.Management.ApiManagement.Tests.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/ManagementApiTests/ApiDiagnosticTests.cs(62,101): error CS1503: Argument 2: cannot convert from 'System.Collections.Generic.Dictionary<string, string>' to 'string' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/Microsoft.Azure.Management.ApiManagement.Tests.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/ManagementApiTests/DiagnosticTests.cs(48,101): error CS1503: Argument 2: cannot convert from 'System.Collections.Generic.Dictionary<string, string>' to 'string' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/Microsoft.Azure.Management.ApiManagement.Tests.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/ManagementApiTests/LoggerTests.cs(78,95): error CS1503: Argument 2: cannot convert from 'System.Collections.Generic.Dictionary<string, string>' to 'string' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/Microsoft.Azure.Management.ApiManagement.Tests.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/ManagementApiTests/GatewayTests.cs(178,21): error CS1929: 'IGatewayHostnameConfigurationOperations' does not contain a definition for 'Delete' and the best extension method overload 'ApiOperationsExtensions.Delete(IApiOperations, string, string, string, string, bool?)' requires a receiver of type 'IApiOperations' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/Microsoft.Azure.Management.ApiManagement.Tests.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/ManagementApiTests/GatewayTests.cs(210,25): error CS1929: 'IGatewayHostnameConfigurationOperations' does not contain a definition for 'Delete' and the best extension method overload 'ApiOperationsExtensions.Delete(IApiOperations, string, string, string, string, bool?)' requires a receiver of type 'IApiOperations' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/Microsoft.Azure.Management.ApiManagement.Tests.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/ManagementApiTests/LoggerTests.cs(203,101): error CS1503: Argument 2: cannot convert from 'System.Collections.Generic.Dictionary<string, string>' to 'string' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/tests/Microsoft.Azure.Management.ApiManagement.Tests.csproj]
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: dotnet
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from ec2a6762da5c3bdec3f401c70baf4dad2a0ee87d. SDK Automation 14.0.0 
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️preview/apimanagement/mgmt/2019-12-01-preview/apimanagement [View full logs]  [Preview SDK Changes] Breaking Change Detected
      Only show 15 items here, please refer to log for details.
      info	[Changelog] - New anonymous field `azure.FutureAPI` in struct `ServiceCreateOrUpdateFuture`
info	[Changelog] - New field `Result` in struct `ServiceCreateOrUpdateFuture`
info	[Changelog] - New anonymous field `azure.FutureAPI` in struct `ServiceDeleteFuture`
info	[Changelog] - New field `Result` in struct `ServiceDeleteFuture`
info	[Changelog] - New anonymous field `azure.FutureAPI` in struct `TenantConfigurationDeployFuture`
info	[Changelog] - New field `Result` in struct `TenantConfigurationDeployFuture`
info	[Changelog] - New anonymous field `azure.FutureAPI` in struct `NamedValueUpdateFuture`
info	[Changelog] - New field `Result` in struct `NamedValueUpdateFuture`
info	[Changelog] - New anonymous field `azure.FutureAPI` in struct `TenantConfigurationSaveFuture`
info	[Changelog] - New field `Result` in struct `TenantConfigurationSaveFuture`
info	[Changelog] - New anonymous field `azure.FutureAPI` in struct `APISchemaCreateOrUpdateFuture`
info	[Changelog] - New field `Result` in struct `APISchemaCreateOrUpdateFuture`
info	[Changelog]
info	[Changelog] Total 26 breaking change(s), 13 additive change(s).
info	[Changelog]
    • ️✔️apimanagement/mgmt/2019-12-01/apimanagement [View full logs]  [Preview SDK Changes] Breaking Change Detected
      Only show 15 items here, please refer to log for details.
      info	[Changelog] - New anonymous field `azure.FutureAPI` in struct `NamedValueUpdateFuture`
info	[Changelog] - New field `Result` in struct `NamedValueUpdateFuture`
info	[Changelog] - New anonymous field `azure.FutureAPI` in struct `ServiceRestoreFuture`
info	[Changelog] - New field `Result` in struct `ServiceRestoreFuture`
info	[Changelog] - New anonymous field `azure.FutureAPI` in struct `ServiceCreateOrUpdateFuture`
info	[Changelog] - New field `Result` in struct `ServiceCreateOrUpdateFuture`
info	[Changelog] - New anonymous field `azure.FutureAPI` in struct `APISchemaCreateOrUpdateFuture`
info	[Changelog] - New field `Result` in struct `APISchemaCreateOrUpdateFuture`
info	[Changelog] - New anonymous field `azure.FutureAPI` in struct `TenantConfigurationSaveFuture`
info	[Changelog] - New field `Result` in struct `TenantConfigurationSaveFuture`
info	[Changelog] - New anonymous field `azure.FutureAPI` in struct `TenantConfigurationValidateFuture`
info	[Changelog] - New field `Result` in struct `TenantConfigurationValidateFuture`
info	[Changelog]
info	[Changelog] Total 118 breaking change(s), 13 additive change(s).
info	[Changelog]
    • ️✔️apimanagement/mgmt/2019-01-01/apimanagement [View full logs]  [Preview SDK Changes] Breaking Change Detected
      Only show 15 items here, please refer to log for details.
      info	[Changelog] - New anonymous field `azure.FutureAPI` in struct `ServiceBackupFuture`
info	[Changelog] - New field `Result` in struct `ServiceBackupFuture`
info	[Changelog] - New anonymous field `azure.FutureAPI` in struct `ServiceUpdateFuture`
info	[Changelog] - New field `Result` in struct `ServiceUpdateFuture`
info	[Changelog] - New anonymous field `azure.FutureAPI` in struct `ServiceCreateOrUpdateFuture`
info	[Changelog] - New field `Result` in struct `ServiceCreateOrUpdateFuture`
info	[Changelog] - New anonymous field `azure.FutureAPI` in struct `TenantConfigurationSaveFuture`
info	[Changelog] - New field `Result` in struct `TenantConfigurationSaveFuture`
info	[Changelog] - New anonymous field `azure.FutureAPI` in struct `ServiceDeleteFuture`
info	[Changelog] - New field `Result` in struct `ServiceDeleteFuture`
info	[Changelog] - New anonymous field `azure.FutureAPI` in struct `TenantConfigurationValidateFuture`
info	[Changelog] - New field `Result` in struct `TenantConfigurationValidateFuture`
info	[Changelog]
info	[Changelog] Total 20 breaking change(s), 10 additive change(s).
info	[Changelog]
    • ️✔️preview/apimanagement/mgmt/2018-06-01-preview/apimanagement [View full logs]  [Preview SDK Changes] Breaking Change Detected
      Only show 15 items here, please refer to log for details.
      info	[Changelog] - New anonymous field `azure.FutureAPI` in struct `ServiceRestoreFuture`
info	[Changelog] - New field `Result` in struct `ServiceRestoreFuture`
info	[Changelog] - New anonymous field `azure.FutureAPI` in struct `TenantConfigurationValidateFuture`
info	[Changelog] - New field `Result` in struct `TenantConfigurationValidateFuture`
info	[Changelog] - New anonymous field `azure.FutureAPI` in struct `ServiceDeleteFuture`
info	[Changelog] - New field `Result` in struct `ServiceDeleteFuture`
info	[Changelog] - New anonymous field `azure.FutureAPI` in struct `ServiceCreateOrUpdateFuture`
info	[Changelog] - New field `Result` in struct `ServiceCreateOrUpdateFuture`
info	[Changelog] - New anonymous field `azure.FutureAPI` in struct `APICreateOrUpdateFuture`
info	[Changelog] - New field `Result` in struct `APICreateOrUpdateFuture`
info	[Changelog] - New anonymous field `azure.FutureAPI` in struct `TenantConfigurationSaveFuture`
info	[Changelog] - New field `Result` in struct `TenantConfigurationSaveFuture`
info	[Changelog]
info	[Changelog] Total 22 breaking change(s), 11 additive change(s).
info	[Changelog]
    • ️✔️apimanagement/mgmt/2018-01-01/apimanagement [View full logs]  [Preview SDK Changes] Breaking Change Detected
      Only show 15 items here, please refer to log for details.
      info	[Changelog] - New anonymous field `azure.FutureAPI` in struct `ServiceCreateOrUpdateFuture`
info	[Changelog] - New field `Result` in struct `ServiceCreateOrUpdateFuture`
info	[Changelog] - New anonymous field `azure.FutureAPI` in struct `ServiceUpdateHostnameFuture`
info	[Changelog] - New field `Result` in struct `ServiceUpdateHostnameFuture`
info	[Changelog] - New anonymous field `azure.FutureAPI` in struct `TenantConfigurationValidateFuture`
info	[Changelog] - New field `Result` in struct `TenantConfigurationValidateFuture`
info	[Changelog] - New anonymous field `azure.FutureAPI` in struct `ServiceBackupFuture`
info	[Changelog] - New field `Result` in struct `ServiceBackupFuture`
info	[Changelog] - New anonymous field `azure.FutureAPI` in struct `ServiceApplyNetworkConfigurationUpdatesFuture`
info	[Changelog] - New field `Result` in struct `ServiceApplyNetworkConfigurationUpdatesFuture`
info	[Changelog] - New anonymous field `azure.FutureAPI` in struct `TenantConfigurationSaveFuture`
info	[Changelog] - New field `Result` in struct `TenantConfigurationSaveFuture`
info	[Changelog]
info	[Changelog] Total 18 breaking change(s), 9 additive change(s).
info	[Changelog]
    • ️✔️apimanagement/mgmt/2017-03-01/apimanagement [View full logs]  [Preview SDK Changes] Breaking Change Detected
      Only show 15 items here, please refer to log for details.
      info	[Changelog] - New anonymous field `azure.FutureAPI` in struct `ServiceUpdateHostnameFuture`
info	[Changelog] - New field `Result` in struct `ServiceUpdateHostnameFuture`
info	[Changelog] - New anonymous field `azure.FutureAPI` in struct `ServiceRestoreFuture`
info	[Changelog] - New field `Result` in struct `ServiceRestoreFuture`
info	[Changelog] - New anonymous field `azure.FutureAPI` in struct `ServiceUpdateFuture`
info	[Changelog] - New field `Result` in struct `ServiceUpdateFuture`
info	[Changelog] - New anonymous field `azure.FutureAPI` in struct `TenantConfigurationValidateFuture`
info	[Changelog] - New field `Result` in struct `TenantConfigurationValidateFuture`
info	[Changelog] - New anonymous field `azure.FutureAPI` in struct `TenantConfigurationSaveFuture`
info	[Changelog] - New field `Result` in struct `TenantConfigurationSaveFuture`
info	[Changelog] - New anonymous field `azure.FutureAPI` in struct `ServiceCreateOrUpdateFuture`
info	[Changelog] - New field `Result` in struct `ServiceCreateOrUpdateFuture`
info	[Changelog]
info	[Changelog] Total 18 breaking change(s), 9 additive change(s).
info	[Changelog]
    • ️✔️apimanagement/mgmt/2016-10-10/apimanagement [View full logs]  [Preview SDK Changes] Breaking Change Detected
      Only show 15 items here, please refer to log for details.
      info	[Changelog] - New anonymous field `azure.FutureAPI` in struct `ServicesRestoreFuture`
info	[Changelog] - New field `Result` in struct `ServicesRestoreFuture`
info	[Changelog] - New anonymous field `azure.FutureAPI` in struct `ServicesBackupFuture`
info	[Changelog] - New field `Result` in struct `ServicesBackupFuture`
info	[Changelog] - New anonymous field `azure.FutureAPI` in struct `ServicesManageDeploymentsFuture`
info	[Changelog] - New field `Result` in struct `ServicesManageDeploymentsFuture`
info	[Changelog] - New anonymous field `azure.FutureAPI` in struct `ServicesUpdateHostnameFuture`
info	[Changelog] - New field `Result` in struct `ServicesUpdateHostnameFuture`
info	[Changelog] - New anonymous field `azure.FutureAPI` in struct `ServicesUpdateFuture`
info	[Changelog] - New field `Result` in struct `ServicesUpdateFuture`
info	[Changelog] - New anonymous field `azure.FutureAPI` in struct `TenantConfigurationSaveFuture`
info	[Changelog] - New field `Result` in struct `TenantConfigurationSaveFuture`
info	[Changelog]
info	[Changelog] Total 18 breaking change(s), 9 additive change(s).
info	[Changelog]
    • ️✔️apimanagement/mgmt/2016-07-07/apimanagement [View full logs]  [Preview SDK Changes] Breaking Change Detected
      Only show 15 items here, please refer to log for details.
      info	[Changelog] - New anonymous field `azure.FutureAPI` in struct `ServicesUpdateHostnameFuture`
info	[Changelog] - New field `Result` in struct `ServicesUpdateHostnameFuture`
info	[Changelog] - New anonymous field `azure.FutureAPI` in struct `ServicesUpdateFuture`
info	[Changelog] - New field `Result` in struct `ServicesUpdateFuture`
info	[Changelog] - New anonymous field `azure.FutureAPI` in struct `ServicesManageDeploymentsFuture`
info	[Changelog] - New field `Result` in struct `ServicesManageDeploymentsFuture`
info	[Changelog] - New anonymous field `azure.FutureAPI` in struct `TenantConfigurationValidateFuture`
info	[Changelog] - New field `Result` in struct `TenantConfigurationValidateFuture`
info	[Changelog] - New anonymous field `azure.FutureAPI` in struct `ServicesRestoreFuture`
info	[Changelog] - New field `Result` in struct `ServicesRestoreFuture`
info	[Changelog] - New anonymous field `azure.FutureAPI` in struct `TenantConfigurationSaveFuture`
info	[Changelog] - New field `Result` in struct `TenantConfigurationSaveFuture`
info	[Changelog]
info	[Changelog] Total 16 breaking change(s), 8 additive change(s).
info	[Changelog]
    ️️✔️ azure-sdk-for-python succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from ec2a6762da5c3bdec3f401c70baf4dad2a0ee87d. SDK Automation 14.0.0 
      warn	Skip initScript due to not configured
command	npx n 12
command	python3 -m venv venv
command	pip install --upgrade setuptools wheel pip
command	pip install pathlib jinja2 msrestazure
command	autorest --version=V2 --use=@microsoft.azure/autorest.python@~4.0.71 --python --python-mode=update --multiapi --keep-version-file --no-async --python-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-python/sdk ../azure-rest-api-specs/specification/apimanagement/resource-manager/readme.md
cmdout	[Autorest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'get_entity_state_by_operation' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'get_entity_state_by_api' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'get_entity_state_by_product' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'get_entity_state' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'check_entity_exists' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'check_entity_exists' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'get_entity_tag' method missing 404 status code section -- this might be unintentional.
    • ️✔️azure-mgmt-apimanagement [View full logs]  [Preview SDK Changes] Breaking Change Detected
      cmderr	[buildConf] INFO:packaging_tools:Building template azure-mgmt-apimanagement
cmderr	[buildConf] INFO:packaging_tools.conf:Skipping default conf since the file exists
cmderr	[buildConf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
cmderr	[buildConf] INFO:packaging_tools:Template done azure-mgmt-apimanagement
cmderr	[buildPackage] warning: no files found matching '*.py' under directory 'tests'
cmderr	[buildPackage] warning: no files found matching '*.yaml' under directory 'tests'
cmderr	[buildPackage] warning: no files found matching '*.py' under directory 'tests'
cmderr	[buildPackage] warning: no files found matching '*.yaml' under directory 'tests'
cmderr	[changelogSetup] WARNING: Skipping azure-nspkg as it is not installed.
cmderr	[changelogReport] INFO:__main__:Looking for Autorest generated package in azure.mgmt.apimanagement
cmderr	[changelogReport] INFO:__main__:Found azure.mgmt.apimanagement
cmderr	[changelogReport] INFO:__main__:Working on azure.mgmt.apimanagement
cmderr	[changelogReport] INFO:__main__:Report written to sdk/apimanagement/azure-mgmt-apimanagement/code_reports/latest/report.json
cmderr	[changelogReportLatest] INFO:__main__:Download versions of azure-mgmt-apimanagement on PyPI
cmderr	[changelogReportLatest] INFO:__main__:Got ['0.1.0', '0.2.0', '1.0.0b1', '1.0.0']
cmderr	[changelogReportLatest] INFO:__main__:Only keep last PyPI version
cmderr	[changelogReportLatest] INFO:__main__:Installing version 0.2.0 of azure-mgmt-apimanagement in a venv
cmderr	[changelogReportLatest] Cache entry deserialization failed, entry ignored
cmderr	[changelogReportLatest] INFO:__main__:Looking for Autorest generated package in azure.mgmt.apimanagement
cmderr	[changelogReportLatest] INFO:__main__:Found azure.mgmt.apimanagement
cmderr	[changelogReportLatest] INFO:__main__:Working on azure.mgmt.apimanagement
cmderr	[changelogReportLatest] INFO:__main__:Report written to sdk/apimanagement/azure-mgmt-apimanagement/code_reports/0.2.0/report.json
cmdout	[Changelog] Size of delta 6.559% size of original (original: 245141 chars, delta: 16080 chars)
cmdout	[Changelog] **Features**
cmdout	[Changelog]   - Model ApiManagementServiceBaseProperties has a new parameter restore
cmdout	[Changelog]   - Model CertificateContract has a new parameter key_vault
cmdout	[Changelog]   - Model HostnameConfiguration has a new parameter identity_client_id
cmdout	[Changelog]   - Model NamedValueUpdateParameters has a new parameter key_vault
cmdout	[Changelog]   - Model GatewayHostnameConfigurationContract has a new parameter tls10_enabled
cmdout	[Changelog]   - Model GatewayHostnameConfigurationContract has a new parameter tls11_enabled
cmdout	[Changelog]   - Model GatewayHostnameConfigurationContract has a new parameter http2_enabled
cmdout	[Changelog]   - Model ApiManagementServiceResource has a new parameter restore
cmdout	[Changelog]   - Model ApiManagementServiceResource has a new parameter zones
cmdout	[Changelog]   - Model AdditionalLocation has a new parameter zones
cmdout	[Changelog]   - Model NamedValueCreateContract has a new parameter key_vault
cmdout	[Changelog]   - Model NamedValueContract has a new parameter key_vault
cmdout	[Changelog]   - Model CacheUpdateParameters has a new parameter use_from_location
cmdout	[Changelog]   - Model DiagnosticContract has a new parameter operation_name_format
cmdout	[Changelog]   - Model HttpMessageDiagnostic has a new parameter data_masking
cmdout	[Changelog]   - Model ApiManagementServiceUpdateParameters has a new parameter restore
cmdout	[Changelog]   - Added operation CertificateOperations.refresh_secret
cmdout	[Changelog]   - Added operation group ContentTypeOperations
cmdout	[Changelog]   - Added operation group DeletedServicesOperations
cmdout	[Changelog]   - Added operation group ContentTypeContentItemOperations
cmdout	[Changelog] **Breaking changes**
cmdout	[Changelog]   - Operation CertificateOperations.create_or_update has a new signature
cmdout	[Changelog]   - Operation EmailTemplateOperations.update has a new signature
cmdout	[Changelog]   - Operation GatewayHostnameConfigurationOperations.create_or_update has a new signature
cmdout	[Changelog]   - Operation GatewayHostnameConfigurationOperations.delete has a new signature
cmdout	[Changelog]   - Operation SubscriptionOperations.create_or_update has a new signature
cmdout	[Changelog]   - Operation SubscriptionOperations.update has a new signature
cmdout	[Changelog]   - Operation UserConfirmationPasswordOperations.send has a new signature
cmdout	[Changelog]   - Operation UserOperations.delete has a new signature
cmdout	[Changelog]   - Operation LoggerOperations.delete has a new signature
cmdout	[Changelog]   - Operation EmailTemplateOperations.update has a new signature
cmdout	[Changelog]   - Operation CertificateOperations.create_or_update has a new signature
cmdout	[Changelog]   - Operation GatewayApiOperations.list_by_service has a new signature
cmdout	[Changelog]   - Operation GatewayHostnameConfigurationOperations.list_by_service has a new signature
cmdout	[Changelog]   - Operation GatewayOperations.list_by_service has a new signature
cmdout	[Changelog]   - Operation UserOperations.create_or_update has a new signature
cmdout	[Changelog]   - Model ConnectivityStatusContract has a new required parameter is_optional
cmdout	[Changelog]   - Model ConnectivityStatusContract has a new required parameter resource_type
cmdout	[Changelog]   - Model CacheContract has a new required parameter use_from_location
cmdout	[Changelog]   - Model CertificateCreateOrUpdateParameters has a new signature
warn	Breaking change found in changelog
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from ec2a6762da5c3bdec3f401c70baf4dad2a0ee87d. SDK Automation 14.0.0 
      warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/apimanagement/resource-manager/readme.md
cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'getEntityStateByOperation' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'getEntityStateByApi' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'getEntityStateByProduct' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'getEntityState' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'checkEntityExists' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'checkEntityExists' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
cmdout	[Autorest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    • ️✔️@azure/arm-apimanagement [View full logs]  [Preview SDK Changes] 
      cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/apiManagementClient.js → ./dist/arm-apimanagement.js...
cmderr	[npmPack] created ./dist/arm-apimanagement.js in 1.7s
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    NewApiVersionRequired reason:

    A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support.

    EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.

    @openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Dec 24, 2020
    Draft
    This was referenced Dec 24, 2020
    Draft
    Draft
    @openapi-workflow-bot
    Copy link

    Hi @KacieKK, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ma/swaggerfeedback.

    @PhoenixHe-NV
    Copy link
    Contributor

    PhoenixHe-NV commented Dec 25, 2020 •
    edited
    Loading

    @KacieKK You are adding operation to existing version which is considered breaking change. You could go through breaking change review , or add a new api version 2020-06-01-preview.1

    to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes https://aka.ms/Breakingchangetemplate. Addition details on the process and office hours are on the Breaking change Wiki.

    @PhoenixHe-NV PhoenixHe-NV added the Reviewed-ChangesRequested <valid label in PR review process>add this label when assignee request changes after review label Jan 4, 2021
    @JeffreyRichter JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Jan 4, 2021
    solankisamir
    solankisamir approved these changes Jan 6, 2021
    View reviewed changes
    Copy link
    Member

    @solankisamir solankisamir left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    :shipit:

    @PhoenixHe-NV PhoenixHe-NV merged commit 89048bc into Azure:apimanagement-2020-06-01-preview Jan 7, 2021
    @solankisamir
    Copy link
    Member

    @PhoenixHe-msft we actually wanted this commit in the master branch? Since the breaking change is approved and it is signed off once, can we move it to master
    @KacieKK FYI

    @solankisamir solankisamir mentioned this pull request Jan 9, 2021
    Closed
    25 tasks
    @PhoenixHe-NV
    Copy link
    Contributor

    @solankisamir You can send PR from apimanagement-2020-06-01-preview to master

    KacieKK added a commit to KacieKK/azure-rest-api-specs that referenced this pull request Jan 15, 2021
    @KacieKK
    [2020-06-01-preview] Update certificate add refreshSecret operation (A…
    b6741e4 
    …zure#12226)

* add refresh

* add path

* add keyvault part

* address comments

Co-authored-by: Kacie Kang <jikang@microsoft.com>
    @solankisamir solankisamir mentioned this pull request Jan 17, 2021
    Merged
    25 tasks
    weidongxu-microsoft pushed a commit that referenced this pull request Jan 18, 2021
    @KacieKK
    syncing changes from 2020-06-01-preview api (#12462)
    6a63e0b 
    * [2020-06-01-preview] Update namedvalue add refreshSecret operation (#12223)

* add refreshSecret

* addressing comments

* add 202

* address comments

* parenthesis

Co-authored-by: Kacie Kang <jikang@microsoft.com>

* [2020-06-01-preview] Update certificate add refreshSecret operation (#12226)

* add refresh

* add path

* add keyvault part

* address comments

Co-authored-by: Kacie Kang <jikang@microsoft.com>

Co-authored-by: Kacie Kang <jikang@microsoft.com>
    mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021
    @KacieKK @mkarmark
    syncing changes from 2020-06-01-preview api (Azure#12462)
    3c8c66c 
    * [2020-06-01-preview] Update namedvalue add refreshSecret operation (Azure#12223)

* add refreshSecret

* addressing comments

* add 202

* address comments

* parenthesis

Co-authored-by: Kacie Kang <jikang@microsoft.com>

* [2020-06-01-preview] Update certificate add refreshSecret operation (Azure#12226)

* add refresh

* add path

* add keyvault part

* address comments

Co-authored-by: Kacie Kang <jikang@microsoft.com>

Co-authored-by: Kacie Kang <jikang@microsoft.com>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @solankisamir solankisamir solankisamir approved these changes

    @JeffreyRichter JeffreyRichter JeffreyRichter approved these changes

    Assignees

    @PhoenixHe-NV PhoenixHe-NV

    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 CI-BreakingChange-Go CI-BreakingChange-Python Reviewed-ChangesRequested <valid label in PR review process>add this label when assignee request changes after review
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    4 participants
    @KacieKK @PhoenixHe-NV @solankisamir @JeffreyRichter