add app attribute enable end to end tls #12282

sonwan2020 · 2021-01-05T01:44:20Z

Changelog

Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No, no need to refresh for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of “no breaking changes
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable version with Breaking Change Validation errors
Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2021-01-05T01:44:22Z

Hi, @sonwan2020 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

openapi-pipeline-app · 2021-01-05T01:44:24Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️LintDiff succeeded [Detail] [Expand]

Validation passes for LintDiff.

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]

Validation passes for SDKTrack2Validation

️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2021-01-05T01:44:24Z

Swagger Generation Artifacts

️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]

️⚠️ azure-sdk-for-python warning [Detail]

⚠️Warning [Logs]Release - Generate from 7fd1f02. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️azure-mgmt-appplatform [View full logs] [Release SDK Changes]
- azure-mgmt-appplatform-1.1.0.zip
- azure_mgmt_appplatform-1.1.0-py2.py3-none-any.whl
```
info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model AppResourceProperties has a new parameter enable_end_to_end_tls
```

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 7fd1f02. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-02-23 07:07:20 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-appplatform-generated"
cmderr	[generate.py] 2021-02-23 07:07:20 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
cmderr	[generate.py] 2021-02-23 07:07:20 INFO autorest --version=3.0.6369 --use=@autorest/java@4.0.17 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/appplatform/azure-resourcemanager-appplatform-generated --java.namespace=com.azure.resourcemanager.appplatform.generated   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/appplatform/resource-manager/readme.md
cmderr	[generate.py] 2021-02-23 07:08:05 INFO [CI][Success] Write to ci.yml
cmderr	[generate.py] 2021-02-23 07:08:05 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-02-23 07:08:05 INFO [POM][Skip] pom already has module azure-resourcemanager-appplatform-generated
cmderr	[generate.py] 2021-02-23 07:08:05 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-02-23 07:08:05 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-02-23 07:08:05 INFO [POM][Success] Write to root pom
cmderr	[generate.py] 2021-02-23 07:08:40 ERROR [COMPILE] Maven build fail

️✔️azure-resourcemanager-appplatform-generated [View full logs] [Release SDK Changes]

pom.xml

cmderr	[Inst] 2021-02-23 07:09:59 DEBUG Got artifact_id: azure-resourcemanager-appplatform-generated
cmderr	[Inst] 2021-02-23 07:09:59 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-02-23 07:09:59 ERROR Unmatch any jar in artifacts

️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 7fd1f02. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/appplatform/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.AppPlatform [View full logs] [Release SDK Changes]
- Microsoft.Azure.Management.AppPlatform.1.1.0-preview.nupkg
- Microsoft.Azure.Management.AppPlatform.1.1.0-preview.snupkg

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 7fd1f02. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/appplatform/resource-manager/readme.md

️✔️@azure/arm-appplatform [View full logs] [Release SDK Changes]

azure-arm-appplatform-1.1.0.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/appPlatformManagementClient.js → ./dist/arm-appplatform.js...
cmderr	[npmPack] created ./dist/arm-appplatform.js in 599ms

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 7fd1f02. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️appplatform/mgmt/2020-07-01/appplatform [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```

️✔️preview/appplatform/mgmt/2020-11-01-preview/appplatform [View full logs] [Release SDK Changes]

info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New field `EnableEndToEndTLS` in struct `AppResourceProperties`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 1 additive change(s).
info	[Changelog]

️✔️preview/appplatform/mgmt/2019-05-01-preview/appplatform [View full logs] [Release SDK Changes]

info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New const `Deleting`
info	[Changelog] - New const `DeploymentResourceProvisioningStateDeleting`
info	[Changelog] - New field `Sku` in struct `DeploymentResource`
info	[Changelog] - New field `ToBeExportedForShoebox` in struct `MetricDimension`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 4 additive change(s).
info	[Changelog]

️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 7fd1f02. Schema Automation 14.0.0

warn	Skip initScript due to not configured
command	npx n 12
command	autorest --use=@autorest/azureresourceschema@3.0.92 --version=3.0.6374 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/appplatform/resource-manager/readme.md

️✔️appplatform [View full logs] [Release Schema Changes]

cmderr	[resource-manager] node-pre-gyp
cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
cmderr	[resource-manager]  template-schema-validation-tools@1.0.0 No repository field.
cmderr	[resource-manager]  optional SKIPPING OPTIONAL DEPENDENCY: fsevents@2.1.3 (node_modules/fsevents):
cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.3: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

_{Posted by Swagger Pipeline | How to fix these errors?}

raych1 · 2021-01-05T06:06:47Z

@sonwan2020 , could you paste the ADO work item for S360 KPI for reference? You select NO in SDK refresh checklist. Can you explain why it doesn't need to refresh SDK/CLI? Thanks.

openapi-workflow-bot · 2021-01-05T06:08:39Z

Hi @sonwan2020, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

bowen5 · 2021-01-05T06:38:18Z

@sonwan2020 , could you paste the ADO work item for S360 KPI for reference? You select NO in SDK refresh checklist. Can you explain why it doesn't need to refresh SDK/CLI? Thanks.

Here is the ADO https://msazure.visualstudio.com/Swagger%20KPIs/_workitems/edit/8187806

ghost · 2021-01-24T16:00:31Z

Hi, @sonwan2020. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

zmssp · 2021-02-04T02:25:16Z

The change only affect our latest preview version 2020-11-01-preview, I think it should not be a breaking change

openapi-workflow-bot · 2021-02-04T02:26:32Z

In the Window Period to fix mismatches between swagger and service, when PR is labelled with “FixS360”, breaking change can be approved by PR assignee; the Azure Breaking Change Board is no longer required to approve the PR. Please ensure to clarify what s360 action items to be solved, and @ mention PR assignee for awareness. Please check this wiki [Window to Fix Broken]( Window to Fix Broken - Overview (azure.com)) for more details.

Incarnation-p-lee · 2021-02-04T03:28:54Z

...pplatform/resource-manager/Microsoft.AppPlatform/preview/2020-11-01-preview/appplatform.json

@@ -3408,6 +3408,10 @@
          "description": "Indicate if only https is allowed.",
          "type": "boolean"
        },
+        "enableEndToEndTLS": {
+          "description": "Indicate if end to end tls is allowed.",


end to end tls is allowed -> end to end tls is enabled ?

-> end-to-end TLS ?

thanks
new wording: "Indicate if end to end TLS is enabled."

raych1 · 2021-02-05T01:45:57Z

/azp run

azure-pipelines · 2021-02-05T01:46:11Z

Azure Pipelines successfully started running 2 pipeline(s).

00Kai0 · 2021-02-23T07:02:06Z

/azp run

* add new app attribute enableEndToEndTLS in preview versions * revert changes on old version 2019-05-01-preview * wording

sonwan2020 added 2 commits January 4, 2021 20:36

add new app attribute enableEndToEndTLS in preview versions

9dcef66

Merge branch 'master' into sonwan/add-app-attribute-enableEndToEndTLS

84e11e9

openapi-assignment-bot bot assigned raych1 Jan 5, 2021

raych1 added the BreakingChangeReviewRequired label Jan 5, 2021

ghost added the no-recent-activity label Jan 24, 2021

revert changes on old version 2019-05-01-preview

33b0f70

ghost removed the no-recent-activity label Feb 4, 2021

openapi-workflow-bot bot added the FixS360 label Feb 4, 2021

Incarnation-p-lee reviewed Feb 4, 2021

View reviewed changes

wording

2bc7d62

raych1 approved these changes Feb 4, 2021

View reviewed changes

raych1 added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Feb 5, 2021

raych1 merged commit 7fd1f02 into Azure:master Feb 5, 2021

sonwan2020 deleted the sonwan/add-app-attribute-enableEndToEndTLS branch February 5, 2021 02:02

This was referenced Feb 23, 2021

Azure Spring Cloud: add app resource attribute enableEndToEndTLS Azure/azure-sdk-for-net#18939

Merged

move the new attribute enableEndToEndTLS to the end #13179

Merged

mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021

add app attribute enable end to end tls (Azure#12282)

86d4340

* add new app attribute enableEndToEndTLS in preview versions * revert changes on old version 2019-05-01-preview * wording

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add app attribute enable end to end tls #12282

add app attribute enable end to end tls #12282

sonwan2020 commented Jan 5, 2021 •

edited by raych1

Loading

openapi-workflow-bot bot commented Jan 5, 2021

openapi-pipeline-app bot commented Jan 5, 2021 •

edited

Loading

openapi-pipeline-app bot commented Jan 5, 2021 •

edited

Loading

raych1 commented Jan 5, 2021

openapi-workflow-bot bot commented Jan 5, 2021

bowen5 commented Jan 5, 2021

ghost commented Jan 24, 2021

zmssp commented Feb 4, 2021

openapi-workflow-bot bot commented Feb 4, 2021

Incarnation-p-lee Feb 4, 2021

xscript Feb 4, 2021

sonwan2020 Feb 4, 2021

raych1 commented Feb 5, 2021

azure-pipelines bot commented Feb 5, 2021

00Kai0 commented Feb 23, 2021

add app attribute enable end to end tls #12282

add app attribute enable end to end tls #12282

Conversation

sonwan2020 commented Jan 5, 2021 • edited by raych1 Loading

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Jan 5, 2021

openapi-pipeline-app bot commented Jan 5, 2021 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Jan 5, 2021 • edited Loading

Swagger Generation Artifacts

raych1 commented Jan 5, 2021

openapi-workflow-bot bot commented Jan 5, 2021

bowen5 commented Jan 5, 2021

ghost commented Jan 24, 2021

zmssp commented Feb 4, 2021

openapi-workflow-bot bot commented Feb 4, 2021

Incarnation-p-lee Feb 4, 2021

Choose a reason for hiding this comment

xscript Feb 4, 2021

Choose a reason for hiding this comment

sonwan2020 Feb 4, 2021

Choose a reason for hiding this comment

raych1 commented Feb 5, 2021

azure-pipelines bot commented Feb 5, 2021

00Kai0 commented Feb 23, 2021

sonwan2020 commented Jan 5, 2021 •

edited by raych1

Loading

openapi-pipeline-app bot commented Jan 5, 2021 •

edited

Loading

openapi-pipeline-app bot commented Jan 5, 2021 •

edited

Loading