[Datadog] Add api version parameter #12345

limingu · 2021-01-08T23:32:44Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No, no need to refresh for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of “no breaking changes
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable version with Breaking Change Validation errors
Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

fix https://github.com/Azure/azure-rest-api-specs-pr/issues/8974
fix #20705

openapi-workflow-bot · 2021-01-08T23:32:46Z

Hi, @limingu Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

openapi-pipeline-app · 2021-01-08T23:32:48Z

Swagger Validation Report

️❌BreakingChange: 3 Errors, 0 Warnings failed [Detail]

Compared Swaggers (Based on Oad v0.8.5)
- original: preview/2020-02-01-preview/datadog.json <---> new: preview/2020-02-01-preview/datadog.json

Rule	Message
`❌` 1010 - AddingRequiredParameter	The required parameter 'api-version' was added in the new version. New: Microsoft.Datadog/preview/2020-02-01-preview/datadog.json#L39:9
`❌` 1010 - AddingRequiredParameter	The required parameter 'api-version' was added in the new version. New: Microsoft.Datadog/preview/2020-02-01-preview/datadog.json#L84:9
`❌` 1042 - ChangedParameterOrder	The order of parameter 'body' was changed. New: Microsoft.Datadog/preview/2020-02-01-preview/datadog.json#L84:9 Old: Microsoft.Datadog/preview/2020-02-01-preview/datadog.json#L81:9

️⚠️LintDiff: 1 Warnings warning [Detail]

Linted configuring files (Based on source branch, openapi-validator v1.6.0 , classic-openapi-validator v1.1.5 )
- datadog/resource-manager/readme.md tag:package-2020-02-preview
Linted configuring files (Based on target branch, openapi-validator v1.6.0 , classic-openapi-validator v1.1.5 )
- datadog/resource-manager/readme.md tag:package-2020-02-preview

Rule	Message
⚠️ R4000 - ParameterDescriptionRequired	'body' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation. New: Microsoft.Datadog/preview/2020-02-01-preview/datadog.json#L91

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2021-01-08T23:32:49Z

Swagger Generation Artifacts

️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from c658577. Schema Automation 14.0.0

warn	Skip initScript due to not configured
command	npx n 12
command	autorest --use=@autorest/azureresourceschema@3.0.92 --version=3.0.6351 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/datadog/resource-manager/readme.md

️✔️datadog [View full logs] [Release Schema Changes]

cmderr	[resource-manager] node-pre-gyp
cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
cmderr	[resource-manager] WARN template-schema-validation-tools@1.0.0 No repository field.
cmderr	[resource-manager]  optional SKIPPING OPTIONAL DEPENDENCY: fsevents@2.1.3 (node_modules/fsevents):
cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.3: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from c658577. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️preview/datadog/mgmt/2020-02-01-preview/datadog [View full logs] [Release SDK Changes]

info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New function `SingleSignOnProperties.MarshalJSON() ([]byte, error)`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 1 additive change(s).
info	[Changelog]

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from c658577. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/datadog/resource-manager/readme.md

️✔️@azure/arm-datadog [View full logs] [Release SDK Changes]

azure-arm-datadog-1.0.0.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/microsoftDatadogClient.js → ./dist/arm-datadog.js...
cmderr	[npmPack] created ./dist/arm-datadog.js in 345ms

️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from c658577. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/datadog/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.Datadog [View full logs] [Release SDK Changes]
- Microsoft.Azure.Management.Datadog.0.1.0.nupkg
- Microsoft.Azure.Management.Datadog.0.1.0.snupkg

️️✔️ azure-sdk-for-python succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from c658577. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	npx n 12
command	python3 -m venv venv
command	pip install --upgrade setuptools wheel pip
command	pip install pathlib jinja2 msrestazure
command	autorest --version=V2 --use=@microsoft.azure/autorest.python@~4.0.71 --python --python-mode=update --multiapi --keep-version-file --no-async --python-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-python/sdk ../azure-rest-api-specs/specification/datadog/resource-manager/readme.md

️✔️azure-mgmt-datadog [View full logs] [Release SDK Changes] Breaking Change Detected

cmderr	[buildConf] INFO:packaging_tools:Building template azure-mgmt-datadog
cmderr	[buildConf] INFO:packaging_tools.conf:Build default conf for azure-mgmt-datadog
cmderr	[buildConf] INFO:packaging_tools:Template done azure-mgmt-datadog
cmderr	[buildPackage] warning: no files found matching '*.py' under directory 'tests'
cmderr	[buildPackage] warning: no files found matching '*.yaml' under directory 'tests'
cmderr	[buildPackage] warning: no files found matching '*.py' under directory 'tests'
cmderr	[buildPackage] warning: no files found matching '*.yaml' under directory 'tests'
cmderr	[changelogSetup] WARNING: Skipping azure-nspkg as it is not installed.
cmderr	[changelogReport] INFO:__main__:Looking for Autorest generated package in azure.mgmt.datadog
cmderr	[changelogReport] INFO:__main__:Found azure.mgmt.datadog
cmderr	[changelogReport] INFO:__main__:Working on azure.mgmt.datadog
cmderr	[changelogReport] INFO:__main__:Report written to sdk/datadog/azure-mgmt-datadog/code_reports/latest/report.json
cmderr	[changelogReportLatest] INFO:__main__:Download versions of azure-mgmt-datadog on PyPI
cmderr	[changelogReportLatest] INFO:__main__:Got ['1.0.0b1', '1.0.0b2']
cmderr	[changelogReportLatest] INFO:__main__:Only keep last PyPI version
cmderr	[changelogReportLatest] INFO:__main__:Installing version 1.0.0b2 of azure-mgmt-datadog in a venv
cmderr	[changelogReportLatest] Cache entry deserialization failed, entry ignored
cmderr	[changelogReportLatest] INFO:__main__:Looking for Autorest generated package in azure.mgmt.datadog
cmderr	[changelogReportLatest] INFO:__main__:Found azure.mgmt.datadog
cmderr	[changelogReportLatest] INFO:__main__:Working on azure.mgmt.datadog
cmderr	[changelogReportLatest] INFO:__main__:Report written to sdk/datadog/azure-mgmt-datadog/code_reports/1.0.0b2/report.json
cmdout	[Changelog] Size of delta 33.712% size of original (original: 21912 chars, delta: 7387 chars)
cmdout	[Changelog] **Features**
cmdout	[Changelog]   - Added operation MonitorsOperations.delete
cmdout	[Changelog]   - Added operation MonitorsOperations.create
cmdout	[Changelog]   - Added operation SingleSignOnConfigurationsOperations.create_or_update
cmdout	[Changelog] **Breaking changes**
cmdout	[Changelog]   - Operation TagRulesOperations.list has a new signature
cmdout	[Changelog]   - Operation TagRulesOperations.get has a new signature
cmdout	[Changelog]   - Operation SingleSignOnConfigurationsOperations.list has a new signature
cmdout	[Changelog]   - Operation SingleSignOnConfigurationsOperations.get has a new signature
cmdout	[Changelog]   - Operation RefreshSetPasswordOperations.get has a new signature
cmdout	[Changelog]   - Operation MonitorsOperations.list_by_resource_group has a new signature
cmdout	[Changelog]   - Operation MonitorsOperations.get has a new signature
cmdout	[Changelog]   - Operation MonitoredResourcesOperations.list has a new signature
cmdout	[Changelog]   - Operation LinkedResourcesOperations.list has a new signature
cmdout	[Changelog]   - Operation HostsOperations.list has a new signature
cmdout	[Changelog]   - Operation ApiKeysOperations.set_default_key has a new signature
cmdout	[Changelog]   - Operation ApiKeysOperations.list has a new signature
cmdout	[Changelog]   - Operation ApiKeysOperations.get_default_key has a new signature
cmdout	[Changelog]   - Operation Operations.list has a new signature
cmdout	[Changelog]   - Operation TagRulesOperations.create_or_update has a new signature
cmdout	[Changelog]   - Operation MonitorsOperations.list has a new signature
cmdout	[Changelog]   - Operation MonitorsOperations.update has a new signature
cmdout	[Changelog]   - Operation MarketplaceAgreementsOperations.list has a new signature
cmdout	[Changelog]   - Operation MarketplaceAgreementsOperations.create has a new signature
cmdout	[Changelog]   - Removed operation MonitorsOperations.begin_create
cmdout	[Changelog]   - Removed operation MonitorsOperations.begin_delete
cmdout	[Changelog]   - Removed operation SingleSignOnConfigurationsOperations.begin_create_or_update
warn	Breaking change found in changelog

️️✔️ azure-cli-extensions succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from c658577. Azure CLI Automation 14.0.0

warn	Skip initScript due to not configured
command	npx n 12
command	python3 -m venv venv
command	pip install --upgrade setuptools wheel pip
command	pip install pathlib jinja2 msrestazure
command	autorest --az --use=@autorest/az@latest --version=3.0.6271 --clear-output-folder=true --azure-cli-extension-folder=/home/vsts/work/1/s/azure-cli-extensions ../azure-rest-api-specs/specification/datadog/resource-manager/readme.md
cmdout	[Autorest] WARNING (PreCheck/CheckDuplicateSchemas): Checking for duplicate schemas, this could take a (long) while.  Run with --verbose for more detail.
cmdout	[Autorest] WARNING (): cli.auto-parameter-hidden is not true, skip visibility cleaner
cmderr	[Autorest] BELOW TEST SCENARIO SECTION CAN BE USED IN readme.cli.md
cmderr	[Autorest] --------------------------------------------------------
cmderr	[Autorest]   test-scenario:
cmderr	[Autorest]     - name: /MarketplaceAgreements/put/MarketplaceAgreements_Create
cmderr	[Autorest]     - name: /Monitors/put/Monitors_Create
cmderr	[Autorest]     - name: /Monitors/get/Monitors_Get
cmderr	[Autorest]     - name: /Monitors/get/Monitors_List
cmderr	[Autorest]     - name: /Monitors/get/Monitors_ListByResourceGroup
cmderr	[Autorest]     - name: /Monitors/patch/Monitors_Update
cmderr	[Autorest]     - name: /ApiKeys/post/ApiKeys_GetDefaultKey
cmderr	[Autorest]     - name: /ApiKeys/post/ApiKeys_List
cmderr	[Autorest]     - name: /ApiKeys/post/ApiKeys_SetDefaultKey
cmderr	[Autorest]     - name: /Hosts/post/Hosts_List
cmderr	[Autorest]     - name: /LinkedResources/post/LinkedResources_List
cmderr	[Autorest]     - name: /MarketplaceAgreements/get/MarketplaceAgreements_List
cmderr	[Autorest]     - name: /MonitoredResources/post/MonitoredResources_List
cmderr	[Autorest]     - name: /RefreshSetPassword/post/RefreshSetPassword_Get
cmderr	[Autorest]     - name: /SingleSignOnConfigurations/put/SingleSignOnConfigurations_CreateOrUpdate
cmderr	[Autorest]     - name: /SingleSignOnConfigurations/get/SingleSignOnConfigurations_Get
cmderr	[Autorest]     - name: /SingleSignOnConfigurations/get/SingleSignOnConfigurations_List
cmderr	[Autorest]     - name: /TagRules/put/TagRules_CreateOrUpdate
cmderr	[Autorest]     - name: /TagRules/get/TagRules_Get
cmderr	[Autorest]     - name: /TagRules/get/TagRules_List
cmderr	[Autorest]     - name: /Monitors/delete/Monitors_Delete
cmderr	[Autorest] --------------------------------------------------------
cmderr	[Autorest] /bin/sh: 1: cd: can't cd to home/vsts/work/1/s/azure-rest-api-specs
cmderr	[Autorest] fatal: not a git repository (or any of the parent directories): .git
cmderr	[Autorest] fatal: not a git repository (or any of the parent directories): .git

️✔️datadog [View full logs] [Release Azure CLI Changes]
- datadog-0.1.0-py3-none-any.whl
- datadog-0.1.0.zip

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from c658577. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-01-21 08:54:33 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-datadog"
cmderr	[generate.py] 2021-01-21 08:54:33 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
cmderr	[generate.py] 2021-01-21 08:54:33 INFO autorest --version=3.0.6350 --use=@autorest/java@4.0.11 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/datadog/azure-resourcemanager-datadog --java.namespace=com.azure.resourcemanager.datadog   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/datadog/resource-manager/readme.md
cmderr	[generate.py] 2021-01-21 08:55:16 INFO [CI][Success] Write to ci.yml
cmderr	[generate.py] 2021-01-21 08:55:16 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-01-21 08:55:16 INFO [POM][Skip] pom already has module azure-resourcemanager-datadog
cmderr	[generate.py] 2021-01-21 08:55:16 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-01-21 08:55:16 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-01-21 08:55:16 INFO [POM][Success] Write to root pom
cmderr	[generate.py] WARNING: An illegal reflective access operation has occurred
cmderr	[generate.py] WARNING: Illegal reflective access by org.codehaus.groovy.reflection.ReflectionUtils (file:/home/vsts/.m2/repository/org/codehaus/groovy/groovy/3.0.0-beta-2/groovy-3.0.0-beta-2-indy.jar) to method java.util.Collections$UnmodifiableCollection.toString()
cmderr	[generate.py] WARNING: Please consider reporting this to the maintainers of org.codehaus.groovy.reflection.ReflectionUtils
cmderr	[generate.py] WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
cmderr	[generate.py] WARNING: All illegal access operations will be denied in a future release

️✔️azure-resourcemanager-datadog [View full logs] [Release SDK Changes]

cmderr	[Inst] 2021-01-21 08:58:45 DEBUG Got artifact_id: azure-resourcemanager-datadog
cmderr	[Inst] 2021-01-21 08:58:45 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-01-21 08:58:45 DEBUG Got artifact: azure-resourcemanager-datadog-1.0.0-beta.1.jar
cmderr	[Inst] 2021-01-21 08:58:45 DEBUG Match jar package: azure-resourcemanager-datadog-1.0.0-beta.1.jar
cmderr	[Inst] 2021-01-21 08:58:45 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/12345/azure-sdk-for-java/azure-resourcemanager-datadog/azure-resourcemanager-datadog-1.0.0-beta.1.jar\" -o azure-resourcemanager-datadog-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-datadog -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-datadog-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
```"}

️️✔️ azure-sdk-for-python-track2 succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from c658577. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	npx n 12
command	python3 -m venv venv
command	pip install --upgrade setuptools wheel pip
command	pip install pathlib jinja2 msrestazure
command	autorest --version=3.0.6272 --use=@autorest/python@5.4.3 --python --python-mode=update --multiapi --track2 --python-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-python/sdk ../azure-rest-api-specs/specification/datadog/resource-manager/readme.md
cmdout	[Autorest] WARNING (PreCheck/CheckDuplicateSchemas): Checking for duplicate schemas, this could take a (long) while.  Run with --verbose for more detail.

️✔️track2_azure-mgmt-datadog [View full logs] [Release SDK Changes]

cmderr	[buildConf] INFO:packaging_tools:Building template azure-mgmt-datadog
cmderr	[buildConf] INFO:packaging_tools.conf:Skipping default conf since the file exists
cmderr	[buildConf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
cmderr	[buildConf] INFO:packaging_tools:Template done azure-mgmt-datadog
cmderr	[buildPackage] warning: no files found matching '*.py' under directory 'tests'
cmderr	[buildPackage] warning: no files found matching '*.yaml' under directory 'tests'
cmderr	[buildPackage] warning: no files found matching '*.py' under directory 'tests'
cmderr	[buildPackage] warning: no files found matching '*.yaml' under directory 'tests'
cmderr	[changelogSetup] WARNING: Skipping azure-nspkg as it is not installed.
cmderr	[changelogReport] INFO:__main__:Building code report of azure-mgmt-datadog for version None in default folder (False/False/False)
cmderr	[changelogReport] INFO:__main__:Looking for Autorest generated package in azure.mgmt.datadog
cmderr	[changelogReport] INFO:__main__:Found azure.mgmt.datadog
cmderr	[changelogReport] INFO:__main__:Working on azure.mgmt.datadog
cmderr	[changelogReport] INFO:__main__:Report written to sdk/datadog/azure-mgmt-datadog/code_reports/latest/report.json
cmderr	[changelogReportLatest] INFO:__main__:Building code report of azure-mgmt-datadog for version None in default folder (False/False/True)
cmderr	[changelogReportLatest] INFO:__main__:Download versions of azure-mgmt-datadog on PyPI
cmderr	[changelogReportLatest] INFO:__main__:Got ['1.0.0b1', '1.0.0b2']
cmderr	[changelogReportLatest] INFO:__main__:Only keep last PyPI version
cmderr	[changelogReportLatest] INFO:__main__:Installing version 1.0.0b2 of azure-mgmt-datadog in a venv
cmderr	[changelogReportLatest] Cache entry deserialization failed, entry ignored
cmderr	[changelogReportLatest] INFO:__main__:Building code report of azure-mgmt-datadog for version 1.0.0b2 in default folder (True/False/False)
cmderr	[changelogReportLatest] INFO:__main__:Looking for Autorest generated package in azure.mgmt.datadog
cmderr	[changelogReportLatest] INFO:__main__:Found azure.mgmt.datadog
cmderr	[changelogReportLatest] INFO:__main__:Working on azure.mgmt.datadog
cmderr	[changelogReportLatest] INFO:__main__:Report written to sdk/datadog/azure-mgmt-datadog/code_reports/1.0.0b2/report.json
cmderr	[changelogReportLatest] INFO:__main__:Writing metadata: {'reports': ['sdk/datadog/azure-mgmt-datadog/code_reports/1.0.0b2/report.json']}
cmdout	[Changelog] Size of delta 2.031% size of original (original: 22158 chars, delta: 450 chars)

️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2021-01-08T23:42:16Z

Hi @limingu, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

limingu · 2021-01-08T23:46:09Z

Hi @limingu, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

@jianyexi, the service is still in private preview. So it is ok for the change to be breaking change.

jianyexi · 2021-01-18T02:04:02Z

Hi @limingu
        Limin Gu
        FTE, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow [breaking change policy](https://aka.ms/AzBreakingChangesPolicy) to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
@jianyexi Jianye Xi FTE, the service is still in private preview. So it is ok for the change to be breaking change.

As it's in public repo, this preview version is public preview , right ? Or you need to seed the change to private repo first ?

limingu · 2021-01-20T19:24:54Z

Hi @limingu
        Limin Gu
        FTE, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow [breaking change policy](https://aka.ms/AzBreakingChangesPolicy) to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
@jianyexi Jianye Xi FTE, the service is still in private preview. So it is ok for the change to be breaking change.
As it's in public repo, this preview version is public preview , right ? Or you need to seed the change to private repo first ?

@jianyexi, we will soon be in public preview. Also, I will create another PR to merge into private repo. I don't think the order matters, right?

limingu · 2021-01-20T22:04:13Z

limingu · 2021-01-21T04:00:38Z

@jianyexi, the service is still in private preview and only internal customers and our own team are using the APIs. NO external customers are using it. So the breaking change is fine. Thanks!

[Datadog] Add api version parameter

0ce77dd

openapi-assignment-bot bot assigned jianyexi Jan 8, 2021

openapi-pipeline-app bot added the BreakingChangeReviewRequired label Jan 8, 2021

openapi-pipeline-app bot added the CI-BreakingChange-Python label Jan 8, 2021

fengzhou-msft approved these changes Jan 10, 2021

View reviewed changes

jianyexi merged commit c658577 into Azure:master Jan 21, 2021

mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021

[Datadog] Add api version parameter (Azure#12345)

454acfa

azure-sdk mentioned this pull request Sep 14, 2022

[Cognitive Services - Knowledge] API Review Entity Matching #20705

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Datadog] Add api version parameter #12345

[Datadog] Add api version parameter #12345

limingu commented Jan 8, 2021 •

edited by azure-sdk

Loading

openapi-workflow-bot bot commented Jan 8, 2021

openapi-pipeline-app bot commented Jan 8, 2021 •

edited

Loading

openapi-pipeline-app bot commented Jan 8, 2021 •

edited

Loading

openapi-workflow-bot bot commented Jan 8, 2021

limingu commented Jan 8, 2021

jianyexi commented Jan 18, 2021

limingu commented Jan 20, 2021

limingu commented Jan 20, 2021 via email

limingu commented Jan 21, 2021

[Datadog] Add api version parameter #12345

[Datadog] Add api version parameter #12345

Conversation

limingu commented Jan 8, 2021 • edited by azure-sdk Loading

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Jan 8, 2021

openapi-pipeline-app bot commented Jan 8, 2021 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Jan 8, 2021 • edited Loading

Swagger Generation Artifacts

openapi-workflow-bot bot commented Jan 8, 2021

limingu commented Jan 8, 2021

jianyexi commented Jan 18, 2021

limingu commented Jan 20, 2021

limingu commented Jan 20, 2021 via email

limingu commented Jan 21, 2021

limingu commented Jan 8, 2021 •

edited by azure-sdk

Loading

openapi-pipeline-app bot commented Jan 8, 2021 •

edited

Loading

openapi-pipeline-app bot commented Jan 8, 2021 •

edited

Loading