Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confluent added stable version #12362

Merged
merged 23 commits into from
Jan 14, 2021
Merged

Confluent added stable version #12362

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
40f8e4b
update azure schema readme with stable version
alluri02 Jan 11, 2021
f3d03b4
Update go readme with stable version
alluri02 Jan 11, 2021
ea051bc
Update java readme with stable version
alluri02 Jan 11, 2021
16741ca
Update readme with stable version
alluri02 Jan 11, 2021
3210501
Update python reademe with stable version
alluri02 Jan 11, 2021
9dbee9d
Update ruby with stable version
alluri02 Jan 11, 2021
7a061fc
created stable version confluent.json
alluri02 Jan 11, 2021
77cab39
create marketplace agreements example json
alluri02 Jan 11, 2021
c06a3b1
Create List Agreements json
alluri02 Jan 11, 2021
43c5ec1
Create Organization List Json
alluri02 Jan 11, 2021
1ca44ab
Create Organization example Json
alluri02 Jan 11, 2021
0d8019f
Create Organization Delete Json
alluri02 Jan 11, 2021
85eb09b
Create Organization Get Json
alluri02 Jan 11, 2021
0b47b12
Create Organization List By resourceGroup Json
alluri02 Jan 11, 2021
8ba9aac
Create Organization List by subscription json
alluri02 Jan 11, 2021
fee0c96
Create Organization update json
alluri02 Jan 11, 2021
db491d5
Update confluent json
alluri02 Jan 11, 2021
adcd2b1
update marketplace create json
alluri02 Jan 11, 2021
32e7638
Update marketplace list json
alluri02 Jan 11, 2021
9841dc1
Update Operations list json
alluri02 Jan 11, 2021
8da7463
Update organization create json
alluri02 Jan 11, 2021
35feb11
Update Organization create json
alluri02 Jan 11, 2021
028a2b4
Merge branch 'master' into confluent-stable
alluri02 Jan 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion .../confluent/resource-manager/Microsoft.Confluent/preview/2020-03-01-preview/confluent.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,9 @@
],
"summary": "Create Confluent Marketplace agreement in the subscription.",
"operationId": "MarketplaceAgreements_Create",
"consumes": [
"application/json"
],
"produces": [
"application/json"
],
Expand All @@ -89,6 +92,7 @@
{
"in": "body",
"name": "body",
"description": "Confluent Marketplace Agreement resource",
"schema": {
"$ref": "#/definitions/ConfluentAgreementResource"
}
Expand Down Expand Up @@ -516,13 +520,14 @@
"readOnly": true
},
"properties": {
"x-ms-client-flatten": true,
"$ref": "#/definitions/ConfluentAgreementProperties",
"description": "Represents the properties of the resource."
}
}
},
"ConfluentAgreementResourceListResponse": {
"description": "Response of a agreements operation.",
"description": "Response of a list operation.",
"type": "object",
"properties": {
"value": {
Expand Down Expand Up @@ -571,6 +576,10 @@
"display": {
"description": "The object that represents the operation.",
"$ref": "#/definitions/OperationDisplay"
},
"isDataAction": {
"description": "Indicates whether the operation is a data action",
"type": "boolean"
Comment on lines +580 to +582
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intended? I don't see this change in the private pr. It's a breaking change even if it's a preview version.
https://github.com/microsoft/api-guidelines/blob/vNext/azure/Guidelines.md#api-changes-that-require-a-version-change

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @j5lim, This is added to resolve s360 swagger correctness. in private-repo it was already present.
https://github.com/Azure/azure-rest-api-specs-pr/blob/RPSaaSMaster/specification/confluent/resource-manager/Microsoft.Confluent/stable/2020-03-01/confluent.json#L580

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the changes approved. Thanks.

}
}
},
Expand Down
4 changes: 2 additions & 2 deletions ...r/Microsoft.Confluent/preview/2020-03-01-preview/examples/MarketplaceAgreements_List.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@
"body": {
"value": [
{
"id": "id1",
"id": "/subscriptions/00000000-0000-0000-0000-000000000000/providers/Microsoft.Confluent/agreements/default",
"name": "planid1",
"type": "Microsoft.MarketplaceOrdering/offertypes",
"type": "Microsoft.Confluent/agreements",
"properties": {
"publisher": "pubid1",
"product": "offid1",
Expand Down
3 changes: 3 additions & 0 deletions .../Microsoft.Confluent/preview/2020-03-01-preview/examples/OrganizationOperations_List.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
"value": [
{
"name": "Microsoft.Confluent/organizations/Read",
"isDataAction": false,
"display": {
"provider": "Microsoft.Confluent",
"resource": "organizations",
Expand All @@ -17,6 +18,7 @@
},
{
"name": "Microsoft.Confluent/organizations/Write",
"isDataAction": false,
"display": {
"provider": "Microsoft.Confluent",
"resource": "organizations",
Expand All @@ -26,6 +28,7 @@
},
{
"name": "Microsoft.Confluent/organizations/Delete",
"isDataAction": false,
"display": {
"provider": "Microsoft.Confluent",
"resource": "organizations",
Expand Down
Loading