Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Review request for Microsoft.BotService to add version stable/2020-06-02 #12433

Merged
merged 17 commits into from
Jan 19, 2021
Original file line number Diff line number Diff line change
Expand Up @@ -806,7 +806,7 @@
}
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.BotService/botServices/{resourceName}/Connections/{connectionName}/listWithSecrets": {
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.BotService/botServices/{resourceName}/connections/{connectionName}/listWithSecrets": {
"post": {
"tags": [
"BotConnection"
Expand Down Expand Up @@ -851,7 +851,7 @@
}
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.BotService/botServices/{resourceName}/Connections/{connectionName}": {
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.BotService/botServices/{resourceName}/connections/{connectionName}": {
"put": {
"tags": [
"BotConnection"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"200": {
"body": {
"location": "global",
"id": "/subscriptions/subscription-id/resourceGroups/OneResourceGroupName/providers/Microsoft.BotService/botServices/samplebotname/Connections/sampleConnection",
"id": "/subscriptions/subscription-id/resourceGroups/OneResourceGroupName/providers/Microsoft.BotService/botServices/samplebotname/connections/sampleConnection",
"etag": "etag1",
"name": "sampleConnection",
"properties": {
Expand Down
12 changes: 7 additions & 5 deletions specification/botservice/resource-manager/readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,11 @@ These settings apply only when `--tag=package-2020-06-02` is specified on the co

```yaml $(tag) == 'package-2020-06-02'
input-file:
- Microsoft.BotService/stable/2020-06-02/botservice.json
- Microsoft.BotService/stable/2020-06-02/botservice.json
directive:
- suppress: R4009
from: botservice.json
reason: We do not yet support systemdata.
```


Expand Down Expand Up @@ -109,10 +113,8 @@ swagger-to-sdk:
```
directive:
- suppress: SECRET_PROPERTY
from:
- Microsoft.BotService/stable/2020-06-02/botservice.json
where:
- $.definitions.FacebookChannelProperties.properties.verifyToken
from: botservice.json
where: $.definitions.FacebookChannelProperties.properties.verifyToken
reason: We do need to return verifyToken in FacebookChannelProperties.
```

Expand Down