Datr/add session host health check result #12457

datr93 · 2021-01-15T19:25:04Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No, no need to refresh for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of “no breaking changes
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable version with Breaking Change Validation errors
Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2021-01-15T19:25:07Z

Hi, @datr93 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

openapi-pipeline-app · 2021-01-15T19:25:10Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️LintDiff succeeded [Detail] [Expand]

Validation passes for LintDiff.

Linted configuring files (Based on source branch, openapi-validator v1.7.0 , classic-openapi-validator v1.1.5 )
- desktopvirtualization/resource-manager/readme.md tag:package-2021-01-14-preview
Linted configuring files (Based on target branch, openapi-validator v1.7.0 , classic-openapi-validator v1.1.5 )
- desktopvirtualization/resource-manager/readme.md tag:default

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️⚠️[Staging] Cross Version BreakingChange (Base on preview version): 3 Warnings warning [Detail]

Compared Swaggers (Based on Oad v0.8.6)
- original: preview/2020-11-10-preview/desktopvirtualization.json <---> new: preview/2021-01-14-preview/desktopvirtualization.json

Rule	Message
⚠️ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'rampUpLoadBalancingAlgorithm' renamed or removed? New: Microsoft.DesktopVirtualization/preview/2021-01-14-preview/desktopvirtualization.json#L4155:7 Old: Microsoft.DesktopVirtualization/preview/2020-11-10-preview/desktopvirtualization.json#L4064:7
⚠️ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'rampUpMinimumHostsPct' renamed or removed? New: Microsoft.DesktopVirtualization/preview/2021-01-14-preview/desktopvirtualization.json#L4155:7 Old: Microsoft.DesktopVirtualization/preview/2020-11-10-preview/desktopvirtualization.json#L4064:7
⚠️ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'rampDownWaitTimeMinutes' renamed or removed? New: Microsoft.DesktopVirtualization/preview/2021-01-14-preview/desktopvirtualization.json#L4155:7 Old: Microsoft.DesktopVirtualization/preview/2020-11-10-preview/desktopvirtualization.json#L4064:7

️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2021-01-15T19:25:10Z

Swagger Generation Artifacts

️⚠️ azure-sdk-for-js warning [Detail]

⚠️Warning [Logs]Release - Generate from 296af42. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/desktopvirtualization/resource-manager/readme.md
warn	No file changes detected after generation
warn	No package detected after generation

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 296af42. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-01-26 01:53:37 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-desktopvirtualization"
cmderr	[generate.py] 2021-01-26 01:53:37 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
cmderr	[generate.py] 2021-01-26 01:53:37 INFO autorest --version=3.0.6350 --use=@autorest/java@4.0.11 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/desktopvirtualization/azure-resourcemanager-desktopvirtualization --java.namespace=com.azure.resourcemanager.desktopvirtualization   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/desktopvirtualization/resource-manager/readme.md
cmderr	[generate.py] 2021-01-26 01:54:30 INFO [CI][Success] Write to ci.yml
cmderr	[generate.py] 2021-01-26 01:54:30 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-01-26 01:54:30 INFO [POM][Skip] pom already has module azure-resourcemanager-desktopvirtualization
cmderr	[generate.py] 2021-01-26 01:54:30 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-01-26 01:54:30 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-01-26 01:54:30 INFO [POM][Success] Write to root pom
cmderr	[generate.py] 2021-01-26 01:56:19 ERROR [COMPILE] Maven build fail

️✔️azure-resourcemanager-desktopvirtualization [View full logs] [Release SDK Changes]

cmderr	[Inst] 2021-01-26 01:57:24 DEBUG Got artifact_id: azure-resourcemanager-desktopvirtualization
cmderr	[Inst] 2021-01-26 01:57:24 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-01-26 01:57:24 DEBUG Got artifact: azure-resourcemanager-desktopvirtualization-1.0.0-beta.1-javadoc.jar
cmderr	[Inst] 2021-01-26 01:57:24 DEBUG Got artifact: azure-resourcemanager-desktopvirtualization-1.0.0-beta.1.jar
cmderr	[Inst] 2021-01-26 01:57:24 DEBUG Match jar package: azure-resourcemanager-desktopvirtualization-1.0.0-beta.1.jar
cmderr	[Inst] 2021-01-26 01:57:24 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/12457/azure-sdk-for-java/azure-resourcemanager-desktopvirtualization/azure-resourcemanager-desktopvirtualization-1.0.0-beta.1.jar\" -o azure-resourcemanager-desktopvirtualization-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-desktopvirtualization -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-desktopvirtualization-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
```"}

️⚠️ azure-sdk-for-python warning [Detail]

⚠️Warning [Logs]Release - Generate from 296af42. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	npx n 12
command	python3 -m venv venv
command	pip install --upgrade setuptools wheel pip
command	pip install pathlib jinja2 msrestazure
command	autorest --version=V2 --use=@microsoft.azure/autorest.python@~4.0.71 --python --python-mode=update --multiapi --keep-version-file --no-async --python-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-python/sdk ../azure-rest-api-specs/specification/desktopvirtualization/resource-manager/readme.md

⚠️azure-mgmt-desktopvirtualization [View full logs] [Release SDK Changes]

cmderr	[buildConf] INFO:packaging_tools:Building template azure-mgmt-desktopvirtualization
cmderr	[buildConf] INFO:packaging_tools.conf:Build default conf for azure-mgmt-desktopvirtualization
cmderr	[buildConf] INFO:packaging_tools:Template done azure-mgmt-desktopvirtualization
cmderr	[buildPackage] warning: no files found matching '*.py' under directory 'tests'
cmderr	[buildPackage] warning: no files found matching '*.yaml' under directory 'tests'
cmderr	[buildPackage] warning: no files found matching '*.py' under directory 'tests'
cmderr	[buildPackage] warning: no files found matching '*.yaml' under directory 'tests'
cmderr	[changelogSetup] WARNING: Skipping azure-nspkg as it is not installed.
cmderr	[changelogReport] Traceback (most recent call last):
cmderr	[changelogReport]   File "/usr/lib/python3.6/runpy.py", line 193, in _run_module_as_main
cmderr	[changelogReport]     "__main__", mod_spec)
cmderr	[changelogReport]   File "/usr/lib/python3.6/runpy.py", line 85, in _run_code
cmderr	[changelogReport]     exec(code, run_globals)
cmderr	[changelogReport]   File "/home/vsts/work/1/s/azure-sdk-for-python/tools/azure-sdk-tools/packaging_tools/code_report.py", line 399, in <module>
cmderr	[changelogReport]     main(args.package_name, args.version, args.no_venv, args.pypi, args.last_pypi, args.output)
cmderr	[changelogReport]   File "/home/vsts/work/1/s/azure-sdk-for-python/tools/azure-sdk-tools/packaging_tools/code_report.py", line 254, in main
cmderr	[changelogReport]     path_to_package = resolve_package_directory(package_name)
cmderr	[changelogReport]   File "/home/vsts/work/1/s/azure-sdk-for-python/tools/azure-sdk-tools/packaging_tools/code_report.py", line 133, in resolve_package_directory
cmderr	[changelogReport]     return packages[0]
cmderr	[changelogReport] IndexError: list index out of range
warn	Script return with result [warning] code [1] signal [null] cwd [azure-sdk-for-python]: python
cmderr	[changelogReportLatest] Traceback (most recent call last):
cmderr	[changelogReportLatest]   File "/usr/lib/python3.6/runpy.py", line 193, in _run_module_as_main
cmderr	[changelogReportLatest]     "__main__", mod_spec)
cmderr	[changelogReportLatest]   File "/usr/lib/python3.6/runpy.py", line 85, in _run_code
cmderr	[changelogReportLatest]     exec(code, run_globals)
cmderr	[changelogReportLatest]   File "/home/vsts/work/1/s/azure-sdk-for-python/tools/azure-sdk-tools/packaging_tools/code_report.py", line 399, in <module>
cmderr	[changelogReportLatest]     main(args.package_name, args.version, args.no_venv, args.pypi, args.last_pypi, args.output)
cmderr	[changelogReportLatest]   File "/home/vsts/work/1/s/azure-sdk-for-python/tools/azure-sdk-tools/packaging_tools/code_report.py", line 254, in main
cmderr	[changelogReportLatest]     path_to_package = resolve_package_directory(package_name)
cmderr	[changelogReportLatest]   File "/home/vsts/work/1/s/azure-sdk-for-python/tools/azure-sdk-tools/packaging_tools/code_report.py", line 133, in resolve_package_directory
cmderr	[changelogReportLatest]     return packages[0]
cmderr	[changelogReportLatest] IndexError: list index out of range
warn	Script return with result [warning] code [1] signal [null] cwd [azure-sdk-for-python]: python
warn	Not exact 2 reports found:
warn	Not generating changelog.

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 296af42. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️preview/desktopvirtualization/mgmt/2021-01-14-preview/desktopvirtualization [View full logs] [Release SDK Changes]
```
info	[Changelog] This is a new package
```
️✔️preview/desktopvirtualization/mgmt/2020-11-10-preview/desktopvirtualization [View full logs] [Release SDK Changes]
```
info	[Changelog] This is a new package
```
️✔️preview/desktopvirtualization/mgmt/2020-11-02-preview/desktopvirtualization [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️preview/desktopvirtualization/mgmt/2020-10-19-preview/desktopvirtualization [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️preview/desktopvirtualization/mgmt/2020-09-21-preview/desktopvirtualization [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️preview/desktopvirtualization/mgmt/2019-12-10-preview/desktopvirtualization [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️preview/desktopvirtualization/mgmt/2019-09-24-preview/desktopvirtualization [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️preview/desktopvirtualization/mgmt/2019-01-23-preview/desktopvirtualization [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```

️️✔️ azure-cli-extensions succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 296af42. Azure CLI Automation 14.0.0

warn	Skip initScript due to not configured
command	npx n 12
command	python3 -m venv venv
command	pip install --upgrade setuptools wheel pip
command	pip install pathlib jinja2 msrestazure
command	autorest --az --use=@autorest/az@latest --version=3.0.6271 --clear-output-folder=true --azure-cli-extension-folder=/home/vsts/work/1/s/azure-cli-extensions ../azure-rest-api-specs/specification/desktopvirtualization/resource-manager/readme.md
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'CloudError' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ResourceProviderOperationList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ResourceProviderOperation' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ResourceProviderOperation-display' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'Resource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'TrackedResource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/CheckDuplicateSchemas): Checking for duplicate schemas, this could take a (long) while.  Run with --verbose for more detail.
cmdout	[Autorest] WARNING (): Operation Update has already existed in group! Skip split!
cmdout	[Autorest] WARNING (): Operation Update has already existed in group! Skip split!
cmdout	[Autorest] WARNING (): Operation Update has already existed in group! Skip split!
cmdout	[Autorest] WARNING (): Operation Update has already existed in group! Skip split!
cmdout	[Autorest] WARNING (): Operation Update has already existed in group! Skip split!
cmdout	[Autorest] WARNING (): cli.auto-parameter-hidden is not true, skip visibility cleaner
cmderr	[Autorest] BELOW TEST SCENARIO SECTION CAN BE USED IN readme.cli.md
cmderr	[Autorest] --------------------------------------------------------
cmderr	[Autorest]   test-scenario:
cmderr	[Autorest]     - name: /HostPools/put/HostPool_Create
cmderr	[Autorest]     - name: /HostPools/get/HostPool_Get
cmderr	[Autorest]     - name: /HostPools/get/HostPool_List
cmderr	[Autorest]     - name: /HostPools/get/HostPool_ListByResourceGroup
cmderr	[Autorest]     - name: /HostPools/patch/HostPool_Update
cmderr	[Autorest]     - name: /ApplicationGroups/put/ApplicationGroup_Create
cmderr	[Autorest]     - name: /ApplicationGroups/get/ApplicationGroup_Get
cmderr	[Autorest]     - name: /ApplicationGroups/get/ApplicationGroup_List
cmderr	[Autorest]     - name: /ApplicationGroups/get/ApplicationGroup_ListByResourceGroup
cmderr	[Autorest]     - name: /ApplicationGroups/patch/ApplicationGroups_Update
cmderr	[Autorest]     - name: /ApplicationGroups/delete/ApplicationGroup_Delete
cmderr	[Autorest]     - name: /MsixImages/post/MsixImage_Expand
cmderr	[Autorest]     - name: /MSIXPackages/put/MSIXPackage_Create
cmderr	[Autorest]     - name: /MSIXPackages/get/MSIXPackage_Get
cmderr	[Autorest]     - name: /MSIXPackages/get/MSIXPackage_List
cmderr	[Autorest]     - name: /MSIXPackages/patch/MSIXPackage_Update
cmderr	[Autorest]     - name: /MSIXPackages/delete/MSIXPackage_Delete
cmderr	[Autorest]     - name: /ScalingPlans/put/ScalingPlans_Create
cmderr	[Autorest]     - name: /ScalingPlans/get/ScalingPlans_Get
cmderr	[Autorest]     - name: /ScalingPlans/get/ScalingPlans_ListByResourceGroup
cmderr	[Autorest]     - name: /ScalingPlans/get/ScalingPlans_ListBySubscription
cmderr	[Autorest]     - name: /ScalingPlans/get/UserSession_SendMessage_Post
cmderr	[Autorest]     - name: /ScalingPlans/patch/ScalingPlans_Update
cmderr	[Autorest]     - name: /ScalingPlans/delete/ScalingPlans_Delete
cmderr	[Autorest]     - name: /HostPools/delete/HostPool_Delete
cmderr	[Autorest]     - name: /Workspaces/put/Workspace_Create
cmderr	[Autorest]     - name: /Workspaces/get/Workspace_Get
cmderr	[Autorest]     - name: /Workspaces/get/Workspace_ListByResourceGroup
cmderr	[Autorest]     - name: /Workspaces/get/Workspace_ListBySubscription
cmderr	[Autorest]     - name: /Workspaces/patch/Workspace_Update
cmderr	[Autorest]     - name: /Workspaces/delete/Workspace_Delete
cmderr	[Autorest] --------------------------------------------------------
cmderr	[Autorest] fatal: not a git repository (or any of the parent directories): .git
cmderr	[Autorest] fatal: not a git repository (or any of the parent directories): .git
cmderr	[Autorest] /bin/sh: 1: cd: can't cd to home/vsts/work/1/s/azure-rest-api-specs

️✔️desktopvirtualization [View full logs] [Release Azure CLI Changes]
- desktopvirtualization-0.1.0-py3-none-any.whl
- desktopvirtualization-0.1.0.zip

️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 296af42. Schema Automation 14.0.0

warn	Skip initScript due to not configured
command	npx n 12
command	autorest --use=@autorest/azureresourceschema@3.0.92 --version=3.0.6351 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/desktopvirtualization/resource-manager/readme.md

️✔️desktopvirtualization [View full logs] [Release Schema Changes]

cmderr	[resource-manager] node-pre-gyp
cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
cmderr	[resource-manager]  WARN template-schema-validation-tools@1.0.0 No repository field.
cmderr	[resource-manager]  optional SKIPPING OPTIONAL DEPENDENCY: fsevents@2.1.3 (node_modules/fsevents):
cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.3: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2021-01-15T19:34:56Z

Hi @datr93, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

Task	How to fix	Priority	Support (Microsoft alias)
Avocado	Fix-Avocado	High	ruowan
Semantic validation	Fix-SemanticValidation-Error	High	raychen, jianyxi
Model validation	Fix-ModelValidation-Error	High	raychen,jianyxi
LintDiff	Fix-LintDiff	high	jianyxi, ruoxuan

If you need further help, please feedback via swagger feedback."

openapi-workflow-bot · 2021-01-18T01:52:28Z

Hi, @datr93 your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). cc @ChenTanyi

...anager/Microsoft.DesktopVirtualization/preview/2021-01-14-preview/desktopvirtualization.json

.../Microsoft.DesktopVirtualization/preview/2021-01-14-preview/examples/SessionHost_Delete.json

datr93 · 2021-01-22T18:12:56Z

@RamyasreeChakka @jorgecotillo can you guys take another look? and is one of you guys from the arm review board?

ChenTanyi · 2021-01-25T03:40:08Z

@datr93 please let me know when it is ready to merge.

datr93 · 2021-01-25T18:08:25Z

@ChenTanyi please merge!!!!

* top level name can be 64 char long * add 2021-01-14-preview * update api version * add readme version very easy to missup * new changes * prettier * linter * read only for all * check name to lastHealthCheckDateTime * add enum * custom words * add description * fix spelling

datr93 added 6 commits November 16, 2020 11:37

top level name can be 64 char long

5e4b09a

Merge remote-tracking branch 'upstream/master'

ca28ca0

add 2021-01-14-preview

f61e0b7

update api version

b11dc41

add readme version very easy to missup

c69703e

new changes

8b99a73

datr93 requested a review from lirenhe as a code owner January 15, 2021 19:25

openapi-assignment-bot bot assigned ChenTanyi Jan 15, 2021

openapi-pipeline-app bot added the CI-FixRequiredOnFailure label Jan 15, 2021

prettier

7575601

openapi-pipeline-app bot added CI-FixRequiredOnFailure and removed CI-FixRequiredOnFailure labels Jan 15, 2021

linter

ef849d2

openapi-pipeline-app bot removed the CI-FixRequiredOnFailure label Jan 15, 2021

openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 18, 2021

jorgecotillo self-assigned this Jan 19, 2021

jorgecotillo added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Jan 20, 2021

jorgecotillo reviewed Jan 20, 2021

View reviewed changes

...anager/Microsoft.DesktopVirtualization/preview/2021-01-14-preview/desktopvirtualization.json Show resolved Hide resolved

...anager/Microsoft.DesktopVirtualization/preview/2021-01-14-preview/desktopvirtualization.json Show resolved Hide resolved

datr93 added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Jan 20, 2021

datr93 added 2 commits January 20, 2021 11:30

Merge remote-tracking branch 'upstream/master'

c44e2c2

Merge branch 'master' into datr/addSessionHostHealthCheckResult

5eefc05

jorgecotillo reviewed Jan 21, 2021

View reviewed changes

.../Microsoft.DesktopVirtualization/preview/2021-01-14-preview/examples/SessionHost_Delete.json Outdated Show resolved Hide resolved

datr93 added 4 commits January 21, 2021 18:37

add enum

3858606

custom words

f546721

Merge remote-tracking branch 'upstream/master'

f2fab7a

Merge branch 'master' into datr/addSessionHostHealthCheckResult

1dcf7bf

jorgecotillo added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review labels Jan 22, 2021

datr93 added 2 commits January 22, 2021 11:42

add description

006b79f

fix spelling

e28a637

datr93 removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Jan 22, 2021

ChenTanyi approved these changes Jan 25, 2021

View reviewed changes

ChenTanyi added the Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates label Jan 25, 2021

ChenTanyi merged commit 296af42 into Azure:master Jan 26, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Datr/add session host health check result #12457

Datr/add session host health check result #12457

datr93 commented Jan 15, 2021 •

edited by ChenTanyi

Loading

openapi-workflow-bot bot commented Jan 15, 2021

openapi-pipeline-app bot commented Jan 15, 2021 •

edited

Loading

openapi-pipeline-app bot commented Jan 15, 2021 •

edited

Loading

openapi-workflow-bot bot commented Jan 15, 2021

openapi-workflow-bot bot commented Jan 18, 2021

datr93 commented Jan 22, 2021

ChenTanyi commented Jan 25, 2021

datr93 commented Jan 25, 2021

Datr/add session host health check result #12457

Datr/add session host health check result #12457

Conversation

datr93 commented Jan 15, 2021 • edited by ChenTanyi Loading

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Jan 15, 2021

openapi-pipeline-app bot commented Jan 15, 2021 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Jan 15, 2021 • edited Loading

Swagger Generation Artifacts

openapi-workflow-bot bot commented Jan 15, 2021

openapi-workflow-bot bot commented Jan 18, 2021

datr93 commented Jan 22, 2021

ChenTanyi commented Jan 25, 2021

datr93 commented Jan 25, 2021

datr93 commented Jan 15, 2021 •

edited by ChenTanyi

Loading

openapi-pipeline-app bot commented Jan 15, 2021 •

edited

Loading

openapi-pipeline-app bot commented Jan 15, 2021 •

edited

Loading