[Hub Generated] Review request for Microsoft.HanaOnAzure to remove version preview/2017-11-03-preview for SapMonitor #12461

PakDLiu · 2021-01-15T22:34:09Z

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
  Removing a deprecated API version
When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
It's already deployed
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No, no need to refresh for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of “no breaking changes
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable version with Breaking Change Validation errors
Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2021-01-15T22:34:12Z

Hi, @PakDLiu Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

openapi-pipeline-app · 2021-01-15T22:34:13Z

Swagger Validation Report

️❌BreakingChange: 6 Errors, 0 Warnings failed [Detail]

Compared Swaggers (Based on Oad v0.8.5)
- original: preview/2017-11-03-preview/hanaonazure.json <---> new: preview/2017-11-03-preview/hanaonazure.json

Rule	Message
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.HanaOnAzure/sapMonitors' removed or restructured? New: azure-rest-api-specs/blob/2a1cd10f00ad4c156090ee6f6dd9aafee3a3cb3d/ Old: Microsoft.HanaOnAzure/preview/2017-11-03-preview/hanaonazure.json#L488:5
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.HanaOnAzure/sapMonitors/{sapMonitorName}' removed or restructured? New: azure-rest-api-specs/blob/2a1cd10f00ad4c156090ee6f6dd9aafee3a3cb3d/ Old: Microsoft.HanaOnAzure/preview/2017-11-03-preview/hanaonazure.json#L528:5
`❌` 1006 - RemovedDefinition	The new version is missing a definition that was found in the old version. Was 'SapMonitor' removed or renamed? New: Microsoft.HanaOnAzure/preview/2017-11-03-preview/hanaonazure.json#L489:3 Old: Microsoft.HanaOnAzure/preview/2017-11-03-preview/hanaonazure.json#L718:3
`❌` 1006 - RemovedDefinition	The new version is missing a definition that was found in the old version. Was 'SapMonitorProperties' removed or renamed? New: Microsoft.HanaOnAzure/preview/2017-11-03-preview/hanaonazure.json#L489:3 Old: Microsoft.HanaOnAzure/preview/2017-11-03-preview/hanaonazure.json#L718:3
`❌` 1007 - RemovedClientParameter	The new version is missing a client parameter that was found in the old version. Was 'SapMonitorNameParameter' removed or renamed? New: Microsoft.HanaOnAzure/preview/2017-11-03-preview/hanaonazure.json#L900:3 Old: Microsoft.HanaOnAzure/preview/2017-11-03-preview/hanaonazure.json#L1239:3
`❌` 1007 - RemovedClientParameter	The new version is missing a client parameter that was found in the old version. Was 'SapMonitorParameter' removed or renamed? New: Microsoft.HanaOnAzure/preview/2017-11-03-preview/hanaonazure.json#L900:3 Old: Microsoft.HanaOnAzure/preview/2017-11-03-preview/hanaonazure.json#L1239:3

️️✔️LintDiff succeeded [Detail] [Expand]

Validation passes for LintDiff.

Linted configuring files (Based on source branch, openapi-validator v1.6.0 , classic-openapi-validator v1.1.5 )
- hanaonazure/resource-manager/readme.md tag:package-2017-11
Linted configuring files (Based on target branch, openapi-validator v1.6.0 , classic-openapi-validator v1.1.5 )
- hanaonazure/resource-manager/readme.md tag:package-2017-11

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2021-01-15T22:34:13Z

Swagger Generation Artifacts

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from f59e6c5. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️preview/hanaonazure/mgmt/2017-11-03-preview/hanaonazure [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Function `SapMonitorListResultPage.Response` has been removed
info	[Changelog] - Function `SapMonitorsClient.DeletePreparer` has been removed
info	[Changelog] - Function `StorageProfile.MarshalJSON` has been removed
info	[Changelog] - Function `SapMonitorsClient.CreateSender` has been removed
info	[Changelog] - Function `SapMonitorsClient.Update` has been removed
info	[Changelog] - Function `SapMonitor.MarshalJSON` has been removed
info	[Changelog] - Function `SapMonitorsClient.ListResponder` has been removed
info	[Changelog] - Function `SapMonitorsClient.UpdatePreparer` has been removed
info	[Changelog] - Function `NewSapMonitorListResultPage` has been removed
info	[Changelog] - Function `SapMonitorsClient.CreateResponder` has been removed
info	[Changelog] - Function `SapMonitorListResultIterator.Response` has been removed
info	[Changelog] - Function `SapMonitorsClient.CreatePreparer` has been removed
info	[Changelog] - Function `SapMonitorsClient.ListSender` has been removed
info	[Changelog] - Function `SapMonitorProperties.MarshalJSON` has been removed
info	[Changelog] - Function `SapMonitorsClient.ListPreparer` has been removed
info	[Changelog] - Function `*SapMonitorListResultIterator.Next` has been removed
info	[Changelog] - Function `NewSapMonitorsClient` has been removed
info	[Changelog] - Function `NewSapMonitorListResultIterator` has been removed
info	[Changelog] - Function `SapMonitorListResultPage.Values` has been removed
info	[Changelog] - Function `SapMonitorsClient.ListComplete` has been removed
info	[Changelog] - Function `SapMonitorListResultIterator.NotDone` has been removed
info	[Changelog] - Function `*SapMonitorListResultPage.NextWithContext` has been removed
info	[Changelog] - Function `SapMonitorsClient.List` has been removed
info	[Changelog] - Function `SapMonitorsClient.UpdateResponder` has been removed
info	[Changelog] - Function `SapMonitorsClient.GetPreparer` has been removed
info	[Changelog] - Function `OSProfile.MarshalJSON` has been removed
info	[Changelog] - Function `SapMonitorListResult.IsEmpty` has been removed
info	[Changelog] - Function `HanaInstanceProperties.MarshalJSON` has been removed
info	[Changelog] - Function `SapMonitorsClient.UpdateSender` has been removed
info	[Changelog] - Function `SapMonitorsClient.Delete` has been removed
info	[Changelog] - Function `*SapMonitorListResultIterator.NextWithContext` has been removed
info	[Changelog] - Function `SapMonitorsClient.Create` has been removed
info	[Changelog] - Function `SapMonitorsClient.DeleteResponder` has been removed
info	[Changelog] - Function `NewSapMonitorsClientWithBaseURI` has been removed
info	[Changelog] - Function `*SapMonitorListResultPage.Next` has been removed
info	[Changelog] - Function `SapMonitorListResultPage.NotDone` has been removed
info	[Changelog] - Function `SapMonitorsClient.GetSender` has been removed
info	[Changelog] - Function `*SapMonitor.UnmarshalJSON` has been removed
info	[Changelog] - Function `SapMonitorsClient.GetResponder` has been removed
info	[Changelog] - Function `NetworkProfile.MarshalJSON` has been removed
info	[Changelog] - Function `SapMonitorsClient.Get` has been removed
info	[Changelog] - Function `SapMonitorsClient.DeleteSender` has been removed
info	[Changelog] - Function `SapMonitorListResultIterator.Value` has been removed
info	[Changelog] - Struct `SapMonitor` has been removed
info	[Changelog] - Struct `SapMonitorListResult` has been removed
info	[Changelog] - Struct `SapMonitorListResultIterator` has been removed
info	[Changelog] - Struct `SapMonitorListResultPage` has been removed
info	[Changelog] - Struct `SapMonitorProperties` has been removed
info	[Changelog] - Struct `SapMonitorsClient` has been removed
info	[Changelog] - Struct `SapMonitorsCreateFuture` has been removed
info	[Changelog] - Struct `SapMonitorsDeleteFuture` has been removed
info	[Changelog] - Field `Message` of struct `ErrorResponse` has been removed
info	[Changelog] - Field `Code` of struct `ErrorResponse` has been removed
info	[Changelog]
info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New struct `ErrorResponseError`
info	[Changelog] - New field `Error` in struct `ErrorResponse`
info	[Changelog]
info	[Changelog] Total 60 breaking change(s), 3 additive change(s).
info	[Changelog]

️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from f59e6c5. Schema Automation 14.0.0

warn	Skip initScript due to not configured
command	npx n 12
command	autorest --use=@autorest/azureresourceschema@3.0.92 --version=3.0.6351 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/hanaonazure/resource-manager/readme.md

️✔️hanaonazure [View full logs] [Release Schema Changes]

cmderr	[resource-manager] node-pre-gyp
cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
cmderr	[resource-manager] WARN template-schema-validation-tools@1.0.0 No repository field.
cmderr	[resource-manager] optional SKIPPING OPTIONAL DEPENDENCY: fsevents@2.1.3 (node_modules/fsevents):
cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.3: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
cmderr	[resource-manager] npm ERR! code ELIFECYCLE
cmderr	[resource-manager] npm ERR! errno 3
cmderr	[resource-manager] npm ERR! template-schema-validation-tools@1.0.0 test: `mocha -r ts-node/register tests.ts`
cmderr	[resource-manager] npm ERR! Exit status 3
cmderr	[resource-manager] npm ERR!
cmderr	[resource-manager] npm ERR! Failed at the template-schema-validation-tools@1.0.0 test script.
cmderr	[resource-manager] npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
cmderr	[resource-manager]  A complete log of this run can be found in:
cmderr	[resource-manager] npm ERR!     /home/vsts/.npm/_logs/2021-01-26T02_05_21_121Z-debug.log
cmderr	[resource-manager] Error: Command failed: npm run test --prefix tools
cmderr	[resource-manager]     at checkExecSyncError (child_process.js:635:11)
cmderr	[resource-manager]     at Object.execSync (child_process.js:671:15)
cmderr	[resource-manager]     at Object.<anonymous> (/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas/sdkauto_afterscript.js:13:28)
cmderr	[resource-manager]     at Module._compile (internal/modules/cjs/loader.js:999:30)
cmderr	[resource-manager]     at Object.Module._extensions..js (internal/modules/cjs/loader.js:1027:10)
cmderr	[resource-manager]     at Module.load (internal/modules/cjs/loader.js:863:32)
cmderr	[resource-manager]     at Function.Module._load (internal/modules/cjs/loader.js:708:14)
cmderr	[resource-manager]     at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:60:12)
cmderr	[resource-manager]     at internal/main/run_main_module.js:17:47 {
cmderr	[resource-manager]   status: 3,
cmderr	[resource-manager]   signal: null,
cmderr	[resource-manager]   output: [ null, null, null ],
cmderr	[resource-manager]   pid: 3039,
cmderr	[resource-manager]   stdout: null,
cmderr	[resource-manager]   stderr: null
cmderr	[resource-manager] }

️⚠️ azure-sdk-for-python warning [Detail]

⚠️Warning [Logs]Release - Generate from f59e6c5. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
cmderr	[automation_init.sh]   Failed building wheel for ConfigArgParse
cmderr	[automation_init.sh]   Failed building wheel for yarl
cmderr	[automation_init.sh]   Failed building wheel for wrapt
cmderr	[automation_init.sh]   Failed building wheel for multidict
cmderr	[automation_init.sh] Cannot uninstall requirement azure-nspkg, not installed
cmderr	[automation_init.sh] Command '['/home/vsts/work/1/s/azure-sdk-for-python_tmp/venv-sdk/bin/python', '-m', 'pip', 'uninstall', '-y', 'azure-nspkg']' returned non-zero exit status 1.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️azure-mgmt-hanaonazure [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] **Breaking changes**
info	[Changelog]
info	[Changelog]   - Parameter location of model SapMonitor is now required
info	[Changelog]   - Parameter location of model TrackedResource is now required
info	[Changelog]   - Model ErrorResponse has a new signature

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from f59e6c5. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-01-26 02:06:06 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-hanaonazure"
cmderr	[generate.py] 2021-01-26 02:06:06 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
cmderr	[generate.py] 2021-01-26 02:06:06 INFO autorest --version=3.0.6350 --use=@autorest/java@4.0.11 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/hanaonazure/azure-resourcemanager-hanaonazure --java.namespace=com.azure.resourcemanager.hanaonazure   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/hanaonazure/resource-manager/readme.md
cmderr	[generate.py] 2021-01-26 02:06:44 INFO [CI][Success] Write to ci.yml
cmderr	[generate.py] 2021-01-26 02:06:44 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-01-26 02:06:44 INFO [POM][Skip] pom already has module azure-resourcemanager-hanaonazure
cmderr	[generate.py] 2021-01-26 02:06:44 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-01-26 02:06:44 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-01-26 02:06:44 INFO [POM][Success] Write to root pom
cmderr	[generate.py] WARNING: An illegal reflective access operation has occurred
cmderr	[generate.py] WARNING: Illegal reflective access by org.codehaus.groovy.reflection.ReflectionUtils (file:/home/vsts/.m2/repository/org/codehaus/groovy/groovy/3.0.0-beta-2/groovy-3.0.0-beta-2-indy.jar) to method java.util.Collections$UnmodifiableCollection.toString()
cmderr	[generate.py] WARNING: Please consider reporting this to the maintainers of org.codehaus.groovy.reflection.ReflectionUtils
cmderr	[generate.py] WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
cmderr	[generate.py] WARNING: All illegal access operations will be denied in a future release

️✔️azure-resourcemanager-hanaonazure [View full logs] [Release SDK Changes]

cmderr	[Inst] 2021-01-26 02:09:36 DEBUG Got artifact_id: azure-resourcemanager-hanaonazure
cmderr	[Inst] 2021-01-26 02:09:36 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-01-26 02:09:36 DEBUG Got artifact: azure-resourcemanager-hanaonazure-1.0.0-beta.1-sources.jar
cmderr	[Inst] 2021-01-26 02:09:36 DEBUG Got artifact: azure-resourcemanager-hanaonazure-1.0.0-beta.1.jar
cmderr	[Inst] 2021-01-26 02:09:36 DEBUG Match jar package: azure-resourcemanager-hanaonazure-1.0.0-beta.1.jar
cmderr	[Inst] 2021-01-26 02:09:36 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/12461/azure-sdk-for-java/azure-resourcemanager-hanaonazure/azure-resourcemanager-hanaonazure-1.0.0-beta.1.jar\" -o azure-resourcemanager-hanaonazure-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-hanaonazure -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-hanaonazure-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
```"}

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from f59e6c5. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/hanaonazure/resource-manager/readme.md

️✔️@azure/arm-hanaonazure [View full logs] [Release SDK Changes]

azure-arm-hanaonazure-3.0.0.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/hanaManagementClient.js → ./dist/arm-hanaonazure.js...
cmderr	[npmPack] created ./dist/arm-hanaonazure.js in 242ms

️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2021-01-15T22:37:10Z

Hi @PakDLiu, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

PakDLiu · 2021-01-20T18:26:23Z

API version 2017-11-03-preview for SapMonitor has been deprecated and no longer used.
The new API version is 2020-02-07-preview.

Removing SapMonitor API Version v20171103

2a1cd10

openapi-pipeline-app bot added the BreakingChangeReviewRequired label Jan 15, 2021

openapi-pipeline-app bot added the CI-BreakingChange-Go label Jan 15, 2021

openapi-sdkautomation bot mentioned this pull request Jan 15, 2021

[AutoPR azure-mgmt-hanaonazure] [Hub Generated] Review request for Microsoft.HanaOnAzure to add version preview/2017-11-03-preview AzureSDKAutomation/azure-sdk-for-python#3731

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Python label Jan 15, 2021

openapi-sdkautomation bot mentioned this pull request Jan 15, 2021

[AutoPR azure-resourcemanager-hanaonazure] [Hub Generated] Review request for Microsoft.HanaOnAzure to add version preview/2017-11-03-preview AzureSDKAutomation/azure-sdk-for-java#7200

Closed

PakDLiu marked this pull request as ready for review January 15, 2021 22:41

openapi-assignment-bot bot assigned jianyexi Jan 15, 2021

PakDLiu changed the title ~~[Hub Generated] Review request for Microsoft.HanaOnAzure to add version preview/2017-11-03-preview~~ [Hub Generated] Review request for Microsoft.HanaOnAzure to remove version preview/2017-11-03-preview for SapMonitor Jan 15, 2021

JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Jan 19, 2021

JeffreyRichter approved these changes Jan 19, 2021

View reviewed changes

jianyexi merged commit f59e6c5 into Azure:master Jan 26, 2021

mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021

Removing SapMonitor API Version v20171103 (Azure#12461)

ddc4b8d

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Hub Generated] Review request for Microsoft.HanaOnAzure to remove version preview/2017-11-03-preview for SapMonitor #12461

[Hub Generated] Review request for Microsoft.HanaOnAzure to remove version preview/2017-11-03-preview for SapMonitor #12461

PakDLiu commented Jan 15, 2021 •

edited

Loading

openapi-workflow-bot bot commented Jan 15, 2021

openapi-pipeline-app bot commented Jan 15, 2021 •

edited

Loading

openapi-pipeline-app bot commented Jan 15, 2021 •

edited

Loading

openapi-workflow-bot bot commented Jan 15, 2021

PakDLiu commented Jan 20, 2021

[Hub Generated] Review request for Microsoft.HanaOnAzure to remove version preview/2017-11-03-preview for SapMonitor #12461

[Hub Generated] Review request for Microsoft.HanaOnAzure to remove version preview/2017-11-03-preview for SapMonitor #12461

Conversation

PakDLiu commented Jan 15, 2021 • edited Loading

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Jan 15, 2021

openapi-pipeline-app bot commented Jan 15, 2021 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Jan 15, 2021 • edited Loading

Swagger Generation Artifacts

openapi-workflow-bot bot commented Jan 15, 2021

PakDLiu commented Jan 20, 2021

PakDLiu commented Jan 15, 2021 •

edited

Loading

openapi-pipeline-app bot commented Jan 15, 2021 •

edited

Loading

openapi-pipeline-app bot commented Jan 15, 2021 •

edited

Loading