Saas - Remove CheckModernEligability endpoint used only by UI up to this Deprecation #12494

tabenari · 2021-01-19T13:38:51Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No, no need to refresh for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of “no breaking changes
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable version with Breaking Change Validation errors
Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2021-01-19T13:38:53Z

Hi, @tabenari Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

openapi-pipeline-app · 2021-01-19T13:38:55Z

Swagger Validation Report

️❌BreakingChange: 1 Errors, 0 Warnings failed [Detail]

Compared Swaggers (Based on Oad v0.8.6)
- original: preview/2018-03-01-beta/saas.json <---> new: preview/2018-03-01-beta/saas.json

Rule	Message
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.SaaS/checkModernEligibility' removed or restructured? Old: Microsoft.SaaS/preview/2018-03-01-beta/saas.json#L76:5

️️✔️LintDiff succeeded [Detail] [Expand]

Validation passes for LintDiff.

Linted configuring files (Based on source branch, openapi-validator v1.7.0 , classic-openapi-validator v1.1.5 )
- saas/resource-manager/readme.md tag:package-2018-03-01-beta
Linted configuring files (Based on target branch, openapi-validator v1.7.0 , classic-openapi-validator v1.1.5 )
- saas/resource-manager/readme.md tag:package-2018-03-01-beta

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2021-01-19T13:38:55Z

Swagger Generation Artifacts

️️✔️ azure-sdk-for-python succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 01ce5ea. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	npx n 12
command	python3 -m venv venv
command	pip install --upgrade setuptools wheel pip
command	pip install pathlib jinja2 msrestazure
command	autorest --version=V2 --use=@microsoft.azure/autorest.python@~4.0.71 --python --python-mode=update --multiapi --keep-version-file --no-async --python-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-python/sdk ../azure-rest-api-specs/specification/saas/resource-manager/readme.md
warn	No package detected after generation

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 01ce5ea. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-01-25 23:49:36 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-saas"
cmderr	[generate.py] 2021-01-25 23:49:36 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
cmderr	[generate.py] 2021-01-25 23:49:36 INFO autorest --version=3.0.6350 --use=@autorest/java@4.0.11 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/saas/azure-resourcemanager-saas --java.namespace=com.azure.resourcemanager.saas   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/saas/resource-manager/readme.md
cmderr	[generate.py] 2021-01-25 23:50:22 INFO [CI][Success] Write to ci.yml
cmderr	[generate.py] 2021-01-25 23:50:22 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-01-25 23:50:22 INFO [POM][Skip] pom already has module azure-resourcemanager-saas
cmderr	[generate.py] 2021-01-25 23:50:22 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-01-25 23:50:22 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-01-25 23:50:22 INFO [POM][Success] Write to root pom
cmderr	[generate.py] WARNING: An illegal reflective access operation has occurred
cmderr	[generate.py] WARNING: Illegal reflective access by org.codehaus.groovy.reflection.ReflectionUtils (file:/home/vsts/.m2/repository/org/codehaus/groovy/groovy/3.0.0-beta-2/groovy-3.0.0-beta-2-indy.jar) to method java.util.Collections$UnmodifiableCollection.toString()
cmderr	[generate.py] WARNING: Please consider reporting this to the maintainers of org.codehaus.groovy.reflection.ReflectionUtils
cmderr	[generate.py] WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
cmderr	[generate.py] WARNING: All illegal access operations will be denied in a future release

️✔️azure-resourcemanager-saas [View full logs] [Release SDK Changes]

cmderr	[Inst] 2021-01-25 23:53:23 DEBUG Got artifact_id: azure-resourcemanager-saas
cmderr	[Inst] 2021-01-25 23:53:23 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-01-25 23:53:23 DEBUG Got artifact: azure-resourcemanager-saas-1.0.0-beta.1-javadoc.jar
cmderr	[Inst] 2021-01-25 23:53:23 DEBUG Got artifact: azure-resourcemanager-saas-1.0.0-beta.1.jar
cmderr	[Inst] 2021-01-25 23:53:23 DEBUG Match jar package: azure-resourcemanager-saas-1.0.0-beta.1.jar
cmderr	[Inst] 2021-01-25 23:53:23 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/12494/azure-sdk-for-java/azure-resourcemanager-saas/azure-resourcemanager-saas-1.0.0-beta.1.jar\" -o azure-resourcemanager-saas-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-saas -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-saas-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
```"}

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 01ce5ea. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️preview/saas/mgmt/2018-03-01-beta/saas [View full logs] [Release SDK Changes]
```
info	[Changelog] This is a new package
```

️⚠️ azure-sdk-for-js warning [Detail]

⚠️Warning [Logs]Release - Generate from 01ce5ea. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/saas/resource-manager/readme.md
warn	No file changes detected after generation
warn	No package detected after generation

️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

_{Posted by Swagger Pipeline | How to fix these errors?}

tabenari · 2021-01-19T13:43:11Z

We recently published our RP swagger here. No users other than our own Ibiza UI.
We need to fix an issue of a deprecated api call by removing it from the services, swagger and manifest.

leniatgh · 2021-01-20T02:04:02Z

/azp run

azure-pipelines · 2021-01-20T02:04:18Z

Azure Pipelines successfully started running 2 pipeline(s).

openapi-workflow-bot · 2021-01-20T02:07:15Z

Hi @tabenari, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

…his Deprecation (Azure#12494) * Remove CheckModernEligibility endpoint * Delete SaaSGetModerneligibility.json

tabenari added 2 commits January 19, 2021 15:37

Remove CheckModernEligibility endpoint

25f63c3

Delete SaaSGetModerneligibility.json

ef1a256

openapi-assignment-bot bot assigned leniatgh Jan 19, 2021

tabenari changed the title ~~Saas rm chk mdrn elig~~ Saas - Remove CheckModernEligability endpoint used only by UI up to this Deprecation Jan 19, 2021

openapi-pipeline-app bot added the BreakingChangeReviewRequired label Jan 20, 2021

openapi-sdkautomation bot mentioned this pull request Jan 20, 2021

[AutoPR azure-resourcemanager-saas] Saas - Remove CheckModernEligability endpoint used only by UI up to this Deprecation AzureSDKAutomation/azure-sdk-for-java#7220

Closed

JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Jan 25, 2021

JeffreyRichter approved these changes Jan 25, 2021

View reviewed changes

leniatgh merged commit 01ce5ea into master Jan 25, 2021

This was referenced Jan 25, 2021

[ReleasePR preview/saas/mgmt/2018-03-01-beta/saas] Diyakobo/add location field Azure/azure-sdk-for-go#14095

Closed

[ReleasePR azure-resourcemanager-saas] Diyakobo/add location field Azure/azure-sdk-for-java#18487

Closed

JackTn deleted the saasRmChkMdrnElig branch August 9, 2021 10:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Saas - Remove CheckModernEligability endpoint used only by UI up to this Deprecation #12494

Saas - Remove CheckModernEligability endpoint used only by UI up to this Deprecation #12494

tabenari commented Jan 19, 2021 •

edited

Loading

openapi-workflow-bot bot commented Jan 19, 2021

openapi-pipeline-app bot commented Jan 19, 2021 •

edited

Loading

openapi-pipeline-app bot commented Jan 19, 2021 •

edited

Loading

tabenari commented Jan 19, 2021

leniatgh commented Jan 20, 2021

azure-pipelines bot commented Jan 20, 2021

openapi-workflow-bot bot commented Jan 20, 2021

Saas - Remove CheckModernEligability endpoint used only by UI up to this Deprecation #12494

Saas - Remove CheckModernEligability endpoint used only by UI up to this Deprecation #12494

Conversation

tabenari commented Jan 19, 2021 • edited Loading

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Jan 19, 2021

openapi-pipeline-app bot commented Jan 19, 2021 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Jan 19, 2021 • edited Loading

Swagger Generation Artifacts

tabenari commented Jan 19, 2021

leniatgh commented Jan 20, 2021

azure-pipelines bot commented Jan 20, 2021

openapi-workflow-bot bot commented Jan 20, 2021

tabenari commented Jan 19, 2021 •

edited

Loading

openapi-pipeline-app bot commented Jan 19, 2021 •

edited

Loading

openapi-pipeline-app bot commented Jan 19, 2021 •

edited

Loading