[Sentinel] [DataConnectors+ Entities] Live Validation Correctness fix #12498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @sagamzu Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
Swagger Validation Report
|
| Rule | Message |
|---|---|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isEnabled Location: Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json#L11265 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️❌[Staging] SDK Track2 Validation: 8 Errors, 46 Warnings failed [Detail]
Only 10 items are listed, please refer to log for more details.
- The following tags are being changed in this PR
| Rule | Message |
|---|---|
|
"readme":"securityinsights/resource-manager/readme.md", "tag":"package-2019-01-preview-only", "details":"Duplicate Schema named AggregationsKind -- properties: "kind":"description":"The kind of the setting", "$ref":"#/components/schemas/AggregationsKind" =>, type: undefined => "string", required: ["kind"] =>, enum: undefined => ["CasesAggregation"], x-ms-enum: undefined => "modelAsString":true, "name":"AggregationsKind" ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"securityinsights/resource-manager/readme.md", "tag":"package-2019-01-preview-only", "details":"Duplicate Schema named AlertRuleKind -- properties: "kind":"description":"The kind of the alert rule", "$ref":"#/components/schemas/AlertRuleKind" =>, type: undefined => "string", required: ["kind"] =>, enum: undefined => ["Scheduled", "MicrosoftSecurityIncidentCreation", "Fusion", "MLBehaviorAnalytics", "ThreatIntelligence", "Anomaly"], x-ms-enum: undefined => "modelAsString":true, "name":"AlertRuleKind", "values":["value":"Scheduled", "value":"MicrosoftSecurityIncidentCreation", "value":"Fusion", "value":"MLBehaviorAnalytics", "value":"ThreatIntelligence", "value":"Anomaly"] ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"securityinsights/resource-manager/readme.md", "tag":"package-2019-01-preview-only", "details":"Duplicate Schema named DataConnectorKind -- properties: "kind":"description":"The kind of the data connector", "$ref":"#/components/schemas/DataConnectorKind" =>, type: undefined => "string", required: ["kind"] =>, enum: undefined => ["AzureActiveDirectory", "AzureSecurityCenter", "MicrosoftCloudAppSecurity", "ThreatIntelligence", "ThreatIntelligenceTaxii", "Office365", "OfficeATP", "AmazonWebServicesCloudTrail", "AzureAdvancedThreatProtection", "MicrosoftDefenderAdvancedThreatProtection", "Dynamics365", "MicrosoftThreatProtection", "MicrosoftThreatIntelligence"], x-ms-enum: undefined => "modelAsString":true, "name":"DataConnectorKind", "values":["value":"AzureActiveDirectory", "value":"AzureSecurityCenter", "value":"MicrosoftCloudAppSecurity", "value":"ThreatIntelligence", "value":"ThreatIntelligenceTaxii", "value":"Office365", "value":"OfficeATP", "value":"AmazonWebServicesCloudTrail", "value":"AzureAdvancedThreatProtection", "value":"MicrosoftDefenderAdvancedThreatProtection", "value":"Dynamics365", "value":"MicrosoftThreatProtection", "value":"MicrosoftThreatIntelligence"] ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"securityinsights/resource-manager/readme.md", "tag":"package-2019-01-preview-only", "details":"Duplicate Schema named EntityKind -- properties: "kind":"description":"The kind of the entity.", "$ref":"#/components/schemas/EntityKind" =>, type: undefined => "string", required: ["kind"] =>, enum: undefined => ["Account", "Host", "File", "AzureResource", "CloudApplication", "DnsResolution", "FileHash", "Ip", "Malware", "Process", "RegistryKey", "RegistryValue", "SecurityGroup", "Url", "IoTDevice", "SecurityAlert", "Bookmark", "Mailbox", "MailCluster", "MailMessage", "SubmissionMail"], x-ms-enum: undefined => "modelAsString":true, "name":"EntityKind", "values":["description":"Entity represents account in the system.", "value":"Account", "description":"Entity represents host in the system.", "value":"Host", "description":"Entity represents file in the system.", "value":"File", "description":"Entity represents azure resource in the system.", "value":"AzureResource", "description":"Entity represents cloud application in the system.", "value":"CloudApplication", "description":"Entity represents dns resolution in the system.", "value":"DnsResolution", "description":"Entity represents file hash in the system.", "value":"FileHash", "description":"Entity represents ip in the system.", "value":"Ip", "description":"Entity represents malware in the system.", "value":"Malware", "description":"Entity represents process in the system.", "value":"Process", "description":"Entity represents registry key in the system.", "value":"RegistryKey", "description":"Entity represents registry value in the system.", "value":"RegistryValue", "description":"Entity represents security group in the system.", "value":"SecurityGroup", "description":"Entity represents url in the system.", "value":"Url", "description":"Entity represents IoT device in the system.", "value":"IoTDevice", "description":"Entity represents security alert in the system.", "value":"SecurityAlert", "description":"Entity represents bookmark in the system.", "value":"Bookmark", "description":"Entity represents mail cluster in the system.", "value":"MailCluster", "description":"Entity represents mail message in the system.", "value":"MailMessage", "description":"Entity represents mailbox in the system.", "value":"Mailbox", "description":"Entity represents submission mail in the system.", "value":"SubmissionMail"] ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"securityinsights/resource-manager/readme.md", "tag":"package-2019-01-preview-only", "details":"Duplicate Schema named EntityQueryKind -- properties: "kind":"description":"The kind of the entity query", "$ref":"#/components/schemas/EntityQueryKind" =>, type: undefined => "string", required: ["kind"] =>, enum: undefined => ["Expansion", "Insight"], x-ms-enum: undefined => "modelAsString":true, "name":"EntityQueryKind", "values":["value":"Expansion", "value":"Insight"] ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"securityinsights/resource-manager/readme.md", "tag":"package-2019-01-preview-only", "details":"Duplicate Schema named ThreatIntelligenceResourceKind -- properties: "kind":"description":"The kind of the entity.", "$ref":"#/components/schemas/ThreatIntelligenceResourceKind" =>, type: undefined => "string", required: ["kind"] =>, enum: undefined => ["indicator"], x-ms-enum: undefined => "modelAsString":true, "name":"ThreatIntelligenceResourceKind", "values":["description":"Entity represents threat intelligence indicator in the system.", "value":"indicator"] ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"securityinsights/resource-manager/readme.md", "tag":"package-2019-01-preview-only", "details":"Duplicate Schema named ThreatIntelligenceSortingCriteria -- properties: "itemKey":"description":"Column name", "$ref":"#/components/schemas/schemas:835", "sortOrder":"description":"Sorting order (ascending/descending/unsorted).", "$ref":"#/components/schemas/ThreatIntelligenceSortingCriteria" =>, type: undefined => "string", enum: undefined => ["unsorted", "ascending", "descending"], x-ms-enum: undefined => "modelAsString":true, "name":"ThreatIntelligenceSortingCriteria", "values":["value":"unsorted", "value":"ascending", "value":"descending"] ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"securityinsights/resource-manager/readme.md", "tag":"package-2019-01-preview-only", "details":"Error: Plugin prechecker reported failure." |
| "readme":"securityinsights/resource-manager/readme.md", "tag":"package-2019-01-preview-only", "details":"The schema 'MLBehaviorAnalyticsAlertRuleTemplate-properties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"securityinsights/resource-manager/readme.md", "tag":"package-2019-01-preview-only", "details":"The schema 'ActionsList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
Swagger Generation Artifacts
|
|
Hi @sagamzu, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
|
Hi @sagamzu, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This was referenced Jan 19, 2021
openapi-pipeline-app
bot
added
CI-FixRequiredOnFailure
and removed
CI-FixRequiredOnFailure
labels
openapi-pipeline-app
bot
added
CI-FixRequiredOnFailure
and removed
CI-FixRequiredOnFailure
CI-BreakingChange-Go
labels
openapi-pipeline-app
bot
added
CI-FixRequiredOnFailure
and removed
CI-FixRequiredOnFailure
BreakingChangeReviewRequired
labels
|
@jianyexi could you please take a look on this PR |
|
@ArcturusZhang could you take a look at Go SDK generation failure |
|
@msyyc could you take a look at the Python SDK failure? |
ArcturusZhang
requested changes
Feb 8, 2021
...resource-manager/Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json
Outdated
Show resolved
Hide resolved
|
Or can you provide the error list that you want to fix in this PR? |
In the above comment you can see the list, and as i mention maybe some of them already fixed in another PR because this one is open for a long time, and I did some merge |
|
@sagamzu could you fix the duplicate schema errors : |
@jianyexi I go over these errors and all of them are not related to the changes i did in this pr, so i am not going to fix it now. |
Actually it's easy to fix the issue , just rename the duplicate model name . see https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/ci-fix.md#sdk-track2-validation on how to run locally. |
jianyexi
added
the
Approved-BreakingChange
jianyexi
approved these changes
Feb 22, 2021
ArcturusZhang
approved these changes
Feb 22, 2021
This was referenced Feb 22, 2021
Merged
mkarmark
pushed a commit
to mkarmark/azure-rest-api-specs
that referenced
this pull request
Jul 21, 2021
…Azure#12498) * Correctness fix * remove nuulable property * fix incorrect property * fix required properties * fix merge conflict * add custom words for spell check * fix to camel case * change to camel case * fic enum name * remove duplicate enum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.