Adding deep fetch swagger support for getUnresolvedDependencies api #12504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @dukum Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
The optional parameter 'dependencyLevel' was added in the new version. New: Microsoft.Migrate/preview/2019-10-01-preview/resourcemovercollection.json#L590:11 |
|
The optional parameter '$orderby' was added in the new version. New: Microsoft.Migrate/preview/2019-10-01-preview/resourcemovercollection.json#L605:11 |
|
The optional parameter '$filter' was added in the new version. New: Microsoft.Migrate/preview/2019-10-01-preview/resourcemovercollection.json#L615:11 |
️⚠️LintDiff: 4 Warnings warning [Detail]
- Linted configuring files (Based on source branch, openapi-validator v1.7.0 , classic-openapi-validator v1.1.5 )
- Linted configuring files (Based on target branch, openapi-validator v1.7.0 , classic-openapi-validator v1.1.5 )
| Rule | Message |
|---|---|
| Since operation 'UnresolvedDependencies_Get' response has model definition 'x-ms-pageable', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. New: Microsoft.Migrate/preview/2019-10-01-preview/resourcemovercollection.json#L575 |
|
| Consider using x-ms-client-flatten to provide a better end user experience New: Microsoft.Migrate/preview/2019-10-01-preview/resourcemovercollection.json#L1576 |
|
| 'properties' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. New: Microsoft.Migrate/preview/2019-10-01-preview/resourcemovercollection.json#L1576 |
|
| 'UnresolvedDependenciesFilterProperties' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. New: Microsoft.Migrate/preview/2019-10-01-preview/resourcemovercollection.json#L1581 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
Swagger Generation Artifacts
|
|
NewApiVersionRequired reason: |
This was referenced Jan 19, 2021
|
Our service is currently not in GA. We are limited to only a couple of public regions now. As we are going towards GA we are trying to make sure that the new changes are run in public regions with the preview swagger. We are making sure in our service that none of our client breaks if they use the old parameters.
|
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
Hi @dukum, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
innosam
reviewed
Jan 20, 2021
...r/resource-manager/Microsoft.Migrate/preview/2019-10-01-preview/resourcemovercollection.json
Show resolved
Hide resolved
innosam
approved these changes
Jan 20, 2021
innosam
requested changes
Jan 20, 2021
...r/resource-manager/Microsoft.Migrate/preview/2019-10-01-preview/resourcemovercollection.json
Outdated
Show resolved
Hide resolved
|
/azp run |
|
Commenter does not have sufficient privileges for PR 12504 in repo Azure/azure-rest-api-specs |
innosam
approved these changes
Jan 21, 2021
JeffreyRichter
added
the
Approved-BreakingChange
JeffreyRichter
approved these changes
Jan 21, 2021
zhenglaizhang
added
the
Approved-OkToMerge
This was referenced Jan 22, 2021
Closed
mkarmark
pushed a commit
to mkarmark/azure-rest-api-specs
that referenced
this pull request
Jul 21, 2021
…zure#12504) * adding deep fetch swagger support * adding filter properties * example improvements and fixes * marking property readOnly Co-authored-by: Durgesh Kumar <dukum@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.