DBForPostgreSQL fixing s360 violations #12529

dsgouda · 2021-01-20T23:13:07Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No, no need to refresh for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of “no breaking changes
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable version with Breaking Change Validation errors
Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

…into pgml

openapi-workflow-bot · 2021-01-20T23:13:10Z

Hi, @dsgouda Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

openapi-pipeline-app · 2021-01-20T23:13:12Z

Swagger Validation Report

️❌BreakingChange: 6 Errors, 0 Warnings failed [Detail]

Compared Swaggers (Based on Oad v0.8.6)
- original: stable/2018-06-01/QueryPerformanceInsights.json <---> new: stable/2018-06-01/QueryPerformanceInsights.json

Rule	Message
`❌` 1038 - AddedPath	The new version is adding a path that was not found in the old version. New: Microsoft.DBforPostgreSQL/stable/2018-06-01/QueryPerformanceInsights.json#L79:5
`❌` 1038 - AddedPath	The new version is adding a path that was not found in the old version. New: Microsoft.DBforPostgreSQL/stable/2018-06-01/QueryPerformanceInsights.json#L124:5
`❌` 1038 - AddedPath	The new version is adding a path that was not found in the old version. New: Microsoft.DBforPostgreSQL/stable/2018-06-01/QueryPerformanceInsights.json#L180:5
`❌` 1038 - AddedPath	The new version is adding a path that was not found in the old version. New: Microsoft.DBforPostgreSQL/stable/2018-06-01/QueryPerformanceInsights.json#L225:5
`❌` 1038 - AddedPath	The new version is adding a path that was not found in the old version. New: Microsoft.DBforPostgreSQL/stable/2018-06-01/QueryPerformanceInsights.json#L270:5
`❌` 1038 - AddedPath	The new version is adding a path that was not found in the old version. New: Microsoft.DBforPostgreSQL/stable/2018-06-01/QueryPerformanceInsights.json#L315:5

️⚠️LintDiff: 3 Warnings warning [Detail]

Linted configuring files (Based on source branch, openapi-validator v1.7.0 , classic-openapi-validator v1.1.5 )
- postgresql/resource-manager/readme.md tag:package-2018-06-01
Linted configuring files (Based on target branch, openapi-validator v1.7.0 , classic-openapi-validator v1.1.5 )
- postgresql/resource-manager/readme.md tag:package-2018-06-01

Rule	Message
⚠️ R3010 - TrackedResourceListByImmediateParent	The child tracked resource, 'queryTexts' with immediate parent 'Server', must have a list by immediate parent operation. New: Microsoft.DBforPostgreSQL/stable/2018-06-01/QueryPerformanceInsights.json#L370
⚠️ R3010 - TrackedResourceListByImmediateParent	The child tracked resource, 'topQueryStatistics' with immediate parent 'Server', must have a list by immediate parent operation. New: Microsoft.DBforPostgreSQL/stable/2018-06-01/QueryPerformanceInsights.json#L370
⚠️ R3010 - TrackedResourceListByImmediateParent	The child tracked resource, 'waitStatistics' with immediate parent 'Server', must have a list by immediate parent operation. New: Microsoft.DBforPostgreSQL/stable/2018-06-01/QueryPerformanceInsights.json#L370

️⚠️Avocado: 1 Warnings warning [Detail]

Rule	Message
⚠️ MULTIPLE_API_VERSION	The default tag contains multiple API versions swaggers. readme: specification/postgresql/resource-manager/readme.md tag: specification/postgresql/resource-manager/readme.md#tag-package-2020-01-01

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2021-01-20T23:13:12Z

Swagger Generation Artifacts

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 0c90247. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/postgresql/resource-manager/readme.md

️✔️@azure/arm-postgresql [View full logs] [Release SDK Changes]

azure-arm-postgresql-4.4.0.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/postgreSQLManagementClient.js → ./dist/arm-postgresql.js...
cmderr	[npmPack] created ./dist/arm-postgresql.js in 503ms

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 0c90247. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️postgresql/mgmt/2020-01-01/postgresql [View full logs] [Release SDK Changes]

Only show 24 items here, please refer to log for details.

info	[Changelog] - New function `NewRecoverableServersClientWithBaseURI(string, string) RecoverableServersClient`
info	[Changelog] - New function `ServerSecurityAlertPolicyListResultIterator.Response() ServerSecurityAlertPolicyListResult`
info	[Changelog] - New function `RecoverableServersClient.GetSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `ServerSecurityAlertPoliciesClient.ListByServerSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `NewServerSecurityAlertPolicyListResultPage(ServerSecurityAlertPolicyListResult, func(context.Context, ServerSecurityAlertPolicyListResult) (ServerSecurityAlertPolicyListResult, error)) ServerSecurityAlertPolicyListResultPage`
info	[Changelog] - New function `ServerSecurityAlertPolicyListResultIterator.NotDone() bool`
info	[Changelog] - New struct `RecoverableServerProperties`
info	[Changelog] - New struct `RecoverableServerResource`
info	[Changelog] - New struct `RecoverableServersClient`
info	[Changelog] - New struct `ServerBasedPerformanceTierClient`
info	[Changelog] - New struct `ServerParametersClient`
info	[Changelog] - New struct `ServerParametersListUpdateConfigurationsFuture`
info	[Changelog] - New struct `ServerSecurityAlertPolicyListResult`
info	[Changelog] - New struct `ServerSecurityAlertPolicyListResultIterator`
info	[Changelog] - New struct `ServerSecurityAlertPolicyListResultPage`
info	[Changelog] - New field `MaxBackupRetentionDays` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MinBackupRetentionDays` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MaxStorageMB` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MinLargeStorageMB` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MaxLargeStorageMB` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MinStorageMB` in struct `PerformanceTierProperties`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 57 additive change(s).
info	[Changelog]

️✔️postgresql/mgmt/2017-12-01/postgresql [View full logs] [Release SDK Changes]

Only show 24 items here, please refer to log for details.

info	[Changelog] - New function `NewRecoverableServersClient(string) RecoverableServersClient`
info	[Changelog] - New function `ServerSecurityAlertPolicyListResultPage.Values() []ServerSecurityAlertPolicy`
info	[Changelog] - New function `ServerParametersClient.ListUpdateConfigurationsPreparer(context.Context, string, string, ConfigurationListResult) (*http.Request, error)`
info	[Changelog] - New function `ServerParametersClient.ListUpdateConfigurations(context.Context, string, string, ConfigurationListResult) (ServerParametersListUpdateConfigurationsFuture, error)`
info	[Changelog] - New function `ServerSecurityAlertPoliciesClient.ListByServerPreparer(context.Context, string, string) (*http.Request, error)`
info	[Changelog] - New function `ServerSecurityAlertPoliciesClient.ListByServer(context.Context, string, string) (ServerSecurityAlertPolicyListResultPage, error)`
info	[Changelog] - New struct `RecoverableServerProperties`
info	[Changelog] - New struct `RecoverableServerResource`
info	[Changelog] - New struct `RecoverableServersClient`
info	[Changelog] - New struct `ServerBasedPerformanceTierClient`
info	[Changelog] - New struct `ServerParametersClient`
info	[Changelog] - New struct `ServerParametersListUpdateConfigurationsFuture`
info	[Changelog] - New struct `ServerSecurityAlertPolicyListResult`
info	[Changelog] - New struct `ServerSecurityAlertPolicyListResultIterator`
info	[Changelog] - New struct `ServerSecurityAlertPolicyListResultPage`
info	[Changelog] - New field `MaxLargeStorageMB` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MinStorageMB` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MaxBackupRetentionDays` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MinBackupRetentionDays` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MaxStorageMB` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MinLargeStorageMB` in struct `PerformanceTierProperties`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 57 additive change(s).
info	[Changelog]

️✔️preview/postgresql/mgmt/2020-11-05-preview/postgresqlflexibleservers [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️preview/postgresql/mgmt/2020-02-14-preview/postgresqlflexibleservers [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```

️✔️preview/postgresql/mgmt/2017-12-01-preview/postgresql [View full logs] [Release SDK Changes]

Only show 24 items here, please refer to log for details.

info	[Changelog] - New function `ServerSecurityAlertPolicyListResult.IsEmpty() bool`
info	[Changelog] - New function `ServerSecurityAlertPoliciesClient.ListByServerComplete(context.Context, string, string) (ServerSecurityAlertPolicyListResultIterator, error)`
info	[Changelog] - New function `NewServerBasedPerformanceTierClientWithBaseURI(string, string) ServerBasedPerformanceTierClient`
info	[Changelog] - New function `*ServerSecurityAlertPolicyListResultPage.Next() error`
info	[Changelog] - New function `RecoverableServersClient.GetSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `NewServerSecurityAlertPolicyListResultIterator(ServerSecurityAlertPolicyListResultPage) ServerSecurityAlertPolicyListResultIterator`
info	[Changelog] - New struct `RecoverableServerProperties`
info	[Changelog] - New struct `RecoverableServerResource`
info	[Changelog] - New struct `RecoverableServersClient`
info	[Changelog] - New struct `ServerBasedPerformanceTierClient`
info	[Changelog] - New struct `ServerParametersClient`
info	[Changelog] - New struct `ServerParametersListUpdateConfigurationsFuture`
info	[Changelog] - New struct `ServerSecurityAlertPolicyListResult`
info	[Changelog] - New struct `ServerSecurityAlertPolicyListResultIterator`
info	[Changelog] - New struct `ServerSecurityAlertPolicyListResultPage`
info	[Changelog] - New field `MaxLargeStorageMB` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MinStorageMB` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MaxBackupRetentionDays` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MinBackupRetentionDays` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MaxStorageMB` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MinLargeStorageMB` in struct `PerformanceTierProperties`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 57 additive change(s).
info	[Changelog]

️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 0c90247. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/postgresql/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.PostgreSQL [View full logs] [Release SDK Changes]
- Microsoft.Azure.Management.PostgreSQL.0.9.5-preview.nupkg
- Microsoft.Azure.Management.PostgreSQL.0.9.5-preview.snupkg

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 0c90247. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-02-01 09:16:30 INFO [VERSION][Found] current version "com.azure.resourcemanager:azure-resourcemanager-postgresql;1.0.0-beta.1;1.0.0-beta.2"
cmderr	[generate.py] 2021-02-01 09:16:30 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.2"
cmderr	[generate.py] 2021-02-01 09:16:30 INFO autorest --version=3.0.6350 --use=@autorest/java@4.0.11 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/postgresql/azure-resourcemanager-postgresql --java.namespace=com.azure.resourcemanager.postgresql   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/postgresql/resource-manager/readme.md
cmderr	[generate.py] 2021-02-01 09:17:12 INFO [CI][Skip] ci.yml already has module azure-resourcemanager-postgresql
cmderr	[generate.py] 2021-02-01 09:17:12 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-02-01 09:17:12 INFO [POM][Skip] pom already has module azure-resourcemanager-postgresql
cmderr	[generate.py] 2021-02-01 09:17:12 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-02-01 09:17:12 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-02-01 09:17:12 INFO [POM][Skip] pom already has module sdk/postgresql
cmderr	[generate.py] 2021-02-01 09:17:12 INFO [POM][Success] Write to root pom
cmderr	[generate.py] WARNING: An illegal reflective access operation has occurred
cmderr	[generate.py] WARNING: Illegal reflective access by org.codehaus.groovy.reflection.ReflectionUtils (file:/home/vsts/.m2/repository/org/codehaus/groovy/groovy/3.0.0-beta-2/groovy-3.0.0-beta-2-indy.jar) to method java.util.Collections$UnmodifiableCollection.toString()
cmderr	[generate.py] WARNING: Please consider reporting this to the maintainers of org.codehaus.groovy.reflection.ReflectionUtils
cmderr	[generate.py] WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
cmderr	[generate.py] WARNING: All illegal access operations will be denied in a future release

️✔️azure-resourcemanager-postgresql [View full logs] [Release SDK Changes]

cmderr	[Inst] 2021-02-01 09:19:40 DEBUG Got artifact_id: azure-resourcemanager-postgresql
cmderr	[Inst] 2021-02-01 09:19:40 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-02-01 09:19:40 DEBUG Got artifact: azure-resourcemanager-postgresql-1.0.0-beta.2.jar
cmderr	[Inst] 2021-02-01 09:19:40 DEBUG Match jar package: azure-resourcemanager-postgresql-1.0.0-beta.2.jar
cmderr	[Inst] 2021-02-01 09:19:40 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/12529/azure-sdk-for-java/azure-resourcemanager-postgresql/azure-resourcemanager-postgresql-1.0.0-beta.2.jar\" -o azure-resourcemanager-postgresql-1.0.0-beta.2.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-postgresql -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-postgresql-1.0.0-beta.2.jar -Dpackaging=jar -DgeneratePom=true
```"}

️⚠️ azure-sdk-for-python warning [Detail]

⚠️Warning [Logs]Release - Generate from 0c90247. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
cmderr	[automation_init.sh]   Failed building wheel for ConfigArgParse
cmderr	[automation_init.sh]   Failed building wheel for yarl
cmderr	[automation_init.sh]   Failed building wheel for wrapt
cmderr	[automation_init.sh]   Failed building wheel for multidict
cmderr	[automation_init.sh] Cannot uninstall requirement azure-nspkg, not installed
cmderr	[automation_init.sh] Command '['/home/vsts/work/1/s/azure-sdk-for-python_tmp/venv-sdk/bin/python', '-m', 'pip', 'uninstall', '-y', 'azure-nspkg']' returned non-zero exit status 1.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️azure-mgmt-rdbms [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model LogFile has a new parameter log_file_type
info	[Changelog]   - Model Server has a new parameter server_tags
info	[Changelog]   - Added operation PrivateEndpointConnectionsOperations.update_tags
info	[Changelog]   - Added operation PrivateEndpointConnectionsOperations.create_or_update
info	[Changelog]   - Added operation PrivateEndpointConnectionsOperations.delete
info	[Changelog]   - Added operation VirtualNetworkRulesOperations.create_or_update
info	[Changelog]   - Added operation VirtualNetworkRulesOperations.delete
info	[Changelog]   - Added operation ConfigurationsOperations.update
info	[Changelog]   - Added operation ServerKeysOperations.create_or_update
info	[Changelog]   - Added operation ServerKeysOperations.delete
info	[Changelog]   - Added operation FirewallRulesOperations.create_or_update
info	[Changelog]   - Added operation FirewallRulesOperations.delete
info	[Changelog]   - Added operation ServerSecurityAlertPoliciesOperations.list_by_server
info	[Changelog]   - Added operation ServerSecurityAlertPoliciesOperations.create_or_update
info	[Changelog]   - Added operation MariaDBManagementClientOperationsMixin.create_recommended_action_session
info	[Changelog]   - Added operation MySQLManagementClientOperationsMixin.create_recommended_action_session
info	[Changelog]   - Added operation ServerAdministratorsOperations.create_or_update
info	[Changelog]   - Added operation ServerAdministratorsOperations.delete
info	[Changelog]   - Added operation DatabasesOperations.create
info	[Changelog]   - Added operation DatabasesOperations.delete
info	[Changelog]   - Added operation ServersOperations.start
info	[Changelog]   - Added operation ServersOperations.update
info	[Changelog]   - Added operation ServersOperations.stop
info	[Changelog]   - Added operation ServersOperations.delete
info	[Changelog]   - Added operation ServersOperations.restart
info	[Changelog]   - Added operation ServersOperations.create
info	[Changelog]   - Added operation group RecoverableServersOperations
info	[Changelog]   - Added operation group ServerBasedPerformanceTierOperations
info	[Changelog]   - Added operation group ServerParametersOperations
info	[Changelog]
info	[Changelog] **Breaking changes**
info	[Changelog]
info	[Changelog]   - Parameter virtual_network_subnet_id of model VirtualNetworkRule is now required
info	[Changelog]   - Parameter administrator_type of model ServerAdministratorResource is now required
info	[Changelog]   - Parameter login of model ServerAdministratorResource is now required
info	[Changelog]   - Parameter tenant_id of model ServerAdministratorResource is now required
info	[Changelog]   - Parameter sid of model ServerAdministratorResource is now required
info	[Changelog]   - Parameter server_key_type of model ServerKey is now required
info	[Changelog]   - Parameter state of model ServerSecurityAlertPolicy is now required
info	[Changelog]   - Operation WaitStatisticsOperations.list_by_server has a new signature
info	[Changelog]   - Operation WaitStatisticsOperations.get has a new signature
info	[Changelog]   - Operation VirtualNetworkRulesOperations.list_by_server has a new signature
info	[Changelog]   - Operation VirtualNetworkRulesOperations.get has a new signature
info	[Changelog]   - Operation TopQueryStatisticsOperations.list_by_server has a new signature
info	[Changelog]   - Operation TopQueryStatisticsOperations.get has a new signature
info	[Changelog]   - Operation ServerKeysOperations.list has a new signature
info	[Changelog]   - Operation ServerKeysOperations.get has a new signature
info	[Changelog]   - Operation ReplicasOperations.list_by_server has a new signature
info	[Changelog]   - Operation RecommendedActionsOperations.list_by_server has a new signature
info	[Changelog]   - Operation RecommendedActionsOperations.get has a new signature
info	[Changelog]   - Operation QueryTextsOperations.list_by_server has a new signature
info	[Changelog]   - Operation QueryTextsOperations.get has a new signature
info	[Changelog]   - Operation PrivateLinkResourcesOperations.list_by_server has a new signature
info	[Changelog]   - Operation PrivateLinkResourcesOperations.get has a new signature
info	[Changelog]   - Operation PrivateEndpointConnectionsOperations.list_by_server has a new signature
info	[Changelog]   - Operation PrivateEndpointConnectionsOperations.get has a new signature
info	[Changelog]   - Operation LogFilesOperations.list_by_server has a new signature
info	[Changelog]   - Operation LocationBasedRecommendedActionSessionsResultOperations.list has a new signature
info	[Changelog]   - Operation LocationBasedRecommendedActionSessionsOperationStatusOperations.get has a new signature
info	[Changelog]   - Operation LocationBasedPerformanceTierOperations.list has a new signature
info	[Changelog]   - Operation LocationBasedCapabilitiesOperations.execute has a new signature
info	[Changelog]   - Operation FirewallRulesOperations.list_by_server has a new signature
info	[Changelog]   - Operation FirewallRulesOperations.get has a new signature
info	[Changelog]   - Operation ConfigurationsOperations.list_by_server has a new signature
info	[Changelog]   - Operation ConfigurationsOperations.get has a new signature
info	[Changelog]   - Operation AdvisorsOperations.list_by_server has a new signature
info	[Changelog]   - Operation AdvisorsOperations.get has a new signature
info	[Changelog]   - Model LogFile no longer has parameter type_properties_type
info	[Changelog]   - Model ConfigurationListResult no longer has parameter next_link
info	[Changelog]   - Model Server no longer has parameter tags_properties_tags
info	[Changelog]   - Operation CheckVirtualNetworkSubnetUsageOperations.execute has a new signature
info	[Changelog]   - Operation VirtualNetworkSubnetUsageOperations.execute has a new signature
info	[Changelog]   - Operation CheckNameAvailabilityOperations.execute has a new signature
info	[Changelog]   - Operation Operations.list has a new signature
info	[Changelog]   - Model PerformanceTierProperties has a new signature
info	[Changelog]   - Removed operation PrivateEndpointConnectionsOperations.begin_create_or_update
info	[Changelog]   - Removed operation PrivateEndpointConnectionsOperations.begin_update_tags
info	[Changelog]   - Removed operation PrivateEndpointConnectionsOperations.begin_delete
info	[Changelog]   - Removed operation VirtualNetworkRulesOperations.begin_create_or_update
info	[Changelog]   - Removed operation VirtualNetworkRulesOperations.begin_delete
info	[Changelog]   - Removed operation ConfigurationsOperations.begin_update
info	[Changelog]   - Removed operation ServerKeysOperations.begin_create_or_update
info	[Changelog]   - Removed operation ServerKeysOperations.begin_delete
info	[Changelog]   - Removed operation FirewallRulesOperations.begin_create_or_update
info	[Changelog]   - Removed operation FirewallRulesOperations.begin_delete
info	[Changelog]   - Removed operation ServerSecurityAlertPoliciesOperations.begin_create_or_update
info	[Changelog]   - Removed operation MariaDBManagementClientOperationsMixin.begin_create_recommended_action_session
info	[Changelog]   - Removed operation MySQLManagementClientOperationsMixin.begin_create_recommended_action_session
info	[Changelog]   - Removed operation ServerAdministratorsOperations.begin_create_or_update
info	[Changelog]   - Removed operation ServerAdministratorsOperations.begin_delete
info	[Changelog]   - Removed operation DatabasesOperations.begin_create_or_update
info	[Changelog]   - Removed operation DatabasesOperations.begin_delete
info	[Changelog]   - Removed operation ServersOperations.begin_delete
info	[Changelog]   - Removed operation ServersOperations.begin_start
info	[Changelog]   - Removed operation ServersOperations.begin_stop
info	[Changelog]   - Removed operation ServersOperations.begin_restart
info	[Changelog]   - Removed operation ServersOperations.begin_create
info	[Changelog]   - Removed operation ServersOperations.begin_update

️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 0c90247. Schema Automation 14.0.0

warn	Skip initScript due to not configured
command	npx n 12
command	autorest --use=@autorest/azureresourceschema@3.0.92 --version=3.0.6369 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/postgresql/resource-manager/readme.md

️✔️postgresql [View full logs] [Release Schema Changes]

cmderr	[resource-manager] node-pre-gyp
cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
cmderr	[resource-manager] WARN template-schema-validation-tools@1.0.0 No repository field.
cmderr	[resource-manager]  SKIPPING OPTIONAL DEPENDENCY: fsevents@2.1.3 (node_modules/fsevents):
cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.3: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2021-01-20T23:14:56Z

Hi @dsgouda, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

Task	How to fix	Priority	Support (Microsoft alias)
Avocado	Fix-Avocado	High	ruowan
Semantic validation	Fix-SemanticValidation-Error	High	raychen, jianyxi
Model validation	Fix-ModelValidation-Error	High	raychen,jianyxi
LintDiff	Fix-LintDiff	high	jianyxi, ruoxuan

If you need further help, please feedback via swagger feedback."

openapi-workflow-bot · 2021-01-21T01:42:22Z

NewApiVersionRequired reason:

A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support.

EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.

openapi-workflow-bot · 2021-01-21T01:53:56Z

Hi @dsgouda, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

openapi-workflow-bot · 2021-01-25T02:32:55Z

Hi, @dsgouda your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). cc @jianyexi

...l/resource-manager/Microsoft.DBforPostgreSQL/stable/2018-06-01/QueryPerformanceInsights.json

...resource-manager/Microsoft.DBforPostgreSQL/stable/2018-06-01/examples/WaitStatisticsGet.json

...l/resource-manager/Microsoft.DBforPostgreSQL/stable/2018-06-01/QueryPerformanceInsights.json

...resource-manager/Microsoft.DBforPostgreSQL/stable/2018-06-01/examples/WaitStatisticsGet.json

...manager/Microsoft.DBforPostgreSQL/stable/2018-06-01/examples/WaitStatisticsListByServer.json

pilor · 2021-01-28T22:04:04Z

...ger/Microsoft.DBforPostgreSQL/stable/2018-06-01/examples/TopQueryStatisticsListByServer.json

+      "body": {
+        "value": [
+          {
+            "id": "/subscriptions/ffffffff-ffff-ffff-ffff-ffffffffffff/resourceGroups/testResourceGroupName/providers/Microsoft.DBforPostgreSQL/servers/testServerName/queryStatistic/66-636923268000000000-636923277000000000-avg-duration",


these are "topQueryStatistics", not "queryStatistic"

The resource type being returned is a queryStatistic, topQueryStatistics is an aggregate over the querystatistics

If a user requests a topQueryStatistics resource type they need to get that back. This will result in s360 violations on your RP. See https://armwiki.azurewebsites.net/api_contracts/RPCstrongvalidation.html?q=validation

Could you suggest some workaround here, this is an APi in production for the last 2 years and it has always returned queryStatistics as the response type. The idea was to return the top from the list of querystatistics.
@ssen-msft FYI

Please mark it down on your end to fix in the next api-version

Noted, will create a workitem at our end

...urce-manager/Microsoft.DBforPostgreSQL/stable/2018-06-01/examples/TopQueryStatisticsGet.json

dsgouda · 2021-01-29T22:53:02Z

@jianyexi please merge the PR

* Fixing violations * CI check fixes * Addressed PR comments

dsgouda added 2 commits January 20, 2021 15:04

Fixing violations

d104de3

Merge branch 'pgml' of https://github.com/dsgouda/azure-rest-api-specs …

83031a4

…into pgml

openapi-assignment-bot bot assigned jianyexi Jan 20, 2021

openapi-pipeline-app bot added the CI-FixRequiredOnFailure label Jan 20, 2021

This was referenced Jan 20, 2021

[AutoPR @azure/arm-postgresql] DBForPostgreSQL fixing s360 violations AzureSDKAutomation/azure-sdk-for-js#3287

Closed

[AutoPR azure-mgmt-rdbms] DBForPostgreSQL fixing s360 violations AzureSDKAutomation/azure-sdk-for-python#3806

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Python label Jan 20, 2021

openapi-pipeline-app bot added CI-FixRequiredOnFailure and removed CI-FixRequiredOnFailure labels Jan 21, 2021

dsgouda force-pushed the pgml branch from 31c7c6e to bfa76b6 Compare January 21, 2021 01:39

openapi-pipeline-app bot added CI-FixRequiredOnFailure NewApiVersionRequired and removed CI-FixRequiredOnFailure labels Jan 21, 2021

openapi-pipeline-app bot added BreakingChangeReviewRequired and removed CI-FixRequiredOnFailure labels Jan 21, 2021

JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Jan 24, 2021

JeffreyRichter approved these changes Jan 24, 2021

View reviewed changes

openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 25, 2021

CI check fixes

e6da4a3

dsgouda force-pushed the pgml branch from c54863f to e6da4a3 Compare January 27, 2021 14:59

openapi-pipeline-app bot removed the BreakingChangeReviewRequired label Jan 27, 2021

pilor self-requested a review January 28, 2021 17:32

pilor added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Jan 28, 2021

pilor reviewed Jan 28, 2021

View reviewed changes

dsgouda force-pushed the pgml branch from 89c4877 to 6d8911e Compare January 29, 2021 02:53

Addressed PR comments

1030656

dsgouda force-pushed the pgml branch from 6d8911e to 1030656 Compare January 29, 2021 04:25

pilor added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jan 29, 2021

jianyexi approved these changes Feb 1, 2021

View reviewed changes

jianyexi merged commit 0c90247 into Azure:master Feb 1, 2021

mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021

DBForPostgreSQL fixing s360 violations (Azure#12529)

d6195da

* Fixing violations * CI check fixes * Addressed PR comments

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DBForPostgreSQL fixing s360 violations #12529

DBForPostgreSQL fixing s360 violations #12529

dsgouda commented Jan 20, 2021 •

edited by jianyexi

Loading

openapi-workflow-bot bot commented Jan 20, 2021

openapi-pipeline-app bot commented Jan 20, 2021 •

edited

Loading

openapi-pipeline-app bot commented Jan 20, 2021 •

edited

Loading

openapi-workflow-bot bot commented Jan 20, 2021

openapi-workflow-bot bot commented Jan 21, 2021

openapi-workflow-bot bot commented Jan 21, 2021

openapi-workflow-bot bot commented Jan 25, 2021

pilor Jan 28, 2021

dsgouda Jan 29, 2021 •

edited

Loading

pilor Jan 29, 2021

dsgouda Jan 29, 2021 •

edited

Loading

pilor Jan 29, 2021

dsgouda Jan 29, 2021

dsgouda commented Jan 29, 2021

DBForPostgreSQL fixing s360 violations #12529

DBForPostgreSQL fixing s360 violations #12529

Conversation

dsgouda commented Jan 20, 2021 • edited by jianyexi Loading

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Jan 20, 2021

openapi-pipeline-app bot commented Jan 20, 2021 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Jan 20, 2021 • edited Loading

Swagger Generation Artifacts

openapi-workflow-bot bot commented Jan 20, 2021

openapi-workflow-bot bot commented Jan 21, 2021

openapi-workflow-bot bot commented Jan 21, 2021

openapi-workflow-bot bot commented Jan 25, 2021

pilor Jan 28, 2021

Choose a reason for hiding this comment

dsgouda Jan 29, 2021 • edited Loading

Choose a reason for hiding this comment

pilor Jan 29, 2021

Choose a reason for hiding this comment

dsgouda Jan 29, 2021 • edited Loading

Choose a reason for hiding this comment

pilor Jan 29, 2021

Choose a reason for hiding this comment

dsgouda Jan 29, 2021

Choose a reason for hiding this comment

dsgouda commented Jan 29, 2021

dsgouda commented Jan 20, 2021 •

edited by jianyexi

Loading

openapi-pipeline-app bot commented Jan 20, 2021 •

edited

Loading

openapi-pipeline-app bot commented Jan 20, 2021 •

edited

Loading

dsgouda Jan 29, 2021 •

edited

Loading

dsgouda Jan 29, 2021 •

edited

Loading