Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Review request for Microsoft.StorageCache to add version stable/2020-10-01 #12572

Conversation

brpanask
Copy link
Contributor

@brpanask brpanask commented Jan 22, 2021

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @brpanask Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 22, 2021

    Swagger Validation Report

    ️❌BreakingChange: 8 Errors, 0 Warnings failed [Detail]

    Rule Message
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.StorageCache/stable/2020-10-01/storagecache.json#L1344:13
    Old: Microsoft.StorageCache/stable/2020-10-01/storagecache.json#L1345:13
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.StorageCache/stable/2020-10-01/storagecache.json#L1449:9
    Old: Microsoft.StorageCache/stable/2020-10-01/storagecache.json#L1449:9
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'extendedGroupsEnabled' renamed or removed?
    New: Microsoft.StorageCache/stable/2020-10-01/storagecache.json#L1571:7
    Old: Microsoft.StorageCache/stable/2020-10-01/storagecache.json#L1570:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'ldapBaseDn' renamed or removed?
    New: Microsoft.StorageCache/stable/2020-10-01/storagecache.json#L1571:7
    Old: Microsoft.StorageCache/stable/2020-10-01/storagecache.json#L1570:7
    1041 - AddedPropertyInResponse The new version has a new property 'properties' in response that was not found in the old version.
    New: Microsoft.StorageCache/stable/2020-03-01/storagecache.json#L1200:7
    Old: Microsoft.StorageCache/stable/2020-03-01/storagecache.json#L1200:7
    1041 - AddedPropertyInResponse The new version has a new property 'properties' in response that was not found in the old version.
    New: Microsoft.StorageCache/stable/2020-10-01/storagecache.json#L1246:7
    Old: Microsoft.StorageCache/stable/2020-10-01/storagecache.json#L1264:7
    1041 - AddedPropertyInResponse The new version has a new property 'extendedGroups' in response that was not found in the old version.
    New: Microsoft.StorageCache/stable/2020-10-01/storagecache.json#L1571:7
    Old: Microsoft.StorageCache/stable/2020-10-01/storagecache.json#L1570:7
    1041 - AddedPropertyInResponse The new version has a new property 'ldapBaseDN' in response that was not found in the old version.
    New: Microsoft.StorageCache/stable/2020-10-01/storagecache.json#L1571:7
    Old: Microsoft.StorageCache/stable/2020-10-01/storagecache.json#L1570:7
    ️⚠️LintDiff: 1 Warnings warning [Detail]

    Rule Message
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: extendedGroups
    New: Microsoft.StorageCache/stable/2020-10-01/storagecache.json#L1572
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 22, 2021

    Swagger Generation Artifacts

    ️⚠️ azure-sdk-for-python warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from d5479b5. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
      cmderr	[automation_init.sh]   Failed building wheel for ConfigArgParse
      cmderr	[automation_init.sh]   Failed building wheel for yarl
      cmderr	[automation_init.sh]   Failed building wheel for wrapt
      cmderr	[automation_init.sh]   Failed building wheel for multidict
      cmderr	[automation_init.sh] Cannot uninstall requirement azure-nspkg, not installed
      cmderr	[automation_init.sh] Command '['/home/vsts/work/1/s/azure-sdk-for-python_tmp/venv-sdk/bin/python', '-m', 'pip', 'uninstall', '-y', 'azure-nspkg']' returned non-zero exit status 1.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️azure-mgmt-storagecache [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Model StorageTarget has a new parameter system_data
      info	[Changelog]   - Model StorageTarget has a new parameter location
      info	[Changelog]   - Model ApiOperationDisplay has a new parameter description
      info	[Changelog]   - Model NamespaceJunction has a new parameter nfs_access_policy
      info	[Changelog]   - Model ApiOperation has a new parameter service_specification
      info	[Changelog]   - Model ApiOperation has a new parameter is_data_action
      info	[Changelog]   - Model ApiOperation has a new parameter origin
      info	[Changelog]   - Model Cache has a new parameter system_data
      info	[Changelog]   - Model Cache has a new parameter directory_services_settings
      info	[Changelog]   - Model StorageTargetResource has a new parameter system_data
      info	[Changelog]   - Model StorageTargetResource has a new parameter location
      info	[Changelog]   - Added operation CachesOperations.debug_info
      info	[Changelog]   - Added operation group AscOperations
      info	[Changelog]
      info	[Changelog] **Breaking changes**
      info	[Changelog]
      info	[Changelog]   - Parameter target_type of model Nfs3TargetProperties is now required
      info	[Changelog]   - Parameter target_type of model UnknownTargetProperties is now required
      info	[Changelog]   - Parameter target_type of model StorageTargetProperties is now required
      info	[Changelog]   - Parameter target_type of model ClfsTargetProperties is now required
      info	[Changelog]   - Model Nfs3TargetProperties no longer has parameter target_base_type
      info	[Changelog]   - Model StorageTarget no longer has parameter target_type
      info	[Changelog]   - Model UnknownTargetProperties no longer has parameter target_base_type
      info	[Changelog]   - Model StorageTargetProperties no longer has parameter target_base_type
      info	[Changelog]   - Model ClfsTargetProperties no longer has parameter target_base_type
      info	[Changelog]   - Model CacheSecuritySettings has a new signature
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from d5479b5. SDK Automation 14.0.0
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️storagecache/mgmt/2020-10-01/storagecache [View full logs]  [Release SDK Changes]
      info	[Changelog] This is a new package
    • ️✔️storagecache/mgmt/2020-03-01/storagecache [View full logs]  [Release SDK Changes]
      info	[Changelog] ### New Content
      info	[Changelog]
      info	[Changelog] - New function `AscOperationProperties.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New function `*AscOperation.UnmarshalJSON([]byte) error`
      info	[Changelog] - New function `AscOperation.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New struct `AscOperationProperties`
      info	[Changelog] - New anonymous field `*AscOperationProperties` in struct `AscOperation`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 6 additive change(s).
      info	[Changelog]
    • ️✔️storagecache/mgmt/2019-11-01/storagecache [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️preview/storagecache/mgmt/2019-08-01-preview/storagecache [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    ️️✔️ azure-cli-extensions succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from d5479b5. Azure CLI Automation 14.0.0
      warn	Skip initScript due to not configured
      command	npx n 12
      command	python3 -m venv venv
      command	pip install --upgrade setuptools wheel pip
      command	pip install pathlib jinja2 msrestazure
      command	autorest --az --use=@autorest/az@latest --version=3.0.6271 --clear-output-folder=true --azure-cli-extension-folder=/home/vsts/work/1/s/azure-cli-extensions ../azure-rest-api-specs/specification/storagecache/resource-manager/readme.md
      cmdout	[Autorest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'Nfs3TargetProperties' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
      cmdout	[Autorest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'ClfsTargetProperties' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
      cmdout	[Autorest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'UnknownTargetProperties' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ApiOperation-display' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'AscOperationProperties-output' with an undefined type and additionalProperties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'CacheIdentity' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'CacheNetworkSettings' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'CacheEncryptionSettings' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'CacheSecuritySettings' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'CacheActiveDirectorySettings-credentials' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'CacheUsernameDownloadSettings-credentials' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'NfsAccessPolicy' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'NfsAccessRule' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'KeyVaultKeyReference' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'KeyVaultKeyReference-sourceVault' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'CacheHealth' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'StorageTargetResource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'Nfs3Target' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ClfsTarget' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'UnknownTarget' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'Restriction' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ResourceSkusResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/CheckDuplicateSchemas): Checking for duplicate schemas, this could take a (long) while.  Run with --verbose for more detail.
      cmdout	[Autorest] WARNING (): Operation Update has already existed in group! Skip split!
      cmdout	[Autorest] WARNING (): cli.auto-parameter-hidden is not true, skip visibility cleaner
      cmderr	[Autorest] BELOW TEST SCENARIO SECTION CAN BE USED IN readme.cli.md
      cmderr	[Autorest] --------------------------------------------------------
      cmderr	[Autorest]   test-scenario:
      cmderr	[Autorest]     - name: /AscOperations/get/AscOperations_Get
      cmderr	[Autorest]     - name: /Caches/put/Caches_CreateOrUpdate
      cmderr	[Autorest]     - name: /Caches/put/Caches_CreateOrUpdate_ldap_only
      cmderr	[Autorest]     - name: /Caches/get/Caches_Get
      cmderr	[Autorest]     - name: /Caches/get/Caches_List
      cmderr	[Autorest]     - name: /Caches/get/Caches_ListByResourceGroup
      cmderr	[Autorest]     - name: /Caches/patch/Caches_Update
      cmderr	[Autorest]     - name: /Caches/patch/Caches_Update_ldap_only
      cmderr	[Autorest]     - name: /Caches/post/Caches_DebugInfo
      cmderr	[Autorest]     - name: /Caches/post/Caches_Flush
      cmderr	[Autorest]     - name: /Caches/post/Caches_Start
      cmderr	[Autorest]     - name: /Caches/post/Caches_Stop
      cmderr	[Autorest]     - name: /Caches/post/Caches_UpgradeFirmware
      cmderr	[Autorest]     - name: /Caches/delete/Caches_Delete
      cmderr	[Autorest]     - name: /Skus/get/Skus_List
      cmderr	[Autorest]     - name: /StorageTargets/put/StorageTargets_CreateOrUpdate
      cmderr	[Autorest]     - name: /StorageTargets/put/StorageTargets_CreateOrUpdate_NoJunctions
      cmderr	[Autorest]     - name: /StorageTargets/get/StorageTargets_Get
      cmderr	[Autorest]     - name: /StorageTargets/get/StorageTargets_List
      cmderr	[Autorest]     - name: /StorageTargets/delete/StorageTargets_Delete
      cmderr	[Autorest]     - name: /UsageModels/get/UsageModels_List
      cmderr	[Autorest] --------------------------------------------------------
      cmderr	[Autorest] fatal: not a git repository (or any of the parent directories): .git
      cmderr	[Autorest] /bin/sh: 1: cd: can't cd to home/vsts/work/1/s/azure-rest-api-specs
      cmderr	[Autorest] fatal: not a git repository (or any of the parent directories): .git
    • ️✔️storagecache [View full logs]  [Release Azure CLI Changes]
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from d5479b5. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      cmderr	[generate.py] 2021-01-29 09:29:41 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-storagecache"
      cmderr	[generate.py] 2021-01-29 09:29:41 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
      cmderr	[generate.py] 2021-01-29 09:29:41 INFO autorest --version=3.0.6350 --use=@autorest/java@4.0.11 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/storagecache/azure-resourcemanager-storagecache --java.namespace=com.azure.resourcemanager.storagecache   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/storagecache/resource-manager/readme.md
      cmderr	[generate.py] 2021-01-29 09:30:22 INFO [CI][Success] Write to ci.yml
      cmderr	[generate.py] 2021-01-29 09:30:22 INFO [POM][Process] dealing with pom.xml
      cmderr	[generate.py] 2021-01-29 09:30:22 INFO [POM][Skip] pom already has module azure-resourcemanager-storagecache
      cmderr	[generate.py] 2021-01-29 09:30:22 INFO [POM][Success] Write to pom.xml
      cmderr	[generate.py] 2021-01-29 09:30:22 INFO [POM][Process] dealing with root pom
      cmderr	[generate.py] 2021-01-29 09:30:22 INFO [POM][Success] Write to root pom
      cmderr	[generate.py] WARNING: An illegal reflective access operation has occurred
      cmderr	[generate.py] WARNING: Illegal reflective access by org.codehaus.groovy.reflection.ReflectionUtils (file:/home/vsts/.m2/repository/org/codehaus/groovy/groovy/3.0.0-beta-2/groovy-3.0.0-beta-2-indy.jar) to method java.util.Collections$UnmodifiableCollection.toString()
      cmderr	[generate.py] WARNING: Please consider reporting this to the maintainers of org.codehaus.groovy.reflection.ReflectionUtils
      cmderr	[generate.py] WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
      cmderr	[generate.py] WARNING: All illegal access operations will be denied in a future release
    • ️✔️azure-resourcemanager-storagecache [View full logs]  [Release SDK Changes]
      cmderr	[Inst] 2021-01-29 09:32:57 DEBUG Got artifact_id: azure-resourcemanager-storagecache
      cmderr	[Inst] 2021-01-29 09:32:57 DEBUG Got artifact: pom.xml
      cmderr	[Inst] 2021-01-29 09:32:57 DEBUG Got artifact: azure-resourcemanager-storagecache-1.0.0-beta.1.jar
      cmderr	[Inst] 2021-01-29 09:32:57 DEBUG Match jar package: azure-resourcemanager-storagecache-1.0.0-beta.1.jar
      cmderr	[Inst] 2021-01-29 09:32:57 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/12572/azure-sdk-for-java/azure-resourcemanager-storagecache/azure-resourcemanager-storagecache-1.0.0-beta.1.jar\" -o azure-resourcemanager-storagecache-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-storagecache -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-storagecache-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
      ```"}
    ️⚠️ azure-sdk-for-net warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from d5479b5. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-5.0
      command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/storagecache/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      warn	No file changes detected after generation
      warn	No package detected after generation
    ️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from d5479b5. Schema Automation 14.0.0
      warn	Skip initScript due to not configured
      command	npx n 12
      command	autorest --use=@autorest/azureresourceschema@3.0.92 --version=3.0.6369 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/storagecache/resource-manager/readme.md
    • ️✔️storagecache [View full logs]  [Release Schema Changes]
      cmderr	[resource-manager] node-pre-gyp
      cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
      cmderr	[resource-manager] npm WARN template-schema-validation-tools@1.0.0 No repository field.
      cmderr	[resource-manager] npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@2.1.3 (node_modules/fsevents):
      cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.3: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from d5479b5. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/storagecache/resource-manager/readme.md
    • ️✔️@azure/arm-storagecache [View full logs]  [Release SDK Changes]
      cmderr	[npmPack] loaded rollup.config.js with warnings
      cmderr	[npmPack] (!) Unused external imports
      cmderr	[npmPack] default imported from external module 'rollup' but never used
      cmderr	[npmPack] ./esm/storageCacheManagementClient.js → ./dist/arm-storagecache.js...
      cmderr	[npmPack] created ./dist/arm-storagecache.js in 420ms
    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi @brpanask, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

    …and correct spelling error found by spell checker.
    @brpanask
    Copy link
    Contributor Author

    @ruowan,
    Can you review or merge this now that all checks have passed.
    Thanks,
    Brian

    mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021
    …ion stable/2020-10-01 (Azure#12572)
    
    * Address s360 errors updating fields names to match the RP and add missing field.
    
    * Correct additional s360 errors while breaking changes window is open and correct spelling error found by spell checker.
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 CI-BreakingChange-Python FixS360
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants