Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix readme Configuration Tags for sql #12596

Merged
merged 1 commit into from
Jan 26, 2021
Merged

Conversation

ctaggart
Copy link
Contributor

This just fixes parsing of the readme. A Tag must be directly below a Configuration, Composite packages.

@ctaggart ctaggart requested a review from lirenhe as a code owner January 25, 2021 01:52
@openapi-workflow-bot
Copy link

Hi, @ctaggart Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 25, 2021

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️LintDiff succeeded [Detail] [Expand]
    Validation passes for LintDiff.
    ️⚠️Avocado: 1 Warnings warning [Detail]
    Rule Message
    ⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/sql/resource-manager/readme.md
    tag: specification/sql/resource-manager/readme.md#tag-package-composite-v4
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 25, 2021

    Swagger Generation Artifacts

    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 5e07d09. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-5.0
      command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/sql/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
    • ️✔️Microsoft.Azure.Management.Sql [View full logs]  [Release SDK Changes]
    ️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 5e07d09. Schema Automation 14.0.0
      warn	Skip initScript due to not configured
      command	npx n 12
      command	autorest --use=@autorest/azureresourceschema@3.0.92 --version=3.0.6351 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/sql/resource-manager/readme.md
      cmdout	[Autorest] WARNING: Found duplicate definition for type Microsoft.Sql/servers/firewallRules in scope ResourceGroup
    • cmderr	[resource-manager] node-pre-gyp
      cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
      cmderr	[resource-manager]  WARN template-schema-validation-tools@1.0.0 No repository field.
      cmderr	[resource-manager]  optional SKIPPING OPTIONAL DEPENDENCY: fsevents@2.1.3 (node_modules/fsevents):
      cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.3: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
    ️⚠️ azure-sdk-for-python warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 5e07d09. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
      cmderr	[automation_init.sh]   Failed building wheel for ConfigArgParse
      cmderr	[automation_init.sh]   Failed building wheel for yarl
      cmderr	[automation_init.sh]   Failed building wheel for wrapt
      cmderr	[automation_init.sh]   Failed building wheel for multidict
      cmderr	[automation_init.sh] Cannot uninstall requirement azure-nspkg, not installed
      cmderr	[automation_init.sh] Command '['/home/vsts/work/1/s/azure-sdk-for-python_tmp/venv-sdk/bin/python', '-m', 'pip', 'uninstall', '-y', 'azure-nspkg']' returned non-zero exit status 1.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️azure-mgmt-sql [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Added operation ServersOperations.import_database
      info	[Changelog]   - Added operation group ImportExportOperations
      info	[Changelog]
      info	[Changelog] **Breaking changes**
      info	[Changelog]
      info	[Changelog]   - Removed operation DatabasesOperations.import_method
      info	[Changelog]   - Removed operation DatabasesOperations.import_database
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 5e07d09. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/sql/resource-manager/readme.md
    • ️✔️@azure/arm-sql [View full logs]  [Release SDK Changes]
      cmderr	[npmPack] loaded rollup.config.js with warnings
      cmderr	[npmPack] (!) Unused external imports
      cmderr	[npmPack] default imported from external module 'rollup' but never used
      cmderr	[npmPack] ./esm/sqlManagementClient.js → ./dist/arm-sql.js...
      cmderr	[npmPack] created ./dist/arm-sql.js in 2.1s
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 5e07d09. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      cmderr	[generate.py] 2021-01-26 09:34:10 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-sql-generated"
      cmderr	[generate.py] 2021-01-26 09:34:10 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
      cmderr	[generate.py] 2021-01-26 09:34:10 INFO autorest --version=3.0.6350 --use=@autorest/java@4.0.11 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/sql/azure-resourcemanager-sql-generated --java.namespace=com.azure.resourcemanager.sql.generated   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/sql/resource-manager/readme.md
      cmderr	[generate.py] 2021-01-26 09:37:25 INFO [CI][Success] Write to ci.yml
      cmderr	[generate.py] 2021-01-26 09:37:25 INFO [POM][Process] dealing with pom.xml
      cmderr	[generate.py] 2021-01-26 09:37:25 INFO [POM][Skip] pom already has module azure-resourcemanager-sql-generated
      cmderr	[generate.py] 2021-01-26 09:37:25 INFO [POM][Success] Write to pom.xml
      cmderr	[generate.py] 2021-01-26 09:37:25 INFO [POM][Process] dealing with root pom
      cmderr	[generate.py] 2021-01-26 09:37:25 INFO [POM][Success] Write to root pom
      cmderr	[generate.py] WARNING: An illegal reflective access operation has occurred
      cmderr	[generate.py] WARNING: Illegal reflective access by org.codehaus.groovy.reflection.ReflectionUtils (file:/home/vsts/.m2/repository/org/codehaus/groovy/groovy/3.0.0-beta-2/groovy-3.0.0-beta-2-indy.jar) to method java.util.Collections$UnmodifiableCollection.toString()
      cmderr	[generate.py] WARNING: Please consider reporting this to the maintainers of org.codehaus.groovy.reflection.ReflectionUtils
      cmderr	[generate.py] WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
      cmderr	[generate.py] WARNING: All illegal access operations will be denied in a future release
    • ️✔️azure-resourcemanager-sql-generated [View full logs]  [Release SDK Changes]
      cmderr	[Inst] 2021-01-26 09:42:53 DEBUG Got artifact_id: azure-resourcemanager-sql-generated
      cmderr	[Inst] 2021-01-26 09:42:53 DEBUG Got artifact: pom.xml
      cmderr	[Inst] 2021-01-26 09:42:53 DEBUG Got artifact: azure-resourcemanager-sql-generated-1.0.0-beta.1-sources.jar
      cmderr	[Inst] 2021-01-26 09:42:53 DEBUG Got artifact: azure-resourcemanager-sql-generated-1.0.0-beta.1.jar
      cmderr	[Inst] 2021-01-26 09:42:53 DEBUG Match jar package: azure-resourcemanager-sql-generated-1.0.0-beta.1.jar
      cmderr	[Inst] 2021-01-26 09:42:53 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/12596/azure-sdk-for-java/azure-resourcemanager-sql-generated/azure-resourcemanager-sql-generated-1.0.0-beta.1.jar\" -o azure-resourcemanager-sql-generated-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-sql-generated -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-sql-generated-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
      ```"}
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 5e07d09. SDK Automation 14.0.0
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sql/mgmt/2014-04-01/sql [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️preview/sql/mgmt/v3.0/sql [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 20 items here, please refer to log for details.
      info	[Changelog] - New function `*TopQueriesListResultIterator.Next() error`
      info	[Changelog] - New function `ManagedInstancesClient.ListByManagedInstanceComplete(context.Context, string, string, *int32, string, string, string, QueryTimeGrainType, AggregationFunctionType, MetricType) (TopQueriesListResultIterator, error)`
      info	[Changelog] - New function `NewTopQueriesListResultPage(TopQueriesListResult, func(context.Context, TopQueriesListResult) (TopQueriesListResult, error)) TopQueriesListResultPage`
      info	[Changelog] - New function `PossibleQueryTimeGrainTypeValues() []QueryTimeGrainType`
      info	[Changelog] - New struct `ManagedInstancePecProperty`
      info	[Changelog] - New struct `ManagedInstancePrivateEndpointConnectionProperties`
      info	[Changelog] - New struct `ManagedInstancePrivateEndpointProperty`
      info	[Changelog] - New struct `QueryMetricInterval`
      info	[Changelog] - New struct `QueryMetricProperties`
      info	[Changelog] - New struct `QueryStatisticsProperties`
      info	[Changelog] - New struct `TopQueries`
      info	[Changelog] - New struct `TopQueriesListResult`
      info	[Changelog] - New struct `TopQueriesListResultIterator`
      info	[Changelog] - New struct `TopQueriesListResultPage`
      info	[Changelog] - New field `Identity` in struct `ManagedInstanceUpdate`
      info	[Changelog] - New field `PrivateEndpointConnections` in struct `ManagedInstanceProperties`
      info	[Changelog] - New field `ZoneRedundant` in struct `ManagedInstanceProperties`
      info	[Changelog]
      info	[Changelog] Total 20 breaking change(s), 70 additive change(s).
      info	[Changelog]
    • ️✔️preview/sql/mgmt/2018-06-01-preview/sql [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Const `None` type has been changed from `SensitivityLabelRank` to `IdentityType`
      info	[Changelog] - Const `Low` has been removed
      info	[Changelog] - Const `Medium` has been removed
      info	[Changelog] - Const `Critical` has been removed
      info	[Changelog] - Const `High` has been removed
      info	[Changelog]
      info	[Changelog] ### New Content
      info	[Changelog]
      info	[Changelog] - New const `UserAssigned`
      info	[Changelog] - New const `SensitivityLabelRankCritical`
      info	[Changelog] - New const `SensitivityLabelRankHigh`
      info	[Changelog] - New const `SensitivityLabelRankMedium`
      info	[Changelog] - New const `SensitivityLabelRankNone`
      info	[Changelog] - New const `SensitivityLabelRankLow`
      info	[Changelog]
      info	[Changelog] Total 5 breaking change(s), 6 additive change(s).
      info	[Changelog]
    • ️✔️preview/sql/mgmt/2017-10-01-preview/sql [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️preview/sql/mgmt/2017-03-01-preview/sql [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 20 items here, please refer to log for details.
      info	[Changelog] - Const `Total` has been removed
      info	[Changelog] - Const `Average` has been removed
      info	[Changelog]
      info	[Changelog] ### New Content
      info	[Changelog]
      info	[Changelog] - New const `PrimaryAggregationTypeMinimum`
      info	[Changelog] - New const `Percent`
      info	[Changelog] - New const `PrimaryAggregationTypeNone`
      info	[Changelog] - New const `PrimaryAggregationTypeMaximum`
      info	[Changelog] - New const `BytesPerSecond`
      info	[Changelog] - New const `Bytes`
      info	[Changelog] - New const `PrimaryAggregationTypeAverage`
      info	[Changelog] - New const `PrimaryAggregationTypeCount`
      info	[Changelog] - New const `PrimaryAggregationTypeTotal`
      info	[Changelog] - New const `CountPerSecond`
      info	[Changelog] - New const `UserAssigned`
      info	[Changelog] - New const `Seconds`
      info	[Changelog]
      info	[Changelog] Total 12 breaking change(s), 12 additive change(s).
      info	[Changelog]
    • ️✔️preview/sql/mgmt/2015-05-01-preview/sql [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 20 items here, please refer to log for details.
      info	[Changelog] - Const `UnitDefinitionTypePercent` has been removed
      info	[Changelog] - Const `UnitDefinitionTypeBytes` has been removed
      info	[Changelog]
      info	[Changelog] ### New Content
      info	[Changelog]
      info	[Changelog] - New const `PrimaryAggregationTypeNone`
      info	[Changelog] - New const `UserAssigned`
      info	[Changelog] - New const `PrimaryAggregationTypeMaximum`
      info	[Changelog] - New const `Bytes`
      info	[Changelog] - New const `BytesPerSecond`
      info	[Changelog] - New const `PrimaryAggregationTypeCount`
      info	[Changelog] - New const `PrimaryAggregationTypeTotal`
      info	[Changelog] - New const `CountPerSecond`
      info	[Changelog] - New const `Seconds`
      info	[Changelog] - New const `PrimaryAggregationTypeMinimum`
      info	[Changelog] - New const `Percent`
      info	[Changelog] - New const `PrimaryAggregationTypeAverage`
      info	[Changelog]
      info	[Changelog] Total 12 breaking change(s), 12 additive change(s).
      info	[Changelog]
    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]
    Posted by Swagger Pipeline | How to fix these errors?

    @akning-ms akning-ms merged commit 5e07d09 into Azure:master Jan 26, 2021
    @ctaggart ctaggart deleted the tags-sql branch January 26, 2021 21:30
    mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants