Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Review request for Microsoft.KeyVault to add version stable/2019-09-01 #12618

Merged
merged 5 commits into from
Feb 8, 2021
Merged

[Hub Generated] Review request for Microsoft.KeyVault to add version stable/2019-09-01 #12618

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3e6afd7
Add missing properties for KeyVault
jiacheng-L Jan 25, 2021
b86db27
Fix typo
jiacheng-L Jan 25, 2021
e4aef73
Fix typo
jiacheng-L Jan 25, 2021
77772e5
Add missing punctuation and space
jiacheng-L Jan 27, 2021
16664bc
Merge branch 'master' into dev-keyvault-Microsoft.KeyVault-2019-09-01…
jiacheng-L Feb 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions .../keyvault/resource-manager/Microsoft.KeyVault/stable/2019-09-01/examples/createVault.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,21 @@
"name": "standard"
},
"tenantId": "00000000-0000-0000-0000-000000000000",
"networkAcls": {
"bypass": "AzureServices",
"defaultAction": "Deny",
"ipRules": [
{
"value": ""
}
],
"virtualNetworkRules": [
{
"id": "",
"ignoreMissingVnetServiceEndpoint": false
}
]
},
"accessPolicies": [
{
"tenantId": "00000000-0000-0000-0000-000000000000",
Expand Down Expand Up @@ -136,6 +151,21 @@
}
}
],
"privateEndpointConnections": [
{
"id": "",
"properties": {
"provisioningState": "Succeeded",
"privateEndpoint": {
"id": ""
},
"privateLinkServiceConnectionState": {
"status": "Approved",
"actionsRequired": "None"
}
}
}
],
"enabledForDeployment": true,
"enabledForDiskEncryption": true,
"enabledForTemplateDeployment": true,
Expand Down
30 changes: 30 additions & 0 deletions ...yvault/resource-manager/Microsoft.KeyVault/stable/2019-09-01/examples/listOperations.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,36 @@
"displayName": "Audit Logs",
"blobDuration": "PT1H"
}
],
"metricSpecifications": [
{
"name": "ServiceApiHit",
"displayName": "",
"displayDescription": "",
"unit": "",
"aggregationType": "",
"supportedAggregationTypes": [
""
],
"supportedTimeGrainTypes": [
""
],
"lockAggregationType": "",
"dimensions": [
{
"name": "ActivityType",
"displayName": "",
"toBeExportedForShoebox": true
},
{
"name": "ActivityName",
"displayName": "",
"toBeExportedForShoebox": true
}
],
"fillGapWithZero": false,
"internalMetricName": "AuditEvent"
}
]
}
}
Expand Down
30 changes: 30 additions & 0 deletions .../keyvault/resource-manager/Microsoft.KeyVault/stable/2019-09-01/examples/updateVault.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,21 @@
"name": "standard"
},
"tenantId": "00000000-0000-0000-0000-000000000000",
"networkAcls": {
"bypass": "AzureServices",
"defaultAction": "Deny",
"ipRules": [
{
"value": ""
}
],
"virtualNetworkRules": [
{
"id": "",
"ignoreMissingVnetServiceEndpoint": false
}
]
},
"accessPolicies": [
{
"tenantId": "00000000-0000-0000-0000-000000000000",
Expand Down Expand Up @@ -135,6 +150,21 @@
}
}
],
"privateEndpointConnections": [
{
"id": "",
"properties": {
"provisioningState": "Succeeded",
"privateEndpoint": {
"id": ""
},
"privateLinkServiceConnectionState": {
"status": "Approved",
"actionsRequired": "None"
}
}
}
],
"enabledForDeployment": true,
"enabledForDiskEncryption": true,
"enabledForTemplateDeployment": true,
Expand Down
8 changes: 8 additions & 0 deletions specification/keyvault/resource-manager/Microsoft.KeyVault/stable/2019-09-01/keyvault.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1789,6 +1789,10 @@
"id": {
"type": "string",
"description": "Full resource id of a vnet subnet, such as '/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/virtualNetworks/test-vnet/subnets/subnet1'."
},
"ignoreMissingVnetServiceEndpoint": {
"type": "boolean",
"description": "Property to specify whether NRP will ignore the check if parent subnet has serviceEndpoints configured."
}
},
"required": [
Expand All @@ -1798,6 +1802,10 @@
},
"PrivateEndpointConnectionItem": {
"properties": {
"id": {
"type": "string",
"description": "Id of private endpoint connection."
},
"properties": {
"$ref": "#/definitions/PrivateEndpointConnectionProperties",
"x-ms-client-flatten": true,
Expand Down
82 changes: 82 additions & 0 deletions specification/keyvault/resource-manager/Microsoft.KeyVault/stable/2019-09-01/providers.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,13 @@
"items": {
"$ref": "#/definitions/LogSpecification"
}
},
"metricSpecifications": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you adding a new property to a GA'd version? This could cause problems with existing clients, including data loss for input-output models.

/cc @JeffreyRichter

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@heaths This property is reported by the S360 swagger correctness report, which is missing defined in swagger spec in the 2019-09-01 version, but it exists in traffic payload

"description": "Metric specifications of operation.",
"type": "array",
"items": {
"$ref": "#/definitions/MetricSpecification"
}
}
}
},
Expand All @@ -159,6 +166,81 @@
}
}
},
"MetricSpecification": {
"description": "Metric specification of operation.",
"properties": {
"name": {
"type": "string",
"description": "Name of metric specification."
},
"displayName": {
"type": "string",
"description": "Display name of Metric specification."
},
"displayDescription": {
"type": "string",
"description": "Display description of Metric specification."
},
"unit": {
"type": "string",
"description": "The metric unit. Possible values include: 'Bytes', 'Count', 'Milliseconds'."
},
"aggregationType": {
"type": "string",
"description": "The metric aggregation type. Possible values include: 'Average', 'Count', 'Total'."
},
"supportedAggregationTypes": {
"type": "array",
"description": "The supported aggregation types for the metrics.",
"items": {
"type": "string"
}
},
"supportedTimeGrainTypes": {
"type": "array",
"description": "The supported time grain types for the metrics.",
"items": {
"type": "string"
}
},
"lockAggregationType": {
"type": "string",
"description": "The metric lock aggregation type."
},
"dimensions": {
"type": "array",
"description": "The dimensions of metric",
"items": {
"$ref": "#/definitions/DimensionProperties"
}
},
"fillGapWithZero": {
"type": "boolean",
"description": "Property to specify whether to fill gap with zero."
},
"internalMetricName": {
"type": "string",
"description": "The internal metric name."
}
}
},
"DimensionProperties": {
"description": "Type of operation: get, read, delete, etc.",
"properties": {
"name": {
"type": "string",
"description": "Name of dimension."
},
"displayName": {
"type": "string",
"description": "Display name of dimension."
},
"toBeExportedForShoebox": {
"type": "boolean",
"description": "Property to specify whether the dimension should be exported for shoebox."
}
}
},
"CloudError": {
"description": "An error response from Key Vault resource provider",
"properties": {
Expand Down