Adding list library and custom library referred schema changed #12667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @navneet35 Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
ghost
added
the
customer-reported
Swagger Validation Report
|
| Rule | Message |
|---|---|
| 200/201 Responses of long running operations must have a schema definition for return type. OperationId: 'Library_Create', Response code: '200' Location: Microsoft.Synapse/preview/2019-06-01-preview/library.json#L244 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️❌[Staging] SDK Track2 Validation: 9 Errors, 374 Warnings failed [Detail]
Only 10 items are listed, please refer to log for more details.
- The following tags are being changed in this PR
| Rule | Message |
|---|---|
|
"readme":"synapse/resource-manager/readme.md", "tag":"package-2019-06-01-preview", "details":"Duplicate Schema named CloudError -- properties.error.$ref: undefined => "#/components/schemas/schemas:803" ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"synapse/resource-manager/readme.md", "tag":"package-2019-06-01-preview", "details":"Duplicate Schema named CloudErrorBody -- properties.details.$ref: undefined => "#/components/schemas/schemas:807" ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"synapse/resource-manager/readme.md", "tag":"package-2019-06-01-preview", "details":"Duplicate Schema named PrivateEndpointConnectionForPrivateLinkHubBasic -- properties.id.description: "identifier" =>, properties.id.readOnly: true =>, properties.id.$ref: undefined => "#/components/schemas/schemas:1097", properties.properties.description: "Properties of private endpoint connection for private link hub" =>, properties.properties.x-ms-client-flatten: true => ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"synapse/resource-manager/readme.md", "tag":"package-2019-06-01-preview", "details":"Error: Plugin prechecker reported failure." |
|
"readme":"synapse/resource-manager/readme.md", "tag":"package-2020-12-01", "details":"Duplicate Schema named PrivateEndpointConnectionForPrivateLinkHubBasic -- properties.id.description: "identifier" =>, properties.id.readOnly: true =>, properties.id.$ref: undefined => "#/components/schemas/schemas:1191", properties.properties.description: "Properties of private endpoint connection for private link hub" =>, properties.properties.x-ms-client-flatten: true => ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"synapse/resource-manager/readme.md", "tag":"package-2020-12-01", "details":"Error: Plugin prechecker reported failure." |
|
"readme":"synapse/data-plane/readme.md", "tag":"package-artifacts-2019-06-01-preview", "details":"Duplicate Schema named CloudError -- properties.error.$ref: undefined => "#/components/schemas/schemas:350" ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"synapse/data-plane/readme.md", "tag":"package-artifacts-2019-06-01-preview", "details":"Duplicate Schema named CloudErrorBody -- properties.details.$ref: undefined => "#/components/schemas/schemas:354" ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"synapse/data-plane/readme.md", "tag":"package-artifacts-2019-06-01-preview", "details":"Error: Plugin prechecker reported failure." |
| "readme":"synapse/resource-manager/readme.md", "tag":"package-2019-06-01-preview", "details":"The schema 'MetadataSyncConfig-properties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
|
Thank you for your contribution navneet35! We will review the pull request and get back to you soon. |
Swagger Generation Artifacts
|
|
Hi @navneet35, Your PR has some issues. Please fix the CI sequentially by following the order of
|
openapi-pipeline-app
bot
added
BreakingChangeReviewRequired
and removed
CI-FixRequiredOnFailure
labels
|
Hi @navneet35, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
This was referenced Jan 27, 2021
navneet35
force-pushed
the
navsi/lib_mgmt_stable
branch
from
4d8afca to
4808aea
Compare
This was referenced Jan 27, 2021
amoghnatu
reviewed
Jan 27, 2021
specification/synapse/resource-manager/Microsoft.Synapse/stable/2020-12-01/bigDataPool.json
Outdated
Show resolved
Hide resolved
navneet35
force-pushed
the
navsi/lib_mgmt_stable
branch
from
4808aea to
d9a1b20
Compare
navneet35
force-pushed
the
navsi/lib_mgmt_stable
branch
from
d9a1b20 to
58f78b7
Compare
openapi-pipeline-app
bot
added
CI-FixRequiredOnFailure
and removed
CI-BreakingChange-Go
CI-BreakingChange-Python
labels
navneet35
force-pushed
the
navsi/lib_mgmt_stable
branch
from
58f78b7 to
0edf76f
Compare
openapi-pipeline-app
bot
added
CI-FixRequiredOnFailure
and removed
CI-FixRequiredOnFailure
labels
navneet35
force-pushed
the
navsi/lib_mgmt_stable
branch
from
84a08d5 to
c158b5b
Compare
openapi-pipeline-app
bot
added
BreakingChangeReviewRequired
and removed
CI-FixRequiredOnFailure
labels
|
NewApiVersionRequired reason: |
navneet35
force-pushed
the
navsi/lib_mgmt_stable
branch
from
c158b5b to
2a34ffb
Compare
...synapse/data-plane/Microsoft.Synapse/preview/2019-06-01-preview/examples/Library_Append.json
Outdated
Show resolved
Hide resolved
specification/synapse/data-plane/Microsoft.Synapse/preview/2019-06-01-preview/library.json
Outdated
Show resolved
Hide resolved
specification/synapse/data-plane/Microsoft.Synapse/preview/2019-06-01-preview/library.json
Show resolved
Hide resolved
navneet35
force-pushed
the
navsi/lib_mgmt_stable
branch
from
2a34ffb to
c0a8220
Compare
|
@jonathandturner Since you are data-plane synapse PR assignee, could you help to review this PR? |
JeffreyRichter
approved these changes
Feb 5, 2021
JeffreyRichter
added
the
Approved-BreakingChange
navneet35
force-pushed
the
navsi/lib_mgmt_stable
branch
from
c0a8220 to
7c54151
Compare
ruowan
approved these changes
Feb 8, 2021
This was referenced Feb 8, 2021
[ReleasePR synapse] [Synapse] - Remove x-ms-azure-resource
Azure/azure-resource-manager-schemas#1315
Merged
mkarmark
pushed a commit
to mkarmark/azure-rest-api-specs
that referenced
this pull request
Jul 21, 2021
…#12667) * List Libraries in Workspace API specs * LibraryArtifacts changed to Libraries * create and append library api separated using x-ms-paths to resolve SDK issue * supressing R4009 systemData violation Co-authored-by: Navneet Singh <navsi@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.