Swagger correctness: Mark readonly properties #12810

anponnet · 2021-02-03T05:44:47Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No, no need to refresh for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable version with Breaking Change Validation errors
Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

…pecs into swaggercorrectreadonly

openapi-workflow-bot · 2021-02-03T05:44:51Z

Hi, @anponnet Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

openapi-pipeline-app · 2021-02-03T05:44:53Z

Swagger Validation Report

️❌BreakingChange: 8 Errors, 0 Warnings failed [Detail]

Compared Swaggers (Based on Oad v0.8.6)
- original: preview/2020-09-01-preview/databoxedge.json <---> new: preview/2020-09-01-preview/databoxedge.json
- original: stable/2020-09-01/databoxedge.json <---> new: stable/2020-09-01/databoxedge.json

Rule	Message
`❌` 1029 - ReadonlyPropertyChanged	The read only property has changed from 'false' to 'true'. New: Microsoft.DataBoxEdge/preview/2020-09-01-preview/databoxedge.json#L4628:9 Old: Microsoft.DataBoxEdge/preview/2020-09-01-preview/databoxedge.json#L4628:9
`❌` 1029 - ReadonlyPropertyChanged	The read only property has changed from 'false' to 'true'. New: Microsoft.DataBoxEdge/preview/2020-09-01-preview/databoxedge.json#L4796:9 Old: Microsoft.DataBoxEdge/preview/2020-09-01-preview/databoxedge.json#L4794:9
`❌` 1029 - ReadonlyPropertyChanged	The read only property has changed from 'false' to 'true'. New: Microsoft.DataBoxEdge/preview/2020-09-01-preview/databoxedge.json#L4801:9 Old: Microsoft.DataBoxEdge/preview/2020-09-01-preview/databoxedge.json#L4798:9
`❌` 1029 - ReadonlyPropertyChanged	The read only property has changed from 'false' to 'true'. New: Microsoft.DataBoxEdge/preview/2020-09-01-preview/databoxedge.json#L4818:9 Old: Microsoft.DataBoxEdge/preview/2020-09-01-preview/databoxedge.json#L4814:9
`❌` 1029 - ReadonlyPropertyChanged	The read only property has changed from 'false' to 'true'. New: Microsoft.DataBoxEdge/stable/2020-09-01/databoxedge.json#L4628:9 Old: Microsoft.DataBoxEdge/stable/2020-09-01/databoxedge.json#L4628:9
`❌` 1029 - ReadonlyPropertyChanged	The read only property has changed from 'false' to 'true'. New: Microsoft.DataBoxEdge/stable/2020-09-01/databoxedge.json#L4796:9 Old: Microsoft.DataBoxEdge/stable/2020-09-01/databoxedge.json#L4794:9
`❌` 1029 - ReadonlyPropertyChanged	The read only property has changed from 'false' to 'true'. New: Microsoft.DataBoxEdge/stable/2020-09-01/databoxedge.json#L4801:9 Old: Microsoft.DataBoxEdge/stable/2020-09-01/databoxedge.json#L4798:9
`❌` 1029 - ReadonlyPropertyChanged	The read only property has changed from 'false' to 'true'. New: Microsoft.DataBoxEdge/stable/2020-09-01/databoxedge.json#L4818:9 Old: Microsoft.DataBoxEdge/stable/2020-09-01/databoxedge.json#L4814:9

️️✔️LintDiff succeeded [Detail] [Expand]

Validation passes for LintDiff.

Linted configuring files (Based on source branch, openapi-validator v1.7.0 , classic-openapi-validator v1.1.5 )
- databoxedge/resource-manager/readme.md tag:package-2020-09-01-preview
- databoxedge/resource-manager/readme.md tag:package-2020-09-01
Linted configuring files (Based on target branch, openapi-validator v1.7.0 , classic-openapi-validator v1.1.5 )
- databoxedge/resource-manager/readme.md tag:package-2020-09-01-preview
- databoxedge/resource-manager/readme.md tag:package-2020-09-01

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2021-02-03T05:44:53Z

Swagger Generation Artifacts

️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from fbd2810. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/databoxedge/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.DataBoxEdge [View full logs] [Release SDK Changes]
- Microsoft.Azure.Management.DataBoxEdge.1.0.0.nupkg
- Microsoft.Azure.Management.DataBoxEdge.1.0.0.snupkg

️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from fbd2810. Schema Automation 14.0.0

warn	Skip initScript due to not configured
command	npx n 12
command	autorest --use=@autorest/azureresourceschema@3.0.92 --version=3.0.6369 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/databoxedge/resource-manager/readme.md

️✔️databoxedge [View full logs] [Release Schema Changes]

cmderr	[resource-manager] node-pre-gyp
cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
cmderr	[resource-manager] WARN template-schema-validation-tools@1.0.0 No repository field.
cmderr	[resource-manager] optional SKIPPING OPTIONAL DEPENDENCY: fsevents@2.1.3 (node_modules/fsevents):
cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.3: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

️⚠️ azure-sdk-for-python warning [Detail]

⚠️Warning [Logs]Release - Generate from fbd2810. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
cmderr	[automation_init.sh]   Failed building wheel for ConfigArgParse
cmderr	[automation_init.sh]   Failed building wheel for yarl
cmderr	[automation_init.sh]   Failed building wheel for wrapt
cmderr	[automation_init.sh]   Failed building wheel for multidict
cmderr	[automation_init.sh] Cannot uninstall requirement azure-nspkg, not installed
cmderr	[automation_init.sh] Command '['/home/vsts/work/1/s/azure-sdk-for-python_tmp/venv-sdk/bin/python', '-m', 'pip', 'uninstall', '-y', 'azure-nspkg']' returned non-zero exit status 1.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️azure-mgmt-databoxedge [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model Order has a new parameter shipment_type
info	[Changelog]   - Model StorageAccountCredential has a new parameter system_data
info	[Changelog]   - Model OrderStatus has a new parameter tracking_information
info	[Changelog]   - Model PeriodicTimerEventTrigger has a new parameter system_data
info	[Changelog]   - Model User has a new parameter system_data
info	[Changelog]   - Model Role has a new parameter system_data
info	[Changelog]   - Model DataBoxEdgeDeviceExtendedInfo has a new parameter channel_integrity_key_name
info	[Changelog]   - Model DataBoxEdgeDeviceExtendedInfo has a new parameter client_secret_store_id
info	[Changelog]   - Model DataBoxEdgeDeviceExtendedInfo has a new parameter client_secret_store_url
info	[Changelog]   - Model DataBoxEdgeDeviceExtendedInfo has a new parameter channel_integrity_key_version
info	[Changelog]   - Model Operation has a new parameter is_data_action
info	[Changelog]   - Model DataBoxEdgeSku has a new parameter shipment_types
info	[Changelog]   - Model DataBoxEdgeDevice has a new parameter edge_profile
info	[Changelog]   - Model DataBoxEdgeDevice has a new parameter system_data
info	[Changelog]   - Model DataBoxEdgeDevice has a new parameter resource_move_details
info	[Changelog]   - Model DataBoxEdgeDevice has a new parameter identity
info	[Changelog]   - Model DataBoxEdgeDevice has a new parameter kind
info	[Changelog]   - Model BandwidthSchedule has a new parameter system_data
info	[Changelog]   - Model IoTRole has a new parameter compute_resource
info	[Changelog]   - Model IoTRole has a new parameter system_data
info	[Changelog]   - Model StorageAccount has a new parameter system_data
info	[Changelog]   - Model Trigger has a new parameter system_data
info	[Changelog]   - Model DataBoxEdgeDevicePatch has a new parameter edge_profile
info	[Changelog]   - Model DataBoxEdgeDevicePatch has a new parameter identity
info	[Changelog]   - Model Container has a new parameter system_data
info	[Changelog]   - Model FileEventTrigger has a new parameter system_data
info	[Changelog]   - Model Alert has a new parameter system_data
info	[Changelog]   - Model Share has a new parameter system_data
info	[Changelog]   - Added operation OrdersOperations.list_dc_access_code
info	[Changelog]   - Added operation DevicesOperations.generate_certificate
info	[Changelog]   - Added operation DevicesOperations.update_extended_information
info	[Changelog]   - Added operation group AddonsOperations
info	[Changelog]   - Added operation group MonitoringConfigOperations
info	[Changelog]
info	[Changelog] **Breaking changes**
info	[Changelog]
info	[Changelog]   - Parameter data_policy of model StorageAccount is now required
info	[Changelog]   - Operation UsersOperations.list_by_data_box_edge_device has a new signature
info	[Changelog]   - Model SkuInformation no longer has parameter capabilities
info	[Changelog]   - Model SkuInformation no longer has parameter resource_type
info	[Changelog]   - Model SkuInformation no longer has parameter size
info	[Changelog]   - Model DataBoxEdgeSku no longer has parameter restrictions
info	[Changelog]   - Model ResourceTypeSku has a new signature

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from fbd2810. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/databoxedge/resource-manager/readme.md

️✔️@azure/arm-databoxedge [View full logs] [Release SDK Changes]

azure-arm-databoxedge-1.0.0.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/dataBoxEdgeManagementClient.js → ./dist/arm-databoxedge.js...
cmderr	[npmPack] created ./dist/arm-databoxedge.js in 544ms

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from fbd2810. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-02-03 08:11:01 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-databoxedge"
cmderr	[generate.py] 2021-02-03 08:11:01 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
cmderr	[generate.py] 2021-02-03 08:11:01 INFO autorest --version=3.0.6350 --use=@autorest/java@4.0.11 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/databoxedge/azure-resourcemanager-databoxedge --java.namespace=com.azure.resourcemanager.databoxedge   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/databoxedge/resource-manager/readme.md
cmderr	[generate.py] 2021-02-03 08:11:51 INFO [CI][Success] Write to ci.yml
cmderr	[generate.py] 2021-02-03 08:11:51 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-02-03 08:11:51 INFO [POM][Skip] pom already has module azure-resourcemanager-databoxedge
cmderr	[generate.py] 2021-02-03 08:11:51 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-02-03 08:11:51 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-02-03 08:11:51 INFO [POM][Success] Write to root pom
cmderr	[generate.py] WARNING: An illegal reflective access operation has occurred
cmderr	[generate.py] WARNING: Illegal reflective access by org.codehaus.groovy.reflection.ReflectionUtils (file:/home/vsts/.m2/repository/org/codehaus/groovy/groovy/3.0.0-beta-2/groovy-3.0.0-beta-2-indy.jar) to method java.util.Collections$UnmodifiableCollection.toString()
cmderr	[generate.py] WARNING: Please consider reporting this to the maintainers of org.codehaus.groovy.reflection.ReflectionUtils
cmderr	[generate.py] WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
cmderr	[generate.py] WARNING: All illegal access operations will be denied in a future release

️✔️azure-resourcemanager-databoxedge [View full logs] [Release SDK Changes]

cmderr	[Inst] 2021-02-03 08:15:25 DEBUG Got artifact_id: azure-resourcemanager-databoxedge
cmderr	[Inst] 2021-02-03 08:15:25 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-02-03 08:15:25 DEBUG Got artifact: azure-resourcemanager-databoxedge-1.0.0-beta.1-sources.jar
cmderr	[Inst] 2021-02-03 08:15:25 DEBUG Got artifact: azure-resourcemanager-databoxedge-1.0.0-beta.1.jar
cmderr	[Inst] 2021-02-03 08:15:25 DEBUG Match jar package: azure-resourcemanager-databoxedge-1.0.0-beta.1.jar
cmderr	[Inst] 2021-02-03 08:15:25 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/12810/azure-sdk-for-java/azure-resourcemanager-databoxedge/azure-resourcemanager-databoxedge-1.0.0-beta.1.jar\" -o azure-resourcemanager-databoxedge-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-databoxedge -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-databoxedge-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
```"}

️️✔️ azure-cli-extensions succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from fbd2810. Azure CLI Automation 14.0.0

warn	Skip initScript due to not configured
command	npx n 12
command	python3 -m venv venv
command	pip install --upgrade setuptools wheel pip
command	pip install pathlib jinja2 msrestazure
command	autorest --az --use=@autorest/az@latest --version=3.0.6271 --clear-output-folder=true --azure-cli-extension-folder=/home/vsts/work/1/s/azure-cli-extensions ../azure-rest-api-specs/specification/databoxedge/resource-manager/readme.md
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'CloudError' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'CloudErrorBody' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/CheckDuplicateSchemas): Checking for duplicate schemas, this could take a (long) while.  Run with --verbose for more detail.
cmdout	[Autorest] WARNING (PreCheck/PropertyRedeclarationWarning): Schema 'FileEventTrigger' has a property 'id' that is already declared the parent schema 'ARMBaseModel' but isn't significantly different. The property has been removed from FileEventTrigger
cmdout	[Autorest] WARNING (PreCheck/PropertyRedeclarationWarning): Schema 'FileEventTrigger' has a property 'name' that is already declared the parent schema 'ARMBaseModel' but isn't significantly different. The property has been removed from FileEventTrigger
cmdout	[Autorest] WARNING (PreCheck/PropertyRedeclarationWarning): Schema 'FileEventTrigger' has a property 'type' that is already declared the parent schema 'ARMBaseModel' but isn't significantly different. The property has been removed from FileEventTrigger
cmdout	[Autorest] WARNING (PreCheck/PropertyRedeclarationWarning): Schema 'IoTRole' has a property 'id' that is already declared the parent schema 'ARMBaseModel' but isn't significantly different. The property has been removed from IoTRole
cmdout	[Autorest] WARNING (PreCheck/PropertyRedeclarationWarning): Schema 'IoTRole' has a property 'name' that is already declared the parent schema 'ARMBaseModel' but isn't significantly different. The property has been removed from IoTRole
cmdout	[Autorest] WARNING (PreCheck/PropertyRedeclarationWarning): Schema 'IoTRole' has a property 'type' that is already declared the parent schema 'ARMBaseModel' but isn't significantly different. The property has been removed from IoTRole
cmdout	[Autorest] WARNING (PreCheck/PropertyRedeclarationWarning): Schema 'PeriodicTimerEventTrigger' has a property 'id' that is already declared the parent schema 'ARMBaseModel' but isn't significantly different. The property has been removed from PeriodicTimerEventTrigger
cmdout	[Autorest] WARNING (PreCheck/PropertyRedeclarationWarning): Schema 'PeriodicTimerEventTrigger' has a property 'name' that is already declared the parent schema 'ARMBaseModel' but isn't significantly different. The property has been removed from PeriodicTimerEventTrigger
cmdout	[Autorest] WARNING (PreCheck/PropertyRedeclarationWarning): Schema 'PeriodicTimerEventTrigger' has a property 'type' that is already declared the parent schema 'ARMBaseModel' but isn't significantly different. The property has been removed from PeriodicTimerEventTrigger
cmdout	[Autorest] WARNING (): Operation Update has already existed in group! Skip split!
cmdout	[Autorest] WARNING (): cli.auto-parameter-hidden is not true, skip visibility cleaner
cmderr	[Autorest] BELOW TEST SCENARIO SECTION CAN BE USED IN readme.cli.md
cmderr	[Autorest] --------------------------------------------------------
cmderr	[Autorest]   test-scenario:
cmderr	[Autorest]     - name: /Devices/put/DataBoxEdgeDevicePut
cmderr	[Autorest]     - name: /Devices/get/DataBoxEdgeDeviceGetByName
cmderr	[Autorest]     - name: /Devices/get/DataBoxEdgeDeviceGetByResourceGroup
cmderr	[Autorest]     - name: /Devices/get/DataBoxEdgeDeviceGetBySubscription
cmderr	[Autorest]     - name: /Devices/get/NetworkSettingsGet
cmderr	[Autorest]     - name: /Devices/get/UpdateSummaryGet
cmderr	[Autorest]     - name: /Devices/patch/DataBoxEdgeDevicePatch
cmderr	[Autorest]     - name: /Devices/post/CreateOrUpdateSecuritySettings
cmderr	[Autorest]     - name: /Devices/post/DownloadUpdatesPost
cmderr	[Autorest]     - name: /Devices/post/ExtendedInfoPost
cmderr	[Autorest]     - name: /Devices/post/InstallUpdatesPost
cmderr	[Autorest]     - name: /Devices/post/ScanForUpdatesPost
cmderr	[Autorest]     - name: /Devices/post/UploadCertificatePost
cmderr	[Autorest]     - name: /Alerts/get/AlertGet
cmderr	[Autorest]     - name: /Alerts/get/AlertGetAllInDevice
cmderr	[Autorest]     - name: /BandwidthSchedules/put/BandwidthSchedulePut
cmderr	[Autorest]     - name: /BandwidthSchedules/get/BandwidthScheduleGet
cmderr	[Autorest]     - name: /BandwidthSchedules/get/BandwidthScheduleGetAllInDevice
cmderr	[Autorest]     - name: /BandwidthSchedules/delete/BandwidthScheduleDelete
cmderr	[Autorest]     - name: /Containers/put/ContainerPut
cmderr	[Autorest]     - name: /Containers/get/ContainerGet
cmderr	[Autorest]     - name: /Containers/get/ContainerListAllInDevice
cmderr	[Autorest]     - name: /Containers/post/ContainerRefresh
cmderr	[Autorest]     - name: /Containers/delete/ContainerDelete
cmderr	[Autorest]     - name: /Jobs/get/JobsGet
cmderr	[Autorest]     - name: /Nodes/get/NodesGetAllInDevice
cmderr	[Autorest]     - name: /OperationsStatus/get/OperationsStatusGet
cmderr	[Autorest]     - name: /Orders/put/OrderPut
cmderr	[Autorest]     - name: /Orders/get/OrderGet
cmderr	[Autorest]     - name: /Orders/get/OrderGetAllInDevice
cmderr	[Autorest]     - name: /Orders/delete/OrderDelete
cmderr	[Autorest]     - name: /Roles/put/RolePut
cmderr	[Autorest]     - name: /Roles/get/RoleGet
cmderr	[Autorest]     - name: /Roles/get/RoleGetAllInDevice
cmderr	[Autorest]     - name: /Roles/delete/RoleDelete
cmderr	[Autorest]     - name: /StorageAccountCredentials/get/SACGet
cmderr	[Autorest]     - name: /StorageAccountCredentials/get/SACGetAllInDevice
cmderr	[Autorest]     - name: /Shares/put/SharePut
cmderr	[Autorest]     - name: /Shares/get/ShareGet
cmderr	[Autorest]     - name: /Shares/get/ShareGetAllInDevice
cmderr	[Autorest]     - name: /Shares/post/ShareRefreshPost
cmderr	[Autorest]     - name: /Shares/delete/ShareDelete
cmderr	[Autorest]     - name: /Devices/delete/DataBoxEdgeDeviceDelete
cmderr	[Autorest]     - name: /Skus/get/ListSkus
cmderr	[Autorest]     - name: /StorageAccountCredentials/delete/SACDelete
cmderr	[Autorest]     - name: /StorageAccounts/get/StorageAccountGet
cmderr	[Autorest]     - name: /StorageAccounts/get/StorageAccountGetAllInDevice
cmderr	[Autorest]     - name: /StorageAccounts/delete/StorageAccountDelete
cmderr	[Autorest]     - name: /Triggers/put/TriggerPut
cmderr	[Autorest]     - name: /Triggers/get/TriggerGet
cmderr	[Autorest]     - name: /Triggers/get/TriggerGetAllInDevice
cmderr	[Autorest]     - name: /Triggers/delete/TriggerDelete
cmderr	[Autorest]     - name: /Users/put/UserPut
cmderr	[Autorest]     - name: /Users/get/UserGet
cmderr	[Autorest]     - name: /Users/get/UserGetAllInDevice
cmderr	[Autorest]     - name: /Users/delete/UserDelete
cmderr	[Autorest] --------------------------------------------------------
cmderr	[Autorest] fatal: not a git repository (or any of the parent directories): .git
cmderr	[Autorest] fatal: not a git repository (or any of the parent directories): .git
cmderr	[Autorest] /bin/sh: 1: cd: can't cd to home/vsts/work/1/s/azure-rest-api-specs

️✔️databoxedge [View full logs] [Release Azure CLI Changes]
- databoxedge-0.1.0-py3-none-any.whl
- databoxedge-0.1.0.zip

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from fbd2810. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️databoxedge/mgmt/2020-09-01/databoxedge [View full logs] [Release SDK Changes]
```
info	[Changelog] This is a new package
```
️✔️databoxedge/mgmt/2019-08-01/databoxedge [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️databoxedge/mgmt/2019-07-01/databoxedge [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️databoxedge/mgmt/2019-03-01/databoxedge [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️preview/databoxedge/mgmt/2020-09-01-preview/databoxedge [View full logs] [Release SDK Changes]
```
info	[Changelog] This is a new package
```
️✔️preview/databoxedge/mgmt/2020-05-01-preview/databoxedge [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```

️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2021-02-03T05:45:02Z

In the Window Period to fix mismatches between swagger and service, when PR is labelled with “FixS360”, breaking change can be approved by PR assignee; the Azure Breaking Change Board is no longer required to approve the PR. Please ensure to clarify what s360 action items to be solved, and @ mention PR assignee for awareness. Please check this wiki [Window to Fix Broken]( Window to Fix Broken - Overview (azure.com)) for more details.

openapi-workflow-bot · 2021-02-03T05:46:57Z

Hi @anponnet, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

Task	How to fix	Priority	Support (Microsoft alias)
Avocado	Fix-Avocado	High	ruowan
Semantic validation	Fix-SemanticValidation-Error	High	raychen, jianyxi
Model validation	Fix-ModelValidation-Error	High	raychen,jianyxi
LintDiff	Fix-LintDiff	high	jianyxi, ruoxuan

If you need further help, please feedback via swagger feedback."

anponnet · 2021-02-03T06:23:29Z

Hi @ruowan , This is an S360 fix and there was an email this does not need version upgrade to fix. Can you please review and approve if it meets criteria
S360 item: https://msazure.visualstudio.com/Swagger%20KPIs/_workitems/edit/9116769

ruowan · 2021-02-03T08:05:51Z

LGTM, merged.

* Swagger correctness operations API * Swagger correctness: Fix readonly properties * Swagger correctness: Fix readonly properties * Correcting readonly fields

anponnet added 4 commits January 28, 2021 14:18

Swagger correctness operations API

798fd9c

Swagger correctness: Fix readonly properties

27fe850

Merge branch 'master' of https://github.com/anponnet/azure-rest-api-s…

c38cec2

…pecs into swaggercorrectreadonly

Swagger correctness: Fix readonly properties

bb9c74f

openapi-assignment-bot bot assigned ruowan Feb 3, 2021

openapi-workflow-bot bot added the FixS360 label Feb 3, 2021

openapi-pipeline-app bot added the CI-FixRequiredOnFailure label Feb 3, 2021

openapi-pipeline-app bot removed the CI-FixRequiredOnFailure label Feb 3, 2021

This was referenced Feb 3, 2021

[AutoPR @azure/arm-databoxedge] Swagger correctness: Mark readonly properties AzureSDKAutomation/azure-sdk-for-js#3514

Closed

[AutoPR databoxedge] Swagger correctness: Mark readonly properties AzureSDKAutomation/azure-cli-extensions#611

Closed

openapi-pipeline-app bot added the CI-FixRequiredOnFailure label Feb 3, 2021

This was referenced Feb 3, 2021

[AutoPR databoxedge] Swagger correctness: Mark readonly properties AzureSDKAutomation/azure-resource-manager-schemas#1593

Closed

[AutoPR azure-mgmt-databoxedge] Swagger correctness: Mark readonly properties AzureSDKAutomation/azure-sdk-for-python#4067

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Python label Feb 3, 2021

openapi-sdkautomation bot mentioned this pull request Feb 3, 2021

[AutoPR azure-resourcemanager-databoxedge] Swagger correctness: Mark readonly properties AzureSDKAutomation/azure-sdk-for-java#7395

Closed

Correcting readonly fields

0b5d7cf

openapi-pipeline-app bot removed the CI-FixRequiredOnFailure label Feb 3, 2021

openapi-sdkautomation bot mentioned this pull request Feb 3, 2021

[AutoPR Microsoft.Azure.Management.DataBoxEdge] Swagger correctness: Mark readonly properties AzureSDKAutomation/azure-sdk-for-net#3121

Closed

ruowan approved these changes Feb 3, 2021

View reviewed changes

ruowan added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Feb 3, 2021

ruowan merged commit fbd2810 into Azure:master Feb 3, 2021

mikhailshilkov mentioned this pull request Feb 4, 2021

Breaking changes in API pulumi/pulumi-azure-native#127

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Swagger correctness: Mark readonly properties #12810

Swagger correctness: Mark readonly properties #12810

anponnet commented Feb 3, 2021 •

edited

Loading

openapi-workflow-bot bot commented Feb 3, 2021

openapi-pipeline-app bot commented Feb 3, 2021 •

edited

Loading

openapi-pipeline-app bot commented Feb 3, 2021 •

edited

Loading

openapi-workflow-bot bot commented Feb 3, 2021

openapi-workflow-bot bot commented Feb 3, 2021

anponnet commented Feb 3, 2021

ruowan commented Feb 3, 2021

Swagger correctness: Mark readonly properties #12810

Swagger correctness: Mark readonly properties #12810

Conversation

anponnet commented Feb 3, 2021 • edited Loading

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Feb 3, 2021

openapi-pipeline-app bot commented Feb 3, 2021 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Feb 3, 2021 • edited Loading

Swagger Generation Artifacts

openapi-workflow-bot bot commented Feb 3, 2021

openapi-workflow-bot bot commented Feb 3, 2021

anponnet commented Feb 3, 2021

ruowan commented Feb 3, 2021

anponnet commented Feb 3, 2021 •

edited

Loading

openapi-pipeline-app bot commented Feb 3, 2021 •

edited

Loading

openapi-pipeline-app bot commented Feb 3, 2021 •

edited

Loading