-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hub Generated] Public private branch 'dev-maintenance-Microsoft.Maintenance-2021-04-01-preview' #12899
Merged
allenjzhang
merged 13 commits into
master
from
copied-from-private/KalpeshChavan12/azure-rest-api-specs-pr/dev-maintenance-Microsoft.Maintenance-2021-04-01-preview
Feb 9, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…0-07-01-preview to version 2021-04-01-preview
Added New operations for AppluUpdates, ConfigurationAssignment, MaintenanceConfiguration
MaintenanceScope.
Hi, @KalpeshChavan12 Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
Swagger Validation Report
|
Rule | Message |
---|---|
Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDataAction Location: Microsoft.Maintenance/preview/2021-04-01-preview/Maintenance.json#L2228 |
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️⚠️
[Staging] Cross Version BreakingChange (Base on preview version): 15 Warnings warning [Detail]
Only 10 items are listed, please refer to log for more details.
- Compared Swaggers (Based on Oad v0.8.6)
- original: preview/2020-07-01-preview/Maintenance.json <---> new: preview/2021-04-01-preview/Maintenance.json
️⚠️
[Staging] Cross Version BreakingChange (Base on stable version): 15 Warnings warning [Detail]
Only 10 items are listed, please refer to log for more details.
- Compared Swaggers (Based on Oad v0.8.6)
- original: stable/2020-04-01/Maintenance.json <---> new: preview/2021-04-01-preview/Maintenance.json
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️
[Staging] SDK Track2 Validation: 1 Warnings warning [Detail]
- The following tags are being changed in this PR
Rule | Message |
---|---|
"readme":"maintenance/resource-manager/readme.md", "tag":"package-preview-2021-04", "details":"Checking for duplicate schemas, this could take a (long) while. Run with --verbose for more detail." |
️️✔️
[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
Swagger Generation Artifacts
|
This was referenced Feb 8, 2021
allenjzhang
reviewed
Feb 8, 2021
...intenance/resource-manager/Microsoft.Maintenance/preview/2021-04-01-preview/Maintenance.json
Show resolved
Hide resolved
...intenance/resource-manager/Microsoft.Maintenance/preview/2021-04-01-preview/Maintenance.json
Show resolved
Hide resolved
ApiDocPreview passed in ADO pipeline. |
allenjzhang
approved these changes
Feb 9, 2021
This was referenced Feb 9, 2021
mkarmark
pushed a commit
to mkarmark/azure-rest-api-specs
that referenced
this pull request
Jul 21, 2021
…tenance-2021-04-01-preview' (Azure#12899) * Adds base for updating Microsoft.Maintenance from version preview/2020-07-01-preview to version 2021-04-01-preview * Updates readme * Updates API version in new specs and examples * Added Guest OS patch configuration support in maintenance config. * Fixed typos. * Fixed typos for TaskScope enum. * Added Get method for config assignments. * Fixed Example. * Fixed Swagger LintDiff issue. Added New operations for AppluUpdates, ConfigurationAssignment, MaintenanceConfiguration * Added Examples * Fixed Resource name. * Fixed spell check. * Removed maintenanceScopeType enum. Removed All, Resource, InResource MaintenanceScope. Co-authored-by: Kalpesh Chavan <kachavan@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ARMSignedOff
<valid label in PR review process>add this label when ARM approve updates after review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the private branch that was created into public. The branch has already been reviewed, to view the status, please go to the OpenAPI Hub.