[Hub Generated] Review request for Microsoft.Consumption to add version stable/2019-11-01 #12942

Lira-tron · 2021-02-10T18:57:58Z

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When you are targeting to deploy new service/feature to public regions? it is already public
When you expect to publish swagger? February 2021
If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No, no need to refresh for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of “no breaking changes
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable version with Breaking Change Validation errors
Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

NOTE: This version was missing and was reported by an s360 item, there are no changes in api, and the api version has been live for a while.

…-10-01 to version 2019-11-01

openapi-workflow-bot · 2021-02-10T18:58:01Z

Hi, @octalimon Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

openapi-pipeline-app · 2021-02-10T18:58:02Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️⚠️LintDiff: 5 Warnings warning [Detail]

Linted configuring files (Based on source branch, openapi-validator v1.7.0 , classic-openapi-validator v1.1.5 )
- consumption/resource-manager/readme.md tag:package-2019-11
Linted configuring files (Based on target branch, openapi-validator v1.7.0 , classic-openapi-validator v1.1.5 )
- consumption/resource-manager/readme.md tag:default

Rule	Message
⚠️ R3017 - GuidUsage	Guid used in model definition 'ModernUsageDetailProperties' for property 'meterId'. Usage of Guid is not recommanded. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board. Location: Microsoft.Consumption/stable/2019-11-01/consumption.json#L2155
⚠️ R4030 - UniqueXmsExample	Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: ReservationRecommendationsBySubscription-Legacy Location: Microsoft.Consumption/stable/2019-11-01/consumption.json#L1132
⚠️ R4030 - UniqueXmsExample	Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: ReservationRecommendationsByResourceGroup-Legacy Location: Microsoft.Consumption/stable/2019-11-01/consumption.json#L1132
⚠️ R4030 - UniqueXmsExample	Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: ReservationRecommendationsByBillingAccount-Legacy Location: Microsoft.Consumption/stable/2019-11-01/consumption.json#L1132
⚠️ R4030 - UniqueXmsExample	Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: ReservationRecommendationsByBillingProfile-Modern Location: Microsoft.Consumption/stable/2019-11-01/consumption.json#L1132

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️⚠️[Staging] Cross Version BreakingChange (Base on preview version): 39 Warnings warning [Detail]

Only 10 items are listed, please refer to log for more details.

Compared Swaggers (Based on Oad v0.8.6)
- original: preview/2019-05-01-preview/consumption.json <---> new: stable/2019-11-01/consumption.json

Rule	Message
⚠️ 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/{scope}/providers/Microsoft.Consumption/usageDetails/download' removed or restructured? Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L154:5
⚠️ 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.Consumption/reservationRecommendations' removed or restructured? Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L876:5
⚠️ 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/providers/Microsoft.Management/managementGroups/{managementGroupId}/providers/Microsoft.Billing/billingPeriods/{billingPeriodName}/Microsoft.Consumption/aggregatedcost' removed or restructured? Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L1194:5
⚠️ 1006 - RemovedDefinition	The new version is missing a definition that was found in the old version. Was 'Filters' removed or renamed? New: Microsoft.Consumption/stable/2019-11-01/consumption.json#L1738:3 Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L1237:3
⚠️ 1008 - ModifiedOperationId	The operation id has been changed from 'Charges_ListByScope' to 'Charges_List'. This will impact generated code. New: Microsoft.Consumption/stable/2019-11-01/consumption.json#L480:7 Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L533:7
⚠️ 1011 - AddingResponseCode	The new version adds a response code '204'. New: Microsoft.Consumption/stable/2019-11-01/consumption.json#L467:11
⚠️ 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Consumption/stable/2019-11-01/consumption.json#L131:11 Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L119:11
⚠️ 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Consumption/stable/2019-11-01/consumption.json#L218:11 Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L275:11
⚠️ 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Consumption/stable/2019-11-01/consumption.json#L1319:11 Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L958:11
⚠️ 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Consumption/stable/2019-11-01/consumption.json#L1385:11 Old: Microsoft.Consumption/preview/2019-05-01-preview/consumption.json#L1023:11

️⚠️[Staging] Cross Version BreakingChange (Base on stable version): 11 Warnings warning [Detail]

Only 10 items are listed, please refer to log for more details.

Compared Swaggers (Based on Oad v0.8.6)
- original: stable/2019-10-01/consumption.json <---> new: stable/2019-11-01/consumption.json

Rule	Message
⚠️ 1009 - RemovedRequiredParameter	The required parameter 'billingScope' was removed in the new version. Old: Microsoft.Consumption/stable/2019-10-01/consumption.json#L1146:9
⚠️ 1015 - ParameterInHasChanged	How the parameter is passed has changed -- it used to be 'query', now it is 'path'. New: Microsoft.Consumption/stable/2019-11-01/consumption.json#L1146:9 Old: Microsoft.Consumption/stable/2019-10-01/consumption.json#L1146:9
⚠️ 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Consumption/stable/2019-11-01/consumption.json#L2155:9 Old: Microsoft.Consumption/stable/2019-10-01/consumption.json#L2155:9
⚠️ 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Consumption/stable/2019-11-01/consumption.json#L3386:9 Old: Microsoft.Consumption/stable/2019-10-01/consumption.json#L3405:9
⚠️ 1026 - TypeChanged	The new version has a different type 'string' than the previous one 'integer'. New: Microsoft.Consumption/stable/2019-11-01/consumption.json#L3386:9 Old: Microsoft.Consumption/stable/2019-10-01/consumption.json#L3405:9
⚠️ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'additionalInfo' renamed or removed? New: Microsoft.Consumption/stable/2019-11-01/consumption.json#L2484:7 Old: Microsoft.Consumption/stable/2019-10-01/consumption.json#L2489:7
⚠️ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'value' renamed or removed? New: Microsoft.Consumption/stable/2019-11-01/consumption.json#L3813:7 Old: Microsoft.Consumption/stable/2019-10-01/consumption.json#L3833:7
⚠️ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'download' renamed or removed? New: Microsoft.Consumption/stable/2019-11-01/consumption.json#L4113:7 Old: Microsoft.Consumption/stable/2019-10-01/consumption.json#L4140:7
⚠️ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'description' renamed or removed? New: Microsoft.Consumption/stable/2019-11-01/consumption.json#L4632:11 Old: Microsoft.Consumption/stable/2019-10-01/consumption.json#L4704:11
⚠️ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'payGPrice' renamed or removed? New: Microsoft.Consumption/stable/2019-11-01/consumption.json#L2101:7 Old: Microsoft.Consumption/stable/2019-10-01/consumption.json#L2101:7

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️[Staging] SDK Track2 Validation: 50 Warnings warning [Detail]

Only 10 items are listed, please refer to log for more details.

The following tags are being changed in this PR

consumption/resource-manager/readme.md#package-2019-11

Rule	Message
⚠️ PreCheck/SchemaMissingType	"readme":"consumption/resource-manager/readme.md", "tag":"package-2019-11", "details":"The schema 'MeterDetails' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/SchemaMissingType	"readme":"consumption/resource-manager/readme.md", "tag":"package-2019-11", "details":"The schema 'UsageDetailsListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/SchemaMissingType	"readme":"consumption/resource-manager/readme.md", "tag":"package-2019-11", "details":"The schema 'LegacyUsageDetailProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/SchemaMissingType	"readme":"consumption/resource-manager/readme.md", "tag":"package-2019-11", "details":"The schema 'ModernUsageDetailProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/SchemaMissingType	"readme":"consumption/resource-manager/readme.md", "tag":"package-2019-11", "details":"The schema 'ReservationSummariesListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/SchemaMissingType	"readme":"consumption/resource-manager/readme.md", "tag":"package-2019-11", "details":"The schema 'ReservationSummaryProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/SchemaMissingType	"readme":"consumption/resource-manager/readme.md", "tag":"package-2019-11", "details":"The schema 'ReservationDetailsListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/SchemaMissingType	"readme":"consumption/resource-manager/readme.md", "tag":"package-2019-11", "details":"The schema 'ReservationDetailProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/SchemaMissingType	"readme":"consumption/resource-manager/readme.md", "tag":"package-2019-11", "details":"The schema 'ReservationRecommendationDetailsProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/SchemaMissingType	"readme":"consumption/resource-manager/readme.md", "tag":"package-2019-11", "details":"The schema 'ReservationRecommendationDetailsCalculatedSavingsProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"

️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2021-02-10T18:58:03Z

Swagger Generation Artifacts

️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 8d15dc6. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/consumption/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.Consumption [View full logs] [Release SDK Changes]
- Microsoft.Azure.Management.Consumption.3.0.2.nupkg
- Microsoft.Azure.Management.Consumption.3.0.2.snupkg

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 8d15dc6. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️consumption/mgmt/2019-10-01/consumption [View full logs] [Release SDK Changes] Breaking Change Detected

Only show 11 items here, please refer to log for details.

info	[Changelog] - New field `Etag` in struct `LotSummary`
info	[Changelog] - New field `Etag` in struct `UsageDetail`
info	[Changelog] - New field `Etag` in struct `LegacyReservationRecommendation`
info	[Changelog] - New field `ID` in struct `Operation`
info	[Changelog] - New field `Etag` in struct `ManagementGroupAggregatedCostResult`
info	[Changelog] - New field `Etag` in struct `ReservationDetail`
info	[Changelog] - New field `Etag` in struct `PriceSheetResult`
info	[Changelog] - New field `Etag` in struct `CreditSummary`
info	[Changelog]
info	[Changelog] Total 3 breaking change(s), 36 additive change(s).
info	[Changelog]

️✔️consumption/mgmt/2019-01-01/consumption [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️consumption/mgmt/2018-10-01/consumption [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️consumption/mgmt/2018-08-31/consumption [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️consumption/mgmt/2018-06-30/consumption [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️consumption/mgmt/2018-05-31/consumption [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️consumption/mgmt/2018-03-31/consumption [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️consumption/mgmt/2018-01-31/consumption [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️consumption/mgmt/2017-11-30/consumption [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️preview/consumption/mgmt/2017-12-30-preview/consumption [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️preview/consumption/mgmt/2017-04-24-preview/consumption [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```

️⚠️ azure-sdk-for-python warning [Detail]

⚠️Warning [Logs]Release - Generate from 8d15dc6. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️azure-mgmt-consumption [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model Operation has a new parameter id
info	[Changelog]   - Model Forecast has a new parameter etag
info	[Changelog]   - Model Resource has a new parameter etag
info	[Changelog]   - Model ManagementGroupAggregatedCostResult has a new parameter etag
info	[Changelog]   - Model TagsResult has a new parameter previous_link
info	[Changelog]   - Model TagsResult has a new parameter next_link
info	[Changelog]   - Model PriceSheetResult has a new parameter etag
info	[Changelog]   - Model ReservationSummary has a new parameter remaining_quantity
info	[Changelog]   - Model ReservationSummary has a new parameter kind
info	[Changelog]   - Model ReservationSummary has a new parameter etag
info	[Changelog]   - Model ReservationSummary has a new parameter total_reserved_quantity
info	[Changelog]   - Model ReservationSummary has a new parameter used_quantity
info	[Changelog]   - Model ReservationSummary has a new parameter purchased_quantity
info	[Changelog]   - Model ReservationSummary has a new parameter utilized_percentage
info	[Changelog]   - Model Budget has a new parameter filter
info	[Changelog]   - Model ReservationDetail has a new parameter instance_flexibility_ratio
info	[Changelog]   - Model ReservationDetail has a new parameter instance_flexibility_group
info	[Changelog]   - Model ReservationDetail has a new parameter kind
info	[Changelog]   - Model ReservationDetail has a new parameter etag
info	[Changelog]   - Model Balance has a new parameter etag
info	[Changelog]   - Model Marketplace has a new parameter etag
info	[Changelog]   - Model Notification has a new parameter threshold_type
info	[Changelog]   - Added operation ReservationsDetailsOperations.list
info	[Changelog]   - Added operation ReservationRecommendationsOperations.list
info	[Changelog]   - Added operation ReservationsSummariesOperations.list
info	[Changelog]   - Added operation ChargesOperations.list
info	[Changelog]   - Added operation group LotsOperations
info	[Changelog]   - Added operation group CreditsOperations
info	[Changelog]   - Added operation group EventsOperations
info	[Changelog]   - Added operation group ReservationRecommendationDetailsOperations
info	[Changelog]   - Added operation group ReservationTransactionsOperations
info	[Changelog]
info	[Changelog] **Breaking changes**
info	[Changelog]
info	[Changelog]   - Model Budget no longer has parameter filters
info	[Changelog]   - Model ChargeSummary has a new signature
info	[Changelog]   - Model ReservationRecommendation has a new signature
info	[Changelog]   - Model UsageDetail has a new signature
info	[Changelog]   - Removed operation UsageDetailsOperations.download
info	[Changelog]   - Removed operation ChargesOperations.list_by_scope

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 8d15dc6. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️track2_azure-mgmt-consumption [View full logs] [Release SDK Changes]

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model LotSummary has a new parameter etag
info	[Changelog]   - Model LegacyReservationRecommendation has a new parameter etag
info	[Changelog]   - Model ReservationRecommendation has a new parameter etag
info	[Changelog]   - Model Balance has a new parameter etag
info	[Changelog]   - Model ModernReservationRecommendation has a new parameter etag
info	[Changelog]   - Model Forecast has a new parameter etag
info	[Changelog]   - Model LegacyUsageDetail has a new parameter etag
info	[Changelog]   - Model ModernChargeSummary has a new parameter etag
info	[Changelog]   - Model ChargeSummary has a new parameter etag
info	[Changelog]   - Model CreditSummary has a new parameter etag
info	[Changelog]   - Model TagsResult has a new parameter next_link
info	[Changelog]   - Model TagsResult has a new parameter previous_link
info	[Changelog]   - Model EventSummary has a new parameter etag
info	[Changelog]   - Model PriceSheetResult has a new parameter etag
info	[Changelog]   - Model ReservationDetail has a new parameter etag
info	[Changelog]   - Model Marketplace has a new parameter etag
info	[Changelog]   - Model ReservationRecommendationDetailsModel has a new parameter etag
info	[Changelog]   - Model ReservationSummary has a new parameter etag
info	[Changelog]   - Model UsageDetail has a new parameter etag
info	[Changelog]   - Model ModernUsageDetail has a new parameter etag
info	[Changelog]   - Model Resource has a new parameter etag
info	[Changelog]   - Model ManagementGroupAggregatedCostResult has a new parameter etag
info	[Changelog]   - Model Operation has a new parameter id
info	[Changelog]   - Model LegacyChargeSummary has a new parameter etag
info	[Changelog]   - Added operation ReservationRecommendationDetailsOperations.get

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 8d15dc6. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-03-10 01:10:39 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-consumption"
cmderr	[generate.py] 2021-03-10 01:10:39 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
cmderr	[generate.py] 2021-03-10 01:10:39 INFO autorest --version=3.1.0 --use=@autorest/java@4.0.19 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/consumption/azure-resourcemanager-consumption --java.namespace=com.azure.resourcemanager.consumption   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/consumption/resource-manager/readme.md
cmderr	[generate.py] 2021-03-10 01:11:19 INFO [CI][Success] Write to ci.yml
cmderr	[generate.py] 2021-03-10 01:11:19 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-03-10 01:11:19 INFO [POM][Skip] pom already has module azure-resourcemanager-consumption
cmderr	[generate.py] 2021-03-10 01:11:19 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-03-10 01:11:19 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-03-10 01:11:19 INFO [POM][Success] Write to root pom

️✔️azure-resourcemanager-consumption [View full logs] [Release SDK Changes]

cmderr	[Inst] 2021-03-10 01:14:56 DEBUG Got artifact_id: azure-resourcemanager-consumption
cmderr	[Inst] 2021-03-10 01:14:56 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-03-10 01:14:56 DEBUG Got artifact: azure-resourcemanager-consumption-1.0.0-beta.1.jar
cmderr	[Inst] 2021-03-10 01:14:56 DEBUG Match jar package: azure-resourcemanager-consumption-1.0.0-beta.1.jar
cmderr	[Inst] 2021-03-10 01:14:56 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/12942/azure-sdk-for-java/azure-resourcemanager-consumption/azure-resourcemanager-consumption-1.0.0-beta.1.jar\" -o azure-resourcemanager-consumption-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-consumption -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-consumption-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
```"}

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 8d15dc6. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/consumption/resource-manager/readme.md

️✔️@azure/arm-consumption [View full logs] [Release SDK Changes]

azure-arm-consumption-6.3.0.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/consumptionManagementClient.js → ./dist/arm-consumption.js...
cmderr	[npmPack] created ./dist/arm-consumption.js in 534ms

️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 8d15dc6. Schema Automation 14.0.0

warn	Skip initScript due to not configured
command	npx n 12
command	autorest --use=@autorest/azureresourceschema@3.0.92 --version=3.0.6374 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/consumption/resource-manager/readme.md

️✔️consumption [View full logs] [Release Schema Changes]

cmderr	[resource-manager] node-pre-gyp
cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
cmderr	[resource-manager] WARN template-schema-validation-tools@1.0.0 No repository field.
cmderr	[resource-manager]  SKIPPING OPTIONAL DEPENDENCY: fsevents@2.1.3 (node_modules/fsevents):
cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.3: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

️🔄[Staging] ApiDocPreview inProgress [Detail]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2021-02-10T21:20:44Z

Hi, @octalimon your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). cc @

markcowl · 2021-02-16T18:09:49Z

/azp run

azure-pipelines · 2021-02-16T18:10:03Z

Azure Pipelines successfully started running 2 pipeline(s).

...cation/consumption/resource-manager/Microsoft.Consumption/stable/2019-11-01/consumption.json

markcowl · 2021-02-19T21:25:58Z

...cation/consumption/resource-manager/Microsoft.Consumption/stable/2019-11-01/consumption.json

+        }
+      }
+    },
+    "Resource": {


Please reference the standard resource definitions here: https://github.com/Azure/azure-rest-api-specs/blob/master/specification/common-types/resource-management/v1/types.json#L9 You will likely use either TrackedResource or ProxyResource

So in our definition ProxyResource has eTags, and in the common one it does not, also for Resource we have defined tags + etags. If you think this is ok I would like to keep it as it is for now.

I just saw that there are some validation errors because of this, I will work on it. thanks!

I don't see any changes related to this.

I did take a look but did not update the comment, sorry about that, I was looking for example UsageDetail, and it has tags, however it does not have a location currently in the response, this will end up with several errors in case to use TrackedResource (most of them falls in the same category).

It will required code changes from several teams, Mark, do you think we can deliver this one as it is in order to get the completeness part, then we can ask each team to see how to move to the correct Resources definitions?

markcowl

Note: if any of the suggested changes would result in a breaking change, then please do not make the breakign change (and please note this)

markcowl · 2021-02-19T21:29:32Z

...cation/consumption/resource-manager/Microsoft.Consumption/stable/2019-11-01/consumption.json

+        }
+      }
+    },
+    "ErrorResponse": {


Please reference the default error response: https://github.com/Azure/azure-rest-api-specs/blob/master/specification/common-types/resource-management/v1/types.json#L277 unless this results in a breaking change

Please indicate whether this would be a breaking change. There is good reason to use the common definition - it allows uniform handling of errors across RPs fro generated SDKs (and also for customers using the REST API).

yes, it ends up with breaking changes.

markcowl · 2021-02-19T21:31:12Z

/azp run

azure-pipelines · 2021-02-19T21:31:26Z

Azure Pipelines successfully started running 2 pipeline(s).

openapi-workflow-bot · 2021-02-22T18:10:18Z

Hi, @octalimon your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). cc @markcowl

Lira-tron · 2021-02-22T18:59:02Z

Why was this marked as breaking change? if this was successful ? https://github.com/Azure/azure-rest-api-specs/pull/12942/checks?check_run_id=1938628179

The PR for adding new version 2019-11-01 took longer than expected to be approved, so some fixes made in 10-01 were not included in 2019-11-01 version. The missing changes were the following PRs: #12777 #12555 #13039 #13097 #12822 #13280 #12942 #13248 #13378 This PR is to add those corrections to 2019-11-01 version

Adding fixes made in 2019-10-01 to 2019-11-01 (Azure#13414) The PR for adding new version 2019-11-01 took longer than expected to be approved, so some fixes made in 10-01 were not included in 2019-11-01 version. The missing changes were the following PRs: Azure/azure-rest-api-specs#12777 Azure/azure-rest-api-specs#12555 Azure/azure-rest-api-specs#13039 Azure/azure-rest-api-specs#13097 Azure/azure-rest-api-specs#12822 Azure/azure-rest-api-specs#13280 Azure/azure-rest-api-specs#12942 Azure/azure-rest-api-specs#13248 Azure/azure-rest-api-specs#13378 This PR is to add those corrections to 2019-11-01 version

Adding fixes made in 2019-10-01 to 2019-11-01 (#13414) The PR for adding new version 2019-11-01 took longer than expected to be approved, so some fixes made in 10-01 were not included in 2019-11-01 version. The missing changes were the following PRs: Azure/azure-rest-api-specs#12777 Azure/azure-rest-api-specs#12555 Azure/azure-rest-api-specs#13039 Azure/azure-rest-api-specs#13097 Azure/azure-rest-api-specs#12822 Azure/azure-rest-api-specs#13280 Azure/azure-rest-api-specs#12942 Azure/azure-rest-api-specs#13248 Azure/azure-rest-api-specs#13378 This PR is to add those corrections to 2019-11-01 version

Adding fixes made in 2019-10-01 to 2019-11-01 (Azure#13414) The PR for adding new version 2019-11-01 took longer than expected to be approved, so some fixes made in 10-01 were not included in 2019-11-01 version. The missing changes were the following PRs: Azure/azure-rest-api-specs#12777 Azure/azure-rest-api-specs#12555 Azure/azure-rest-api-specs#13039 Azure/azure-rest-api-specs#13097 Azure/azure-rest-api-specs#12822 Azure/azure-rest-api-specs#13280 Azure/azure-rest-api-specs#12942 Azure/azure-rest-api-specs#13248 Azure/azure-rest-api-specs#13378 This PR is to add those corrections to 2019-11-01 version

Adding fixes made in 2019-10-01 to 2019-11-01 (#13414) The PR for adding new version 2019-11-01 took longer than expected to be approved, so some fixes made in 10-01 were not included in 2019-11-01 version. The missing changes were the following PRs: Azure/azure-rest-api-specs#12777 Azure/azure-rest-api-specs#12555 Azure/azure-rest-api-specs#13039 Azure/azure-rest-api-specs#13097 Azure/azure-rest-api-specs#12822 Azure/azure-rest-api-specs#13280 Azure/azure-rest-api-specs#12942 Azure/azure-rest-api-specs#13248 Azure/azure-rest-api-specs#13378 This PR is to add those corrections to 2019-11-01 version

…on stable/2019-11-01 (Azure#12942) * Adds base for updating Microsoft.Consumption from version stable/2019-10-01 to version 2019-11-01 * Updates readme * Updates API version in new specs and examples * Fixing spell syntax error. * Fixin some types and adding description to ServiceInfo1 and ServiceInfo2 * Updating description of resourceId, serviceInfo1 and serviceInfo2 * Adding usage detail to the resourceId definition

The PR for adding new version 2019-11-01 took longer than expected to be approved, so some fixes made in 10-01 were not included in 2019-11-01 version. The missing changes were the following PRs: Azure#12777 Azure#12555 Azure#13039 Azure#13097 Azure#12822 Azure#13280 Azure#12942 Azure#13248 Azure#13378 This PR is to add those corrections to 2019-11-01 version

…on stable/2019-11-01 (Azure#12942) * Adds base for updating Microsoft.Consumption from version stable/2019-10-01 to version 2019-11-01 * Updates readme * Updates API version in new specs and examples * Fixing spell syntax error. * Fixin some types and adding description to ServiceInfo1 and ServiceInfo2 * Updating description of resourceId, serviceInfo1 and serviceInfo2 * Adding usage detail to the resourceId definition

The PR for adding new version 2019-11-01 took longer than expected to be approved, so some fixes made in 10-01 were not included in 2019-11-01 version. The missing changes were the following PRs: Azure#12777 Azure#12555 Azure#13039 Azure#13097 Azure#12822 Azure#13280 Azure#12942 Azure#13248 Azure#13378 This PR is to add those corrections to 2019-11-01 version

Lira-tron added 3 commits February 9, 2021 16:31

Adds base for updating Microsoft.Consumption from version stable/2019…

3aeaba2

…-10-01 to version 2019-11-01

Updates readme

782e383

Updates API version in new specs and examples

d1f03bc

openapi-pipeline-app bot added the CI-BreakingChange-Go label Feb 10, 2021

openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 10, 2021

Fixing spell syntax error.

7d3791e

Lira-tron marked this pull request as ready for review February 11, 2021 16:29

Lira-tron requested a review from kjeur as a code owner February 11, 2021 16:29

openapi-assignment-bot bot assigned markcowl Feb 11, 2021

markcowl added the FixS360 label Feb 16, 2021

markcowl requested changes Feb 19, 2021

View reviewed changes

markcowl added the Reviewed-ChangesRequested <valid label in PR review process>add this label when assignee request changes after review label Feb 19, 2021

openapi-sdkautomation bot mentioned this pull request Feb 19, 2021

[AutoPR azure-mgmt-consumption] [Hub Generated] Review request for Microsoft.Consumption to add version stable/2019-11-01 AzureSDKAutomation/azure-sdk-for-python#4227

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Python label Feb 19, 2021

Lira-tron mentioned this pull request Mar 15, 2021

[Hub Generated] Review request for Microsoft.Consumption to add version stable/2019-11-01 #13414

Merged

25 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Hub Generated] Review request for Microsoft.Consumption to add version stable/2019-11-01 #12942

[Hub Generated] Review request for Microsoft.Consumption to add version stable/2019-11-01 #12942

Lira-tron commented Feb 10, 2021 •

edited

Loading

openapi-workflow-bot bot commented Feb 10, 2021

openapi-pipeline-app bot commented Feb 10, 2021 •

edited

Loading

openapi-pipeline-app bot commented Feb 10, 2021 •

edited

Loading

openapi-workflow-bot bot commented Feb 10, 2021

markcowl commented Feb 16, 2021

azure-pipelines bot commented Feb 16, 2021

markcowl Feb 19, 2021

Lira-tron Feb 22, 2021

Lira-tron Feb 22, 2021

markcowl Mar 9, 2021

Lira-tron Mar 9, 2021

markcowl left a comment

markcowl Feb 19, 2021

markcowl Mar 9, 2021

Lira-tron Mar 9, 2021

markcowl commented Feb 19, 2021

azure-pipelines bot commented Feb 19, 2021

openapi-workflow-bot bot commented Feb 22, 2021

Lira-tron commented Feb 22, 2021

[Hub Generated] Review request for Microsoft.Consumption to add version stable/2019-11-01 #12942

[Hub Generated] Review request for Microsoft.Consumption to add version stable/2019-11-01 #12942

Conversation

Lira-tron commented Feb 10, 2021 • edited Loading

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Feb 10, 2021

openapi-pipeline-app bot commented Feb 10, 2021 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Feb 10, 2021 • edited Loading

Swagger Generation Artifacts

openapi-workflow-bot bot commented Feb 10, 2021

markcowl commented Feb 16, 2021

azure-pipelines bot commented Feb 16, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

markcowl left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

markcowl commented Feb 19, 2021

azure-pipelines bot commented Feb 19, 2021

openapi-workflow-bot bot commented Feb 22, 2021

Lira-tron commented Feb 22, 2021

Lira-tron commented Feb 10, 2021 •

edited

Loading

openapi-pipeline-app bot commented Feb 10, 2021 •

edited

Loading

openapi-pipeline-app bot commented Feb 10, 2021 •

edited

Loading