added clientId to byos api response schema #12944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonykslee
requested review from
hectorhdzg,
lzchen,
ramthi and
trask
as code owners
|
Hi, @tonykslee Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
"readme":"applicationinsights/resource-manager/readme.md", "tag":"package-2020-02-12", "details":"Duplicate Schema named ManagedIdentity -- properties.userAssignedIdentities.$ref: undefined => "#/components/schemas/schemas:346" ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"applicationinsights/resource-manager/readme.md", "tag":"package-2020-02-12", "details":"Duplicate Schema named UserAssignedIdentities -- properties.clientId: undefined => "description":"The client ID of resource.", "readOnly":true, "$ref":"#/components/schemas/schemas:349" ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"applicationinsights/resource-manager/readme.md", "tag":"package-2020-02-12", "details":"Error: Plugin prechecker reported failure." |
|
"readme":"applicationinsights/resource-manager/readme.md", "tag":"package-2020-10-20", "details":"Duplicate Schema named ManagedIdentity -- properties.userAssignedIdentities.$ref: undefined => "#/components/schemas/schemas:346" ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"applicationinsights/resource-manager/readme.md", "tag":"package-2020-10-20", "details":"Duplicate Schema named UserAssignedIdentities -- properties.clientId: undefined => "description":"The client ID of resource.", "readOnly":true, "$ref":"#/components/schemas/schemas:349" ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"applicationinsights/resource-manager/readme.md", "tag":"package-2020-10-20", "details":"Error: Plugin prechecker reported failure." |
| "readme":"applicationinsights/resource-manager/readme.md", "tag":"package-2020-02-12", "details":"The schema 'AnnotationsListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"applicationinsights/resource-manager/readme.md", "tag":"package-2020-02-12", "details":"The schema 'ApplicationInsightsComponentAPIKeyListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"applicationinsights/resource-manager/readme.md", "tag":"package-2020-02-12", "details":"The schema 'ComponentsResource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"applicationinsights/resource-manager/readme.md", "tag":"package-2020-02-12", "details":"The schema 'ComponentsResource-tags' with an undefined type and additionalProperties is a bit ambigious. This has been auto-corrected to 'type:object'" |
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
Swagger Generation Artifacts
|
|
In the Window Period to fix mismatches between swagger and service, when PR is labelled with “FixS360”, breaking change can be approved by PR assignee; the Azure Breaking Change Board is no longer required to approve the PR. Please ensure to clarify what s360 action items to be solved, and @ mention PR assignee for awareness. Please check this wiki Window to Fix Broken for more details. |
This was referenced Feb 10, 2021
allenjzhang
approved these changes
Feb 17, 2021
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
not sure why the validations are failing for python stuff when i didn't touch it. can someone else merge this please? |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
Hi @tonykslee, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
|
Hi @tonykslee, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This reverts commit 40de802.
openapi-pipeline-app
bot
removed
CI-FixRequiredOnFailure
BreakingChangeReviewRequired
labels
|
@allenjzhang Can you please help me understand what is causing the SDK Track 2 Validation error? Duplicate Schema named ManagedIdentity -- properties.userAssignedIdentities.$ref: undefined Duplicate Schema named UserAssignedIdentities -- properties.clientId: undefined |
As these error are existing errors, not introduced by this PR, I think you can ignore them .Also fixing these issue may bring breaking change. |
mkarmark
pushed a commit
to mkarmark/azure-rest-api-specs
that referenced
this pull request
Jul 21, 2021
* added clientId to byos api response schema * fixing duplicate schema * Revert "fixing duplicate schema" This reverts commit 40de802.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.