[Hub Generated] Review request for Microsoft.HybridCompute to add version preview/2021-01-28-preview #13007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…020-08-15-preview to version 2021-01-28-preview
|
Hi, @dkirby017 Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
Swagger Validation Report
|
| Rule | Message |
|---|---|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.HybridCompute/preview/2021-01-28-preview/HybridCompute.json#L853 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.HybridCompute/preview/2021-01-28-preview/HybridCompute.json#L878 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.HybridCompute/preview/2021-01-28-preview/HybridCompute.json#L923 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.HybridCompute/preview/2021-01-28-preview/HybridCompute.json#L942 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.HybridCompute/preview/2021-01-28-preview/privateLinkScopes.json#L721 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.HybridCompute/preview/2021-01-28-preview/privateLinkScopes.json#L848 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.HybridCompute/preview/2021-01-28-preview/privateLinkScopes.json#L952 |
|
| Based on the response model schema, operation 'PrivateLinkScopes_GetValidationDetails' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.HybridCompute/preview/2021-01-28-preview/privateLinkScopes.json#L591 |
|
| Based on the response model schema, operation 'PrivateLinkScopes_GetValidationDetailsForMachine' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.HybridCompute/preview/2021-01-28-preview/privateLinkScopes.json#L630 |
|
| The child tracked resource, 'extensions' with immediate parent 'Machine', must have a list by immediate parent operation. Location: Microsoft.HybridCompute/preview/2021-01-28-preview/privateLinkScopes.json#L669 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️⚠️[Staging] Cross Version BreakingChange (Base on preview version): 79 Warnings warning [Detail]
Only 10 items are listed, please refer to log for more details.
- Compared Swaggers (Based on Oad v0.8.6)
| Rule | Message |
|---|---|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.HybridCompute/privateLinkScopes/{scopeName}/scopedResources/{name}' removed or restructured? Old: Microsoft.HybridCompute/preview/2020-08-15-preview/privateLinkScopes.json#L590:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.HybridCompute/privateLinkScopes/{scopeName}/scopedResources' removed or restructured? Old: Microsoft.HybridCompute/preview/2020-08-15-preview/privateLinkScopes.json#L755:5 |
|
| The new version is missing a definition that was found in the old version. Was 'ScopedResource' removed or renamed? New: Microsoft.HybridCompute/preview/2021-01-28-preview/privateLinkScopes.json#L669:3 Old: Microsoft.HybridCompute/preview/2020-08-15-preview/privateLinkScopes.json#L801:3 |
|
| The new version is missing a definition that was found in the old version. Was 'ScopedResourceProperties' removed or renamed? New: Microsoft.HybridCompute/preview/2021-01-28-preview/privateLinkScopes.json#L669:3 Old: Microsoft.HybridCompute/preview/2020-08-15-preview/privateLinkScopes.json#L801:3 |
|
| The required parameter 'name' was removed in the new version. Old: Microsoft.HybridCompute/preview/2020-08-15-preview/HybridCompute.json#L58:11 |
|
| The required parameter 'name' was removed in the new version. Old: Microsoft.HybridCompute/preview/2020-08-15-preview/HybridCompute.json#L115:11 |
|
| The required parameter 'name' was removed in the new version. Old: Microsoft.HybridCompute/preview/2020-08-15-preview/HybridCompute.json#L172:11 |
|
| The required parameter 'name' was removed in the new version. Old: Microsoft.HybridCompute/preview/2020-08-15-preview/HybridCompute.json#L220:11 |
|
| The required parameter 'name' was removed in the new version. Old: Microsoft.HybridCompute/preview/2020-08-15-preview/HybridCompute.json#L363:11 |
|
| The required parameter 'name' was removed in the new version. Old: Microsoft.HybridCompute/preview/2020-08-15-preview/HybridCompute.json#L425:11 |
️⚠️[Staging] Cross Version BreakingChange (Base on stable version): 59 Warnings warning [Detail]
Only 10 items are listed, please refer to log for more details.
- Compared Swaggers (Based on Oad v0.8.6)
- original: stable/2020-08-02/HybridCompute.json <---> new: preview/2021-01-28-preview/HybridCompute.json
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️[Staging] SDK Track2 Validation: 34 Warnings warning [Detail]
Only 10 items are listed, please refer to log for more details.
- The following tags are being changed in this PR
| Rule | Message |
|---|---|
| "readme":"hybridcompute/resource-manager/readme.md", "tag":"package-preview-2021-01", "details":"The schema 'OperationListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"hybridcompute/resource-manager/readme.md", "tag":"package-preview-2021-01", "details":"The schema 'OperationValue' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"hybridcompute/resource-manager/readme.md", "tag":"package-preview-2021-01", "details":"The schema 'OperationValueDisplay' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"hybridcompute/resource-manager/readme.md", "tag":"package-preview-2021-01", "details":"The schema 'OSProfile' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"hybridcompute/resource-manager/readme.md", "tag":"package-preview-2021-01", "details":"The schema 'MachineProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"hybridcompute/resource-manager/readme.md", "tag":"package-preview-2021-01", "details":"The schema 'MachineUpdateProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"hybridcompute/resource-manager/readme.md", "tag":"package-preview-2021-01", "details":"The schema 'Machine' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"hybridcompute/resource-manager/readme.md", "tag":"package-preview-2021-01", "details":"The schema 'MachineUpdate' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"hybridcompute/resource-manager/readme.md", "tag":"package-preview-2021-01", "details":"The schema 'MachineListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"hybridcompute/resource-manager/readme.md", "tag":"package-preview-2021-01", "details":"The schema 'ResourceUpdate' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
Swagger Generation Artifacts
|
This was referenced Feb 17, 2021
dkirby017
force-pushed
the
dev-hybridcompute-2021-01-28-preview
branch
from
0576397 to
1bb5675
Compare
|
/azp run unifiedPipeline |
|
No pipelines are associated with this pull request. |
|
Hi @dkirby017, Your PR has some issues. Please fix the CI sequentially by following the order of
|
|
/azp run unifiedPipeline |
|
No pipelines are associated with this pull request. |
openapi-pipeline-app
bot
added
CI-FixRequiredOnFailure
and removed
CI-FixRequiredOnFailure
labels
|
/azp run unifiedPipeline |
|
No pipelines are associated with this pull request. |
|
/azp run unifiedPipeline |
|
No pipelines are associated with this pull request. |
openapi-pipeline-app
bot
added
CI-FixRequiredOnFailure
and removed
CI-FixRequiredOnFailure
labels
|
/azp run unifiedPipeline |
|
/azp run unifiedPipeline |
openapi-pipeline-app
bot
added
CI-FixRequiredOnFailure
and removed
CI-FixRequiredOnFailure
labels
openapi-pipeline-app
bot
added
CI-FixRequiredOnFailure
and removed
CI-FixRequiredOnFailure
CI-BreakingChange-Python
labels
|
@markcowl I've addressed most of your comments and left a note on the extension section. I'm not sure what it's complaining about at this point, but please take a look as soon as you can. |
openapi-pipeline-app
bot
added
CI-BreakingChange-Python
and removed
CI-FixRequiredOnFailure
labels
|
@markcowl everything looks happier after my latest update |
markcowl
requested changes
Feb 24, 2021
| "description": "Specifies the version of the script handler." | ||
| }, | ||
| "status": { | ||
| "properties": { |
There was a problem hiding this comment.
I am asking if MachineExtensionImageView is a resource (the corresponding VirtualMachineInstanceView is)
|
@dkirby017 See my comments on the unresolved comments above. Underspecifying extensions is a long-standing problem, so if this is urgent, we can file an issue and defer until later. I would hate to do this with settings/protectSettings, but am open to treating these the same way if your team will fix the problem in an upcoming api-version |
|
@markcowl it is urgent that we get this new api in. It's blocking an upcoming preview of our private link support. I've filed https://msazure.visualstudio.com/One/_workitems/edit/9398639 to address your comments on the extensions and we'll get those in in the next update :) |
markcowl
approved these changes
Feb 25, 2021
markcowl
added
Approved-OkToMerge
This was referenced Feb 25, 2021
Merged
mkarmark
pushed a commit
to mkarmark/azure-rest-api-specs
that referenced
this pull request
Jul 21, 2021
…sion preview/2021-01-28-preview (Azure#13007) * Adds base for updating Microsoft.HybridCompute from version preview/2020-08-15-preview to version 2021-01-28-preview * Updates readme * Updates API version in new specs and examples * update api * revert changes to package-lock.json * address a bunch of comments * run prettier and fix errorresponse reference * update parameter name in examples * fix parameter names * got lots of errors after removing the allOfs so following adps example and using them at the top level of the definitions * fix some lint errors * use common errorDetail definition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.