Microsoft.IoTSecurity - Add locations and deviceSecurityGroups #13091

liranc · 2021-02-22T10:37:37Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No, no need to refresh for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2021-02-22T10:37:41Z

Hi, @liranc Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

openapi-pipeline-app · 2021-02-22T10:37:42Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️LintDiff succeeded [Detail] [Expand]

Validation passes for LintDiff.

Linted configuring files (Based on source branch, openapi-validator v1.9.0 , classic-openapi-validator v1.1.6 )
- iotsecurity/resource-manager/readme.md tag:2021-02-01-preview
Linted configuring files (Based on target branch, openapi-validator v1.9.0 , classic-openapi-validator v1.1.6 )
- iotsecurity/resource-manager/readme.md tag:2021-02-01-preview

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️[Staging] SDK Track2 Validation: 7 Warnings warning [Detail]

The following tags are being changed in this PR

iotsecurity/resource-manager/readme.md#2021-02-01-preview

Rule	Message
⚠️ PreCheck/SchemaMissingType	"readme":"iotsecurity/resource-manager/readme.md", "tag":"2021-02-01-preview", "details":"The schema 'ErrorResponseModel-error' with an undefined type and 'allOf'/'anyOf'/'oneOf' is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/SchemaMissingType	"readme":"iotsecurity/resource-manager/readme.md", "tag":"2021-02-01-preview", "details":"The schema 'Resource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/SchemaMissingType	"readme":"iotsecurity/resource-manager/readme.md", "tag":"2021-02-01-preview", "details":"The schema 'ProxyResource' with an undefined type and 'allOf'/'anyOf'/'oneOf' is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/SchemaMissingType	"readme":"iotsecurity/resource-manager/readme.md", "tag":"2021-02-01-preview", "details":"The schema 'ErrorDetail' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/SchemaMissingType	"readme":"iotsecurity/resource-manager/readme.md", "tag":"2021-02-01-preview", "details":"The schema 'ErrorResponse' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/SchemaMissingType	"readme":"iotsecurity/resource-manager/readme.md", "tag":"2021-02-01-preview", "details":"The schema 'ErrorAdditionalInfo' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/CheckDuplicateSchemas	"readme":"iotsecurity/resource-manager/readme.md", "tag":"2021-02-01-preview", "details":"Checking for duplicate schemas, this could take a (long) while. Run with --verbose for more detail."

️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2021-02-22T10:37:42Z

Swagger Generation Artifacts

️⚠️ azure-sdk-for-net warning [Detail]

⚠️Warning [Logs]Release - Generate from c3beceb. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/iotsecurity/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
warn	No file changes detected after generation
warn	No package detected after generation

️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2021-02-22T10:39:32Z

Hi @liranc, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

Task	How to fix	Priority	Support (Microsoft alias)
Avocado	Fix-Avocado	High	ruowan
Semantic validation	Fix-SemanticValidation-Error	High	raychen, jianyxi
Model validation	Fix-ModelValidation-Error	High	raychen,jianyxi
LintDiff	Fix-LintDiff	high	jianyxi, ruoxuan

If you need further help, please feedback via swagger feedback."

...security/resource-manager/Microsoft.IoTSecurity/preview/2021-02-01-preview/deviceGroups.json

j5lim · 2021-03-11T01:34:14Z

...iotsecurity/resource-manager/Microsoft.IoTSecurity/preview/2021-02-01-preview/locations.json

+          "readOnly": true,
+          "type": "object",
+          "description": "Azure Resource Manager metadata containing createdBy and modifiedBy information.",
+          "$ref": "../../../../../common-types/resource-management/v2/types.json#/definitions/systemData"


Not sure having systemData for location makes sense since there is no way for users to create a location..

@j5lim Is systemData optional for proxy resources?
On a separate PR, we've attempted to create a new proxy resource without systemData but received a CI validation error, saying the property must be defined.
Can this error be ignored for proxy resources?

The ARM guideline says it should be supported by all resources, but I mean in this particular case it does not make sense to me. Wondering there is a way to suppress the CI validation.. @ruowan do you know if it's possible?

@j5lim @ruowan Any decision on this? I'd like to complete this PR (we have some other dependencies on completing it)

@liranc You can leave it as it is if it causes a CI failure.

@j5lim Can the PR be merged in that case, or are there any other action items left? 🙂

@liranc Please work with the pr assignee to get the pr merged. ARM team does not have merge permission.

…#13091) * Locations * v1 * v2 * v3 * File rename * Rename resource * Update common types file path * add pageable option * Add missing nextLink property Co-authored-by: Liran Chen <lirche@microsoft.com>

Liran Chen added 4 commits February 22, 2021 09:31

Locations

bcd18c2

v1

be541c3

v2

c9bf082

v3

60eaf8d

openapi-assignment-bot bot assigned ruowan Feb 22, 2021

liranc added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Feb 22, 2021

openapi-pipeline-app bot added CI-FixRequiredOnFailure and removed CI-FixRequiredOnFailure labels Feb 22, 2021

Liran Chen added 2 commits February 22, 2021 12:43

File rename

6627779

Rename resource

5d8c870

openapi-pipeline-app bot added CI-FixRequiredOnFailure and removed CI-FixRequiredOnFailure labels Feb 22, 2021

orkayam approved these changes Feb 22, 2021

View reviewed changes

Liran Chen added 2 commits February 28, 2021 07:47

Merge branch 'master' into lirche/deviceGroups

214a43b

Update common types file path

e30d4b7

liranc removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Feb 28, 2021

Merge branch 'master' into lirche/deviceGroups

97a076f

liranc added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 3, 2021

zcxcasd reviewed Mar 3, 2021

View reviewed changes

...security/resource-manager/Microsoft.IoTSecurity/preview/2021-02-01-preview/deviceGroups.json Show resolved Hide resolved

j5lim self-requested a review March 11, 2021 01:06

j5lim reviewed Mar 11, 2021

View reviewed changes

...security/resource-manager/Microsoft.IoTSecurity/preview/2021-02-01-preview/deviceGroups.json Show resolved Hide resolved

j5lim reviewed Mar 11, 2021

View reviewed changes

j5lim approved these changes Mar 11, 2021

View reviewed changes

j5lim added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Mar 11, 2021

Merge branch 'master' into lirche/deviceGroups

c5dee05

add pageable option

4611975

openapi-pipeline-app bot added the CI-FixRequiredOnFailure label Mar 11, 2021

Liran Chen added 2 commits March 14, 2021 13:33

Merge branch 'master' into lirche/deviceGroups

504798f

Add missing nextLink property

369b757

openapi-pipeline-app bot removed the CI-FixRequiredOnFailure label Mar 14, 2021

ruowan merged commit c3beceb into Azure:master Mar 17, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Microsoft.IoTSecurity - Add locations and deviceSecurityGroups #13091

Microsoft.IoTSecurity - Add locations and deviceSecurityGroups #13091

liranc commented Feb 22, 2021 •

edited

Loading

openapi-workflow-bot bot commented Feb 22, 2021

openapi-pipeline-app bot commented Feb 22, 2021 •

edited

Loading

openapi-pipeline-app bot commented Feb 22, 2021 •

edited

Loading

openapi-workflow-bot bot commented Feb 22, 2021

j5lim Mar 11, 2021

liranc Mar 11, 2021 •

edited

Loading

j5lim Mar 12, 2021

liranc Mar 15, 2021

j5lim Mar 15, 2021

liranc Mar 16, 2021

j5lim Mar 16, 2021

Microsoft.IoTSecurity - Add locations and deviceSecurityGroups #13091

Microsoft.IoTSecurity - Add locations and deviceSecurityGroups #13091

Conversation

liranc commented Feb 22, 2021 • edited Loading

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Feb 22, 2021

openapi-pipeline-app bot commented Feb 22, 2021 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Feb 22, 2021 • edited Loading

Swagger Generation Artifacts

openapi-workflow-bot bot commented Feb 22, 2021

j5lim Mar 11, 2021

Choose a reason for hiding this comment

liranc Mar 11, 2021 • edited Loading

Choose a reason for hiding this comment

j5lim Mar 12, 2021

Choose a reason for hiding this comment

liranc Mar 15, 2021

Choose a reason for hiding this comment

j5lim Mar 15, 2021

Choose a reason for hiding this comment

liranc Mar 16, 2021

Choose a reason for hiding this comment

j5lim Mar 16, 2021

Choose a reason for hiding this comment

liranc commented Feb 22, 2021 •

edited

Loading

openapi-pipeline-app bot commented Feb 22, 2021 •

edited

Loading

openapi-pipeline-app bot commented Feb 22, 2021 •

edited

Loading

liranc Mar 11, 2021 •

edited

Loading